From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 319ED2571A5; Mon, 27 Oct 2025 09:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.140.195.201 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761556243; cv=pass; b=Zsbajqdy87ljk/gkv5/Oy+Hje7GtSQq/41cULde4J9n9Ih+vYmmqiURcvenRR9vSkwXND5mzYQuSHbaq8FhDkOaco+8DJiNKV9gEPXJmAwgrp0d9aqMmRT6PFqLL7VGqj98QjPLO9HcMwP8oaWxWtI3/7jcH0Od800IrHJTbZbg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761556243; c=relaxed/simple; bh=Ij4ohQMcsJcLq06iIAxPqOlod7AhQEs/L0pIdbSbQl0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gjIKLEfDzea/42eV5ZjKMQDBf1+wHinIeLGp1F0RgvxATpuUu0aeCodnhqiBAq4I4LH+cnmkVgw87MjiTxGF0rWqWaN8b+mxk1h+/XinR4CF4n4e3YYbG1WJ224iCzRKHTbp3zItLeZe9UZgKycHZPM3joC6zNu+2PlqpQzQ5pM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi; spf=pass smtp.mailfrom=iki.fi; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b=YwnyYSc8; arc=pass smtp.client-ip=195.140.195.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iki.fi Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b="YwnyYSc8" Received: from hillosipuli.retiisi.eu (91-158-51-183.elisa-laajakaista.fi [91.158.51.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id 4cw75W5p7qzyT0; Mon, 27 Oct 2025 11:10:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1761556239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FgI6V23Ri1vReEoNo6plAZiLdf2JKlAnRf/2oXQccV8=; b=YwnyYSc8oChOBrSUdHjqrf2iSqRRIRfeZQDbYFQ2wNsdKyyA/dxdu1vNyPVQRMTC8tweqJ 3M8C4h/oU+HsvnnRph7lR51dZJeoh1ICc+yqNlzALf1jJ3JCxFeycpTsh9hc3fkCO3FGFd Xja1pavEtX7bHfj81eGBJWXbmVjDvZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1761556239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FgI6V23Ri1vReEoNo6plAZiLdf2JKlAnRf/2oXQccV8=; b=Re120l8vm66ZP8IRQddsokS4lEtpxb66A7cj4WH2b1H9bqLGfwFs9izE7Ip+7s2AJK+jDq Yb9pRqGBeg59xuIhvy1JRFEKmxNkjudSyl4OwMrAvlr92ZxYgwBa+sk6zMi+7cHuGTxoi9 Ofg9T1iUWpW+YT7mwp8Ut/D2r7O1WPU= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1761556239; a=rsa-sha256; cv=none; b=ujjWn5pbp4xouvvewe+keUfMTohYr/knkyTAzdh/fLzBo3WpXgnjDI8fPm/IoT5K83b4uj 1e6LMx+lWX9nHzNGfBLPjfNfFRsOlgs1RHEI2r7RbpBQKDtIH9VjgELxl6GxZxD7RT1Sk6 R5C/bNWIxd7seTnqDbtDJLXrjypXIQ4= Received: from valkosipuli.retiisi.eu (valkosipuli.local [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id A00FC634C5B; Mon, 27 Oct 2025 11:10:39 +0200 (EET) Date: Mon, 27 Oct 2025 11:10:39 +0200 From: Sakari Ailus To: Frank Li Cc: Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eugen Hristev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Alice Yuan , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Steve Longerbeam , Greg Kroah-Hartman , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v3 17/31] media: synopsys: move imx6-mipi-csi2.c to synopsys/mipi-csi2.c Message-ID: References: <20250821-95_cam-v3-0-c9286fbb34b9@nxp.com> <20250821-95_cam-v3-17-c9286fbb34b9@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250821-95_cam-v3-17-c9286fbb34b9@nxp.com> Hi Frank, On Thu, Aug 21, 2025 at 04:15:52PM -0400, Frank Li wrote: > Move dw MIPI CSI2 common part drivers/staging/media/imx/imx6-mipi-csi2.c > under synopsys to let more SoC can reuse it. > > Signed-off-by: Frank Li > --- > drivers/media/platform/synopsys/Kconfig | 12 ++++++++++++ > drivers/media/platform/synopsys/Makefile | 2 ++ > .../imx6-mipi-csi2.c => media/platform/synopsys/mipi-csi2.c} | 0 > drivers/staging/media/imx/Kconfig | 1 + > drivers/staging/media/imx/Makefile | 2 +- > 5 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig > index 4fd521f78425a96985fa3b6b017deef36631d1a9..e54dad835349d420dead6d5313c0623567c28c0b 100644 > --- a/drivers/media/platform/synopsys/Kconfig > +++ b/drivers/media/platform/synopsys/Kconfig > @@ -1,3 +1,15 @@ > # SPDX-License-Identifier: GPL-2.0-only > > +config VIDEO_SYNOPSYS_MIPI_CSI2 > + tristate "Synopsys DesignWare MIPI CSI2 Receiver common library" > + depends on VIDEO_DEV > + select MEDIA_CONTROLLER > + select VIDEO_V4L2_SUBDEV_API > + select VIDEOBUF2_DMA_CONTIG > + help > + Common library for MIPI CSI2 Controller. > + > + To compile this driver as a module, choose M here. The module > + will be called synopsys_hdmirx > + > source "drivers/media/platform/synopsys/hdmirx/Kconfig" > diff --git a/drivers/media/platform/synopsys/Makefile b/drivers/media/platform/synopsys/Makefile > index 3b12c574dd67c072901108d88cad64ca3a723938..045ed3177738e6d28aa223804b79e6774e141dc8 100644 > --- a/drivers/media/platform/synopsys/Makefile > +++ b/drivers/media/platform/synopsys/Makefile > @@ -1,2 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0-only > obj-y += hdmirx/ > + > +obj-$(CONFIG_VIDEO_SYNOPSYS_MIPI_CSI2) += mipi-csi2.o Please give the module a more specific name. > diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/media/platform/synopsys/mipi-csi2.c > similarity index 100% > rename from drivers/staging/media/imx/imx6-mipi-csi2.c > rename to drivers/media/platform/synopsys/mipi-csi2.c > diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig > index 1cd48028b6416ae16ed69c68186281b6c6bcbec8..53e5c1546ac53e4942974a9acdcf078de1cb6073 100644 > --- a/drivers/staging/media/imx/Kconfig > +++ b/drivers/staging/media/imx/Kconfig > @@ -10,6 +10,7 @@ config VIDEO_IMX_MEDIA > select V4L2_MEM2MEM_DEV > select VIDEOBUF2_DMA_CONTIG > select VIDEO_V4L2_SUBDEV_API > + select VIDEO_SYNOPSYS_MIPI_CSI2 > help > Say yes here to enable support for video4linux media controller > drivers for the i.MX5/6 SOC. > diff --git a/drivers/staging/media/imx/Makefile b/drivers/staging/media/imx/Makefile > index 064a6c6c069aa440c72a483080cbedf89d370193..1978b82fd1876566acbb952a4d14cf9aca35e996 100644 > --- a/drivers/staging/media/imx/Makefile > +++ b/drivers/staging/media/imx/Makefile > @@ -11,4 +11,4 @@ imx6-media-csi-objs := imx-media-csi.o imx-media-fim.o > obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-common.o > obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-media.o > obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-media-csi.o > -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-mipi-csi2.o imx6-csi2.o > +obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-csi2.o > -- Regards, Sakari Ailus