Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Frank Li <Frank.li@nxp.com>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
	Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:OMNIVISION OV2680 SENSOR DRIVER"
	<linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
Date: Wed, 22 Oct 2025 09:59:40 +0300	[thread overview]
Message-ID: <aPiA3G9x_RsTL9Mv@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <aPepRZOL1Ys4PH/u@lizhi-Precision-Tower-5810>

Hi Frank,

On Tue, Oct 21, 2025 at 11:39:49AM -0400, Frank Li wrote:
> On Tue, Oct 21, 2025 at 12:00:09PM +0300, Sakari Ailus wrote:
> > Hi Frank,
> >
> > On Wed, Aug 27, 2025 at 03:49:18PM -0400, Frank Li wrote:
> > > The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> > > additionalProperties with unevaluatedProperties to allow use common
> > > properties.
> > >
> > > Fix below CHECK_DTBS warnings:
> > >   arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> > > 	from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > index 634d3b821b8c7..ec5c40684b6bd 100644
> > > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > @@ -58,7 +58,7 @@ properties:
> > >      properties:
> > >        endpoint:
> > >          $ref: /schemas/media/video-interfaces.yaml#
> > > -        additionalProperties: false
> > > +        unevaluatedProperties: false
> >
> > There are a lot more than just data-lanes in video-interfaces.yaml.
> >
> > Could you instead drop data-lanes and clock-lanes from the bindings? They
> > are redundant.
> 
> What's your means?  drop data-lanes and clock-lanes from the dts file?
> 
> The board design may use less data-lanes, why it is reduntant?

That would be no data lanes at all then. The sensor supports a single lane
only, which is why data-lanes isn't listed as a property in bindings.

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2025-10-22  6:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
2025-08-29 16:52 ` Rob Herring (Arm)
2025-10-21  9:00 ` Sakari Ailus
2025-10-21 15:39   ` Frank Li
2025-10-22  6:59     ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPiA3G9x_RsTL9Mv@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hansg@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rmfrfs@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox