From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from akranes.kaiser.cx (akranes.kaiser.cx [152.53.16.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E195F232395; Wed, 26 Nov 2025 20:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=152.53.16.207 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764189063; cv=none; b=rcVvhrfXay6LMgSnkGUDWvnrlLL8tKtv7rWDGghc+drak0CclAYSKUbZUCnWMwoW3GVXmotikBEG9vjpBk0SGt4FknU95aSqBbjk4oZBUlKDLdBZEGEHRE1TmVGkIViPbopKNVPv1rkfWhcE1IlZFHTk8qfglyef+BybjXALib8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764189063; c=relaxed/simple; bh=pKETpT/qtE1W7EPF8Otd2b1X2DpkV2LH1hN1uUbdTHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gM+8xf3UbHiyfUJ6LIdBq+/9XzbdLm0qVeqgN4p+0Zv04uTLTRbXoU4ZRZXi+6I/aKHWXgWgNSRrxUFhUiSlteKPaHADr656AtOyoKjW1pQAzcQc1zag0yVU3212l3LDC1wiKlS7SZeEi/0jzZ4cm3H2vsKizTKAjBri6qU3Uy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx; spf=pass smtp.mailfrom=kaiser.cx; arc=none smtp.client-ip=152.53.16.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kaiser.cx Received: from martin by akranes.kaiser.cx with local (Exim 4.96) (envelope-from ) id 1vOM9P-009WC2-1t; Wed, 26 Nov 2025 21:30:07 +0100 Date: Wed, 26 Nov 2025 21:30:07 +0100 From: Martin Kaiser To: Jean-Michel Hautbois via B4 Relay Cc: Greg Ungerer , Geert Uytterhoeven , Olivia Mackall , Herbert Xu , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Jean-Michel Hautbois , Frank Li Subject: Re: [PATCH v4 1/2] hwrng: imx-rngc: Use optional clock Message-ID: References: <20251126-b4-m5441x-add-rng-support-v4-0-5309548c9555@yoseli.org> <20251126-b4-m5441x-add-rng-support-v4-1-5309548c9555@yoseli.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126-b4-m5441x-add-rng-support-v4-1-5309548c9555@yoseli.org> Sender: "Martin Kaiser,,," Thus wrote Jean-Michel Hautbois via B4 Relay (devnull+jeanmichel.hautbois.yoseli.org@kernel.org): > From: Jean-Michel Hautbois > Change devm_clk_get() to devm_clk_get_optional() to support platforms > where the RNG clock is always enabled and not exposed via the clock > framework (such as ColdFire MCF54418). > Reviewed-by: Frank Li > Signed-off-by: Jean-Michel Hautbois > --- > drivers/char/hw_random/imx-rngc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c > index 241664a9b5d9..d6a847e48339 100644 > --- a/drivers/char/hw_random/imx-rngc.c > +++ b/drivers/char/hw_random/imx-rngc.c > @@ -259,7 +259,7 @@ static int __init imx_rngc_probe(struct platform_device *pdev) > if (IS_ERR(rngc->base)) > return PTR_ERR(rngc->base); > - rngc->clk = devm_clk_get(&pdev->dev, NULL); > + rngc->clk = devm_clk_get_optional(&pdev->dev, NULL); > if (IS_ERR(rngc->clk)) > return dev_err_probe(&pdev->dev, PTR_ERR(rngc->clk), "Cannot get rng_clk\n"); The clock is not optional on a standard imx25 system. If it's missing in the device tree, the rngb will not work and we should not load the driver. Should we call devm_clk_get or devm_clk_get_optional, depending on the detected device? Best regards, Martin