From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47461DFFD for ; Thu, 18 Dec 2025 09:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048958; cv=none; b=Oc9eN96jNPYMeaN18LpdWc3Og+KGMsUjJdWOv0LlF38KfW+GyUr9hutMK3QPb0bPrjgwarwRmpAnjpw02Tu/0nALyxs/KtYsgGRGsst+Bjx48Rjx7teVCARqsfcD1OOlbAdGI+f60njkEsV1xFrFGFkkYYk7kZIJcREyRQgmsYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048958; c=relaxed/simple; bh=JLOsRuLJC0lQwq8IdJlieAKJlWnRllG5tdlb00mT5Sg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AL335jU+B+iyewphAhKugGIkrpzBFNGNSBUoPVrrWRq3dSdUl7jHWykSN0bpvRrFlVGr59M8gSDr/nSrvBUy8OS1/dqnpfErh6kc4ZAGXJmXNF8hJgH6peRkrQaxw88p3Vr6OvE2KuVnaoS5U6k0p/+Akp75UT8+ac92ClgwR2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWA0S-0000bE-Cz; Thu, 18 Dec 2025 10:09:08 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWA0R-006FaQ-1N; Thu, 18 Dec 2025 10:09:07 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vWA0R-00EXba-0t; Thu, 18 Dec 2025 10:09:07 +0100 Date: Thu, 18 Dec 2025 10:09:07 +0100 From: Michael Tretter To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Michael Tretter , Frank Li Subject: Re: [PATCH v2 0/2] media: staging: imx: fix multiple video input Message-ID: Mail-Followup-To: Michael Tretter , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Michael Tretter , Frank Li References: <20251107-media-imx-fixes-v2-0-07d949964194@pengutronix.de> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251107-media-imx-fixes-v2-0-07d949964194@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: imx@lists.linux.dev On Fri, 07 Nov 2025 11:34:32 +0100, Michael Tretter wrote: > If the IMX media pipeline is configured to receive multiple video > inputs, the second input stream may be broken on start. This happens if > the IMX CSI hardware has to be reconfigured for the second stream, while > the first stream is already running. > > The IMX CSI driver configures the IMX CSI in the link_validate callback. > The media pipeline is only validated on the first start. Thus, any later > start of the media pipeline skips the validation and directly starts > streaming. This may leave the hardware in an inconsistent state compared > to the driver configuration. Moving the hardware configuration to the > stream start to make sure that the hardware is configured correctly. > > Patch 1 removes the caching of the upstream mbus_config in > csi_link_validate and explicitly request the mbus_config in csi_start, > to get rid of this implicit dependency. > > Patch 2 actually moves the hardware register setting from > csi_link_validate to csi_start to fix the skipped hardware > reconfiguration. Gentle ping. Michael > > Signed-off-by: Michael Tretter > --- > Changes in v2: > - Document changed locking in commit message > - Link to v1: https://lore.kernel.org/r/20251105-media-imx-fixes-v1-0-99e48b4f5cbc@pengutronix.de > > --- > Michael Tretter (2): > media: staging: imx: request mbus_config in csi_start > media: staging: imx: configure src_mux in csi_start > > drivers/staging/media/imx/imx-media-csi.c | 84 ++++++++++++++++++------------- > 1 file changed, 48 insertions(+), 36 deletions(-) > --- > base-commit: 27afd6e066cfd80ddbe22a4a11b99174ac89cced > change-id: 20251105-media-imx-fixes-acef77c7ba12