From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Primoz Fiser <primoz.fiser@norik.com>,
Yannic Moog <y.moog@phytec.de>,
Markus Niebel <Markus.Niebel@tq-group.com>,
Josua Mayer <josua@solid-run.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/3] arm64: dts: imx95-var-dart: Add support for Variscite Sonata board
Date: Mon, 29 Dec 2025 21:58:58 +0100 [thread overview]
Message-ID: <aVLrkqgjrsX7jfYw@Lord-Beerus.station> (raw)
In-Reply-To: <0afc0945-af65-410d-8556-1d09792981cb@lunn.ch>
On Mon, Dec 29, 2025 at 07:24:50PM +0100, Andrew Lunn wrote:
>
> What is this ethernet connected to? In the commit message you mention
> an SFP? So i would expect a phandle pointing to the SFP cage node,
> which follows:
>
> Documentation/devicetree/bindings/net/sff,sfp.yam
>
> Andrew
Hi Andrew,
You're absolutely right, thanks for pointing that out!
I mistakenly thought fixed-link alone was sufficient, but after reading
the sff,sfp.yaml binding I understand the sfp node is needed to properly
handle the SFP+ cage and transceiver module detection via I2C.
I've updated the patch to include the sfp node with i2c-bus and
los-gpios properties.
Sending v2 shortly.
Thanks,
Stefano
prev parent reply other threads:[~2025-12-29 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 15:04 [PATCH v1 0/3] Add support for Variscite DART-MX95 and Sonata board Stefano Radaelli
2025-12-29 15:04 ` [PATCH v1 1/3] dt-bindings: arm: fsl: add Variscite DART-MX95 Boards Stefano Radaelli
2025-12-29 15:04 ` [PATCH v1 2/3] arm64: dts: freescale: Add support for Variscite DART-MX95 Stefano Radaelli
2025-12-29 18:20 ` Andrew Lunn
2025-12-29 15:04 ` [PATCH v1 3/3] arm64: dts: imx95-var-dart: Add support for Variscite Sonata board Stefano Radaelli
2025-12-29 18:24 ` Andrew Lunn
2025-12-29 20:58 ` Stefano Radaelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVLrkqgjrsX7jfYw@Lord-Beerus.station \
--to=stefano.radaelli21@gmail.com \
--cc=Markus.Niebel@tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox