From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F2D16F8FC for ; Thu, 18 Apr 2024 16:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713457771; cv=none; b=UQ1jqEz64z5plcNMtlYgwo1TF1whBktQ1pG0srdgpfTJV4yB1e5hf8m1mQoHuaLt5Ng1aGb1vRcbjlf6P1PPB7kCsEkUyFft4XdjHQfb3jboFEUTME18xAs2G4aaRIfFJZb95i9CiLRq0iqzikNaYr5q9DVrTBsJTCmHUsrw0+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713457771; c=relaxed/simple; bh=n5UTBwm9LwxWCwUD5WYTPdP8hKDjMr22biXL1uuugRA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=VtbyfnQIGKyiqq1/rZIANLScskuZ8hYONJF12boPtYLzG/LinbHBHf6QRMzmh0s/azqyDKGTqXhkZislOIsj/J9+lEHga66eVJNmUghKn7B4ruvHdPEt9vAcke0rVlaftCBQEMh78KX8YXMUxUTimc2RNrund0PhK5vLk07JTaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WorPOG+K; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WorPOG+K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713457770; x=1744993770; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=n5UTBwm9LwxWCwUD5WYTPdP8hKDjMr22biXL1uuugRA=; b=WorPOG+KsIwVnrDeaQwb3MyusTObhlNOFkxVjwEsUX2R9Z+K14LJK4f/ xKHLFkWI26cGJ21KTI5j9LaL21KkH5F/nsK6HPlDhmure+ZHke3gSSIfE NQVeFTnGK2p2r8VaMpQWiUt1jjMFnOrI85MkNkfbtILXpoxvKESTlNqSn EnoN2K+3UGfljXVxrRDNWJBtUeau3N/QSEBs1n5eOL+2vwQJNcKuN1LHH Uzg0fb59lmQ86VBOHsDu3fD+5cl1bzS5EjcNd3WUEHQRjdQKVSNReCsYx STv54LFa/V7h6C/oGe+pP0OyZKKSu5VSxOkCcEHnfYeXcxG7KyuhZF0ZF A==; X-CSE-ConnectionGUID: Y9pusyYpSNCCXEBhF4Tl3w== X-CSE-MsgGUID: LHlWJ/CdQ/CrLGnXGpZPfg== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="8882340" X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="8882340" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 09:27:57 -0700 X-CSE-ConnectionGUID: QL+FsKavRtigEK3tKkR75g== X-CSE-MsgGUID: ZaFP6k8bT0OPD8LxfPhFXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="23105114" Received: from rswoodsx-mobl.amr.corp.intel.com (HELO [10.213.167.100]) ([10.213.167.100]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 09:27:53 -0700 Message-ID: Date: Thu, 18 Apr 2024 11:26:06 -0500 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/23] ASoC: Intel: Replace playback/capture_only to playback/capture_assertion To: =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= , Kuninori Morimoto , Alexandre Belloni , Alper Nebi Yasak , AngeloGioacchino Del Regno , Banajit Goswami , Bard Liao , Brent Lu , Cezary Rojewski , Charles Keepax , Claudiu Beznea , Cristian Ciocaltea , Daniel Baluta , Hans de Goede , Jaroslav Kysela , Jerome Brunet , Jiawei Wang , Jonathan Corbet , Kai Vehmanen , Kevin Hilman , Liam Girdwood , Mark Brown , Maso Huang , Matthias Brugger , Neil Armstrong , Nicolas Ferre , Peter Ujfalusi , Ranjani Sridharan , Sascha Hauer , Shawn Guo , Shengjiu Wang , Srinivas Kandagatla , Sylwester Nawrocki , Takashi Iwai , Vinod Koul , Xiubo Li , alsa-devel@alsa-project.org, imx@lists.linux.dev, linux-doc@vger.kernel.org, linux-sound@vger.kernel.org References: <87h6fz8g3u.wl-kuninori.morimoto.gx@renesas.com> <87plun71db.wl-kuninori.morimoto.gx@renesas.com> <481d5755-ac70-4a01-899d-9d39f5075350@linux.intel.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <481d5755-ac70-4a01-899d-9d39f5075350@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/18/24 06:19, Amadeusz Sławiński wrote: > On 4/18/2024 6:15 AM, Kuninori Morimoto wrote: >> soc_get_playback_capture() is now handling DPCM and normal >> comprehensively for playback/capture stream in same code. >> This patch converts xxx_only flag to xxx_assertion. >> >> Signed-off-by: Kuninori Morimoto >> --- >>   sound/soc/intel/boards/bdw-rt5677.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/intel/boards/bdw-rt5677.c >> b/sound/soc/intel/boards/bdw-rt5677.c >> index 54e3c5d3c251..9170b1d509e2 100644 >> --- a/sound/soc/intel/boards/bdw-rt5677.c >> +++ b/sound/soc/intel/boards/bdw-rt5677.c >> @@ -339,7 +339,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = { >>       { >>           .name = "Codec DSP", >>           .stream_name = "Wake on Voice", >> -        .capture_only = 1, >> +        .capture_assertion = 1, >>           .ops = &bdw_rt5677_dsp_ops, >>           SND_SOC_DAILINK_REG(dsp), >>       }, > > Should this have been part of patch 8? Patch 8 deals with the following changes - .dpcm_playback = 1, - .dpcm_capture = 1, + .playback_assertion = 1, + .capture_assertion = 1, This case is about > - .capture_only = 1, > + .capture_assertion = 1, I think it's good to make this change separately.