From: Frank Li <Frank.li@nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Yannic Moog <y.moog@phytec.de>,
Markus Niebel <Markus.Niebel@tq-group.com>,
Primoz Fiser <primoz.fiser@norik.com>,
Josua Mayer <josua@solid-run.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/3] arm64: dts: imx95-var-dart: Add support for Variscite Sonata board
Date: Mon, 9 Mar 2026 12:45:24 -0400 [thread overview]
Message-ID: <aa75JLEUDLsKtgdC@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260225170347.77841-4-stefano.r@variscite.com>
On Wed, Feb 25, 2026 at 06:03:38PM +0100, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> Add device tree support for the Variscite Sonata carrier board with
> the DART-MX95 system on module.
>
> The Sonata board includes
> - uSD Card support
> - USB ports and OTG
> - Additional Gigabit Ethernet interface
> - 10Gb Ethernet SFP+ connector
> - Uart interfaces
> - OV5640 Camera support
> - GPIO Expanders
> - RTC module
> - TPM module
> - PCIE support
>
> Link: https://variscite.com/carrier-boards/sonata-board/
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
> ---
...
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> + led-heartbeat {
> + label = "Heartbeat";
> + gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
gpio-leds should be after gpio-keys.
Can you run https://github.com/lznuaa/dt-format to avoid manual check
such nodes orders.
In past, duplicated nodes was added in sequency update because it is hard
to find duplicate nodes by patch. So we try to enhance node orders for
new dts file to avoid duplicate nodes added in future.
Frank
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
...
> 2.47.3
>
next prev parent reply other threads:[~2026-03-09 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 17:03 [PATCH v6 0/3] Add support for Variscite DART-MX95 and Sonata board Stefano Radaelli
2026-02-25 17:03 ` [PATCH v6 1/3] dt-bindings: arm: fsl: add Variscite DART-MX95 Boards Stefano Radaelli
2026-02-25 17:03 ` [PATCH v6 2/3] arm64: dts: freescale: Add support for Variscite DART-MX95 Stefano Radaelli
2026-02-25 17:03 ` [PATCH v6 3/3] arm64: dts: imx95-var-dart: Add support for Variscite Sonata board Stefano Radaelli
2026-03-09 16:45 ` Frank Li [this message]
2026-03-24 18:45 ` (subset) [PATCH v6 0/3] Add support for Variscite DART-MX95 and " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa75JLEUDLsKtgdC@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=Markus.Niebel@tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
--cc=stefano.radaelli21@gmail.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox