From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F33FD33A712 for ; Thu, 5 Mar 2026 21:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772745517; cv=none; b=Sb5XgdF5j6SIQHaZtB85jZHeVrRWWslnsooIcfNWYMFCyjjp/1Aww5Q/BBfsamH93HF4mbUxe+e8l9hLo5xnMrJdppYN4jHp2OTLCBELTMHQQTGD87LlaJAyU4DM+IyqJYaYZMK897QmR+fKxPmofh/atIRzw1BrzERASyOoMww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772745517; c=relaxed/simple; bh=6H2FBr+h/R7p6UFbOa1JlXKs8KnLDNSITprKGuUVwgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hEyqf+X4Vva3nONPMFWYknelvLzeJ95aFqnmqx9TJlPkFZmURxuN2ZesgVRZETAQtzKDmePQe1w0Ge4oM1gLKM73+KSprexlIgWvwVMEd3tOVAULBgfe9YfIAdYZh5L8JYx57Z4XXUgcPf+qh3F0qhqwlWiONQd3t8L3UemDi00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NQK+RLlK; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NQK+RLlK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772745516; x=1804281516; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6H2FBr+h/R7p6UFbOa1JlXKs8KnLDNSITprKGuUVwgk=; b=NQK+RLlKZh/uTXhOH1O2a3FpRQcrmb2zfqeCPdpDagW7dFHa0fbDyKrh xAZTrIa5ROEYcNBkM1/KJRWwk55LCJB/lNpFAlBbu2tbZnftgcUt5CbkZ Qwkpew1wbefUkHWK8T8jlczH2CorR27ZCENUxGfxFSRw3sZDC9L0uMrvv VJQaXXsXz/Q3PKUIGlolP4yFGmshzbW5HhSCZHhcALqxN5ujVLm1OTAMc HMmE7wVPgXj8KgqsxgyO4eZqeR8Z+D4mekD5IyzRWgJLmQWkra4a+QtzX RArxInAVqjj2iKZgLdNvC93ZzRJSZSFvvppNWX3z/gKmQQRgqKwnHwzHd g==; X-CSE-ConnectionGUID: zyP100EJTfKIJUL7cORA0w== X-CSE-MsgGUID: ovjRfUX1QTO6W+smxt7lmA== X-IronPort-AV: E=McAfee;i="6800,10657,11720"; a="73921731" X-IronPort-AV: E=Sophos;i="6.23,103,1770624000"; d="scan'208";a="73921731" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2026 13:18:35 -0800 X-CSE-ConnectionGUID: Jpr2x9n2RTi0MZCT//8IMQ== X-CSE-MsgGUID: 4QmsBi6TSGeHgZbJNENP6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,103,1770624000"; d="scan'208";a="223505518" Received: from fpallare-mobl4.ger.corp.intel.com (HELO [10.245.244.90]) ([10.245.244.90]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2026 13:18:32 -0800 Message-ID: Date: Thu, 5 Mar 2026 23:18:29 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: hcd: queue wakeup_work to system_freezable_wq workqueue To: Alan Stern , Xu Yang Cc: Mathias Nyman , gregkh@linuxfoundation.org, tglx@kernel.org, mingo@kernel.org, claudiu.beznea.uj@bp.renesas.com, kees@kernel.org, bigeasy@linutronix.de, ulf.hansson@linaro.org, rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com References: <20260304115729.857136-1-xu.yang_2@nxp.com> Content-Language: en-US From: Mathias Nyman In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/5/26 17:47, Alan Stern wrote: > >>> A better question to ask would be: Why does xhci_resume() call >>> usb_hcd_resume_root_hub()? That does not seem like the right thing to >>> do -- at least, not in this scenario. The proper time to resume the >>> root hub after a system sleep is when the PM core calls its resume >>> routine. >> >> Good question, it seems like commit 79989bd4ab86 ("xhci: always resume >> roothubs if xHC was reset during resume") is added to fix some issues. > > The changelog for that commit says that it was meant to take care of > problems during runtime resume, but it also affects system resume. This > appears to be an oversight. That is possible We should probably limit the all the usb_hcd_resume_root_hub() calls in xhci_resume() to runtime resume cases only. There is a similar case further down in xhci_resume() where driver is looking for pending port events. Thanks Mathias