From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDF3E35B646; Tue, 21 Apr 2026 18:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776796092; cv=none; b=Dr8EovFnvd3EoUZKcep+d+bEr9yLUmkIv/7kW07gYyh+LjrkNBY2xBEAO/RPa92AYs+UnW8k9qb1tSkYZk4jE1IiulOmIL74Kf+b+K2LYyY++/k/wruabyG2uiO+LnvEiCc/QwstuX3yBF5vNOT1H8n/6gEvSjSFgLTGdlefWDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776796092; c=relaxed/simple; bh=n3dFxMKJkQu67xhbz49OLagibL5gtHF+dkwuBR5uteg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MY+Fwtd1L/n7HKZHwZ2hendA/hnUCHinCsyRt0/DIZaizzCnnGQdc1ojB53xT26bM8B3X9j1bNGu4BilRrsh5FyghaFTFHagfPRFXeXjanWQx3hul0MAs0Hq5udkUqVrY68sl0h53I/mWD+trN1KuZZSz13XzzxEeBCfSo4spzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S5kgsuKx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S5kgsuKx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81DCFC2BCB0; Tue, 21 Apr 2026 18:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776796092; bh=n3dFxMKJkQu67xhbz49OLagibL5gtHF+dkwuBR5uteg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S5kgsuKxgTalvztk266gbjNGjYD49ThIX5hAUweIJvRZYCD11hJ5ZbEZWzXep5IJ1 zRLQIzB1nldVn1oHvvdITsCT+ZxgcJHn9ADXOPj/yJFxl/fO1mSyBpsgLwiGyANe+m 5KdDqVqaGsAtWFQG74e2iQSfBOypmjAMbPejHna96UNRsknNjM1LwbHnDmNGCwkYkR 5cncruZ5QTysqMSeBMySB1g2wsMOwpM9vgBdGFuUunJ+ZASNc6e8AKxeCUouhjXGKZ kfys1uJQ3vwVupbj5rBZxRDHNPFBWAFd14VVJg03/B/VlNUaYZZIONasPcaqLonxBO tc0XWwMLmoKPA== Date: Tue, 21 Apr 2026 21:28:07 +0300 From: Jarkko Sakkinen To: Peng Fan Cc: Stefan Wahren , Peter Huewe , Jason Gunthorpe , "linux-arm-kernel@lists.infradead.org" , "linux-integrity@vger.kernel.org" , "kernel@pengutronix.de" , Frank Li , Sascha Hauer , "imx@lists.linux.dev" Subject: Re: tpm: spi: do not call blocking ops when !TASK_RUNNING; during shutdown Message-ID: References: Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 21, 2026 at 09:04:43AM +0000, Peng Fan wrote: > > Subject: tpm: spi: do not call blocking ops when !TASK_RUNNING; > > during shutdown > > > > Hi, > > we use a custom i.MX93 board, which based on Phytec Phycore i.MX93 > > with a TPM connected via SPI. If I enable > > CONFIG_DEBUG_ATOMIC_SLEEP=y in our kernel config with mainline > > kernel 6.18.23 and reboot our board, I will get the following warning: > > ffff0000000d8000 > > The issue seems at drivers/char/tpm/tpm_tis_core.c > 94 rc = wait_event_interruptible_timeout(*queue, > 95 wait_for_tpm_stat_cond(chip, sts_mask, check_cancel, > 96 &canceled), > 97 timeout); > > wait_event_interruptible_timeout set task to !TASK_RUNNING, > but wait_for_tpm_stat_cond still calls into mutex_lock. > > Regards > Peng > > > [   43.422135] Call trace: > > [   43.424570]  __might_sleep+0x74/0x7c (P) > > [   43.428487]  mutex_lock+0x24/0x80 > > [   43.431797]  spi_bus_lock+0x20/0x50 > > [   43.435281]  tpm_tis_spi_transfer_full+0x70/0x2c4 > > [   43.439979]  tpm_tis_spi_read_bytes+0x3c/0x48 > > [   43.444321]  tpm_tis_status+0x58/0xf8 > > [   43.447978]  wait_for_tpm_stat_cond+0x30/0x90 > > [   43.452329]  wait_for_tpm_stat+0x1cc/0x2e0 > > [   43.456419]  tpm_tis_send_data+0xdc/0x334 > > [   43.460423]  tpm_tis_send_main+0x74/0x160 > > [   43.464427]  tpm_tis_send+0xd4/0x13c > > [   43.467998]  tpm_transmit+0xc4/0x3c4 > > [   43.471569]  tpm_transmit_cmd+0x38/0xd4 > > [   43.475399]  tpm2_shutdown+0x6c/0xa4 > > [   43.478970]  tpm_class_shutdown+0x60/0x88 > > [   43.482974]  device_shutdown+0x130/0x25c > > [   43.486891]  kernel_restart+0x44/0xa4 > > [   43.490549]  __do_sys_reboot+0x114/0x254 > > [   43.494466]  __arm64_sys_reboot+0x24/0x30 > > [   43.498470]  invoke_syscall+0x48/0x10c > > [   43.502214]  el0_svc_common.constprop.0+0x40/0xe0 > > [   43.506911]  do_el0_svc+0x1c/0x28 > > [   43.510222]  el0_svc+0x34/0xec > > [   43.513273]  el0t_64_sync_handler+0xa0/0xe4 > > [   43.517441]  el0t_64_sync+0x198/0x19c > > > > Best regards On travel this week but thanks for the report. Investigating next weeek In the meantime, patches are welcome (whcih I will review next week). Br, Jarkko