Re: [PATCH 1/3] usb: chipidea: udc: add a helper ci_udc_enable_vbus_irq()

Frank Li
2026-04-21T09:28:50Z

On Tue, Apr 21, 2026 at 04:24:34PM +0800, Xu Yang wrote:
> The VBUS interrupt is configured in multiple places, add a helper function
> ci_udc_enable_vbus_irq() to simplify the code.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/usb/chipidea/udc.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index f2de86d0ce40..d4277d6611ee 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1835,6 +1835,20 @@ static const struct usb_ep_ops usb_ep_ops = {
> * GADGET block
> *****************************************************************************/
>
> +static void ci_udc_enable_vbus_irq(struct ci_hdrc *ci, bool enable)
> +{
> + u32 reg = OTGSC_BSVIS;
> +
> + if (!ci->is_otg)
> + return;
> +
> + if (enable)
> + reg |= OTGSC_BSVIE;
> +
> + /* Clear pending BSVIS and enable/disable BSVIE */
> + hw_write_otgsc(ci, OTGSC_BSVIE | OTGSC_BSVIS, reg);
> +}
> +
> static int ci_udc_get_frame(struct usb_gadget *_gadget)
> {
> struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget);
> @@ -2352,23 +2366,13 @@ static int udc_id_switch_for_device(struct ci_hdrc *ci)
> pinctrl_select_state(ci->platdata->pctl,
> ci->platdata->pins_device);
>
> - if (ci->is_otg)
> - /* Clear and enable BSV irq */
> - hw_write_otgsc(ci, OTGSC_BSVIS | OTGSC_BSVIE,
> - OTGSC_BSVIS | OTGSC_BSVIE);
> -
> + ci_udc_enable_vbus_irq(ci, true);
> return 0;
> }
>
> static void udc_id_switch_for_host(struct ci_hdrc *ci)
> {
> - /*
> - * host doesn't care B_SESSION_VALID event
> - * so clear and disable BSV irq
> - */
> - if (ci->is_otg)
> - hw_write_otgsc(ci, OTGSC_BSVIE | OTGSC_BSVIS, OTGSC_BSVIS);
> -
> + ci_udc_enable_vbus_irq(ci, false);
> ci->vbus_active = 0;
>
> if (ci->platdata->pins_device && ci->platdata->pins_default)
> @@ -2395,9 +2399,7 @@ static void udc_suspend(struct ci_hdrc *ci)
> static void udc_resume(struct ci_hdrc *ci, bool power_lost)
> {
> if (power_lost) {
> - if (ci->is_otg)
> - hw_write_otgsc(ci, OTGSC_BSVIS | OTGSC_BSVIE,
> - OTGSC_BSVIS | OTGSC_BSVIE);
> + ci_udc_enable_vbus_irq(ci, true);
> if (ci->vbus_active)
> usb_gadget_vbus_disconnect(&ci->gadget);
> } else if (ci->vbus_active && ci->driver &&
> --
> 2.34.1
>