From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011004.outbound.protection.outlook.com [52.101.65.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C4854071FE for ; Tue, 9 Jun 2026 06:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.4 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780987920; cv=fail; b=dyiaMnY9gYI9Q0tym/wI0796WVG/c1EMOZynrf4OirnXtj7y+HKH4etPhiY+9XKy+E79B0Zl9tp7jqxE/Q1J4XfeZI8celLbEx8H8s8PRS833WtN9JPKMt+NdxeVASgJY9Bei56HByfe536SH5fAmG+H8LT7NKofD9N2t8CYZ/g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780987920; c=relaxed/simple; bh=XglH2bHvRVLHaINookavwVklwEGHXNmQkkQSUZ822fs=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=gabdBMslbaPRALIN7IvoIazDeRZR1Ei/adZ0WSrnNNC2d6RpQBdrGPnOiVTHNDz4oWFuGNC5bmlLNOFCOeHQTD0tRcaMDKc1tzkboXNKw0ZWRUdAqBzj41yeYUw82/mYmrBTF4MYAf8HxvRbaIKBMwPamOJRYEHEg2I8yrlaayo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ijyTd0G+; arc=fail smtp.client-ip=52.101.65.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ijyTd0G+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nq+yk3OOevlMeqS0yA2Xitzee6zZNDXjaG43jAsqkrVchetBNHUQi1ra/LI7rRV5TLmTWQG5GTB1zqBr/+gUXiS0ym7fxuDd/Z1bAtvSKd5mFiZcvEB/B7VIG1GScd7WpmG1ZUNsyNrDTT4G7Px6ZTe+mVGEejuAzOe567rjsHVHi2TSSHifYhCRCtg0YAukrKvs7vnR4O5y+5QbhlsjJKhoq01UyyBoFlhn+ZBEihFuyG6d1MYOZtI5vb6ROJUoNfkCNTxu+6TjOI6/HIAzsNAf+b3kJgZa+mhlAknYicW34/scAPQAXvU3dCJoNMXbk3Am9dOLbUCgfI+K3hfoVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ixN5sl4KqpBq5TH1IeM1A8SbsbJ155eQ6EgVTheelrg=; b=GHDz++BfaTrZvbBNcI93wdvYlOS06EOJHyszIElkh5oZTsxVrxd9hlrJtzg+zQj8J8diue7CypBuGFdM2amQWw24cxzGXGtVxohqsKbvh1sNJhGFE01ogfKD8/kbu8PJvF0pMxKT0J/Io3DUcyQ4/6zWjvzsXICMas0yhdomO7AQyjzhrHUnUCASqAJxsvPScGuFt8Jf6//MTV/3FCUiY0zMH7hMzEKVnJP2g2yu316cYXietYXFfJa5KUCLdjztI3fllfgonmQdODz5VA4XtwrFVcGcGrLaqas3ETBZ8e6ujkXBsPLCY3Gnb+AWwsgGGtaImepDwbHhIDzwvrEfOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ixN5sl4KqpBq5TH1IeM1A8SbsbJ155eQ6EgVTheelrg=; b=ijyTd0G+2C7+Az1rH3NU2tz1HJxZWEdpAbdhgNbctc1E7+Ro+dlWiYPNWCglXgFblUTkuV9NvmRWQopcwTkdyv+O4dc7aZTdTlykmPR1AoZyaz2X8lwdrAI7X3S2FjGyWCpLDMP7M0lId8VLPkTyr4NYIqlTS6sJPnbhBh3akxzZd+K5nurufL/FI3L8ptbeRKRCXsIJ5R/VvIaQJqm7cUuCUM5fJc8v666OOmetoeLGtwcxowMciTncrca7ytHUpErwJaOHTT+BdI7KxmMW2VTZju8UoKMpFYGcIbG+OMpuZUV45nCl092coIPP91uokmBCsZ5nxXifr9VfcX12nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) by GVXPR04MB9952.eurprd04.prod.outlook.com (2603:10a6:150:117::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.14; Tue, 9 Jun 2026 06:51:55 +0000 Received: from AS1PR04MB9287.eurprd04.prod.outlook.com ([fe80::6f30:763d:17d2:b79c]) by AS1PR04MB9287.eurprd04.prod.outlook.com ([fe80::6f30:763d:17d2:b79c%3]) with mapi id 15.21.0092.011; Tue, 9 Jun 2026 06:51:55 +0000 Date: Tue, 9 Jun 2026 14:53:23 +0800 From: Liu Ying To: Maxime Ripard Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 17/78] drm/bridge: imx8qxp-pixel-combiner: Switch to atomic_create_state Message-ID: References: <20260608-drm-no-more-bridge-reset-v2-0-0a91018bf886@kernel.org> <20260608-drm-no-more-bridge-reset-v2-17-0a91018bf886@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608-drm-no-more-bridge-reset-v2-17-0a91018bf886@kernel.org> X-ClientProxiedBy: SG2PR01CA0184.apcprd01.prod.exchangelabs.com (2603:1096:4:189::9) To AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR04MB9287:EE_|GVXPR04MB9952:EE_ X-MS-Office365-Filtering-Correlation-Id: dc2a2916-bfbe-4ff2-62e8-08dec5f397b8 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|376014|7416014|1800799024|366016|56012099006|4143699003|11063799006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: rcqXNGVOVdJShJxmTPaI1Np/9s+MgSYL4GHzz0lPAfleHMcZpZp8inxMZWdlbpCKZKw9uUJWt5RA62vSkasipsRfRA2EdRQU9/vELQaCKv2cdOMr3+cwD3U6I/2qasKq0xGbFVrvH/1d2dA4qkqqr2IrOVlA2kSm9vyj25ZFOzWdCIImRKKpDo+/WZKdBE9RjkYLAhsO3QbmoHES/irGQ0EGo/GLoMuQeRzr7WERb7zABPTzHdnngCKFuY6dol1tFlBnwqIsmOeVdb1Jem6IB4zYTG62AlPruDhJdewidhIGqdgd7g+FSg81aCbT0QaEVbTMrQQdE2DLy/iRA/mKTv9PAgNJVosl3wyJs+1ZRGpopa4MCwqZ5EVlZeOBVAgGu41VVSykhRvySJM1vEH/W8OY7EAv5VX6vqNy4k3wKn3uG2Uxibra/dbiexwEy9yab1BhHNWUMtQtxcvqMPVHYMJhcvJb6uYByr8/afUu6VB0wxxm+YM7ad5jzANSZkJqauPlSCxaNJP7HUq89ultza+4Nn8c2bzQ2mw78tJS1VL9hZthjKoxhGKWhAxlyJbW4QuwIXMtlcQVWjOiOcf7Eo7oMrqpMMg4WbCqTUSAgCE+zvFNNHw6Zmk9lNQ3Gt0EjYB0yVuKIG41CXkThaGWCC0HE08RGE4N07Sa/0b1he+D1ryvHXz4wgiU9KLueVE/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR04MB9287.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(376014)(7416014)(1800799024)(366016)(56012099006)(4143699003)(11063799006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sx93qdVjryHw4vsetMVQAHyfC2YSYyOE4ua97f/FLtGz52m6YwgzIcMwsOlG?= =?us-ascii?Q?w3YPtZmZo+XyV2R7EN0Y1LtZ0lgV0RVqrXt9WVEY3KiDaPTiPxZfNsu298L2?= =?us-ascii?Q?FMXc69lcy/4XOVRK7TyyBf+Rxb5jKODRMYENmQul38bypz8xyNQKap/+kuGD?= =?us-ascii?Q?Otjl9a7jdeneuWCKW3AvONtor2aHNIg/POmdoxixU0YJ4qz7Kyb7oQgnfzYm?= =?us-ascii?Q?BO1flAHMWGQhf4DZzh65wWZlN9dOB8bXA8+h46zOpCczBi7GRB/2fcdLpxi8?= =?us-ascii?Q?Tm5Ind74MUlDrkOE2+J/2WXPB12iu/zTSLnXrjZMql5TaiogBRKhRSTKLs5J?= =?us-ascii?Q?/PDkNH2YJm+8yOTkKb9LOvW8sjf7mi+7YByADS2rT645BhEfzYecNKQDEq6W?= =?us-ascii?Q?acLfUdhXbFjmPSH2rT3kZikzKExicAQGO1Nj6vdPhJX3wtHP1/3OQhSR59Dh?= =?us-ascii?Q?NLw/FeyWLBBmtzRSCEnQqip0S0q+W6TD1HOEU/yGN96qWlBDnQngwxf0rnEi?= =?us-ascii?Q?Kb7U0OXabvmg71v5e5L5pZgawJimcnfxjUW/TQ8yjEAd8DK+nCdbE8cVsvda?= =?us-ascii?Q?oiGCXTBzJN1zmHGuoPI9kTKiDI5QWhaKA/ZQW4zFtrEIThs1sN79GaEBrhf+?= =?us-ascii?Q?k9+PzTFAX/ZiiBhUi5Au2V1xdgB4rfCt4NgPXMnHAvWyAvDhgltCfB3zaXEM?= =?us-ascii?Q?z5u6lldOktsSwCVNVbhvSpmmBCdi8GDfbcJi+BfGGdbIg3DGjKesKuSdwwJM?= =?us-ascii?Q?p4T5KV8ONPmK56FiEknUbooa66DL0AlqCOcT84N4jCplAbD7iBPbkC2fb7N1?= =?us-ascii?Q?zBWzb2HcnO3DhtPP2i775pQi9+8nssD4Wq7g+8ul5XonC4nmYC+EDlKCmXNc?= =?us-ascii?Q?V/R0br37i/64eyBLWBy7jKSNaC+YRMZEohZT6/qPr9/1LWFuS+GSPFLA+x5Y?= =?us-ascii?Q?hhBKPKUKKcDPKKQciYDxwqMd1jI/asoLneHTDIhcUABpLDuEbaGY33yckVmB?= =?us-ascii?Q?olvL7C9kX54ltfT4dD9OWCle9L3skrEKnevHEcfQYY5E9d7TodJ9N/ucQTua?= =?us-ascii?Q?Pj7ZOHnwLq640qKchsFtg1nLD03TT/AhuZhTy+2cCBVSvLwZ6c2RsUBRynqI?= =?us-ascii?Q?Fo/JM9j8pA2Fa4AvwAe5CTpbVrUv3bv93VabDLKo/QED+ULUg4+wtYZMgklH?= =?us-ascii?Q?nQL6/h20RYsJcEvHf9IJqA3nidbD6BRzVoKGul8geajnAqjCxlilgiwBDUV9?= =?us-ascii?Q?/od3yrzItfNKUH94lwoIWuKsbuUwqy2cr0+W9fc/lvotWQMUhr+0Tbtl2xJx?= =?us-ascii?Q?XSc4DD1xmwdC7X1rhBle85Vw2b2rgZNhTCjKJ19B4dQjuCpU3drEexAgmI5U?= =?us-ascii?Q?0H0pzf0kNW/S2f01/gWTV85d7SaO2AzZRK85vPyjz+vaTJROE1vKhu2cQB/c?= =?us-ascii?Q?NKzeKmFRUvqTSOtgQxbrztw+LMl6SKWgB2k7P0ebrAdJ+dTHiHb9nVwd4CdI?= =?us-ascii?Q?YSXyC0J1lABw9GjgWfAnu/ZtU70UakcP8J60d16sz7+6kVrnhNdJRvOmmG1R?= =?us-ascii?Q?VA5P8Rm10sR3s7HEUDOjrlasyJ7U9XDj+PZZkDfUq34vikEOxakoy9v2B1Gn?= =?us-ascii?Q?fGk06eqFa3tenukDl80jGGG7shnVmvKAiH2v/rwTjeaTuR75HkFffhmvEgTN?= =?us-ascii?Q?t1Y3V97ehvu5wcinV9pyzrFaxo4ZT9aUZ0CCQwNif0Y/AAoH4GNfT3NLUHRK?= =?us-ascii?Q?btBn3EaqFg=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc2a2916-bfbe-4ff2-62e8-08dec5f397b8 X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9287.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2026 06:51:55.0422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IPxCSkaWP+kajwpe40u5queElWTHkwt3TjLBAyi1+k44sP9DWYQZo3NTw+pOztJ9hyf8K2S3vq4uLZc9xktQig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9952 On Mon, Jun 08, 2026 at 04:35:59PM +0200, Maxime Ripard wrote: > The drm_bridge_funcs.atomic_reset callback and its > drm_atomic_helper_bridge_reset() helper are deprecated. > > Switch to the atomic_create_state callback and its > drm_atomic_helper_bridge_create_state() counterpart. > > Reviewed-by: Thomas Zimmermann > Signed-off-by: Maxime Ripard > --- > To: Liu Ying > To: Frank Li > To: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c > index e0ee51a9ca7f..941ce2f91e9e 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c > @@ -249,11 +249,11 @@ imx8qxp_pc_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, > } > > static const struct drm_bridge_funcs imx8qxp_pc_bridge_funcs = { > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > - .atomic_reset = drm_atomic_helper_bridge_reset, > + .atomic_create_state = drm_atomic_helper_bridge_create_state, Nit: drop a tab after .atomic_create_state to align '=' characters vertically. Reviewed-by: Liu Ying > .mode_valid = imx8qxp_pc_bridge_mode_valid, > .attach = imx8qxp_pc_bridge_attach, > .mode_set = imx8qxp_pc_bridge_mode_set, > .atomic_disable = imx8qxp_pc_bridge_atomic_disable, > .atomic_get_input_bus_fmts = > > -- > 2.54.0 > -- Regards, Liu Ying