Re: [PATCH v4 3/4] Input: snvs_pwrkey - use local device pointer to simple code

[Joy Zou <joy.zou@oss.nxp.com>]

On Thu, Jun 18, 2026 at 07:39:46AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> 
> Pre-existing issues:
> - [High] Missing cleanup for device wakeup and wake IRQ on driver unbind causes memory leaks and re-bind warnings.
> --
> 
This is a pre-existing issue that won't be fixed in this patchset.
Will address it in a separate fix.
BR
Joy Zou
> commit aed6a36738ed05979b6e5650a6efcf08cfb05a1d
> Author: Joy Zou <joy.zou@nxp.com>
> 
> Input: snvs_pwrkey - use local device pointer to simple code
> 
> This patch introduces a local device pointer in imx_snvs_pwrkey_probe()
> to simplify the code. It replaces repeated references to the platform device
> pointer with the new local variable.
> 
> > diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
> > --- a/drivers/input/keyboard/snvs_pwrkey.c
> > +++ b/drivers/input/keyboard/snvs_pwrkey.c
> 
> [ ... ]
> 
> > @@ -191,27 +192,27 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
> 
> [ ... ]
> 
> > -	device_init_wakeup(&pdev->dev, pdata->wakeup);
> > -	error = dev_pm_set_wake_irq(&pdev->dev, pdata->irq);
> > +	device_init_wakeup(dev, pdata->wakeup);
> > +	error = dev_pm_set_wake_irq(dev, pdata->irq);
> 
> [Severity: High]
> This is a pre-existing issue, but since there is no remove callback in this
> driver, does this leak the wake IRQ allocation when the driver is unbound?
> 
> When the driver is unbound via sysfs, the wake_irq structure allocated by
> dev_pm_set_wake_irq() seems to remain attached to dev->power.wakeirq.
> 
> If the driver is subsequently rebound, will dev_pm_set_wake_irq() fail with
> -EEXIST and trigger a kernel warning about the wake irq already being
> initialized?
> 
> Furthermore, because device_del() does not automatically free
> dev->power.wakeirq, could this memory permanently leak when the platform
> device is destroyed?
> 
> Would it be better to use devm_pm_set_wake_irq() here to ensure proper
> cleanup?
> 
> >  	if (error)
> > -		dev_err(&pdev->dev, "irq wake enable failed.\n");
> > +		dev_err(dev, "irq wake enable failed.\n");
> >  
> >  	return 0;
> >  }
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260618-b4-pwrkey-v4-0-4bfda105bdf3@oss.nxp.com?part=3