From: Frank Li <Frank.li@oss.nxp.com>
To: Griffin Kroah-Hartman <griffin@kroah.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Vinod Koul <vkoul@kernel.org>,
imx@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] dmaengine: fsl-edma: Add error handling for devm_kasprintf
Date: Wed, 8 Jul 2026 15:58:09 -0500 [thread overview]
Message-ID: <ak654b3IyRUHf2cw@SMW015318> (raw)
In-Reply-To: <20260708075736.47822-1-griffin@kroah.com>
On Wed, Jul 08, 2026 at 09:57:36AM +0200, Griffin Kroah-Hartman wrote:
> Add error handling statement to fsl_edma3_irq_init() for the
> devm_kasprintf() call.
>
> Assisted-by: gkh_clanker_2000
> Cc: stable <stable@kernel.org>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: imx@lists.linux.dev
> Signed-off-by: Griffin Kroah-Hartman <griffin@kroah.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> v2: fixed typos in subject and changelog text
>
> drivers/dma/fsl-edma-main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 36155ab1602a..d9fb717b5b53 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -414,6 +414,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
>
> errirq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s-err",
> dev_name(&pdev->dev));
> + if (!errirq_name)
> + return -ENOMEM;
>
> ret = devm_request_irq(&pdev->dev, fsl_edma->errirq, fsl_edma3_err_handler_shared,
> 0, errirq_name, fsl_edma);
> --
> 2.55.0
>
>
prev parent reply other threads:[~2026-07-08 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 7:57 [PATCH v2] dmaengine: fsl-edma: Add error handling for devm_kasprintf Griffin Kroah-Hartman
2026-07-08 8:14 ` sashiko-bot
2026-07-08 20:58 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak654b3IyRUHf2cw@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=griffin@kroah.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox