From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276573EFD14 for ; Wed, 1 Jul 2026 08:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782895722; cv=none; b=RozlcHsZvplf7ABNaSqDQM/DZajFF8fHYO4fPUvgbPe/qbx+c0J0KrMSl68egcYAhM3tlC8bPB+B87Fg9IuZENLj7R9z6VlPs5/bHW9r15R5MnJzieLa8sd+oGa8Cyoox34c7/rrJLGScYo184/cH3LwOaDuiykF/EnMkUBeTdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782895722; c=relaxed/simple; bh=AJZkLvOfxW0de6r+CyQc5qTyXDoiqp2t4JSLGDtsAk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mxTE8SyEvGzqiidb/V1cx268Y6iRYj6cy4t/z4uUcyev0GOq5xtGiicNKfPKMK9KXyh6u9+6cMAEbNc6W5Jv9MhZ8v27FSPw3EN5rXRiitH51oArtcsWkFSzJ+hO5oTUhgYISe+LmI5zD8dzgtzHjry4SqvdMsk3Hw7YtXJuptc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IMhPr3Lu; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IMhPr3Lu" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490cf3000f0so3229725e9.1 for ; Wed, 01 Jul 2026 01:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782895719; x=1783500519; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iIY4E2Qv/c4b0j+COVpWSOrsvci+vruq4kKRU7Wts6g=; b=IMhPr3LunO5E3LbAzUvscOgdDiI768nmQ7BlRBHyh0mj/GNEc8cxCngJ2ndzEmSiUA XpL+l4c3ZOE2NYokeBSoeeKPh07/ErY2mrXY5XZE1QxCLrKsTf9dQnsEbFnMDTiGcGzR paCtZN+dkFYkijtMeaUtUa8SQU0ZlyMZz3rPyzA6+PlJK7/bYs3NYkyT4tO+idkd7hrK iF+gIrPuPOdf+OCBr3/M96agXldYyBCloAzM7guHxV7xOyPSuscAuoVAyyOWkDClfdTC u0g1soBAhG7G/aerDx6HtnLF6ar7FHvaP1Pfgch/T4K+ue+k/9NfbQiZ+rjSYM18inAT 69Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782895719; x=1783500519; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIY4E2Qv/c4b0j+COVpWSOrsvci+vruq4kKRU7Wts6g=; b=d57ghP2j8tnQi5IX2nI9LCv8D6jGFuYTs2exhdpOksmZVFUWHGWDOopmu7qZ/xLUJr B7xiw9YrWIRIu9O2sQE381WYuci70WAkjixBoKKrxCKP+12C4GRyQUL/tiHNwms6NVup tIhlNj20Bz0KoB4IryzClJjykUd1tf30E0JifXcZDzWnyaJUexdAhgbBguteQaP4zNZX d1s1NtMfleaSEyLMYsWT2lilXEeW+U+TZS41BITmaJeQ0Khzi3EKyU7IrMJEcjvtdmKn hLTbvun5HWQARIR6Vk5OM3OJxYXiHPV4VIHiMSBW3GEfYAg6t0LvZLB7brzz5cWt+Xpe B/rA== X-Forwarded-Encrypted: i=1; AFNElJ8T+OtEoYum2MkkQQ/NmHcb9/hUjg+t7BJxrk9kO+KxqU5hMyhDfSXXO13cng4CqND4eQA=@lists.linux.dev X-Gm-Message-State: AOJu0Yx6tbjnZkGejClavsp3lXVr4S3kkH+T5373Bw78JsUMQA/1QlR4 zPchb4el2U8lPrySzjkP/dpQRBvvq5j9Sh6Ddq1txZVGRxP0jGJRkGFH X-Gm-Gg: AfdE7clMeXtM/wROSfADI6RcVDdvJ6+2RtwINxQyFQVeTBgYiRBoUBYJNZGysD67+ad gHWodL0Rqwi6UwhSIhIdMx2M1zFZ2QpPQLs5DCPO0bouYS3NaKKNWjihTaMPPvu+bgVd7Vtluc4 FjkkKB9Le68xKJodXDG8rayQ+X28TQywUgheN3Y4VKAl5MF6ALe6E8EhEllHBUz7AuJSddPu7I9 kFV5RDfITySYyHrv2fupSFbbngjL2Mzub7WVzQfmEtAB5n2+UL9kC+frn4HZvDHTDDCk+2m5lY7 ZOR3ZgPbBVy4Axy+B71rkwJxyB+S9QLNOjiwwzPLatPOgXvRiVW7xxZ2solBjlT/VQzvNjDvyc1 jxG1hh6Nhn/FSQL/udQIuUsDQx5ciLHYPMBSux1USXy8YPyFoeY2pMx7DT0lb+moom2ct4uoAYb jix0T+i3n1sR0jSZGiekDSfd/7WBZ9nodE0dDPA5Mr/wjG7yhx/WbrnZLbwEPRpm1ZDjWoMLS/h 5vtr9Nr6JsXrAT9bS3pgGmy2bjixVg4 X-Received: by 2002:a05:600c:4f4a:b0:493:a84a:ec5a with SMTP id 5b1f17b1804b1-493c2b26b38mr13891255e9.12.1782895719252; Wed, 01 Jul 2026 01:48:39 -0700 (PDT) Received: from Lord-Beerus.station (net-93-144-65-248.cust.dsl.teletu.it. [93.144.65.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475671d0403sm15802622f8f.29.2026.07.01.01.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 01:48:38 -0700 (PDT) Date: Wed, 1 Jul 2026 10:48:36 +0200 From: Stefano Radaelli To: Frank Li Cc: sashiko-reviews@lists.linux.dev, imx@lists.linux.dev, Frank.Li@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org Subject: Re: [PATCH v5 2/3] arm64: dts: freescale: Add support for Variscite DART-MX8M-PLUS Message-ID: References: <85af11e85dbb7cf5097d7c0ee567272ff6e87ec5.1780998600.git.stefano.r@variscite.com> <20260609100729.C9FF21F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Frank, On Mon, Jun 29, 2026 at 12:48:37PM -0400, Frank Li wrote: > > > > > +/* BT module */ > > > +&uart4 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart4>, <&pinctrl_bt>; > > > + assigned-clocks = <&clk IMX8MP_CLK_UART4>; > > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_80M>; > > > + uart-has-rtscts; > > > + status = "okay"; > > > + > > > + bluetooth_iw61x: bluetooth { > > > + compatible = "nxp,88w8987-bt"; > > > + }; > > > > [Severity: Medium] > > The pinctrl_bt group configures GPIO2_IO06 and GPIO2_IO09 as GPIOs and attaches > > them to uart4, but this bluetooth_iw61x node does not map these pins to any > > properties like device-wakeup-gpios or reset-gpios. > > Please check it, look like make sense This is intentional, these pins are not meant to be controlled by the Bluetooth kernel driver. They only need to be muxed as GPIOs in the device tree so they are not configured with different alternate function, since they are handled by our userspace initialization script following the power-on rules. This is also consistent with the existing Variscite DTS files, where these BT/WBE control pins are only muxed and not mapped to Bluetooth driver properties. Best Regards, Stefano > > > > > Will the kernel driver fail to toggle these pins, leaving the chip in an > > uncontrolled state? Is it relying on bootloader defaults or userspace sysfs > > toggling for these pins? > > > > > +}; > > > > [ ... ] > > > > > + pinctrl_eqos: eqosgrp { > > > + fsl,pins = < > > > + MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x2 > > > + MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO 0x2 > > > + MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0 0x90 > > > + MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1 0x90 > > > + MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2 0x90 > > > + MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3 0x90 > > > + MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK 0x90 > > > + MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL 0x90 > > > + MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0 0x16 > > > + MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1 0x16 > > > + MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2 0x16 > > > + MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3 0x16 > > > + MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL 0x16 > > > + MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK 0x16 > > > + MX8MP_IOMUXC_SD2_WP__GPIO2_IO20 0x10 > > > > [Severity: Medium] > > The pinctrl_eqos node configures MX8MP_IOMUXC_SD2_WP__GPIO2_IO20 as a GPIO, but > > there is no corresponding regulator or driver property that requests this GPIO. > > > > Could this unnecessarily block GPIO2_IO20 and cause a pin conflict for any > > carrier board that attempts to use it (for example, for usdhc2 write protect)? > > Was this possibly a copy-paste error from imx8mp-var-som.dtsi? > > Look like make sense, are you really use GPIO2_IO20 for eqos? > > Frank > > > > > > + MX8MP_IOMUXC_SD1_STROBE__GPIO2_IO11 0x150 > > > + >; Thank you, I will remove this GPIO. Best regards, Stefano