Re: [PATCH v1 07/20] gpio: Add missing OF module annotations

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]

Hello,

On Tue, Jul 14, 2026 at 07:34:25AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> 
> Pre-existing issues:
> - [High] Missing MODULE_DEVICE_TABLE export for the mpc52xx_simple_gpiochip_match table.
> --
> 
> --- Patch [7]: [PATCH v1 07/20] gpio: Add missing OF module annotations ---
> commit 292bbbdcede3ce86fe1309d514a852f272c27bac
> Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> gpio: Add missing OF module annotations
> 
> A driver module matching devices using an of device id table is supposed
> to declare that in the module's metadata. Add this information for
> several drivers that failed to declare these.
> 
> [ ... ]
> 
> > diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> > index 00f209157fd0f..2c828bc922ae3 100644
> > --- a/drivers/gpio/gpio-mpc5200.c
> > +++ b/drivers/gpio/gpio-mpc5200.c
> > @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
> >  	{ .compatible = "fsl,mpc5200-gpio-wkup", },
> >  	{}
> >  };
> > +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
> >  
> >  static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
> >  	.driver = {
> 
> [Severity: High]
> This isn't a bug introduced by this patch, but since the patch focuses on
> adding missing OF module annotations, should it also add one for the second
> match table in this same file?

Ah, this is snaky, there are two drivers in that file and thus two
of_device_id arrays. My script only handles the first, so the style fixes
are missing here, too.

I will wait a bit for further review and then address this in a v2.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]