From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37183A5443 for ; Thu, 23 Jul 2026 05:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784784628; cv=none; b=Qflq08FInZKJXFz9HLFxaYtiLfOG7XM+EOTl8cgPBDFZNWDLjFrnNOuYQgud50zvqj7eGu8P2y2YvdDBjjTo20ivEPy2YiRCeNc9LHuEze1pv3DqHcoAB9XuI9qhJMJk2nVAyEK07t9g8FzbrZkPSLWFOwEMvfiwTIDJMhB05/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784784628; c=relaxed/simple; bh=cIDAJnuOBt+rwzyUW445QgCOtd1xWXtIDuEa5qHVxuk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oiuwMUoHKt4iJDXxN0uMq+wPydBpWUIlyDfdoF8pLzdwz3t5tLFGyhpZWLUvytFckg74w3AiCwTItrQ6uONiqq/tDnrn+vSa7wmd352cST32OkLcEmBE2M2IlwdD+SYD6hJsgZxjj2mY3LNtduvLuxsAmUApJIysBu4px+hab2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=WIdKSPaU; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="WIdKSPaU" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f8773ce8dso154268f8f.0 for ; Wed, 22 Jul 2026 22:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784784624; x=1785389424; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gbqp/BETAuL10zK/QjDMLkNML3uJVDKQA/suEZyhESk=; b=WIdKSPaUNzC/Y+/7UNdQdsylfS5HqWPF54UI3vmllZsQyAwtA38xCwoWs2l2zHG3BG Ko8LJrlVpGZto0OIRgVeEOSX7VqxR1119L2asGION+Ywvynvu/uUX1B7s1q95wivGZR0 TlGG1GLVgrPgR+l8zJco+Qgplk136k5iU5JOas5KHu/QYIxkCnKO9ClQMsT4FKqtXxmp W7y/gZJ4XP4EmhS9/3irmIifskgRJkU3LwvojIjr+hwwE6uHLP2ie92jXBr9WYPDCAFM ZOh9M1kafYPRASqJ04i87AI1en9R+Tl+NJuyJgwz3h8iMVzE9rQ5AIbVrWtCSeYxJ9/X SOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784784624; x=1785389424; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gbqp/BETAuL10zK/QjDMLkNML3uJVDKQA/suEZyhESk=; b=onjv42+Kp1NAQBzu8cio9EQFl22TOUzJsyGK5KHqwwhJMtV5amHWifNAu1y6G2Q6W/ 6AGEJV7qMyuh+ezkcVmHZ+6KwKy0xIoxNt2alwNhCSLv5GHnSZ/qX1AxZrQiYiahW3C+ DDqu1Ni5lgKkv0AUgn1GCWZ6An1GSJ++jgN86Tg7pcvB1y2D0FVA2DxibhZ+FTlaZW1p AtzmOwOTpcpgd1CpTNnqUH85HjfpJUee6XlUvfeiQRv84w8JfVexyCplImrrI0V4Ami7 CEIHzNe+mSldVRPv2In1S6t/ux5963R5EfRIPN5xqUXjWV9He0xZvUwVlX5W1Xm+B/kD 3roQ== X-Forwarded-Encrypted: i=1; AHgh+Rq7sZ7NVqFHW0s7n85Ni+QwrBpMEg0poNwKaiIGaU9TLCo1jEfMlxdpS7FmvCN7IUSQ3T8=@lists.linux.dev X-Gm-Message-State: AOJu0YwLr+uE0GMtNLGg//uaJCqAPRgj4Y2hhLuO5+wHCtxBHCvUtfrZ knIwReevc+tiuw/dd0Rl0LsWJF6q/tdF3zz1a5GdgWJ0xCgABuD0pvJb+tozE2l2sgE= X-Gm-Gg: AR+sD104oQZaJ8Ha+NFrlbHElmgm/23oEa/lH2H70bl8SXfXr2i/nbVpCULgqesNrva MasqS3K3YYVkp67bVBD58xSz9Rb+z40Z1WF90qCTibjIV0MGYzf3TuaMT5AqxMmDyLSlzdyyQIx +ZVebXu6OCOuSmtKGKIf8To0PsZ4g+XHLW3IonggXvmlGaVngEaXM9fpwD+Bi1JFU+n8f5B8xuo kgwHG/M66aQYiQAoNcJXrujC5XKTG7FriprHPq31FmS0KDdkuV0EIwpZ8M8hYL0B0l2iFza9GTq 3+iAx1rWePzQwJvga3MTCu+h6C0ptwT21mLmYoWrDi/+SHYvxaPOQ4wULkJ11bG6ogBonEFkCKu wwpjIM18S/UWjB/u/OL+Q0+42SjPSMwNBkiuKxpk1uycPcSV5Ozw7QXoef3RUda0EoXXeRgKIdW 0ug24pUFM= X-Received: by 2002:a05:6000:402a:b0:47f:4c9b:99b1 with SMTP id ffacd0b85a97d-47f8d754483mr1814550f8f.32.1784784624091; Wed, 22 Jul 2026 22:30:24 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85bc62basm11851732f8f.13.2026.07.22.22.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 22:30:23 -0700 (PDT) Date: Thu, 23 Jul 2026 07:30:21 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Cezary Rojewski Cc: Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Nuno =?utf-8?B?U8Oh?= , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Sylwester Nawrocki , Charles Keepax , Kuninori Morimoto , Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Liam Girdwood , Mark Brown Subject: Re: [PATCH v2 6/6] ASOC: Unify code style for platform_device_id arrays Message-ID: References: <093867d47c079d2aaab06bccaae734c54c342a7d.1784528081.git.u.kleine-koenig@baylibre.com> <0f625961-8e2d-4ed9-ab5a-fd95bcb4c87a@intel.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oygi6rynka5zevcn" Content-Disposition: inline In-Reply-To: <0f625961-8e2d-4ed9-ab5a-fd95bcb4c87a@intel.com> --oygi6rynka5zevcn Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 6/6] ASOC: Unify code style for platform_device_id arrays MIME-Version: 1.0 Hello Cezary, On Wed, Jul 22, 2026 at 07:55:26PM +0200, Cezary Rojewski wrote: > On 7/20/2026 8:23 AM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: >=20 > > sound/soc/au1x/db1200.c | 2 +- > > sound/soc/codecs/adau7118-hw.c | 2 +- > > sound/soc/codecs/bt-sco.c | 10 +++------- > > sound/soc/codecs/wcd934x.c | 6 ++---- > > sound/soc/fsl/imx-pcm-rpmsg.c | 6 +++--- > > sound/soc/intel/avs/boards/da7219.c | 6 ++---- > > sound/soc/intel/avs/boards/dmic.c | 6 ++---- > > sound/soc/intel/avs/boards/es8336.c | 6 ++---- > > sound/soc/intel/avs/boards/hdaudio.c | 6 ++---- > > sound/soc/intel/avs/boards/i2s_test.c | 6 ++---- > > sound/soc/intel/avs/boards/max98357a.c | 6 ++---- > > sound/soc/intel/avs/boards/max98373.c | 6 ++---- > > sound/soc/intel/avs/boards/max98927.c | 6 ++---- > > sound/soc/intel/avs/boards/nau8825.c | 6 ++---- > > sound/soc/intel/avs/boards/pcm3168a.c | 6 ++---- > > sound/soc/intel/avs/boards/probe.c | 2 +- > > sound/soc/intel/avs/boards/rt274.c | 2 +- > > sound/soc/intel/avs/boards/rt286.c | 2 +- > > sound/soc/intel/avs/boards/rt298.c | 2 +- > > sound/soc/intel/avs/boards/rt5514.c | 2 +- > > sound/soc/intel/avs/boards/rt5640.c | 2 +- > > sound/soc/intel/avs/boards/rt5663.c | 2 +- > > sound/soc/intel/avs/boards/rt5682.c | 2 +- > > sound/soc/intel/avs/boards/ssm4567.c | 2 +- > > sound/soc/samsung/i2s.c | 2 +- >=20 > This change is outstanding when compared to patches 1-4 which follow the > per-driver approach. I'd expect one driver per scope e.g.: Intel's avs > split away from the rest. Well, patches 1 and 2 primarily follow the one patch per type of change approach that happen to only affect one driver each. In the v1 thread I was asked to split out split out the amd/acp bits which resulted in patches 3 and 4. (And just now I notice you also replied and asked to split out intel/avs, too, which I missed. Sorry!) Conceptually I think one commit per driver is the right approach[1] but most maintainers/reviewers seem to favour one commit adapting one thing for all drivers in a subsystem. And in my experience no matter how you make it, you get a reply to change. Will split out intel/avs for v3 and maybe hit the sweet spot then. > Nitpick: s/ASOC/ASoC/ Fixed in my tree, so will be correct in v3. Best regards Uwe [1] My reason for that is the "one atomic change per patch" philosophy that allows to document who reviewed/acked what in a fine-grained way and allows selective reverting and backporting as needed. The downside is that the number of patches explodes, but git is able to handle that just fine in my experience. "commit count" is missing in https://markcarrigan.net/2026/06/18/the-museum-of-meaningless-metric= s/ --oygi6rynka5zevcn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmphpusACgkQj4D7WH0S /k4QMAgAiodEGJ+3wdZbbFha1cyeXY/4KnGWZwIGS91iUn/fGAugHIQjGusXDdlf MK7Bm5B6RFc0nJmVRuK+dlVyvBjWnDiaqrcvEgW5iiGHt0e2d4B2yEu7aNVj1PDs wuPQOThaBv7yf9NP9ddxiGofvSIuKVv7TxVf+Qf/OQjSyYseX57zpPS9h19m71vl aVVtSUNPiwoeUnQWkRsq/qWZgnOeUrQTyXQekkv7uz1N43QnOnmb3m3iBX+mI1AN TAfJQ2rTyMYEyIZfvwHe4nD5Nz4TpjStRk1BmH/HE8616DR4stk5Ts4tvSv1f6KT qRSBSo9+7iG4nv7Avnq6gwIf7pTisw== =tSnN -----END PGP SIGNATURE----- --oygi6rynka5zevcn--