From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013011.outbound.protection.outlook.com [40.107.159.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0ABB47ACC1 for ; Thu, 23 Jul 2026 15:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784821977; cv=fail; b=blaSyo5DddREkDebNpqh0mqyFjuLAMbLI0e7WYk9FXVx1d8aOTC6z6Z3bX2niUcYFN4PTf0TKEY+OLDXL+gNr2AG85tSlTHiHnaAvd1nqzChvin8X/TEqrbRH/RDIAp0vY77tDuM6EqcvYp+U358kvq3hw5wuIsbcrTWmkd3zQM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784821977; c=relaxed/simple; bh=fEfsp2mFzUyJYZj4GqQ1obX7kFOF0OcrNYeKzTYT+pI=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=FbILAt7+pSvMJ/yAgXxVUkit4fhAMTCE0I3WPrP2pEt026D6N+Uk1zp3N3EfOfLMxNEgLgP44+YaZ4lr2E48VA4gbOMjYr+oVUxt645WVEjlPeDYTRrHQAPkbEEfyOr4+YG/0JycmHx6aWIF2jH0t+0ceMEI8OHn+7vmMg7pgpk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jgDcXdj7; arc=fail smtp.client-ip=40.107.159.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jgDcXdj7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jsWCE8QsZ9asEh3E5zHjn+JfuGqA7cRmiQKS3trMRdxIRXADLz+Ir8a8E0Tk5xTyBO1vUfKb5wcP5xRAMiRtSxWi6UFi2INLwxtuMhMQt6DpYxV7d7bvrMlMuP1g6lyCFqWSf+c3ISho5uUoW1Imkr+zhDYN/y8IZFrmN7fx4sYXoitYLnvtryT+obJDLZEBFastI2FLcdD9qv1ywtWR9TNqEvneUOaHX1QpBvoxE1Q4qJc2wrgv9vtHafOSVWCpCWl22qFY1NuyGzzLty1XGseCNrXfZm00Eq1ErUnECsbFyxyBC32duLFybGH8qnBiSKmchU0vkoFnJ5j+SL4gPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DM7Et50NJIRgF6R3McPdIaOmJUJ0Fmm5wc+JZ8MM1Dc=; b=GjvE2V2HduGA40aXP9mWushVyFfzuhvWOt8pPv0WLjhdfEjAbNBwy1iBmkrQw6vNXq/PcE9mQsqaWBtNn1PGACpwNTzOJsEc1kUVcP/BSytyz+B/WqA1FEaiba/7LY0DfZbduIPS+eMxwREVi6Rb1PbmclmocoSSuYdZuzDzlqRXRkakVYYC4d3y0sdvz5UtvgqFqKyG38pO+3trvbuaQtA55QOl0c2+v7kDfHp7GwAsfLbhlfbXPckLi+BxIRoNwkbsI9ACsadLWlZHs78OOP22z4xDLr+KPWzldSvQoXJ5bjMKJBfjiG0Y+PBtJbMnLW/nl2ak6cMvOfJzEFH1uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DM7Et50NJIRgF6R3McPdIaOmJUJ0Fmm5wc+JZ8MM1Dc=; b=jgDcXdj7QAjnGJ68ID6NFBXdjNHK3Ej6gPu7bJwktU0U0p2oxdYOBHgoZzl27wf1E1OmlgqRks8EVNjwWXeUkFjY+7zD0GnU+UfgALSsxLHyPVn7pWgRZBxxm8sZD+iiHrjMxxWCBUlZTWcS41RVZ/Dbqc45JfvzyRrQin0OBnUDhGGYhcWbbMQejSd6AXqXqebfY8i2hoYROcViqdcvtxUQkRHbUCMWYxsRE7YFGV0gYPNoyIU8djo+4PerxHKVBcnVwAgwtrruprAG1rK4ncOTggEs1aNb+O9ojKA6RuUT56+WUfP/vxO3a1iMIZwh5Nwy0Vi4vRB5LsOPcQbhPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by AM8PR04MB7284.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Thu, 23 Jul 2026 15:52:48 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0245.010; Thu, 23 Jul 2026 15:52:46 +0000 Date: Thu, 23 Jul 2026 10:52:32 -0500 From: Frank Li To: Liu Ying Cc: festevam@gmail.com, m.felsch@pengutronix.de, Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v13] drm/bridge: imx: Add i.MX93 parallel display format configuration support Message-ID: References: <20260723-v6-18-topic-imx93-parallel-display-v13-1-ccf3f9bbc0fc@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723-v6-18-topic-imx93-parallel-display-v13-1-ccf3f9bbc0fc@nxp.com> X-ClientProxiedBy: PH8PR07CA0038.namprd07.prod.outlook.com (2603:10b6:510:2cf::18) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|AM8PR04MB7284:EE_ X-MS-Office365-Filtering-Correlation-Id: 836e7e36-168d-425a-06b3-08dee8d27041 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|7416014|376014|19092799006|6133799003|56012099006|11063799006|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: /kYgUNL9Les+Conf3P5hVXU8JMxDlbC6AO0XHF4YFVCUJ7A677FCsdVZFmIQkYeCtYzDa49lbShp3iR6cKobjYinliWQj0qPE3KWiORjDj4KYDk5HqaT2jmUgCT2duWoecnbu6IiKq3zmD0N3Vby267Yv8YsSMbj6zvNBy8UeE7AQqSxxUiGW9abAsytSvsZD2j6PAsmK0JOJwncWY5fPxZznpjtktz1cFy6Z7M/xHosZWeiJYxSMqcEleOxkvz63ndEAOE6rmn6kxkQAGDcfq9w0+a6ePGD/pOFCC5I/lXCVgZmeLzrf90IeiGA7KzIBuwRDaGxLch5CyOi2foZctpxNilsXFGjT+8FnvMHX8hn11mJlQpeWG02bnQTwqZhr07yMf1DJoJ6g1izwYyesHZddIc5tCPZQ71iVhWtQEnen/S7Tgo6Lv+vwngsQoQcKpG8VFianizfVGcU8wRbbm0WJlFRA/jTKJAiVoyvuiWZ1aDnTV98CURijb/ExCT8vKEXPXw5dAzj2oatUf6eerBe9dW3XK/B5FxJZbYu91d7dBobCV5MYrRoXY7Z91EUdU9AUIAef9AFvh5JRTKAc06ZEQqlTo7qePiJt/tzHtpG7trLputj4yH0ddj6TtkI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(7416014)(376014)(19092799006)(6133799003)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yetEN1kL04RX3cjx1F/krNq+J0O6nJPiDgzU1NEr13CrUoXwYYSfrqry70o2?= =?us-ascii?Q?4/RoZoax7M2+QLkbAkta4Kpvbs/mV2qr0erY8LicXRfEm1MrmqPn1Eh/G+To?= =?us-ascii?Q?VjH+Azv23i3eFGDVtKzyoTlnND9h0fJZh6Vhw9XCUOfd3aJ4W94CEV+RmVYp?= =?us-ascii?Q?h7Mwedy44KrTXyPIma6uWGkzGAdlKFn15Mv5hiiF3FbY0wHrNKCxpBaime/5?= =?us-ascii?Q?CdwKwzhru/wFLriFFrPpeDngmOvKK3djA0eTcusCGrkZGdhlHaedu9W2swLS?= =?us-ascii?Q?UBfst7RMXo8sDtIlV6RkaYHfEn6lv94qCNUhKs7mAraohMk+1vyM/I5iUzZw?= =?us-ascii?Q?MGATTfcAP2sPBIIJKvkQQ/xuLWGReZR/BlSqFSLYdUpw7f4hJ4YIyl06S71X?= =?us-ascii?Q?6EvhsQd2KqxnGsp5eIRAPiKX3/zAQiv+gXuqErCtDyocUzzT44kUbpu1g3ml?= =?us-ascii?Q?HHJG2b/DS2WTkOO7qdWF4Dof7Xy0SYEs1Xe00d4AsuvqxHVNGrx3nvLM1A/D?= =?us-ascii?Q?fiWgh5qAf5DeSdWW0D4WsGODKmcR3KprJFhLRDgfQc/N9DB4xM7jL4jSsleH?= =?us-ascii?Q?6me4vlhqBL3vQ3X+mrSxBtSSPyF7c/BIA8w/5yqgfLPQTxhwKmx86/WYNSSg?= =?us-ascii?Q?4U7IPjImlstsVXIXRb2RGY+5svtF1os5CEwXrvxgilU7Xi4mn/Rri1+86pQZ?= =?us-ascii?Q?hOxBj1n9knyrnbaECom3Kzs9Eiij3EFaW6WLzYwn/pdMvj4RPpj32OF9KH1G?= =?us-ascii?Q?LvSmDWIVvrUqB2ohGcKsILOrhRAq9F0nySo3wuxSSiCuAXCInReMxsa5gWqh?= =?us-ascii?Q?xD4A97UjT9hPIcmTFH9D6LWjECZU7hFC/xFyShSLR/XZRKoa1Ql5gSh0jECw?= =?us-ascii?Q?ly/QN4Dh0QdixfxpUq7p+/S1J34lRVqRLaS+xOdFJLmcx9NDa3AV4BRxLhHz?= =?us-ascii?Q?jbdKgfOvTFfyXNmXnwFXRXYTvnG1qfAjh+6qJSgsgErUVKrLZDil+5qh78cP?= =?us-ascii?Q?K9wfV4kT97e/Px5VNseq3ErUPS0ejcJyIThxU4RZ7Zrf/IbOXPHECmeC7J54?= =?us-ascii?Q?T9Y732puwSJU16bUTti1WhoT1ZpviSdxfwRcspA9RR46q4aSfk5Cq/iok2Bz?= =?us-ascii?Q?WU1h3nUGboRcu91EDnqi9bfCyH3nwV9llnyZ+Avv4WRU7aLkJ96/IkrW05Po?= =?us-ascii?Q?VFQD0l+gdM1NFAnROJcDJ3m6NXnHUsU0ajgNA3/4zy+Y3q/05zwQSGJE5Klp?= =?us-ascii?Q?qInu3OtOy72XCGUvJ53LuNwioQeQr6IBmlTUBCQh5ce7apqH5Xulmmvx3y7O?= =?us-ascii?Q?JpDHMwh5JgISyqmQ4ZqP9yc+T5sp+Onp4ktFAw+5CaztuYx97VjHMH4mMsJN?= =?us-ascii?Q?/+IUvMoNIk/WzjPNg/1yjOXob5sbr2dvEgnyhcVfsSZ4utxFNbwxnX4A+1FC?= =?us-ascii?Q?oK6fuRfcXrq1xEDJa6gTH55T3Ze2PeI/5MGXb6JCk5ZuMtfMO/ORoSKcfSdP?= =?us-ascii?Q?5bBBDFyoXcRMfbiaJ3iHg9pvYXc5M4eNCSxyb9/2QmWWgBx8gnJ1bS6x8TZO?= =?us-ascii?Q?P5QEUBeISB4ctYWHPoT79rzbcj0czCjkBdoCgENjEGE704vBcuFsUn+lNFLg?= =?us-ascii?Q?pIE5ii9bFPOWcQQGlHOjsFgcsPRj+fTQ2lHvUlr3NzDlrBrvdF4H6JMrwoj4?= =?us-ascii?Q?AH9aFGpPR18RhGe3sjlaIwbXFNdJDtvUv1PiqOA4X+ZVHkibBb4DEBRGUDcX?= =?us-ascii?Q?JZxzcOpcHlYZHVO4lGNAQp7kQc4dE7dBOIb4VLhDMrT1z5c3QM3X?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 836e7e36-168d-425a-06b3-08dee8d27041 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 15:52:45.9746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9qKf/+LIsP9GGCMdeecesx2rMepNZ0EPfPtt/k2nrbRyrVl+PKtWcbRAC73kedhiJ3jLjvcup7rrx93Cx0EuYNAE3QVm1aGSgAAHfOFf0j2ZHWinS6KNrVt57bhuo+Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7284 On Thu, Jul 23, 2026 at 02:37:32PM +0800, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add a DRM bridge driver to support the display format configuration. > > [m.felsch@pengutronix.de: port to v7.0-rc1] > [m.felsch@pengutronix.de: add review feedback (Alexander)] > [m.felsch@pengutronix.de: fix to short Kconfig description (checkpath)] > [m.felsch@pengutronix.de: use "GPL" instead of "GPL v2" (checkpatch)] > [m.felsch@pengutronix.de: add bus-width support] > [ Liu Ying: Port to drm-misc/drm-misc-next(v7.2-rc2 based) ] > [ Liu Ying: Add nxp,imx91-pdfc compatible string ] > [ Liu Ying: Call drm_bridge_get() for next_bridge ] > [ Liu Ying: Reject unsupported output bus fmt in .atomic_get_input_bus_fmts() ] > > Reviewed-by: Luca Ceresoli > Signed-off-by: Marco Felsch > Signed-off-by: Liu Ying > --- Reviewed-by: Frank Li > Hi, > > I'm taking Marco Felsch's v11 work over and trying to add the imx93-pdfc.c > driver. > > DT binding patch and DT patch in v11 have already landed, so only need > to send the driver patch out for review. > --- > Changes in v13: > - Reject unsupported output bus fmt in .atomic_get_input_bus_fmts() (Sashiko bot) > - Tweak commit message about change log > - Link to v12: https://patch.msgid.link/20260722-v6-18-topic-imx93-parallel-display-v12-1-a59dbb4dbc13@nxp.com > > Changes in v12: > - Link to v11: https://lore.kernel.org/r/20260303-v6-18-topic-imx93-parallel-display-v11-0-1b03733c8461@pengutronix.de > - Rebase onto latest drm-misc/drm-misc-next > - Drop DT binding patch and DT patch because they have landed > - Add nxp,imx91-pdfc compatible string > - Call drm_bridge_get() for next_bridge > - Cc Marco > > Changes in v11: > - Link to v10: https://lore.kernel.org/r/20260302-v6-18-topic-imx93-parallel-display-v10-0-634fe2778c7a@pengutronix.de > - Fix double space (Liu) > - Drop 'const' (Liu) > - Drop GFP_KERNEL from kmalloc_obj() (Liu) > - Add r-b (Luca) > > Changes in v10: > - Link to v9: https://lore.kernel.org/r/20260115-v6-18-topic-imx93-parallel-display-v9-0-2c5051e4b144@pengutronix.de > - Add MEDIA_BUS_FMT_FIXED (Liu) > - Drop next_bridge from driver struct and use bridge.next_bridge (Liu) > - Drop linux/of_address.h include (Liu) > - imx93-pdfc: drop bridge.driver_private usage++ (Liu) > - Make use of kmalloc_obj() (Liu) > > Changes in v9: > - Link to v8: https://lore.kernel.org/r/20260113-v6-18-topic-imx93-parallel-display-v8-0-4abccdc473a5@pengutronix.de > - dt-bindings: drop unncessary changes (Frank) > - imx93-pdfc: drop bridge.driver_private usage (Luca) > - Kconfig: Adapt Kconfig symbol and prompt (Luca) > > Changes in v8: > - Link to v7: https://lore.kernel.org/r/20251202-v6-18-topic-imx93-parallel-display-v7-0-2cce31d64608@pengutronix.de > - dt-bindings: add nxp,imx91-pdfc compatible (Liu) > - dt-bindings: use video-interfaces.yaml# (Liu) > - dt-bindings: s/data lanes/data lines/ (Liu) > - dt-bindings: drop 'reg' poperty > - dt-bindings: drop #address-cells, #size-cells > - imx93-pdfc: drop drm/drm_print.h include (Liu) > - imx93-pdfc: s/exist/exists/ (Liu) > - imx93-pdfc: drop MEDIA_BUS_FMT_FIXED from imx93_pdfc_bus_output_fmts > - imx93-pdfc: imx93_pdfc_bus_output_fmt_supported: make fmt const > - imx93-pdfc: Rework input-fmt selection to always fallback to a sane > default. > - imx93-pdfc: imx93_pdfc_bridge_atomic_check: make use of > imx93_pdfc_bus_output_fmt_supported() > - imx93-pdfc: drop 'reg' dt-property usage > - imx93-pdfc: imx93_pdfc_bridge_probe: pass -1 for endpoint reg value (Liu) > > Changes in v7: > - Link to v6: https://lore.kernel.org/r/20251201-v6-18-topic-imx93-parallel-display-v6-0-7b056e1e5b1e@pengutronix.de > - Add missing bits.h and bitfield.h headers (lkp) > > Changes in v6: > - Link to v5: https://lore.kernel.org/all/20250304082434.834031-1-victor.liu@nxp.com/ > - Add bus-width support > - rebase onto v6.18-rc1 > - add review feedback (Alexander) > - driver license "GPL v2" -> "GPL" (checkpatch) > - make use of reg of-property > - fix to short Kconfig description (checkpath) > - add OF integration > > To: Liu Ying > To: Andrzej Hajda > To: Neil Armstrong > To: Robert Foss > To: Laurent Pinchart > To: Jonas Karlman > To: Jernej Skrabec > To: Luca Ceresoli > To: Maarten Lankhorst > To: Maxime Ripard > To: Thomas Zimmermann > To: David Airlie > To: Simona Vetter > To: Frank Li > To: Sascha Hauer > To: Pengutronix Kernel Team > To: Fabio Estevam > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > Cc: Marco Felsch > --- > drivers/gpu/drm/bridge/imx/Kconfig | 11 ++ > drivers/gpu/drm/bridge/imx/Makefile | 1 + > drivers/gpu/drm/bridge/imx/imx93-pdfc.c | 222 ++++++++++++++++++++++++++++++++ > 3 files changed, 234 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > index 005a745e5c47..49fcecfee38e 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -107,4 +107,15 @@ config DRM_IMX93_MIPI_DSI > Choose this to enable MIPI DSI controller found in Freescale i.MX93 > processor. > > +config DRM_IMX93_PARALLEL_DISP_FMT_CONVERTER > + tristate "NXP i.MX91/i.MX93 parallel display format converter" > + depends on OF > + select DRM_KMS_HELPER > + help > + On i.MX93 and i.MX91 SoCs the parallel display format output is > + controlled via the MEDIAMIX BLK-CTRL DISPLAY_MUX. > + > + Say 'Y' or 'M' if you use the parallel display output path on a > + i.MX93 or i.MX91 SoC. > + > endif # ARCH_MXC || COMPILE_TEST > diff --git a/drivers/gpu/drm/bridge/imx/Makefile b/drivers/gpu/drm/bridge/imx/Makefile > index 94ac8c40ebe9..99f28cd013ae 100644 > --- a/drivers/gpu/drm/bridge/imx/Makefile > +++ b/drivers/gpu/drm/bridge/imx/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_DRM_IMX8QXP_PIXEL_COMBINER) += imx8qxp-pixel-combiner.o > obj-$(CONFIG_DRM_IMX8QXP_PIXEL_LINK) += imx8qxp-pixel-link.o > obj-$(CONFIG_DRM_IMX8QXP_PIXEL_LINK_TO_DPI) += imx8qxp-pxl2dpi.o > obj-$(CONFIG_DRM_IMX93_MIPI_DSI) += imx93-mipi-dsi.o > +obj-$(CONFIG_DRM_IMX93_PARALLEL_DISP_FMT_CONVERTER) += imx93-pdfc.o > diff --git a/drivers/gpu/drm/bridge/imx/imx93-pdfc.c b/drivers/gpu/drm/bridge/imx/imx93-pdfc.c > new file mode 100644 > index 000000000000..2d6ca95ed554 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/imx/imx93-pdfc.c > @@ -0,0 +1,222 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +/* > + * Copyright 2022-2025 NXP > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#define IMX93_DISPLAY_MUX_REG 0x60 > +#define PARALLEL_DISP_FORMAT GENMASK(10, 8) > +#define FORMAT_RGB888_TO_RGB888 FIELD_PREP(PARALLEL_DISP_FORMAT, 0) > +#define FORMAT_RGB888_TO_RGB666 FIELD_PREP(PARALLEL_DISP_FORMAT, 1) > +#define FORMAT_RGB565_TO_RGB565 FIELD_PREP(PARALLEL_DISP_FORMAT, 2) > + > +struct imx93_pdfc { > + struct drm_bridge bridge; > + struct device *dev; > + struct regmap *regmap; > + u32 phy_bus_width; > +}; > + > +static struct imx93_pdfc *bridge_to_imx93_pdfc(struct drm_bridge *bridge) > +{ > + return container_of(bridge, struct imx93_pdfc, bridge); > +} > + > +static int > +imx93_pdfc_bridge_attach(struct drm_bridge *bridge, struct drm_encoder *encoder, > + enum drm_bridge_attach_flags flags) > +{ > + return drm_bridge_attach(bridge->encoder, bridge->next_bridge, bridge, flags); > +} > + > +static void imx93_pdfc_bridge_atomic_enable(struct drm_bridge *bridge, > + struct drm_atomic_commit *state) > +{ > + struct imx93_pdfc *pdfc = bridge_to_imx93_pdfc(bridge); > + const struct drm_bridge_state *bridge_state; > + unsigned int mask = PARALLEL_DISP_FORMAT; > + unsigned int val; > + > + bridge_state = drm_atomic_get_new_bridge_state(state, bridge); > + > + switch (bridge_state->output_bus_cfg.format) { > + case MEDIA_BUS_FMT_RGB888_1X24: > + case MEDIA_BUS_FMT_FIXED: > + val = FORMAT_RGB888_TO_RGB888; > + if (pdfc->phy_bus_width == 18) { > + /* > + * Can be valid if physical bus limitation exists, > + * therefore use dev_dbg(). > + */ > + dev_dbg(pdfc->dev, "Truncate two LSBs from each color\n"); > + val = FORMAT_RGB888_TO_RGB666; > + } > + break; > + case MEDIA_BUS_FMT_RGB666_1X18: > + val = FORMAT_RGB888_TO_RGB666; > + break; > + case MEDIA_BUS_FMT_RGB565_1X16: > + val = FORMAT_RGB565_TO_RGB565; > + break; > + } > + > + regmap_update_bits(pdfc->regmap, IMX93_DISPLAY_MUX_REG, mask, val); > +} > + > +/* TODO: Add YUV formats */ > +static const u32 imx93_pdfc_bus_output_fmts[] = { > + MEDIA_BUS_FMT_FIXED, > + MEDIA_BUS_FMT_RGB888_1X24, > + MEDIA_BUS_FMT_RGB666_1X18, > + MEDIA_BUS_FMT_RGB565_1X16, > +}; > + > +static bool imx93_pdfc_bus_output_fmt_supported(u32 fmt) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(imx93_pdfc_bus_output_fmts); i++) { > + if (imx93_pdfc_bus_output_fmts[i] == fmt) > + return true; > + } > + > + return false; > +} > + > +static u32 * > +imx93_pdfc_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state, > + u32 output_fmt, > + unsigned int *num_input_fmts) > +{ > + u32 *input_fmts; > + > + *num_input_fmts = 0; > + > + if (!imx93_pdfc_bus_output_fmt_supported(output_fmt)) > + return NULL; > + > + input_fmts = kmalloc_obj(*input_fmts); > + if (!input_fmts) > + return NULL; > + > + *num_input_fmts = 1; > + > + switch (output_fmt) { > + case MEDIA_BUS_FMT_RGB888_1X24: > + case MEDIA_BUS_FMT_RGB565_1X16: > + input_fmts[0] = output_fmt; > + break; > + case MEDIA_BUS_FMT_RGB666_1X18: > + case MEDIA_BUS_FMT_FIXED: > + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; > + break; > + } > + > + return input_fmts; > +} > + > +static int imx93_pdfc_bridge_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > +{ > + struct imx93_pdfc *pdfc = bridge_to_imx93_pdfc(bridge); > + u32 format = bridge_state->output_bus_cfg.format; > + > + if (imx93_pdfc_bus_output_fmt_supported(format)) > + return 0; > + > + dev_warn(pdfc->dev, "Unsupported output bus format: 0x%x\n", format); > + > + return -EINVAL; > +} > + > +static const struct drm_bridge_funcs funcs = { > + .attach = imx93_pdfc_bridge_attach, > + .atomic_enable = imx93_pdfc_bridge_atomic_enable, > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > + .atomic_get_input_bus_fmts = imx93_pdfc_bridge_atomic_get_input_bus_fmts, > + .atomic_check = imx93_pdfc_bridge_atomic_check, > + .atomic_create_state = drm_atomic_helper_bridge_create_state, > +}; > + > +static int imx93_pdfc_bridge_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct drm_bridge *next_bridge; > + struct imx93_pdfc *pdfc; > + struct device_node *ep; > + int err; > + > + pdfc = devm_drm_bridge_alloc(dev, struct imx93_pdfc, bridge, &funcs); > + if (IS_ERR(pdfc)) > + return PTR_ERR(pdfc); > + > + pdfc->regmap = syscon_node_to_regmap(dev->of_node->parent); > + if (IS_ERR(pdfc->regmap)) > + return dev_err_probe(dev, PTR_ERR(pdfc->regmap), > + "failed to get regmap\n"); > + > + /* No limits per default */ > + pdfc->phy_bus_width = 24; > + > + /* Get output ep (port1/endpoint) */ > + ep = of_graph_get_endpoint_by_regs(dev->of_node, 1, -1); > + if (ep) { > + err = of_property_read_u32(ep, "bus-width", &pdfc->phy_bus_width); > + of_node_put(ep); > + > + /* bus-width is optional but it must have valid data if present */ > + if (err && err != -EINVAL) > + return dev_err_probe(dev, err, > + "failed to query bus-width\n"); > + } > + > + next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0); > + if (IS_ERR(next_bridge)) > + return dev_err_probe(dev, PTR_ERR(next_bridge), > + "failed to get next bridge\n"); > + pdfc->dev = dev; > + pdfc->bridge.of_node = dev->of_node; > + pdfc->bridge.type = DRM_MODE_CONNECTOR_DPI; > + pdfc->bridge.next_bridge = drm_bridge_get(next_bridge); > + > + return devm_drm_bridge_add(dev, &pdfc->bridge); > +} > + > +static const struct of_device_id imx93_pdfc_dt_ids[] = { > + { .compatible = "nxp,imx91-pdfc", }, > + { .compatible = "nxp,imx93-pdfc", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, imx93_pdfc_dt_ids); > + > +static struct platform_driver imx93_pdfc_bridge_driver = { > + .probe = imx93_pdfc_bridge_probe, > + .driver = { > + .of_match_table = imx93_pdfc_dt_ids, > + .name = "imx93_pdfc", > + }, > +}; > +module_platform_driver(imx93_pdfc_bridge_driver); > + > +MODULE_DESCRIPTION("NXP i.MX93 parallel display format configuration driver"); > +MODULE_AUTHOR("Liu Ying "); > +MODULE_LICENSE("GPL"); > > --- > base-commit: 9499d3bc41a2c4e6a1badfb55f943b9d0c34f034 > change-id: 20251201-v6-18-topic-imx93-parallel-display-95f9234bf6cc > > Best regards, > -- > Regards, > Liu Ying > >