From: Frank Li <Frank.li@oss.nxp.com>
To: phucduc.bui@gmail.com
Cc: Frank Li <Frank.Li@nxp.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: mxs-sgtl5000: Drop redundant probe error messages
Date: Wed, 12 Aug 2026 09:15:24 -0500 [thread overview]
Message-ID: <anx__MnpgHU-mSqr@SMW015318> (raw)
In-Reply-To: <20260812101418.37966-4-phucduc.bui@gmail.com>
On Wed, Aug 12, 2026 at 05:14:18PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Remove the probe error messages to avoid duplicate error reporting,
> since the error is already reported by the called functions.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> sound/soc/mxs/mxs-sgtl5000.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c
> index f1c0e612313d..a253a48ca59c 100644
> --- a/sound/soc/mxs/mxs-sgtl5000.c
> +++ b/sound/soc/mxs/mxs-sgtl5000.c
> @@ -155,8 +155,6 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)
>
> ret = snd_soc_of_parse_audio_routing(card, "audio-routing");
> if (ret) {
> - dev_err(&pdev->dev, "failed to parse audio-routing (%d)\n",
> - ret);
> mxs_saif_put_mclk(0);
> return ret;
> }
> --
> 2.43.0
>
>
prev parent reply other threads:[~2026-08-12 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 10:14 [PATCH 0/3] ASoC: mxs: Improve probe error handling phucduc.bui
2026-08-12 10:14 ` [PATCH 1/3] ASoC: mxs-saif: Use dev_err_probe() for " phucduc.bui
2026-08-12 14:17 ` Frank Li
2026-08-12 10:14 ` [PATCH 2/3] ASoC: mxs-saif: Drop redundant probe error messages phucduc.bui
2026-08-12 10:29 ` sashiko-bot
2026-08-12 11:28 ` Bui Duc Phuc
2026-08-12 13:49 ` Daniel Baluta
2026-08-12 10:14 ` [PATCH 3/3] ASoC: mxs-sgtl5000: " phucduc.bui
2026-08-12 13:51 ` Daniel Baluta
2026-08-12 14:15 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anx__MnpgHU-mSqr@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox