From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11B141228F for ; Mon, 24 Aug 2026 12:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573684; cv=none; b=RUp+hdt+6frnGMsa98d71EpqSEO8PfbhVXu6zJViuG9YO8Z+2faShAsnCgotPQ73VZBvhe2BqKArOpHC/gvichSuXdGwA9NmJ8640Za6tvCFpwHKHVW1LULbN3KQP3yOB3tNZGOy9HKyzCOR0y0U1nokPnxBkPK6nZeO1BcNDQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573684; c=relaxed/simple; bh=eiBo1yduJHaXAj53sijSuIC7kmal8T2Qf0O1edtX+Zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tdtnopMes5/e6RiVkC3APp5jPRyeHcswEC1W/GPMtdnPd1yHqeUhb1x9OEScWFmh59t2xfndZ5yE0y1rTgXxXJ9bAbB+gjr0hFKCycdEn27Q9tPP8MSEwkcLksGzzPcvFVGhH5SFZ7BIWutM0u+TJHxiHd5x+VYPSQg8VqU27Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Ef0G2s2U; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Ef0G2s2U" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6a15d54ac95so5876892a12.0 for ; Mon, 24 Aug 2026 05:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787573679; x=1788178479; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IJ2S2NN5RmqVB8PHkfxAhd8Zl5dVEhVpefrqaDYB2O0=; b=Ef0G2s2UFsSjIlRKZwb3XbE3bbSiAFBk7esXMvx0tNn1WGtnI58p2GxpKdSyaJyHBL hU4pj14956TvS52rOfLRIZ6uEuAqnXOrxds5/WyDCNH6GsP84hheTYe0JTtlHJ1SCadF hVAMNjFmtf6Q6bELFlpBs340TrEFL1Hr56kEMDHqGM/GLLBEaipdCYanwGXmMpDDuvze 3VlzbIdwOBPdwpDmOeRL6+ImK8VTAE6VStvedMJmSOLhqvC4QRDRiTBS3pT4MXtcIRM7 NJ+S1C8aSMpkz+DXzo+L8Ozw6TSOCX6kqBOuXY/Nvfx/tTqeFXfILeT6Sh8MqEzpSFas gjnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787573679; x=1788178479; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IJ2S2NN5RmqVB8PHkfxAhd8Zl5dVEhVpefrqaDYB2O0=; b=dkysZ0KaKVJo3pwm+2EEgGJyQcq1nA/5MVJ3BflQ98AJkQ41Ht+NSPjSAQmaSywjMx s9OBpCwW+IoVT0BscclXCOXNLL5V4nuDleq0nc2b/SowTmj7vDwcNEp6JsWjNuw7dbNf uGkpmYxPxylc6e/ptrb4DQSeA7WeO0vzHO+yo601Edf8A1kjEkAg4x6VL2sjalrSqJJk iuNOx1Bz5Grh4AAUDESjB/jE4omi65bdZP2udtCI4hca8g07t+haiNYy345dl51zjrrP 74s2a9IDUma5dvInfj/KcXWUp6F0PwrYkkNy0M4qcHttC4zevl3M4mllQ6myfcyOX/v/ gTog== X-Forwarded-Encrypted: i=1; AHgh+RqgR4v9mSegfHakrz2oyqEy9HJ6JxYzhIM9DaPyVWV/4XvvpiSAxL30uEMv68x1WpRmr3A=@lists.linux.dev X-Gm-Message-State: AFuF++lo9hEqVGBzAAr/31TCQyt/IrhdvtA3lSizVduG92goCIgi86uD bjfprOlnB1eFu48+QwNDbt4jm5sYUqT1+VBB2NgcOxWcbJsVyEdJnnrMz/LsWuab2Ec= X-Gm-Gg: AR+sD13KPD+X1X3IJk224mlkF7HAuyn6wD1+UWRgWQyBsUyE8YT16dt3UwwgglJI838 IzwCluT7J6wK+9w2dwt7zl1Mj1e41Y65NxXaFlxxHORys3KCz4NOW+Ozo/xfRTyv1pwaBTiSYxW cXm45USXTFB00pNXz/ugHVTSX+xAw3220WEvZGFjfPBN2TWUJIe/LF1HhSdrmzY5DdhwiiUOnvS 6U/u5Xc7e6cHLpRtsVYjQGleWHYZnOGZu9iKTktxZViGT3BUgJitC0UD2F43MqecJ6sgrLRGmvs jnxyb5Wd59FjfUHd9Wy4/qWr+03l3GAygnVygrP1+8zv5Sd+S+z/5i1se9+p/shGByjXTgVhc2c NrHqJqTdMwnFExwkyQYtc6THHKSLKGA5IBFiKe4u4n5g1o5i2heOUH3b9KJkI2Q3pvK0fWAYHCl Qu7c/CCUTlBft20SBaKjtPuPSSpQmR3qeLTy1qlQwFGSJpEyP8rCc+nFfIpkeFWVfpHKpNCytST WqKtMe7yExGBwhfCZXbMheg8cIOi1BZ2vT84f+f8kxwgRZk5cox X-Received: by 2002:a05:6402:2b98:b0:6a3:6d6d:2296 with SMTP id 4fb4d7f45d1cf-6a582b0cfe9mr21318328a12.5.1787573679054; Mon, 24 Aug 2026 05:14:39 -0700 (PDT) Received: from localhost (p200300f65f19a904efa8a94b704adaa2.dip0.t-ipconnect.de. [2003:f6:5f19:a904:efa8:a94b:704a:daa2]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6a59e00129fsm10155492a12.1.2026.08.24.05.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 05:14:38 -0700 (PDT) Date: Mon, 24 Aug 2026 14:14:37 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Andersson Cc: Sudeep Holla , Cristian Marussi , Nathan Chancellor , Nicolas Schier , Michael Turquette , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Hans de Goede , Stephen Boyd , Brian Masney , "Rafael J. Wysocki" , Viresh Kumar , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Guenter Roeck , Jyoti Bhayana , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Dmitry Torokhov , Ulf Hansson , Liam Girdwood , Mark Brown , Philipp Zabel , Alexandre Belloni , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 1/2] module: add SCMI device table alias support Message-ID: References: <20260618-scmi-modalias-v2-0-8c7547c1be21@oss.qualcomm.com> <20260618-scmi-modalias-v2-1-8c7547c1be21@oss.qualcomm.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2dhawfj2mm2jx7wk" Content-Disposition: inline In-Reply-To: <20260618-scmi-modalias-v2-1-8c7547c1be21@oss.qualcomm.com> --2dhawfj2mm2jx7wk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 1/2] module: add SCMI device table alias support MIME-Version: 1.0 Hello, On Thu, Jun 18, 2026 at 03:56:34PM +0000, Bjorn Andersson wrote: > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_deviceta= ble.h > index 3b0c9a251a2e..769382f2eadd 100644 > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -473,6 +473,17 @@ struct rpmsg_device_id { > kernel_ulong_t driver_data; > }; > =20 > +/* scmi */ > + > +#define SCMI_NAME_SIZE 32 > +#define SCMI_MODULE_PREFIX "scmi:" > + > +struct scmi_device_id { > + __u8 protocol_id; > + char name[SCMI_NAME_SIZE]; > + kernel_ulong_t driver_data; > +}; > + Note this won't apply since commit ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers"). Please create a header below include/device-id for scmi similar to what was done in ad428f5811bd. (And don't add an #include for it to mod_devicetable.h, but to the modpost program only.) Also please only add a driver_data member if you need it. And if you do, consider using union { kernel_ulong_t driver_data; const void *driver_data_ptr; }; instead of a plain kernel_ulong_t driver_data member. I'm working (less than part-time) on changing the existing device-id members accordingly. See e.g. https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.c= om for an extended rationale. Best regards Uwe --2dhawfj2mm2jx7wk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqMNaoACgkQj4D7WH0S /k4jGgf/c9brV06dZI0ixNsgSDxInOAAwxzw0Va6pEilBFWeD/1x8NZxQxIb86eu ERFi9ET7K8J1CkEXpSDumSzKSUdfMylIEURvojgjfnQEsYGjKUB3lgyc6ZMvZJE8 KVGIQQhfXJzgdOen9ivFrmp13avoOEZecODfflOtBiCVBT9yqo9G8cB98iPlfN0n /20yUKuCi9BVxfitySRFAt3h5YGf8mWqJYyRGszONcDeatlQ3hYxcZRc6nWohvA6 Pj79A4QISdBE4jbZiuZ4B7Tqk88TXQ1mLTCo6WZ0jaoWxESWjauNoBJPyj55WW4m FOrbj1Kew7KV7tsLQ07HGfCNIJuI9A== =DfdU -----END PGP SIGNATURE----- --2dhawfj2mm2jx7wk--