From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C411442124D for ; Mon, 24 Aug 2026 13:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577409; cv=none; b=p99CXx7W68u+38mM0Kos42GQYYhXvpLaYib7In8sLH8s+UseN475EnyRvJN2IXPYWi+6R5UfuohlEUJhyFczN2YpTFGWjrf+LRossz46U6EvWYMCXElzCHuYdxuR0p54tgk1uHrwNxnCeLd9brvtDvTgRQwQtvIJy43owfTpXYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577409; c=relaxed/simple; bh=u69iDQDh65gTSQHaopk712AakCgClJSI2Zoo/JrTLeU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=NDaPfzf5VWzzN9F37wZ3NIdOXxOm0I2OSPGEJ22XdXJn66XzfoQL89UfcPCb+QSk7xOjH4TXHewNno4w2awl9YUdMFq3RhsdN9e67KG9GI6jOOmWqCgoJ4jtOf30CG1uMn63JU2p/nNSdi/yyfXSv28+yh3U+Pcy8olYTFAYbAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IKg/D0on; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IKg/D0on" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=IKg/D0on6WuGIEkDRlaA0AGzaoUcMm9W7vHGwfBWAJy9PM1TAsZ835LTmG9fe7n+UgnIFF bvopKA+EBWEpOmco21ROIk5dc1pKqA14gO8mCCyOW4PPReTY0qxr9Q2Eqkr9ZRnyin93aC 96Kp3cH7vPISNQm2ue5R69NB2ZqffVM= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-wzt4iGssPoy2cGf4SbWFDA-1; Mon, 24 Aug 2026 09:16:43 -0400 X-MC-Unique: wzt4iGssPoy2cGf4SbWFDA-1 X-Mimecast-MFC-AGG-ID: wzt4iGssPoy2cGf4SbWFDA_1787577403 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-836cfd56077so51610937b3.1 for ; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787577403; x=1788182203; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=MwVgwX4cIdgNVC7G5LhM8JK+HeMs/G9oeVYik7jbI80Jy60Slld8xFsQ2mwBRc/FpU O62nodp6O3Le8DMaG3DvdXOyzeCKSyV5BDX1bydlBXQRYOlNXV2Kqa0wC1ln2l0QNwu3 /+QgQIUD+EGgRukBfnJANzK3FACymf6UOxXLyKo9DZhWsDETDr6qqX+Lr0MKH5dSi8Nc lnr8kVDnV5DKAnQkkmJJ7jNj7fQA5GV4IML2h7CO5oGT0fOIhyEQD+QR34CG2ypupS2K lAtKN/yqRYytx/G0GRkjwar6AnYgKE46fVqhp41iKru+3DklCChVfGFYHb8eUKTFLO9N D2hQ== X-Forwarded-Encrypted: i=1; AHgh+Rr3+Xl5vPHxi+dhn9rHv2QOtYeeMIqWXE9hSGjXwEJ4GbnbxnQ2MFaK/r4LjnsvBZLSb9Y=@lists.linux.dev X-Gm-Message-State: AFuF++lBE2DDlR6G4kPefzhowC6cZnd80leh6y8M3FGO5pRMs4UOeOQH 9/WSSdXxo+EYECUlDIynTMR4ldi0KT/xqhrNhx9ckn7plPYHRj/sgoFvHSsMpftSlfJZoAN0Y8I Vlxd0URWkv59xbwfF1Xq4XczPAmCdFCB0yCn5LF8GXvNE491Ix3NvqA== X-Gm-Gg: AR+sD13XpdG0s5FO9xAr2BrIBEWak2JtTAeCklQRu3gRMz1qU7y2t40Xgg9rMLczApM QaUn9GZRq//ooqRUGWzsf5NaeAPC7rvDkQU+2vfKebasyRAmD3OVAhk1hhtSg3sI0qWIWnb23ng qlXokZgx43Wo4ID7QAhUQIamBXjopduLzIiP+bNwQEli5MSikOgoD7lsWFW/x5XnkYWF8E8pQbm smcjvrXfqVaycWZ2+D1e3r4zwxtIxhuRUDEhpI2HoXRIRP4TmpOonyTvT3DfGtk2NP/XPaHYiVc MMc947AWrL/llZ2ho7L4LZXD8sS7BHOdvXeyWInbX+2IM57EB3T1TASdOB1To4NtyoZP5eJC5O9 BMGuL9F+VMeVxyTQWP2C+jLpt5TMj1GcQY84= X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172607b3.22.1787577403068; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172227b3.22.1787577402495; Mon, 24 Aug 2026 06:16:42 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca5d254adsm33243617b3.16.2026.08.24.06.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 06:16:41 -0700 (PDT) Date: Mon, 24 Aug 2026 09:16:34 -0400 From: Brian Masney To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized Message-ID: References: <87b3e83137e1a987f3c69d214706e93ef3898cab.1787239813.git.geert+renesas@glider.be> <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9KhVWbugQxG9vBfY76z1zu-E8Tn5j7X-_JutA9e76RA_1787577403 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Krzysztof, On Fri, Aug 21, 2026 at 01:04:01PM +0200, Krzysztof Kozlowski wrote: > On 21/08/2026 10:53, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Make sure all members are fully initialized, to avoid such bugs, and to > > prevent future breakage when converting drivers to a different method > > for specifying the parents. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > Compile-tested only. > > --- > > drivers/clk/samsung/clk-cpu.c | 2 +- > > drivers/clk/samsung/clk-pll.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > Reviewed-by: Krzysztof Kozlowski > > Let me know if I should take it via Samsung SoC clock tree. I assume by > default this will go directly via clock tree. Please take it through your Samsung tree to avoid merge conflicts if there are other changes to these files during this development cycle. Brian