From: Frank Li <Frank.li@oss.nxp.com>
To: Baoquan He <hebaoquan@kylinos.cn>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de,
harry@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 11/13] media: nxp: imx8-isi: Don't use GFP_DMA when calling dma_alloc_coherent()
Date: Fri, 4 Sep 2026 10:14:16 -0500 [thread overview]
Message-ID: <aprgSHd1O4WqrvX2@SMW015318> (raw)
In-Reply-To: <20260903111836.1777265-12-hebaoquan@kylinos.cn>
On Thu, Sep 03, 2026 at 07:18:34PM +0800, Baoquan He wrote:
> [You don't often get email from hebaoquan@kylinos.cn. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> dma_alloc_coherent() allocates the DMA buffer with the device's
> addressing limitation in mind; the DMA core picks the zone from the
> device's coherent DMA mask and ignores GFP_DMA passed by the caller.
> Remove the redundant GFP_DMA flag.
>
> Cc: imx@lists.linux.dev
> Signed-off-by: Baoquan He <hebaoquan@kylinos.cn>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> index f45c2aae59ce..fc907d357149 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> @@ -773,7 +773,7 @@ static int mxc_isi_video_alloc_discard_buffers(struct mxc_isi_video *video)
>
> buf->size = PAGE_ALIGN(video->pix.plane_fmt[i].sizeimage);
> buf->addr = dma_alloc_coherent(video->pipe->isi->dev, buf->size,
> - &buf->dma, GFP_DMA | GFP_KERNEL);
> + &buf->dma, GFP_KERNEL);
> if (!buf->addr) {
> mxc_isi_video_free_discard_buffers(video);
> return -ENOMEM;
> --
> 2.54.0
>
>
prev parent reply other threads:[~2026-09-04 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260903111836.1777265-1-hebaoquan@kylinos.cn>
2026-09-03 11:18 ` [PATCH 10/13] media: imx7-media-csi: Don't use GFP_DMA when calling dma_alloc_coherent() Baoquan He
2026-09-03 11:36 ` sashiko-bot
2026-09-04 15:14 ` Frank Li
2026-09-03 11:18 ` [PATCH 11/13] media: nxp: imx8-isi: " Baoquan He
2026-09-03 11:37 ` sashiko-bot
2026-09-04 15:14 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aprgSHd1O4WqrvX2@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=akpm@linux-foundation.org \
--cc=harry@kernel.org \
--cc=hch@lst.de \
--cc=hebaoquan@kylinos.cn \
--cc=imx@lists.linux.dev \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox