From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A3237E5DB for ; Sun, 20 Sep 2026 10:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789899535; cv=none; b=AqYt15tg6xCK5tO3OE48YVdYfILVJBWqR91/9Uy1hQdaFsyYRd3zpUN2ONQgf6aR9cbqd3X0Uq1ofrrKn3u+38eITdvJg4c7v8/r+Nm9LIcAVT/QRxEXbhvFXqzbIBwDhL0D0h7DAglGE1qI+d9s9zEEwBCk5oCj58ooXeDiEQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789899535; c=relaxed/simple; bh=HqP7BQVzVu/qEMR55V44Bfd8uKv6sm747Y9t+oz3hvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dRXdQsypI0aCrijkEF1sdPY7pvt+isz220iPRGXwMc8HD4aBBanW8M6RLcVeGZ/K1A//jkCm+itPywKv/G56eYGEcm3U5RkvONlABnAynNhVd7SsyXZKDPnLXVfCO6ABLy2rVObiZSC1GFKfiaPUXnXt9WQHiZMOzqlBAmYQ96U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=i5LZ2Drt; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="i5LZ2Drt" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48434392b02so1596470f8f.3 for ; Sun, 20 Sep 2026 03:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789899530; x=1790504330; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AqS01F0fHUCNlMjJzLaTQZMMSglpdCcpPbBa80dW1pk=; b=i5LZ2DrtmdJEXb6PYRRwcTW1cCrEprED6kJur/giEkcZpdSAL2/JJsg3BHcoQJtt7s RbtpeyiYL21gM0uWWnhSV4B3gAAVFHPcMbKTKrKN8+IOR5z32SQC1mqT/1PV5ax52O6+ VzRx3MwfXKCrE3d0sL7jNLMwnnc/awc4NOJ2Pv4oA1PdmrxpufbQHk2XqojFwgmG/XF5 JQGINVVZ77CEmSSQuMHrvk3B7fSzMrJJfsahNeIeILikQ9Q66B60S+7wUJJMndr2ttxT M0n7WHgfKtLkICHg+D3x3jffKzfn1qVoqwhaI3x+nrdIgDKJv1hPaL3Q/kQqc3gRGkcs Qo6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789899530; x=1790504330; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AqS01F0fHUCNlMjJzLaTQZMMSglpdCcpPbBa80dW1pk=; b=IO78W/giTs2muRpwdps6LOOkp0nRL8la4WJ5th9mcWXh5VS9BLipjclIrUCRp28gmW aoFx9p89ejrZe3rFD/vrhNMLoVzdrnyYeMx2qx/ivqu4Wk4RkDvE3MPjQWt1IhDqWtAc 0DaiiTgUZSeWOxUVK0y4SDnA5RXqaxUGOdnL+LUwy0wd/yX5lH7iTIqYVyr5XvBgQKtI JTPaD+1IDsfSaymB5kuQ3YmGShYyg7Nowf4lmDBOirMaf85tUJpYDSSDYIxsfbx5jEz0 VmJ+E3eYn2mnwnZa3KAG6lBqBFLvgeoUmyTHmtHbnpsXLfBg67lyiVkEHvhYfuLaJNvR 27AA== X-Forwarded-Encrypted: i=1; AKwUvBzB+UT2Xt1qvweVRLS9henWPUrgf/ywzvShde4Ye4pCMTukSybtKOaLWb0pMMhjsw2Urts=@lists.linux.dev X-Gm-Message-State: AFuF++l7yl5719Q0CTWdl7UwWhikk/PzpVo5o7DewGDEoVfI7zcoanuL HxuvYg3H96Kt3pC9Xx+/efq+GspAFLZGQjZWvephffNoaiBlWg5vjJHWLl8Sj+UO8nE= X-Gm-Gg: AYBFou0khbb6HB+G1RRbR4AucWScqTw22Iw4HlLxV7JOPLtiDd5HMWa0H4Kcx9V+SsS Brf0BKGfnFhWT3Ah2Mbx4DhoBXfcoCluvKDgnaIhsx7pP9k+fINTUquv5eZj6cLUFWQQ+AZ6pku h05k0raZ53FAQLYkowN0Nl+xhVFLToAi+GoxawpWMNjs1o/WLdgKY0tdzC5gnRRJSYudAcEuI01 0Th+5rM8Anczwt89Qn+CtxiBzb7EZItMUAktiB3gOzTvgbFyevzUa4C3/xWS2FE6ZuWTRYTIM+q haxTNwZ6eUDaI4RqZ0ykuv8YCm45ZDugfBa9QpRkqHr47tevME4X/o/FALzEBUvVTPqrCmjKTQ3 8pJRgfgM0VX2HLdk88GslZkldJu6heYIsz9W7GhJK2KlkYPoKneDyFDNbfACajsUmkxT24PrB8y bIE0i67y6WL+Vdnagbc9Soi48thwt8uP3rZZ6DnEG0FvqOLbw6LRAm60db2+ZbKwtTncuTJUfIT Xc= X-Received: by 2002:a05:6000:310d:b0:487:27f9:82a with SMTP id ffacd0b85a97d-48727f90ab5mr5715729f8f.31.1789899529909; Sun, 20 Sep 2026 03:18:49 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4872459f446sm12973334f8f.35.2026.09.20.03.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 03:18:49 -0700 (PDT) Date: Sun, 20 Sep 2026 12:18:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: Hans de Goede , Bjorn Andersson , Cristian Marussi , Daniel Lezcano , Bjorn Andersson , Frank.Li@kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/2] module: add SCMI device table alias support Message-ID: References: <20260918092951.5656-1-johannes.goede@oss.qualcomm.com> <20260918092951.5656-2-johannes.goede@oss.qualcomm.com> <20260918-impetuous-daring-barnacle-1ea4d0@sudeepholla> <20260920-hippo-of-immense-assurance-50a5fd@sudeepholla> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="va5epoaani5qcgwk" Content-Disposition: inline In-Reply-To: <20260920-hippo-of-immense-assurance-50a5fd@sudeepholla> --va5epoaani5qcgwk Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 1/2] module: add SCMI device table alias support MIME-Version: 1.0 On Sun, Sep 20, 2026 at 08:36:10AM +0100, Sudeep Holla wrote: > On Fri, Sep 18, 2026 at 10:39:46PM +0200, Uwe Kleine-K=F6nig wrote: > > On Fri, Sep 18, 2026 at 04:09:36PM +0200, Hans de Goede wrote: > > > Hi Sudeep, > > >=20 > > > On 18-Sep-26 15:32, Sudeep Holla wrote: > > >=20 > > > [...] > > >=20 > > > >> diff --git a/include/linux/device-id/scmi.h b/include/linux/device= -id/scmi.h > > > >> new file mode 100644 > > > >> index 000000000000..1b4ccfa9dcc5 > > > >> --- /dev/null > > > >> +++ b/include/linux/device-id/scmi.h > > > >> @@ -0,0 +1,17 @@ > > > >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > > >> +#ifndef LINUX_DEVICE_ID_SCMI_H > > > >> +#define LINUX_DEVICE_ID_SCMI_H > > > >> + > > > >> +#ifdef __KERNEL__ > > > >> +#include > > > >> +#endif > > > >> + > > > >> +#define SCMI_NAME_SIZE 32 > > > >> +#define SCMI_MODULE_PREFIX "scmi:" > > > >> + > > > >> +struct scmi_device_id { > > > >> + __u8 protocol_id; > > > >> + char name[SCMI_NAME_SIZE]; > > > >> +}; > > > >> + > > > >> +#endif /* ifndef LINUX_DEVICE_ID_SCMI_H */ > > > >=20 > > > > You need to include this above file in include/linux/mod_devicetabl= e.h > > > > to avoid duplication of its inclusion elsewhere. That's the pattern= followed > > > > I see. > > >=20 > > > That is what I did for v3, but Uwe, who is leading the splitting > > > of mod_devicetable.h from one large monster include to smaller > > > per subsystem/bus includes explicitly requested me to follow this > > > pattern, see: > > >=20 > > > https://lore.kernel.org/arm-scmi/aow2GFAfy84k-N2B@monoceros/ > > >=20 > > > [...] > > >=20 > > > >> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devic= etable-offsets.c > > > >> index b4178c42d08f..91ec3704ee2b 100644 > > > >> --- a/scripts/mod/devicetable-offsets.c > > > >> +++ b/scripts/mod/devicetable-offsets.c > > > >> @@ -1,5 +1,6 @@ > > > >> // SPDX-License-Identifier: GPL-2.0 > > > >> #define COMPILE_OFFSETS > > > >> +#include > > > >=20 > > > > Drop this for above mentioned reason. > > >=20 > > > This was explictly added at request of Uwe because the goal is to > > > get rid of mod_devicetable.h including all the device-id headers > > > in a big single catch-all include. This is done because currently > > > many files include mod_devicetable.h and then if any of the device-id > > > headers changes everything needs to be rebuild, making incremental > > > kernel builds much slower. > > >=20 > > > (and the same for the second include you point out) > >=20 > > FTR: That all sounds right. > >=20 > > Let's not add the the dependency mess that is mod_devicetable.h. > >=20 >=20 > I am confused. I am asking to align with what's done in > Commit ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers= ") > and you are disagreeing with that ? >=20 > I am not comfortable taking this patch unless there are other similar > examples that are agreed upon to break the pattern followed in the above > mentioned commit. >=20 > Uwe, please suggest. I didn't start removing stuff from mod_devicetable.h yet, as changes there are expensive (regarding build dependencies). So the plan is to stop drivers consuming mod_devicetable.h and then drop it. (Not sure this is sensible as new users come in faster than I can fight them, but I didn't give up yet.) So while adding new device_id structures to mod_devicetable.h is consistent with the existing practise, it still makes the situation worse, as every consumer of mod_devicetable.h then also depends on the new header for the new structure. That's why I think it's a good idea to deviate here, even if you're the first one doing so, to not worsen the already bad situation. If it helps you, I can propose a patch changing modpost to not use that catch-(nearly)-all header and use the needed linux/device-id/*.h instead. I put this on my list for tomorrow. Best regards Uwe --va5epoaani5qcgwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqvswQACgkQj4D7WH0S /k63ZQf/c1EcLMBypE8L0sxQ62078sgY69oGq5tDdBhnBZ+z4IPNuVUBpEsbf6CY hV/ZDy6EEWrIof70NynUSSft8Na4sKCCNoUAX0miGwkgyse7NXgu/+kfxKnYamH8 prDFe1BuWUgOnkVQz30liiPP2R54mXHS98TbV36hRU3VaKmT15gSgmQlaPwKiYud z/8blCaDCvt1oUpT1fLuAd6Ou3zvU9zLm/OpGl5sEMIHcJaTL+/+pJaJOyH34wg/ kfTaQUIXa9gYIwXzC+1IN7VLF1N0CVDKdSABYE1o+07SHdmM4GweLPPNshAaHSN6 N4WYHrSbicQ23mz2Vai55R+WDm/WKA== =3lua -----END PGP SIGNATURE----- --va5epoaani5qcgwk--