From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7575D3BFAD1 for ; Sat, 17 Oct 2026 16:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255372; cv=none; b=jz2/dy6ylffBY7mgD3k+tW7MZPS/ItIIVMoIzTSdV2Xize9RFsVFa0rvXpJF8JCjJaAB0Ya927bw0Y4TlV+cI73bTxM72OVveOdWEB/n0di7yYgfvL7MkzmNZigON30cSrAsnehdEzYuAftWXSZIczm9E5bwhEUIvC0CFvOBTVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255372; c=relaxed/simple; bh=oqtbq2GGeLimTwMiPXXLtV6CRd56cCRXZHus+yXgxlk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RSQKWRjdM/barhAelcqcbR8OYaWS/4riO10lEH7HcYI1lEdDFXDihq0xihG7HcWCDzoAdh8XFqi/kbhqkzaWzN5M24NvAvgM51esxwVEGMykBWloZLUFz/YmxgPdeEMiat/9rx73fYcRI/LAOeDTXSY9x+MHxeFlzt34V4lT9A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lNhoZ5Km; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gJGc6ido; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lNhoZ5Km"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gJGc6ido" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGAbWR2535142 for ; Sat, 17 Oct 2026 16:42:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbyys1gde-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:49 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-35cbea41088so1356014eec.1 for ; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=gJGc6idos69554Nck7+7p7e4OKccqT2chIYhpExPj+XIRvaOSo9uPrrkUE9PG908AA gjW0wHGvAVLWCKmUWr94xh040wRfcj87h9D6iDPcZVWbH9OCemwuoBS7OnlHEIlsrLAZ AqhBDMvPKlYaByHyHrvYPbJ5cxLRiU4DBXYMJbJc9sN+G1zhF2fXyu9sWVmK6WCtvgby 2HEGI+DDP/IwifcOBwnRB0o1zJbi67HutBNIdKcLEMy3O2I0JLM39BU/pIHwB/Lv+INg yy8+Ml9wiJQaS9PvnTB59w4wK1y/aPuvtAJb9SqvIqZdqP+0V+MjraiC4JiavmiVjiPH eVJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=XUwLGccLn85thkh6p7f4C81j1DdVinkzAyMOWaox1sp+U2iGPiBpnlJpgBJ4Kyyh2l fs1YbF/iJV5fOx3UVPSMUndGgdIQ4Tsp1JoSFAbxHEkHPJGxH037Ru77PUQBuKgL7isg zvp7S5eIsmuTjlDhPB3czQ9lf/pUTw9ZCmGO2hv5kuxU9kKIOnVHAqBO7m8QYS55zFEA QI9TR2vzrq7+x7cGh9q6oA+gGk0FYcZHBFy5qL4c9kC0/uJxnxdjBXwnS3uyYhU8hiw0 LutOk0Sjfyw/basb1sJd1So0AUkBdA3tGJ4vVbwRIYc34//LfbyYHHUG9L3gHdSV6w5y xXcw== X-Forwarded-Encrypted: i=1; AKwUvBxB+rjCT0qya9qzdAb90YiROJtdxMZmEvfUpk+r1jZCurYoABHzxvN+wUmV3Djd13avvhA=@lists.linux.dev X-Gm-Message-State: AFq9FYKF3osuLjz3hHwBNwNB29VTbmPAqq4DTasqZCGBx/gOHzqk+n+I 1svGNv4AYpC3BkWw2hTi0bGzkZMkhh0SOgfAv/mfDP+ni/ol01zoqk0GrBxmNXWF6cQktD2EwRL MkaU1vtLtKSJiUL7TGLHokHK4SwFoY29ALuqs9xerj03HbbEzdUczefA= X-Gm-Gg: AYBFou0u++HRMD7SOYQPJcRATT2PTwu8ah/jMC0YFV6d9Jb0ednhxQ0ij8lrCYIz46k VC4dyyFMu5Gtvl/gJz02eaXKXu85p+bZEzGwnhSCFUdbhqXzUeqZY3+rfYz5l+iqRO7F3s0wDy/ hbb6nn3AkRX+nxGji2SvgeH9sp7f4BLbb2r1g/UmrAjColiYdtwCOm9bX1u6aT2kHiG/6znMKYF kFc4Mr+jYdfSfmhI8iRMjh6jieFeMxWteg+g7gYdh/J7uc9erE2jq3pkHPROTja0i0pXH4MAVMI t2dSZlMuvqAzHaTanOq7ZF8WSKEiNCDxVNwwOfAcyCWKxvh1tFfrGywqMDlMvdCzLfyHRhzNrtH gThX9MJsJt4pW1g== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689742c88.45.1792255368763; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX/rOG4EP7JIgd WVj3LPH154xSDeToFBoefxfr57ackOWGW3vIfbZnm9IuMShMWfAKHf235/AFJm9TFBMQR5p2sh5 WA25mRWNZJly/c+4dkTxLPIB0j9u8r8/ZxddHA9FNCG9eg8ZQpetz+5Re1VtzcwteAcGe0CE5e1 Wp54QT9qR4KcMJVvm0XwYYmR5SXMrf3uOHiVJkvMsXqWBW0ul2tZ8FDNtkFvyagFkZaQU6H1fOD dyrLmFCnUlKz6yVMZCXpsefb6uu89NlYXJfXSPR5Z2MVy0ySlKHBMM2/BjLIWW3pxplBBDHYKrV VZHR2dDHYZnSv3/xTqewl47ZDZAMHmwaW/tfm1wO76JdwrYf0Xs5IBMQJ3bUfFH2UfqJxypHpqo xh2XUxjPntx3N/0j4xqVHEoTlIHVjjE+GfX4/a9xykI2scs6a8fd9Ml4jWOacNyks8Z0VbdecKF 9fzW4bJODdJst89AxsA== X-Authority-Analysis: v=2.4 cv=W4WtxhWk c=1 sm=1 tr=0 ts=6ad3a589 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-ORIG-GUID: TSiSdOKeUQqwU-0EOPg9KsYSnl64WGeX X-Proofpoint-GUID: TSiSdOKeUQqwU-0EOPg9KsYSnl64WGeX X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX07IYPxVRPZMv rqllqDzQkHojv3fpDp9t8OfU30u4erSiBgjnoX44nSxILy0zP3EDkPEYoDxwkZktKLp+Heha1+z ixZOYILbp86cqOW0d+1CHbCV7qfIHXI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan