From: Frank Li <Frank.li@oss.nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: sashiko-reviews@lists.linux.dev, imx@lists.linux.dev,
devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases
Date: Wed, 18 Nov 2026 10:24:16 -0600 [thread overview]
Message-ID: <av3RME_CJPOuUd60@SMW015318> (raw)
In-Reply-To: <c3082671-9d0d-4a29-9e05-17ae9d4ca997@oss.qualcomm.com>
On Wed, Nov 18, 2026 at 01:10:30PM +0100, Krzysztof Kozlowski wrote:
> On 17/11/2026 14:47, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue to consider:
> > - [High] arm64: dts: imx8q: removing vpu-core aliases breaks
> > vpu_core_probe()
>
> That's intentional. Users should not add undocumented ABI and rely on that.
This is problem. vpu need know hardware instance ID to talk with firmware.
What's prefer methods to fix this problem?
- Add fsl,id ?
- some old platform use "cell-index"
Frank
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-11-18 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
2026-11-17 13:47 ` sashiko-bot
2026-11-18 12:10 ` Krzysztof Kozlowski
2026-11-18 16:24 ` Frank Li [this message]
2026-11-18 18:37 ` Francesco Dolcini
2026-11-17 13:50 ` [PATCH 1/2] arm64: dts: freescale: fsl: " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av3RME_CJPOuUd60@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox