From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.83.16 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795077882; b=HX0IQmCLRlE+wfbh1Dcz6WZwlpNhNOKQ5UxlLsYHdrONUQ4vwIaeQI0r/viaYAKni0ad TFT9yNoe9eC82O7IJc0WfZS7ew2DyS5i9wra/8hCMCX/welQffOTaO5B38eEOpi95mu6p OJRpR05I2Ndf780PIC1ygI1SESl/3Rie8x273hl1NlbjJrq3Zhx6lUsIRACgPmLMXUK4A gxnc3BRR65BcqCqgG+Aq1BkZDCQHCyLIO5LB5HoYdBgezYuUfxX8wb4fXHFEDFD9Z9eJy eVyPmkzqDa7YUUwpgMZVngmujTuiC2CFmGCH3yOqsmTI3A63hpAHykq1Kqk4dWOxw6g== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795077882; h=DMARC-Filter:DKIM-Signature:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:Content-Type:Content-Disposition: In-Reply-To:X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0: X-MS-Exchange-AntiSpam-MessageData-1:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=aLlUZT059MSLq9CO/oh2NcBBnG/ct5JsOOYoDZECi7U=; b=qvGjHtIYM7eCZftWXtq2ZTigrqrbBQSbaN0hPVjqT9N0P/Zj9iRnxENRExC+9MNCN/4W tllJvhHe4B56xn9/SN+j8WJDFFwxdmlGJYl/FH38ZdyDa8XF3qyQ1csK2Z0j3jDpzGqu/ aFLSgTmJTqys19Iyt2hU2T5Nhdqmlvc9yDO5N3vrfO4q+RFxMsdpah6RwpBQPhPUlL2J7 VJVPNeCfRYvaTUwYRdTyLhbJJVnLswH7nZ9RDQQ1ya+Eir9pHyn4wXWFsOeesbYtDgqcs BBlc6zhUg5kdWWkIRGmShqOzdGo2uCvjpmXui6ZnMKOBAqHXGvZS3y2TbVK5BgArRsA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector1 header.b=T2o0nE7E; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.83.16 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013016.outbound.protection.outlook.com [52.101.83.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5D66606A324 for ; Thu, 19 Nov 2026 08:44:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E5D66606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector1 header.b=T2o0nE7E ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IMr8ECWkxftinoD5BLaghe0seu4HfixjFRsMMkR4xL1x0wuup/JqJpNRfMp4Ox3btdSx2rfZvWDQqxD+iDgvZjxBLOLwf61kJdRL7jJM8KGJTVljZ4qRppX7ca7fldCUUOAR0CWhsg4BaK+sk+0+Pn1ni05eU0J5UZjJxwq7f+DvlzDgmGZRvX7mjLlmb39WwDYVbqA/gGU/n3u4HEQsAgwZTYT3NgfoJ+AkLHs3qbn5uQwS2h52p6wwCO+2QnTh83L7+3n8+YamubTUowlugwZ2uOGS6HfxHb71pTqpwWiur+UJlGY1EaO5UNdQyGvMRxAIhBR60vXoBK00CHip6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aLlUZT059MSLq9CO/oh2NcBBnG/ct5JsOOYoDZECi7U=; b=Ct9YIe32TIvn18Jnmcdss9qtzvo6XBt6+ujyOPaXNUwgHHOWIxFumZJlZDlBGKMpzrALS+jCoaD3Cq8rLbrxvZNYfLcGTbvrxc90dkngOz0sEwIfDJbOXY7u7vwSV0qibG/8jj3NISQ/7QxuWkuP8mg2vHgAy0SD+++4CXzblTy7rkQdJFfYncUC3BaZJgqMlLNM+uOMUN1ghUhQVXBN9pI5F6+L1aCxMQ+EytOsP++FdOdNZaYGvF0j1Ho3Dx5B0k3HW4U9BzHgc3bXMpW2HPBE/j5CqZmOMrjjcDxiCWFEEQWkUROXQzd6KtA+exIpJuhElbEXPZb8bLkCg0lCdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aLlUZT059MSLq9CO/oh2NcBBnG/ct5JsOOYoDZECi7U=; b=T2o0nE7EIpLulHs7lpwa8dnxF4MOwiRiLXvR2bpqD5JiWme7kXyV2WtsQZU385WksINyo4sKYS6WBxvBkXvO7PmJRL8i3S+OAPC2NXjyZp280h4Ph65tjG8wgbIn9xAVgi3jJa++TaItgVdNGfD0GNwFAUQLuN4Lf8tB8b3m1+5wlBxLmw0myc2VTPOwvjOrV1PUvYQBDWFK18vkSb4menPputV4CcX7nUJMgD2cj0JY4Skm8qCYTTQAeHyszNSpbP7sd3ZcpPpfnQQp91JHHyv/NC19nyorlLfN7Un9VyKe6AonYh7ckJG1kKgj9AbmD6HQ/M7EBRm+gEgccXviag== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) by DB8PR04MB6908.eurprd04.prod.outlook.com (2603:10a6:10:116::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Thu, 19 Nov 2026 08:44:36 +0000 Received: from AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023]) by AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023%4]) with mapi id 15.21.0639.010; Thu, 19 Nov 2026 08:44:36 +0000 Date: Thu, 19 Nov 2026 10:44:33 +0200 From: Vladimir Oltean To: Eric Dumazet Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , Wei Fang , Clark Wang , Ioana Ciornei , Willem de Bruijn , imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net 4/4] net: enetc: let core segment GSO skb when headers exceed TSO_HEADER_SIZE Message-ID: References: <20261118235055.1225115-1-vladimir.oltean@nxp.com> <20261118235055.1225115-5-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: VI1PR09CA0096.eurprd09.prod.outlook.com (2603:10a6:803:78::19) To AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6900:EE_|DB8PR04MB6908:EE_ X-MS-Office365-Filtering-Correlation-Id: 387d6844-89c6-4e93-2148-08df46195769 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|10070799003|19092799006|261021135927099003|261022075727099003|10067099003|5023799004|56012099006|11063799006|4143699003|261026140227099003|261028144727099003|261021121427099003|261022105027099003|261026121527099003|261102123227099003|261009223027099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: Mwt0/8kN9TisZ7cd7QS8/LdynKPkQJTmdYr7H3qZeerQKe9QcV1vdUe5NijfkG/UzqH8s44n1lgAZEr+Ni3RomerXW4GR0zzCIkKsGZKBbU0P5+NVRTSQHIRsdM+x7PDAAXZfJsOWyUcFqxMoAeVIApwQgsKW2lKkSFGWjNHlUpgNKrqEnlM/JNuVGtCponWWCVDK/8IKnl3Np6rEeM75zlC/zoiU72nTEaWtyz0roVgFzZVPestc7Qr3HaW2SwGDhiFKDBP/uUJLTUYJ8OVt4THSIFXbpugjmXOdX5ZrSs/mgVO+l2Zb4Sfb8lO5g6LSjGVUv5r5Ms3ONEhtro8KAJJKY3alAq/NsOr8lMrZvOwUQKMRPsodWBOyJgvD7dcEEIktQPXu4dWEgSrftS/PiiNk9YL3kesNSRBtH983NBR74G+uhSEXvQLIqP7VfTs6ygazWldKaOkz4V+kXxbrjG1X1BngTgJj1i56ndzjvmrtf/0aN2XR2V8hVrP7gLV4cVGPvxhMLfdJPLw8YJH/3uq5EcVYcrIb9VUMpHcMBCG60UNEqvvl1XSY6lUEO3OxBuwdHxxoKpGhu6yGTGKvfrST/CQuGcxQU6Qkzjq+FU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6900.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(10070799003)(19092799006)(261021135927099003)(261022075727099003)(10067099003)(5023799004)(56012099006)(11063799006)(4143699003)(261026140227099003)(261028144727099003)(261021121427099003)(261022105027099003)(261026121527099003)(261102123227099003)(261009223027099003)(18002099003)(22082099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZzM4q6jAO4y6JOxMjsK9Titcx954hcklnvoVeB44i+uYuTNC67MnULCd8WJk?= =?us-ascii?Q?9oVJgT2XS9EpP0GcLd9L7jZtI/GMfKYsfXkLsuJANQtfooc+93UAxeNd9vOP?= =?us-ascii?Q?0OF0elWBEdRd02GmNXoGKEYMD9edBYyRkl/hS6Kas3I5YW0CEzFZPQE0ty/O?= =?us-ascii?Q?242FoQd/B5VofEHRZ4dam2NQ+GLZhJYwQKMDgXbsuWU3cKJc47KgLsjmVV44?= =?us-ascii?Q?z4JfpUtIi9v2xBOrXp9iusk4sNuo3LkPdFpJbMK0IH/gp4Fp5rorLMoH4Hqw?= =?us-ascii?Q?l1fd4bq3BCb/obSU0Tzy37SnKY5S3dXRzo84rSbeystiw1OCs835MKR4MBn4?= =?us-ascii?Q?nTaACtEpCK+GVW87r+CeqLfHnKroVIGI7WKYlrz1pRYalpe7VovVImeJ0F+r?= =?us-ascii?Q?1YTrvSmmayBI21XW2qf0L15uGCSbznNm1oI8Us6Zyflo3Yj5lgL9LTRHPuyZ?= =?us-ascii?Q?x9+dPLeQ83wU2eZ8WbKnUuDY2b+4PzLbXyMNH4C8V8UptEj23XUKNW1CoSV7?= =?us-ascii?Q?Tu2pAe999Tath2SbKmkRZB+9mXbRnz3RdCadfH/m85VX2nMgxrZs2g3vuIsw?= =?us-ascii?Q?V3gErJHxr+5xSy301ZAi/5pkd3L+d2+fshvNqMXt7neFtA2/t2yPjlUhByj1?= =?us-ascii?Q?dPsPYnB+y++3owa3bDGdkpquTyre9H8iUSZHs3gdm1f86M30WDMwhiBmmyCv?= =?us-ascii?Q?dO8n2W+Vu0JlQsMQkVNi0EsLzus4Uk23g2XC8lE4C9Uid5YrLaoHKW4ZPvPO?= =?us-ascii?Q?OdCcKw9HKm7FDg5pX0ShelRzeoNn8qT6bbskclwbxjSNIK5ZKd/jXVHcc8Fq?= =?us-ascii?Q?N2Q431AOa/LpcSj19h89kRajhI8Qy29F4gfQPRL9NWPiQGpf/UIiPbZco8E3?= =?us-ascii?Q?xtAt9B+W0LTKvxLFXkkAGDM0oEjmqwBavHia/mbnRA4/B5631YGeW7bVHXTp?= =?us-ascii?Q?rtuiosMMtjHPKHgWPzAC7UWu0+elAfhMWhBMgXD9Ed415ggEp4Qs9Ym/IYxv?= =?us-ascii?Q?VQ3dfiuGdObR2yJKGN8SIonzz2hgNz4bNl8UwlWwYlHJSwGim9B6q9AOhPCN?= =?us-ascii?Q?DS4YmTS0/9Dxu9K01VPF4XHvA2JzLJzqr8hxNUZh3MiqMmDnVD4fy1tsr3rg?= =?us-ascii?Q?QpJ0WkkmVYZD0dZWsgsYPxqi+HngkfihB2hdhkuJx8e8Bi7AI4anni+wljzW?= =?us-ascii?Q?z1v/7QRLOIjfwBvTx1OXgRIDFepNyIR8FfzWohYwLlcSGH7IByybOlKZfEAw?= =?us-ascii?Q?PHCnoKiq15z7QtepHe41toTGyiQSwNZQ/2abBxO4OqwwkeEIStghJ8NEVX2T?= =?us-ascii?Q?I2FPQyFqMGxRBKLpdq+4HxWZ4OW9QgZHvzdQhJITRk5X9o2tb6yGoR6BNUru?= =?us-ascii?Q?qQVl5RMLGmMw70J29/h7cOWk+0ejQS8Tvyi0kpx8wq4h9jGY3FJxWVPhep9w?= =?us-ascii?Q?n9JiXV3OenzzRCwcx6Qqd6z4AxKfCacARSHGFyzZ8cChU2L8l0zL5oSEwoDd?= =?us-ascii?Q?S9b0vGFWLgcPuK76MCmCmD+RNsV18gbmoFZPbxuQR1LjA4W8xQIqykuce4c9?= =?us-ascii?Q?e1bY9Lxv4Ew7lK4/aXlvxxwbQu3M12x3PMp4lZ4GibrlDE8d9DLcYLAJiCtd?= =?us-ascii?Q?qyOS6cfG6cvJ2kXfW2DTKrcbO1rYHGktBHnkbCXDVpkvOAlydUBHuhrhAHmK?= =?us-ascii?Q?s95BSN5TkXEtIuHmhErcmFAIo3durnY46yP72d2iILxFWuoyGMo4iEeXjERx?= =?us-ascii?Q?O02XdfFP6F4AWdnEsB310VHaa35YUW6Zc6PiQCT1fB1OvmWTFk+i8TuakhZR?= X-MS-Exchange-AntiSpam-MessageData-1: LCiV0+KcIKTBBckuOmnHjBBQ5M8s6YFu2ys= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 387d6844-89c6-4e93-2148-08df46195769 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6900.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2026 08:44:36.6231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tBffFt/7kuSBt0S25WtZtrw7BySNLOOE7Im27w7B9P9Ir7naRi0y/An63jYX/Yj27PSD6Ec3BiBekaGyLr2xVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6908 Hi Eric, On Thu, Nov 19, 2026 at 01:03:16AM +0100, Eric Dumazet wrote: > > Bizarrely, enetc is the only affected driver, because the core > > accidentally protects most other drivers against this bug in > > gso_features_check(). There, we have this logic that saves the day: > > > > /* NETIF_F_IPV6_CSUM does not support IPv6 extension headers, > > * so neither does TSO that depends on it. > > */ > > if (features & NETIF_F_IPV6_CSUM && > > skb_has_ipv6_extension_hdr(skb)) > > features &= ~(NETIF_F_IPV6_CSUM | NETIF_F_TSO6 | NETIF_F_GSO_UDP_L4); > > > > enetc is the outlier because it only advertises the more complete > > NETIF_F_HW_CSUM, so for it, this fixup does not clear the NETIF_F_TSO6 > > and NETIF_F_GSO_UDP_L4 bits. > > > > [ astute reviewers may ask: what if we disable NETIF_F_IPV6_CSUM at > > runtime, via ethtool -k, so as to bypass this fixup, don't we make > > all drivers vulnerable? > > No, because netdev_fix_features() will trigger the code path which > > also prints "Dropping TSO6 features since no CSUM feature.\n". > > So TSO skbs will now be segmented in the stack. ] > > > > Surveying every driver that uses TSO_HEADER_SIZE: > > > > Driver | TSO6 | Checksum feature | Core guard fires? | Verdict > > ---------------|---------------------|-------------------|--------- > > enetc | yes | NETIF_F_HW_CSUM | no | vulnerable > > bnxt | yes | NETIF_F_IPV6_CSUM | yes | safe > > nicvf | yes | NETIF_F_IPV6_CSUM | yes | safe > > otx2 | yes | NETIF_F_IPV6_CSUM | yes | safe > > fec | no | NETIF_F_IPV6_CSUM | n/a | safe > > mvneta | no | NETIF_F_IPV6_CSUM | n/a | safe > > mvpp2 | no | NETIF_F_IPV6_CSUM | n/a | safe > > mv643xx | no | NETIF_F_IP_CSUM | n/a | safe > > dpaa2 | no | NETIF_F_IPV6_CSUM | n/a | safe (*) > > > > (*) dpaa2 also uses a fixed-size kmalloc(TSO_HEADER_SIZE) per segment, > > so the identical overflow would apply if it ever gained NETIF_F_TSO6. > > > > The above survey is what influenced the decision to make a localized > > patch in enetc_features_check() rather than create a huge disturbance in > > the core, even though, IMO, TSO_HEADER_SIZE is a huge foot gun. > > I should probably rework my series : > https://lore.kernel.org/netdev/20260403043237.3909226-1-edumazet@google.com/ Do you disagree with my analysis that only enetc risks corruption? I mean, for a second layer of defense, having tso_features_check() everywhere TSO_HEADER_SIZE is used probably makes sense, but I opted for a targeted fix because I couldn't justify it for the other drivers.