Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Peng Fan <peng.fan@nxp.com>,
	linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-rt-devel@lists.linux.dev,
	Bjorn Andersson <andersson@kernel.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3 00/10] mailbox: imx: Use threaded handler to avoid kworker in imx's remoteproc
Date: Thu, 19 Nov 2026 14:25:55 +0800	[thread overview]
Message-ID: <av6Wc+kHFKqwFHAR@shlinux89> (raw)
In-Reply-To: <avrLnVFtgobyTwN1@francesco-nb>

Hi Francesco,

On Mon, Nov 16, 2026 at 10:23:41AM +0100, Francesco Dolcini wrote:
>Hello Sebastian, Peng
>
>On Wed, Jun 17, 2026 at 08:55:25AM +0200, Sebastian Andrzej Siewior wrote:
>> The imx's remoteproc driver uses a kworker from its mailbox callback to
>> complete the request. The reason is that the imx mailbox driver invokes
>> the callback from its interrupt handler and the remoteproc callback (at
>> least the rpmsg-tty) requires a preemptible context.
>> 
>> This works but is problematic in a PREEMPT_RT environment where the
>> latency of the invocation is important. By scheduling a kworker the
>> high task priority from the threaded handler is lost and the kworker
>> competes for CPU ressources with every SCHED_OTHER task in the system.
>> This can lead to long delays on a busy system with other RT threads
>> which are less important than the completion of this request.
>> 
>> Looking over other mailbox driver, like the arm_mhu for instance, they
>> use a threaded interrupt handler to invoke the callback. This avoids the
>> kworker detour.
>> 
>> The here suggested change utilises a threaded interrupt to invoke the
>> callback. The primary handler mask the interrupt source so that the
>> handler can run without getting interrupted by the interrupt again.
>> Doing so avoids marking the interrupt IRQF_ONESHOT so that in a
>> shared-interrupt environment the other interrupt can still fire while
>> the first is masked.
>> 
>> The first four patches are result of the sashiko review. Does not look
>> critical.
>> 
>> This change was tested on a im93 board with rpmsg-tty driver.
>
>Our CI shows a ~10-15% eMMC sequential read throughput drop on i.MX8QXP
>and i.MX8DX (Colibri iMX8X, Cortex-A35), starting with v7.2-rc1 and
>still present in v7.4-rc3 (hdparm --direct -t: ~129 MB/s -> 105-120
>MB/s on i.MX8DX). i.MX8QM, i.MX8M and i.MX9 are not affected.
>
>5d1c0000.mailbox interrupt count before the test went from ~8k on v6.18
>to 60k+ on v7.3/v7.4.
>
>Peng: any idea/suggestion? Does it makes any sense to you?

Please help test whether this helps:

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 683ccea6f2ba..e29044cf4b92 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -635,7 +635,7 @@ static int imx_mu_startup(struct mbox_chan *chan)
 {
        struct imx_mu_priv *priv = to_imx_mu_priv(chan->mbox);
        struct imx_mu_con_priv *cp = chan->con_priv;
-       unsigned long irq_flag = IRQF_NO_THREAD;
+       unsigned long irq_flag = IRQF_NO_THREAD | IRQF_ONESHOT;
        int ret;

        pm_runtime_get_sync(priv->dev);

Regards
Peng

>
>Francesco
>
>

      parent reply	other threads:[~2026-11-19  6:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17  6:55 [PATCH v3 00/10] mailbox: imx: Use threaded handler to avoid kworker in imx's remoteproc Sebastian Andrzej Siewior
2026-06-17  6:55 ` [PATCH v3 01/10] mailbox: imx: Forward the timeout/ error in imx_mu_generic_tx() Sebastian Andrzej Siewior
2026-06-17  7:08   ` sashiko-bot
2026-06-18  1:50   ` Peng Fan
2026-06-18  1:57     ` Peng Fan
2026-06-22 11:24   ` Peng Fan
2026-06-24  7:44     ` Sebastian Andrzej Siewior
2026-06-26  8:23       ` Peng Fan
2026-06-26  8:34         ` Sebastian Andrzej Siewior
2026-06-26  9:00           ` Peng Fan (OSS)
2026-06-29 15:38             ` Sebastian Andrzej Siewior
2026-06-17  6:55 ` [PATCH v3 02/10] mailbox: imx: Add a channel shutdown field Sebastian Andrzej Siewior
2026-06-17  7:08   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 03/10] mailbox: imx: Use devm_pm_runtime_enable() Sebastian Andrzej Siewior
2026-06-17  7:08   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 04/10] mailbox: imx: use devm_of_platform_populate() Sebastian Andrzej Siewior
2026-06-17  7:04   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 05/10] mailbox: imx: Use channel index instead of zero in imx_mu_specific_rx() Sebastian Andrzej Siewior
2026-06-17  7:13   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 06/10] mailbox: imx: Start splitting the IRQ handler in primary and threaded handler Sebastian Andrzej Siewior
2026-06-17  7:08   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 07/10] mailbox: imx: Move the RX part of the mailbox into the " Sebastian Andrzej Siewior
2026-06-17  6:55 ` [PATCH v3 08/10] mailbox: imx: Move the RXDB " Sebastian Andrzej Siewior
2026-06-17  6:55 ` [PATCH v3 09/10] mailbox: imx: Don't force-thread the primary handler Sebastian Andrzej Siewior
2026-06-17  7:08   ` sashiko-bot
2026-06-17  6:55 ` [PATCH v3 10/10] remoteproc: imx_rproc: Invoke the callback directly Sebastian Andrzej Siewior
2026-06-17  7:19   ` sashiko-bot
2026-11-16  9:23 ` [PATCH v3 00/10] mailbox: imx: Use threaded handler to avoid kworker in imx's remoteproc Francesco Dolcini
2026-11-16 10:23   ` Sebastian Andrzej Siewior
2026-11-19 11:40     ` Francesco Dolcini
2026-11-19  6:25   ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av6Wc+kHFKqwFHAR@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=andersson@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mathieu.poirier@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=rostedt@goodmis.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox