From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=185.56.87.12 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794953911; b=ly8+I8NIAA0n98/Pojl+lUtBS9oX6mWIj3ObZreGaVejIk5d1FZXhd+u4K3c804wcZj/ KUfo+h+BIZt6iGXM5GnK3GkU48PDw/RgUweY2dlnqJVMZvbDyzvZpZLD57XU8E6llHcVZ lsIXzuPpqKgChA8ZDwxPWj0GrWKHZ+Tyubqhge1TMM65XucplZA2X7Cbr8jJ6iazD/hxb u0H5negV7fe2r1NsI1dU2yxdpkuARrgHIf+Ya45sFIz6YXbipnkmLMCIf8krL3TzbHz9v Tlm00Ime7q2xnIYB4zyf/CdCngnpUk5rIjX8TvHdNDQMoMp/6YUcdZghd4U/c0goswg== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794953911; h=DMARC-Filter:DKIM-Signature:Received:DKIM-Signature:Received:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-AntiAbuse:X-AntiAbuse:X-AntiAbuse: X-AntiAbuse:X-AntiAbuse:X-Source:X-Source-Args:X-Source-Dir: X-SGantispam-id:X-AntiAbuse:AntiSpam-DLS:AntiSpam-DLSP:AntiSpam-DLSRS: AntiSpam-TS:CFBL-Address:CFBL-Feedback-ID; bh=XDw9/M2MIm98kw8EzKXejlZaq6aMnfzsqjAxXtqrIdg=; b=ZAonKy368TMVQUzpVA5CeE4Op3kuAPSqqFVUlMBE4HZPXW9cjDtXHcAeIf3F8dPDQbtZ LLbrdOji1eM6iJp4do1kPRCV65TRSMz0z6NXWll42FCfzyjGXin7Pcn4iysMXieulAFbA z6JdqChdpmZFgEqvSCriaRWbGhj69GglRMXgPux5v+mCfuiIaUVy8T1iRiH/Tz0ODEVX9 luRlXAH1bh0GywW/Fy2pVI83bViOvqiXyyG96kjZ23cCkZ560N46Qr7gvLREik/8bIFYP Im3Aeg1EVCVQ+Gk9Ro8p0nex8i929GvgX4nUcrrd+lauyUp79CWUflQ1c4qDMDIutwA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=valla.it; spf=pass smtp.mailfrom=valla.it; dkim=pass header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.a=rsa-sha256 header.s=default header.b=w7MHAL21; dkim=pass header.d=valla.it header.i=@valla.it header.a=rsa-sha256 header.s=default header.b="J/o/wHZM"; arc=pass header.oldest-pass=0 smtp.remote-ip=185.56.87.12 Received: from delivery.antispam.mailspamprotection.com (delivery.antispam.mailspamprotection.com [185.56.87.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7695C606A32A for ; Tue, 17 Nov 2026 22:18:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7695C606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valla.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.a=rsa-sha256 header.s=default header.b=w7MHAL21; dkim=pass (1024-bit key, unprotected) header.d=valla.it header.i=@valla.it header.a=rsa-sha256 header.s=default header.b=J/o/wHZM ARC-Seal: i=1; cv=none; a=rsa-sha256; d=outgoing.instance-europe-west4-4zq2.prod.antispam.mailspamprotection.com; s=arckey; t=1794953910; b=K1fJScm9hXB1MeJBqSOq84DQ4jT8baq8DKMSSOzFvx3ygVA1CbF7I2u8yLVlDglRGisgw4KAAA I1h/5HfyOsD56a1EvhjthDNrtU+nihRLpH82r6hoR/LJ7x5GLMYUnTHBotgeYuZNFo94sxNKT6 +sPz/fkpGYfDFsh5ypDVECI/IpzIH4Pb/oSwJxDxBYBSZEUwdgeoYW8ctLPC+0w+5NMoxfPuNv oPHOoQvH5ZbzoLMGQddal7h8e7Uh1VGVjSuzeG/EKs5OzNpgjCwxj6q+jXc7Cfkp1Tofc5Q1+Y g6gJ1ZS76Nrbg6YbqeUSolSOSruwE47cswdtsyBW9Wggag==; ARC-Authentication-Results: i=1; outgoing.instance-europe-west4-4zq2.prod.antispam.mailspamprotection.com; smtp.remote-ip=35.214.173.214; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=outgoing.instance-europe-west4-4zq2.prod.antispam.mailspamprotection.com; s=arckey; t=1794953910; bh=lLTugMaSzlCBSdBDH2IIIB/bAhkr/et1oe9MmxV/meo=; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To: From:Date:DKIM-Signature:DKIM-Signature; b=hRAo8dndRV8WazWr/Nr7wtT7nf3PdzEA3HULHKG6xmmmRqWrtQzV98cva/5mv7HZuEKGF91cEo c1AY1HUYeV3Of9eQ3EjY3G8t3UZdtT9rxgYMFkqNeHuMo1+NtItRTSMMZ4gJfhAz8IMJPSZ9Ji r1zF72pfoASeVt98X3A3HLRsFcni29x4NydE/SIh/iamnIhPtPa7XNH27MzSxVDkd01iwNuahm nKfEbrCbZjN5VkWH87fC8AQYN/wVviDAibOmH/BfoK1PRsiQgi837flAA7PIPpkF3J7drklK26 XeS5sST6V3L+lEt0scve7+jjF+px296fDyVfs8OlP8nJlA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=antispam.mailspamprotection.com; s=default; h=CFBL-Feedback-ID:CFBL-Address :Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: List-Unsubscribe:Content-Transfer-Encoding; bh=XDw9/M2MIm98kw8EzKXejlZaq6aMnfzsqjAxXtqrIdg=; b=w7MHAL21OGlVQkv0srCSrfYIlA QUjPzuevJ4NJpPKeyXAw0JK8+JI0JkWODFsHAbhEbQ+CBqjMtSY1t7JaC2DZas76WqI73cf4rqUCh TwBPPH8R5tupn/64afFYBzYuEX2lqoydqwpcwpU+UsxLCbme5RiLba0wjXiCOtjb9gKM=; Received: from 214.173.214.35.bc.googleusercontent.com ([35.214.173.214] helo=esm19.siteground.biz) by instance-europe-west4-4zq2.prod.antispam.mailspamprotection.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xTRVO-00000001eDU-3JME for imx@lists.linux.dev; Tue, 17 Nov 2026 22:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=valla.it; s=default; h=Subject:Cc:To:From:Date:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; bh=XDw9/M2MIm98kw8EzKXejlZaq6aMnfzsqjAxXtqrIdg=; b=J/o/wHZMlZNHzlGj2v3qrP9lrF VBTkUAvJ0gtM++9cWsX0Yubj11+RtRGUwDNRkoZHjCrkf1RuoAIyHmo6uSXc/Cfe32dTtxBQLppcN BD5OKrVRmK2m4pzECQ/oF6ps0YLJ81c0iz7XtJHKuY1T70AbxRwXbjm+kE+TAWDyHMhs=; Received: from [95.251.96.187] (port=64319 helo=bywater) by esm19.siteground.biz with essmtpa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xTRV7-000000005TO-1T4G; Tue, 17 Nov 2026 22:18:05 +0000 Date: Tue, 17 Nov 2026 23:18:03 +0100 From: Francesco Valla To: Mathieu Poirier Cc: Bjorn Andersson , Kees Cook , "Gustavo A. R. Silva" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Randy Dunlap , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Robin Murphy , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC v2 05/11] remoteproc: virtio: report VIRTIO_F_ACCESS_PLATFORM when required Message-ID: References: <20261102-remoteproc_virtio_map-v2-0-26b300e01c62@valla.it> <20261102-remoteproc_virtio_map-v2-5-26b300e01c62@valla.it> X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - esm19.siteground.biz X-AntiAbuse: Original Domain - lists.linux.dev X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - valla.it X-Source: X-Source-Args: X-Source-Dir: X-SGantispam-id: e6dc434395b3b26d3e802d536fd2bf20 X-AntiAbuse: ID - e6dc434395b3b26d3e802d536fd2bf20 AntiSpam-DLS: false AntiSpam-DLSP: AntiSpam-DLSRS: AntiSpam-TS: 1.0 CFBL-Address: feedback@antispam.mailspamprotection.com; report=arf CFBL-Feedback-ID: 1xTRVO-00000001eDU-3JME-feedback@antispam.mailspamprotection.com Authentication-Results: outgoing.instance-europe-west4-4zq2.prod.antispam.mailspamprotection.com; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none On Mon, Nov 16, 2026 at 11:16:13AM -0600, Mathieu Poirier wrote: > On Mon, Nov 02, 2026 at 12:26:42AM +0100, Francesco Valla wrote: > > Depending on the driver originating them, data buffers used for virtio > > communication can either: > > > > - already be allocated from the coherent memory area that is > > accessible by the remote processor; this is the case of > > remoteproc-specific virtio devices, i.e., rpmsg and rproc-serial; > > - be allocated from generic kmem, and thus not necessarily accessible > > directly by the remote processor. > > > > In the second case, the DMA APIs can be exploited to obtain a > > functional communication, since they will take care of cache maintenance > > and - if required - bounce buffering. The VIRTIO_F_ACCESS_PLATFORM > > feature flag can be used for this purpose: with it set, the virtio > > framework will use the aforementioned DMA APIs to map and unmap buffers. > > > > Bounce buffering will be transparently used in two cases: > > > > - if the buffer address supplied by the virtio driver is not suitable > > for DMA transfers, or > > - if the reserved memory associated to the vdev is a > > restricted-dma-pool; in this case, *all* buffers will be bounced to > > and from this pool. > > > > With this support in place, any kind of virtio device can be supported > > through the remoteproc-virtio transport, at least from a data exchange > > standpoint. > > > > Note that remote processors behind an IOMMU need da == pa for the memory > > region(s) the buffers are allocated from. > > I'm not sure to understand the da == pa requirement - can you expand more on > that? > Yes! With a caveat: the IOMMU usage by the remoteproc framework and how it can integrate with this work is the main reason this is an RFC, as stated in the cover letter, because I'm not sure I understand all of it. See for example the dma-to-da conversion in [1] or the comment in [2]. That said: all the IOMMU setup that is done today by the remoteproc core is linked to the *remoteproc* device, not to the rproc_vdev (i.e., the device backing the virtio device). For that reason, the DMA subsystem should not be able to know that setup even exists, in particular while performing swiotlb operations. Hence, the requirement to have a 1:1 mapping between da (i.e., the address the device uses) and pa (the physical memory map). > > > > Existing use cases (e.g., rpmsg and virtio-console) are not impacted as > > they are explicitly excluded. > > > > Signed-off-by: Francesco Valla > > --- > > drivers/remoteproc/remoteproc_virtio.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > > index f1b362158a9c..1496659ddff9 100644 > > --- a/drivers/remoteproc/remoteproc_virtio.c > > +++ b/drivers/remoteproc/remoteproc_virtio.c > > @@ -280,9 +280,14 @@ static u64 rproc_virtio_get_features(struct virtio_device *vdev) > > * All non-remoteproc-specific virtio devices are assumed to be > > * compliant with virtio specifications 1.x; there is no other method > > * to transmit this capability from the remote processor to the host. > > + * > > + * Virtio devices that are specific for remoteproc usage take care on > > + * their own to allocate memory from the device's coherent pool; use > > + * the DMA APIs for the others through VIRTIO_F_ACCESS_PLATFORM. > > */ > > if (!rproc_virtio_rsc_vdev_rproc_specific(rsc)) > > - features |= (1ULL << VIRTIO_F_VERSION_1); > > + features |= ((1ULL << VIRTIO_F_VERSION_1) | > > + (1ULL << VIRTIO_F_ACCESS_PLATFORM)); > > > > return features; > > } > > @@ -312,7 +317,8 @@ static int rproc_virtio_finalize_features(struct virtio_device *vdev) > > features = vdev->features; > > > > if (!rproc_virtio_rsc_vdev_rproc_specific(rsc)) > > - features &= ~(1ULL << VIRTIO_F_VERSION_1); > > + features &= ~((1ULL << VIRTIO_F_VERSION_1) | > > + (1ULL << VIRTIO_F_ACCESS_PLATFORM)); > > > > if (WARN_ON((u32)vdev->features != features)) > > return -EINVAL; > > > > -- > > 2.56.0 > > > Thank you! Reagrds, Francesco [1] https://elixir.bootlin.com/linux/v7.4-rc1/source/drivers/remoteproc/remoteproc_core.c#L716 [2] https://elixir.bootlin.com/linux/v7.4-rc1/source/drivers/remoteproc/remoteproc_core.c#L461