From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E6A178368; Tue, 15 Oct 2024 06:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728972814; cv=none; b=hI3Ph8Myoh6DOmgQlWyQswoM2hGZ5+7iK1GcX0HnBS2NXd3ha26NkkCjaky2G9tFYZhm35EH1P7tVJHuD3gxYflLUfjDIInX6DAjxrU2FDG8IxRp+J2HhRvp/QukkiislBnwq5zqN9TBa3a+16ogr47ewjZZ+dUaRuGvEt/evYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728972814; c=relaxed/simple; bh=nMcb720BCAExfKB6LJEWqVG38e41Du2Roz3F2hdHex8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ThGHlEHbXyPe3bvveZF8++bc7so/tFZQOtSY6EQa5Y3ZSKcMHdTg9LA2IVNzk0dmgQLahEfbayRvU4zM3ZnIB8+oniegoUtMqX00qbhK39UN5r9yDUDiEjisQut3RdoM8G7dktri7KUZ5qUb66aC/H7khcGigrRbff99Ow/4nU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fuEFHgQO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fuEFHgQO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F0C5C4CEC7; Tue, 15 Oct 2024 06:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728972813; bh=nMcb720BCAExfKB6LJEWqVG38e41Du2Roz3F2hdHex8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fuEFHgQOTV95eYjoJ7Ypx+GID3EqJW0Ax/pS92IxGPTaK/08XHc5M6pxH66wpDbjT jfpMkimI9ipSxxfVASThA3nWwTRx9JFuh6teI4NRX6vFzDpmsZYdcyquTADMg1nfVx txz+x4wxegS5eOCv6GoxPAW8xkH0NY2ykATT34LVfBqbBfIQ0KI/4IG0+fwa4izHDy dGNHUvRDcmSOy0ODfaHobDLALOl9n5p0U0t5w2SopdpUsaU6CSrgWmr6aCg7cE6MWE ga0RC8Vd7v8+81c8YbCf3a6txcENixKqlbILc43hO5r0gMzjiRaFQrzrWPpVGOyirZ ZggOTfo2GPUHQ== Message-ID: Date: Tue, 15 Oct 2024 08:13:19 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema To: Laurent Pinchart Cc: Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dave Stevenson , Sakari Ailus , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Martin Kepplinger , Paul Kocialkowski , "Paul J. Murphy" , Daniele Alessandrelli , Tommaso Merciai , Martin Hecht , Zhi Mao , Alain Volmat , Mikhail Rudenko , Ricardo Ribalda , Kieran Bingham , Umang Jain , Manivannan Sadhasivam , Vladimir Zapolskiy , Dongchun Zhu , Quentin Schulz , Todor Tomov , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-0-a2bb12a1796d@linaro.org> <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-1-a2bb12a1796d@linaro.org> <20241014203441.GF5522@pendragon.ideasonboard.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20241014203441.GF5522@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/10/2024 22:34, Laurent Pinchart wrote: > On Mon, Oct 14, 2024 at 09:43:07AM +0200, Krzysztof Kozlowski wrote: >> On Sat, Oct 12, 2024 at 04:02:50PM +0100, Bryan O'Donoghue wrote: >>> Remove extraneous assigned-clock* from media/i2c/* schemas, retain in the >>> relevant examples. >>> >>> Link: https://lore.kernel.org/linux-media/j7kgz2lyxnler5qwd7yiazdq6fmsv77kyozdrxf33h54ydakjz@uqjhwhoyv6re >>> Signed-off-by: Bryan O'Donoghue >>> --- >>> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 8 -------- >>> Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml | 8 -------- >>> Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml | 8 -------- >>> Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 4 ---- >>> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ---- >>> Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 4 ---- >>> Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ---- >>> Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml | 4 ---- >>> 8 files changed, 44 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml >>> index 60f19e1152b33128cf3baa15b8c70a874ca6d52e..d18ead8f7fc43bfacc291aed85b5ca9166c46edb 100644 >>> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml >>> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml >>> @@ -28,12 +28,6 @@ properties: >>> items: >>> - description: Reference to the mclk clock. >>> >>> - assigned-clocks: >>> - maxItems: 1 >>> - >>> - assigned-clock-rates: >>> - maxItems: 1 >>> - >>> reset-gpios: >>> description: Reference to the GPIO connected to the RESETB pin. Active low. >>> maxItems: 1 >>> @@ -82,8 +76,6 @@ required: >>> - compatible >>> - reg >>> - clocks >>> - - assigned-clocks >>> - - assigned-clock-rates >> >> That's not extraneous, but has a meaning that without assigned-clocks >> this device or driver will not operate. > > How so ? Even if we assume that the device requires a specific clock > frequency (which is often not the case for camera sensors, the > limitation usually comes from drivers, so the constraint shouldn't be > expressed in the bindings in that case), there is no overall requirement > to assign a clock rate as in many cases the clock will come from a > fixed-frequency oscillator. This seems to be a constraint that is > outside of the scope of DT bindings. It is similar to regulators, where > the regulator consumer doesn't have a way to express supported voltages > in its DT bindings. This property does not say it comes from a fixed-frequency oscillator, so I do not understand why you think it is unreasonable constraint. I have no clue what the author wanted to say here, so I just explained that there is a meaning behind requiring such properties. If you claim device or implementations do not have such requirement, after investigating each case, feel free to drop this. I think I also stated this already in other reply. Best regards, Krzysztof