From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45E57C087 for ; Wed, 24 Jan 2024 14:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=134.134.136.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706108388; cv=none; b=ap24HVBhTjBte0ze9L3RAtG+Ouuf+eYFV6YuxmFj7/oT1dRFg2DWn1zJ1Aq9S2zncmBugAX5xGg4EKa2BzDjk9MkL8vqedVM1VP2VHrb8gq3PMVkmi7Lf5OkC4X1Rth5xBjgfe6VxXVv2DtpnWkJPoLZgykQcrf/NLK2+LOoTUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706108388; c=relaxed/simple; bh=RzDbhYSEcmLvl0Tieidy5sjp9uAbbBuDzPRK5lNr8Tk=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=jxe+imgyzJcnvg8wQj6u8BNFQT2jh7yEAzSyhGSUXtONvZCFlXR6yySqFbn0Rf/+CoPa7F7M1JB5Kk8sqfY0P120x8qDJpRqB8JP4+sdxvyCgVOhREM3JanWdEjnaBMW7pWud7AF1nfLmSqabx6l9ZY73UDraYRY2oDiP/g6zwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Cil6swvt; arc=none smtp.client-ip=134.134.136.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Cil6swvt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706108386; x=1737644386; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=RzDbhYSEcmLvl0Tieidy5sjp9uAbbBuDzPRK5lNr8Tk=; b=Cil6swvtNfZ92Cyy1GGmLzszogBQnu1QF5g+xBVoZ+t6GfUXP/FrFt6/ vNdiqyE3EnEd2uZShAz2Qg8nZXvbmhe6tv1wWwAM9KBcVQ1N4EBibHKmx c8LmWpWMay06ynyunvaib7uTPldTVNxGfNbJjDr4JvvdrBVQjSqB3lJOu 7RpbYvg12YOsjPJX5NgGzSiU9tDoUd9skZD6TLcOf3IRFlidpxDjBOSfp OqUwLOL3vzEiCYjZtXw3860DbJydtEGXQa+JRZS0GeOS1HWoXqrxSsW0L bqTh8tOMvNwQjnfHjvJxooQMwDsEEv3uAIoHshTuT/9zKct1eDz8EQUoe Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="405616921" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="405616921" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 06:59:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="1932880" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.48.46]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 06:59:40 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Wed, 24 Jan 2024 16:59:36 +0200 (EET) To: Frank Li cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , imx@lists.linux.dev, Jiri Slaby , joe@perches.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org, LKML , linux-serial , miquel.raynal@bootlin.com, robh@kernel.org, zbigniew.lukwinski@linux.intel.com Subject: Re: [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h In-Reply-To: <20240123231043.3891847-5-Frank.Li@nxp.com> Message-ID: References: <20240123231043.3891847-1-Frank.Li@nxp.com> <20240123231043.3891847-5-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 23 Jan 2024, Frank Li wrote: > SVC i3c is a dual role controller. Move probe() into svc-i3c-main.c. This > prepares to support target probe depending on dts "mode" settings. > > Signed-off-by: Frank Li > --- > drivers/i3c/master/Makefile | 3 +- > drivers/i3c/master/svc-i3c-main.c | 52 +++++++++++++++++++++++++++++ > drivers/i3c/master/svc-i3c-master.c | 34 ++++--------------- > drivers/i3c/master/svc-i3c.h | 11 ++++++ > 4 files changed, 71 insertions(+), 29 deletions(-) > create mode 100644 drivers/i3c/master/svc-i3c-main.c > create mode 100644 drivers/i3c/master/svc-i3c.h > > diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile > index 3e97960160bc8..484cb81f45821 100644 > --- a/drivers/i3c/master/Makefile > +++ b/drivers/i3c/master/Makefile > @@ -2,5 +2,6 @@ > obj-$(CONFIG_CDNS_I3C_MASTER) += i3c-master-cdns.o > obj-$(CONFIG_DW_I3C_MASTER) += dw-i3c-master.o > obj-$(CONFIG_AST2600_I3C_MASTER) += ast2600-i3c-master.o > -obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c-master.o > +svc-i3c-objs += svc-i3c-main.o svc-i3c-master.o > +obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c.o > obj-$(CONFIG_MIPI_I3C_HCI) += mipi-i3c-hci/ > diff --git a/drivers/i3c/master/svc-i3c-main.c b/drivers/i3c/master/svc-i3c-main.c > new file mode 100644 > index 0000000000000..053b2bd9d8317 > --- /dev/null > +++ b/drivers/i3c/master/svc-i3c-main.c ... > +module_platform_driver(svc_i3c_master); > \ No newline at end of file > diff --git a/drivers/i3c/master/svc-i3c.h b/drivers/i3c/master/svc-i3c.h > new file mode 100644 > index 0000000000000..0bd1f0112a071 > --- /dev/null > +++ b/drivers/i3c/master/svc-i3c.h ... > +#endif > \ No newline at end of file Add the trailing newline characters. -- i.