From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32106.qiye.163.com (mail-m32106.qiye.163.com [220.197.32.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE4E2248A0 for ; Mon, 16 Mar 2026 03:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773631373; cv=none; b=d17ZlewS0ZHhDNh+Ge7Ny2xotGTF9aR7MPyGrQ8LOinlhmullUtx+r3MDLW7ZYVcsEKcILvp1w7KEXir+ySDzVHboUzwyUTaF0jpoujD3jVdZoK95Zn4AOi7XOtDZBk2AVQ78pSgHMgdZgIm1djTSjfSaXkRIM8xFMqAkU3XhlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773631373; c=relaxed/simple; bh=4z8V0kOOv9muegthwBM7k/aG/oynOm9gpX8DPKIeMIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C/0+mNwLYhAoMQyPU2lGAZ0p2eaoi+uLJS3y8ot2MTThVxHznSYIKJvUAdpS6NZAAuVHdiztj5uVGsBJ1aM3Nat5YWQDv0W5kXJXqJ5OjnNEzsfVw8O/OTsgAi2zkxD69Enu+D4p3n7bQmSHcsKMOTCfFwDoifRHSp6grxj0jFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=BnqeoqLs; arc=none smtp.client-ip=220.197.32.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="BnqeoqLs" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 370ae76b1; Mon, 16 Mar 2026 11:17:30 +0800 (GMT+08:00) Message-ID: Date: Mon, 16 Mar 2026 11:17:30 +0800 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 11/18] drm/bridge: analogix_dp: Apply drm_bridge_connector helper To: Luca Ceresoli , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, jani.nikula@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-12-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9cf4a612fb03a3kunm3b3e64f61969b4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkpLSFZMThlITR4aQx8eHh9WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=BnqeoqLsGb84BqtPqXiW77m3kBjYMloScvhA6p+8X+sHkdC6G2lBx0K6yTjyx2Pd+6UWnlkIoQZFCKdzbWmIIexPdLKAY2fA5Z0jwBTHiGasgpMISS4eqkCCCA+fPdJ/F+0mi5Gxidvpe/xNvUK/wY8tWC6CoTyvjZ0pFwGHc0A=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=euD4SQJWyl0XJtyrMHkwNbP+gc8j+sYgCcDACn9mPo4=; h=date:mime-version:subject:message-id:from; Hi Luca, On 3/14/2026 1:10 AM, Luca Ceresoli wrote: > Hello Damon, > > On Tue Mar 10, 2026 at 2:24 AM CET, Damon Ding wrote: >> Initialize bridge_connector for both Rockchip and Exynos encoder sides. >> Then, make DRM_BRIDGE_ATTACH_NO_CONNECTOR mandatory for Analogix bridge >> side, as the private &drm_connector is no longer created. >> >> The previous &drm_connector_funcs and &drm_connector_helper_funcs APIs >> are replaced by the corresponding &drm_bridge_funcs APIs: >> >> analogix_dp_atomic_check() -> analogix_dp_bridge_atomic_check() >> analogix_dp_detect() -> analogix_dp_bridge_detect() >> analogix_dp_get_modes() -> analogix_dp_bridge_get_modes() >> analogix_dp_bridge_edid_read() >> >> Additionally, the compatibilities of Analogix DP bridge based on whether >> the next bridge is a 'panel'. If it is, OP_MODES and OP_DETECT are >> supported; If not (the next bridge is a 'monitor' or a bridge chip), >> OP_EDID and OP_DETECT are supported. >> >> The devm_drm_bridge_add() is placed in analogix_dp_bind() instead of >> analogix_dp_probe(), because the type of next bridge (the panel, monitor >> or bridge chip) can only be determined after the probe process has fully >> completed. >> >> Signed-off-by: Damon Ding >> Tested-by: Marek Szyprowski >> Tested-by: Heiko Stuebner (on rk3588) > > ... > >> @@ -73,15 +72,12 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, >> struct drm_bridge *bridge) >> { >> struct exynos_dp_device *dp = to_dp(plat_data); >> - enum drm_bridge_attach_flags flags = 0; >> int ret; >> >> /* Pre-empt DP connector creation if there's a bridge */ >> if (plat_data->next_bridge) { >> - if (dp->has_of_bridge) >> - flags = DRM_BRIDGE_ATTACH_NO_CONNECTOR; >> - >> - ret = drm_bridge_attach(&dp->encoder, plat_data->next_bridge, bridge, flags); >> + ret = drm_bridge_attach(&dp->encoder, plat_data->next_bridge, bridge, >> + DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > Should this be 'flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR' to be future-proof? > Aha, the exynos_dp_bridge_attach() and even &analogix_dp_plat_data.attach() have been removed in [PATCH v10 16/18] for consistency and simplification. Since the only bridge flag supported right now is DRM_BRIDGE_ATTACH_NO_CONNECTOR, let’s leave this as is for now. ;-) Best regards, Damon