From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F07172FA65E; Tue, 17 Jun 2025 16:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750179192; cv=none; b=tUp9SBaTeumoqjHsl+pEM6bquyYlFgP2W5VMEz7oJiI/lXZTddVXe2KKyyzZO342u+ovA/BBFAlD/rqtUMMJJMFC8/tV3BMc2y7u7CC2lodaLrV/I8bvePftKNM+nHQwWa1wgbCtq+KJBsUJp7Jl7X2U114v/0Kb4L4zMYFpuHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750179192; c=relaxed/simple; bh=EDRaIpa6wJ70zFFE4EgCOpigV30lcRZVVqC50V/lpiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kLrg4jrYkSN16wR/TzRH44UH9qsrObQMBWLBFLctWK9Aco8nikKrCUVEKm3ucG04AyH2jxs2yrir1LLpuNg3GTrJKpme3DIcoCEwwptW+Pl7bviomKP0WbYJmuNWRES2sJsyyqmaSy3m3PoOmsaroEE5+pHlQ2wNDuMZN0M35kw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=2azXULNl; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2azXULNl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=qLwy9nWk7FQ2u1fpqK0kJMRSGlwXC3AvpuB1jdFpBfY=; b=2a zXULNlLbVY2lA4WHwdHGKkxblSf0mo45WNp+Gn5lID9vZ7Yf/KTBHQBvKl94A+4xcEO4X0/IkCOv1 0fic+BJ5OSeJ4W/fPjKVypf1HB1qvGsVbPWobIcMDIfuSi488jokKwMlWBP90yNvNeBEfMaQ8fn/m DyKUfIC/3rsRfVQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uRZYQ-00GC94-PV; Tue, 17 Jun 2025 18:52:58 +0200 Date: Tue, 17 Jun 2025 18:52:58 +0200 From: Andrew Lunn To: Fabio Estevam Cc: Frank Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stefan Wahren , "open list:NETWORKING DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , imx@lists.linux.dev Subject: Re: [PATCH v4 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format Message-ID: References: <20250616184820.1997098-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jun 17, 2025 at 01:09:21PM -0300, Fabio Estevam wrote: > On Mon, Jun 16, 2025 at 3:48 PM Frank Li wrote: > > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethernet@0 { > > + compatible = "qca,qca7000"; > > + reg = <0x0>; > > + interrupt-parent = <&gpio3>; /* GPIO Bank 3 */ > > + interrupts = <25 0x1>; /* Index: 25, rising edge */ > > + spi-cpha; /* SPI mode: CPHA=1 */ > > + spi-cpol; /* SPI mode: CPOL=1 */ > > + spi-max-frequency = <8000000>; /* freq: 8 MHz */ > > All of these comments are obvious and don't bring any new information. > > I recommend dropping all of them. I would also suggest replacing 0x1 with IRQ_TYPE_EDGE_RISING. Andrew