From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9967228937F for ; Wed, 7 May 2025 18:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746643136; cv=none; b=TZLKYkneIv5jlqUHG8z1GLGTwSDCNfknc14EIDazx6/2iF8wzMPgamzHJHimBdM1kqvstKYY4xVibn9hCSkUN4PJX3vwT1StoDu0ilJqeEaEBhwwoNti9BrLS4jRgyDbmaXm16ddI9kGGP5+ieNTCWY8kwJOpUP7eIXAxLdvaac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746643136; c=relaxed/simple; bh=tkSEsfPI1N5a1M82NOQFB/88ynVXiiAbgocvBvWNtW4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=E1vdi0fHZucQMR/mvQU/vFhBSj833eDW2g+LgI4KNJrjxRGSA9lRTivHAb73cde+4Fsd5fIt739xhf1FUtYS4V0Xr6IPN7TxvhXdJW1LlxViKL7E9zsze6qW+fv7LW6sKhm4rmwZnzItoPYcwjz2VNAAWJhhZQCvdpfxdvV5tiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DnuxTr2W; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DnuxTr2W" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39129fc51f8so175452f8f.0 for ; Wed, 07 May 2025 11:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746643133; x=1747247933; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5aMHfwYt5MJVS4i/JhdjiG6CFlv9lWRV1TQJw4wPFmE=; b=DnuxTr2WZq2tfYp+/hs1LMRj7/wzC1NXYtSd8l27Hee41Y7K7bWL1p2m/CDjb/nfq4 VojtDJMGYZuUVz9oYeOpkLP1dHExGfnrr7NATeM7WNznuF83LByLYRhgRgARV6YREELg 6HLUYbT+Q+ikquAJKu0FsMmw+P/1U7/OFFL7pZkYD+NDnNCdofRh+q9BSSfvyY9yIgta u8ArvBtxiyZQmzicOMQq8wiXm0U7pK6CT+F4FLdb0SlByoU8opVhAkmbOpkkV6RNT0Pq n4q8YDyfiWKmfxOPnGQvE16kGP/VwvtkZEs+rEczNZG21zzb47/Sj2jEiutwHqBmgHmn SOWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746643133; x=1747247933; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5aMHfwYt5MJVS4i/JhdjiG6CFlv9lWRV1TQJw4wPFmE=; b=XPn3l6XxE0tNo8Pnbas3AuOGcyCEex13XyYYvry+zgfPPr8S2S5/2sxeyzjz//QiQK lL+pr9/V8WpI5yFjgi36x0xN7IeVZjmoz9x03xKEiaghLkhJ/H6IxVLtvjJeqO2pzUqA ZxKbT4i/6ehgQMck7mUqd35xrneBz25uUfok3IE+HiMRy8+5UETOTNJLpEZGHskCtShT qa7epAakQv3dZUI1tugTW3K4SICP9cODZM72N6NqGADioXERYvT8PiQeTDwTi5HmFSXX 9ySLpT2R12O18FPEbJO/rCCrh4HKmVZ9GL49ElzeluJkw7MI6CG2yYJItGignMo1xbxC kvkg== X-Forwarded-Encrypted: i=1; AJvYcCWwu8D3v4SHAVI7wHqH/Sf8CJXenRB+yZo7yWIO6rX9Q9LPz7hAwXAa6W6lOB03uV5W8WI=@lists.linux.dev X-Gm-Message-State: AOJu0YxEg47JgbAepOGItW5Kh/U3N7dwWg/5IYgRJl0TC/I6p/3yKIYH nKP7yuq1M/jCHeyGUBiU03VgkPtSvS9U+wwMrH8CfOr2oQ5lQadi X-Gm-Gg: ASbGncvDkpEXeksbAr+JMDHqZvE05SpnVJ4wKEsEFKZgs2fw0xpdmc3GoaEPQiAs5iy JNOWQoyGd6Tw13hnB5iJV2X3/LrCjGcsCI/KKTc/wzo4cPP/Qne4C56wkC5ksmXVDxbBBZXrdeU W63xoMbtuUvvroz++lXpmg6V2udM6RjrUOmHuVrEBCnguUgICzk3Lr+ZzMpm/hmz45I1bIlerxS DGjRw5T9nO1KP41SmaddnFXFrjw1SPZ1OBJOhjA6v113Ezal4JuXEqPUldzRqyViENS0MI9ZiVz kGrdkKM00hqkkz8qjA+kQlW726TeDGMyF2nLHdQwv1xeV+0E/gL+acWKVoQozEPSFEGzhaDsItH i5NTgtxs4rgZ5ik5Xt1aVhCzLNqwwDyAMZh0+H/3ruDcxOhBzFORmtHwa73AfrusOBMwOnWVt1R XNPRdT X-Google-Smtp-Source: AGHT+IEOPyVedouDyHb6BspLi/4R5sJVFUe2EsSNyB8ADlJIdgA+fk0YAINICu1kEOfHQhbXKF5dbQ== X-Received: by 2002:a05:6000:258a:b0:39e:cbef:c071 with SMTP id ffacd0b85a97d-3a0ba0aa0c8mr177548f8f.22.1746643132629; Wed, 07 May 2025 11:38:52 -0700 (PDT) Received: from ?IPV6:2003:ea:8f2d:8d00:5d7a:c11c:67f1:717e? (p200300ea8f2d8d005d7ac11c67f1717e.dip0.t-ipconnect.de. [2003:ea:8f2d:8d00:5d7a:c11c:67f1:717e]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a0b5a34a1csm3023274f8f.32.2025.05.07.11.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 11:38:52 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 20:39:02 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: phy: remove Kconfig symbol MDIO_DEVRES From: Heiner Kallweit To: "Russell King (Oracle)" , Andrew Lunn Cc: Paolo Abeni , Jakub Kicinski , David Miller , Eric Dumazet , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , "netdev@vger.kernel.org" , imx@lists.linux.dev References: <9c2df2f8-6248-4a06-81ef-f873e5a31921@gmail.com> <5ecf2ece-683b-4c7b-a648-aca82d5843ed@lunn.ch> Content-Language: en-US Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07.05.2025 16:21, Heiner Kallweit wrote: > On 07.05.2025 14:56, Russell King (Oracle) wrote: >> On Wed, May 07, 2025 at 02:49:05PM +0200, Andrew Lunn wrote: >>> On Wed, May 07, 2025 at 11:46:08AM +0100, Russell King (Oracle) wrote: >>>> On Wed, May 07, 2025 at 08:17:17AM +0200, Heiner Kallweit wrote: >>>>> MDIO_DEVRES is only set where PHYLIB/PHYLINK are set which >>>>> select MDIO_DEVRES. So we can remove this symbol. >>>> >>>> Does it make sense for mdio_devres to be a separate module from libphy? >>> >>> I _think_ Broadcom have one MDIO bus master which is not used for >>> PHYs/Switches but regulators or GPIOs or something. In theory, you >>> could build a kernel without networking, but still use those >>> regulators or GPIOs. But given that Broadcom SoCs are all about >>> networking, it does seem like a very unlikely situation. >> >> I'm pointing out that: >> >> libphy-y := phy.o phy-c45.o phy-core.o phy_device.o \ >> linkmode.o phy_link_topology.o \ >> phy_package.o phy_caps.o mdio_bus_provider.o >> >> mdio_bus_provider.o provides at least some of the functions used by >> mdio_devres. >> >> obj-$(CONFIG_PHYLIB) += mdio_devres.o >> obj-$(CONFIG_PHYLIB) += libphy.o >> >> So, when PHYLIB=m, we end up with mdio_devres and libphy as two separate >> loadable modules. I'm questioning whether this makes any sense, or >> whether making mdio_devres part of libphy would be more sensible. >> > I was asking myself the same question. If mdio_devres is a separate module, > then it won't be loaded if no active phylib user requires the devres > functionality, saving a little bit of memory. However mdio_devres is quite > small and we don't gain much. > > For now I decided to keep the current behavior of mdio_devres being a > separate module. However if consensus is that we better make it part of > phylib, fine with me. > After thinking again, I'll submit a v2 and will make mdio_devres part of phylib. > >> Maybe the only case is if mdio_devres adds dependencies we don't want >> libphy to have, but I think that needs to be spelt out in the commit. >> >> > -- pw-bot: cr