From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9B919DF88 for ; Thu, 4 Jul 2024 09:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720083786; cv=none; b=e7IpVc6M3hJZVJSBbX9N50jrYSG7Fn893erJ+9LutRRUBGbuwUP1ZwNdAQT1JS+7rb3RWSR7KAjFemH6Zm/sdORL60SfI9Ix+Stg8FmrWDzxdqrp3fuFx9L7g5jQryGb3g7S/OfmGY9ictjkrejgw9vaemWADz+rHdzwQGs/tio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720083786; c=relaxed/simple; bh=lJeXmk1CcWCnW6+sA0Si+XgkMXTZlK92WQIJ55qf44I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ORsMF3fYRW3jSXn0fptQ4Lmb3Y6IAr8LdNwlHrS//DAOBhuaKWwVN53VJXCD68s9DaBQioCdtgkOkAW3b9eyYuXIMcYijJ8syxczDLUAdv5JFFMO4s9OpF3c+YrE/rlv/IaKt53jym6LevdTe2MVWt22I5+E/TwiNLRVl86CoEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEi6m+5i; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEi6m+5i" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-36799fb93baso315524f8f.0 for ; Thu, 04 Jul 2024 02:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720083783; x=1720688583; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cx3d5CxqTkB14K4gwBHdHmuzRMB2FNvR/ektMnAQxOM=; b=FEi6m+5idm/74PbSwpSegC1V4K/mDqLDEEifr+mz+VqUD1aFUaiiJmaf3ZSRH+j/vg r5e4jbdncqg/Hs0OmMn7KwKmP4WyWECuy59sGzaGvzHkkb+OOIM/AhEDvEfk8AVll9Ez h+kNAIdTalqw+uG1u21XTyoygdAC76LvWyRpS6wRO1ohUrhPdu3kWwzI3KVQYoCgzZRm MLKCLV5Tb+DZyTcujFHdkY418tyb/yzQRHGK+KrFdUwHIWIBNh4kD8NaPWgd9P+rDS36 Bg0i+1YR788xrLPYMvOgMFeCcL+yGmINeg7FKJ92kY7FzVT2H4wGfwQBDhE3cxf3NYq+ r63A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720083783; x=1720688583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cx3d5CxqTkB14K4gwBHdHmuzRMB2FNvR/ektMnAQxOM=; b=GDqOJIofD9EI7Yq09I8AqOQVtnFtcO7S0lGkL21+69YaA41vF3KAGwQJ081CALdAVR lLCZo+Vzll5jDjSFlHsiPFyiDq7GHSb9kDtxuroxWtFCefBpcCAiNOhyubchu9V65jYh f3+S5Yz7eLFiBLAfex1UuXdZ9X4sMGb7CbJ+LHlxaSVPavSoloSLqYpTjQgYErag7uiT us5aS0UXlxs5+0Lky9XCpBrm9hAbKUb1BENv3AtksrXxSiQ2toJhSBJ9LARYhnf34EQF 86j+44QoBZqURH6F478zPX+QwQ6aDof6Zv8fMH61wLCsHFT7jrpJgT6OtU/72uI+HsVv ZIAw== X-Forwarded-Encrypted: i=1; AJvYcCUem5a793IFTdrdYSizZdNGU/7e/qieS7Mc/CBPGz4oRVVlGICZCV49VH4gi9d01hlAPY1IKlmXPSXW+Gpb3/lccL4B X-Gm-Message-State: AOJu0YwveDPViOSV/3+EA0Y4UeWkff4+utnY0iPpCeZs7cALQOvY4XEA DNKtpGsETSUfAlNxFseXqbrdwZEJfKMBb8qyQPT+OztEpsnGM2qw X-Google-Smtp-Source: AGHT+IE5rRRgQ+3VAktBOrwvlEMxaYncLW64BefnBB2CyyVIkKT2zQeyktZpK58oIjvjEAzP4/eFaw== X-Received: by 2002:a5d:608e:0:b0:367:9877:750e with SMTP id ffacd0b85a97d-3679dd3df99mr753973f8f.25.1720083782983; Thu, 04 Jul 2024 02:03:02 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:2c0f:6313:4446:a47? (2a02-8389-41cf-e200-2c0f-6313-4446-0a47.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:2c0f:6313:4446:a47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3679c9008b0sm1194575f8f.80.2024.07.04.02.03.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 02:03:02 -0700 (PDT) Message-ID: Date: Thu, 4 Jul 2024 11:03:00 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] mfd: rohm-bd9576: Constify struct regmap_config To: Matti Vaittinen , Support Opensource , Lee Jones , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Xu Yilun , Tom Rix Cc: linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240703-mfd-const-regmap_config-v1-0-aa6cd00a03bd@gmail.com> <20240703-mfd-const-regmap_config-v1-6-aa6cd00a03bd@gmail.com> <0acd9da5-80ec-4a45-b00a-8e28ab4e345a@gmail.com> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <0acd9da5-80ec-4a45-b00a-8e28ab4e345a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04/07/2024 06:50, Matti Vaittinen wrote: > On 7/3/24 18:37, Javier Carrasco wrote: >> `bd957x_regmap` is not modified and can be declared as const >> to move its data to a read-only section. >> >> Signed-off-by: Javier Carrasco >> --- >>   drivers/mfd/rohm-bd9576.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c >> index 3a9f61961721..634c65c7d108 100644 >> --- a/drivers/mfd/rohm-bd9576.c >> +++ b/drivers/mfd/rohm-bd9576.c >> @@ -57,7 +57,7 @@ static const struct regmap_access_table >> volatile_regs = { >>       .n_yes_ranges = ARRAY_SIZE(volatile_ranges), >>   }; >>   -static struct regmap_config bd957x_regmap = { >> +static const struct regmap_config bd957x_regmap = { >>       .reg_bits = 8, >>       .val_bits = 8, >>       .volatile_table = &volatile_regs, >> > > Thanks a ton Javier. This looks good to me but if you feel like going an > extra mile while you are at it... Do you think this could be extended to: > > > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c > index 3a9f61961721..17323ae39803 100644 > --- a/drivers/mfd/rohm-bd9576.c > +++ b/drivers/mfd/rohm-bd9576.c > @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { >         .n_yes_ranges = ARRAY_SIZE(volatile_ranges), >  }; > > -static struct regmap_config bd957x_regmap = { > +static const struct regmap_config bd957x_regmap = { >         .reg_bits = 8, >         .val_bits = 8, >         .volatile_table = &volatile_regs, > @@ -65,7 +65,7 @@ static struct regmap_config bd957x_regmap = { >         .cache_type = REGCACHE_MAPLE, >  }; > > -static struct regmap_irq bd9576_irqs[] = { > +static const struct regmap_irq bd9576_irqs[] = { >         REGMAP_IRQ_REG(BD9576_INT_THERM, 0, BD957X_MASK_INT_MAIN_THERM), >         REGMAP_IRQ_REG(BD9576_INT_OVP, 0, BD957X_MASK_INT_MAIN_OVP), >         REGMAP_IRQ_REG(BD9576_INT_SCP, 0, BD957X_MASK_INT_MAIN_SCP), > @@ -76,7 +76,7 @@ static struct regmap_irq bd9576_irqs[] = { >         REGMAP_IRQ_REG(BD9576_INT_SYS, 0, BD957X_MASK_INT_MAIN_SYS), >  }; > > -static struct regmap_irq_chip bd9576_irq_chip = { > +static const struct regmap_irq_chip bd9576_irq_chip = { >         .name = "bd9576_irq", >         .irqs = &bd9576_irqs[0], >         .num_irqs = ARRAY_SIZE(bd9576_irqs), > > > Yours, >     -- Matti > Sure, I will generalize it and update the series to cover regmap_irq and regmap_irq_chip as well, of course including these two cases too. Best regards, Javier Carrasco