From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev, kernel@pengutronix.de, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
mathieu.poirier@linaro.org, peng.fan@nxp.com, robh@kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain
Date: Mon, 10 Jun 2024 09:37:56 +0200 [thread overview]
Message-ID: <d78b7a50-8f79-4733-bf2b-ee7d70501c47@kernel.org> (raw)
In-Reply-To: <ZmMk/T3I1jNcxKOB@lizhi-Precision-Tower-5810>
On 07/06/2024 17:19, Frank Li wrote:
> On Fri, Jun 07, 2024 at 09:32:26AM +0200, Krzysztof Kozlowski wrote:
>> On 06/06/2024 17:00, Frank Li wrote:
>>> "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep
>>> the same restriction for other compatible string.
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>>
>>> Notes:
>>> Change from v1 to v2
>>> - set minitem to 2 at top
>>> - Add imx8qm compatible string also
>>> - use not logic to handle difference compatible string restriction
>>> - update commit message.
>>>
>>> pass dt_binding_check.
>>>
>>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-rproc.yaml
>>> SCHEMA Documentation/devicetree/bindings/processed-schema.json
>>> CHKDT Documentation/devicetree/bindings
>>> LINT Documentation/devicetree/bindings
>>> DTEX Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dts
>>> DTC_CHK Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dtb
>>>
>>> .../bindings/remoteproc/fsl,imx-rproc.yaml | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> index df36e29d974ca..da108a39df435 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> @@ -59,6 +59,7 @@ properties:
>>> maxItems: 32
>>>
>>> power-domains:
>>> + minItems: 2
>>> maxItems: 8
>>>
>>> fsl,auto-boot:
>>> @@ -99,6 +100,19 @@ allOf:
>>> properties:
>>> fsl,iomuxc-gpr: false
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + not:
>>> + contains:
>>> + enum:
>>> + - fsl,imx8qxp-cm4
>>> + - fsl,imx8qm-cm4
>>> + then:
>>> + properties:
>>> + power-domains:
>>> + minItems: 8
>>
>> What happened with the "else:"? How many power domains is needed for
>> other devices?
>
> So far, only fsl,imx8qxp-cm4 ind fsl,imx8qm-cm4 need power domain (2-8).
> Power-domains is option property.
>
> Can I just remove whole "if"?
No, I rather expect else.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-10 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 15:00 [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain Frank Li
2024-06-07 7:32 ` Krzysztof Kozlowski
2024-06-07 15:19 ` Frank Li
2024-06-10 7:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d78b7a50-8f79-4733-bf2b-ee7d70501c47@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.li@nxp.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox