imx.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>, Liu Ying <victor.liu@nxp.com>
Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com,
	simona@ffwll.ch, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	shawnguo@kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback
Date: Fri, 7 Nov 2025 22:05:30 +0100	[thread overview]
Message-ID: <da41c891-db89-436f-a262-61dfd33d57f9@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5B+VcGxx9Xa6FFXxeka0qcqBmATrartguqMLMDK4fGduA@mail.gmail.com>

Hi,

On 04.11.25 21:44, Fabio Estevam wrote:
> On Mon, Oct 20, 2025 at 11:53 PM Liu Ying <victor.liu@nxp.com> wrote:
>> On 10/20/2025, Fabio Estevam wrote:
>>> On Tue, Oct 14, 2025 at 1:12 AM Liu Ying <victor.liu@nxp.com> wrote:
>>>
>>>> Strictly speaking, I don't think i.MX6SX LCDIF is compatible with i.MX28 LCDIF
>>>> because at least i.MX28 LCDIF has the version and debug{0,1,2} registers(at
>>>> 0x1c0, 0x1d0, 0x1e0 and 0x1f0) while i.MX6SX LCDIF hasn't.

Thanks for pointing this out. In my opinion, these registers are auxiliary
and don't really change the compatibility situation as a functional driver
can be written without their use, evidenced by the Linux driver doing just
fine without using these registers.

>>> There are some DT users, such as Barebox that matches against
>>> fsl,imx28-lcdif, so we cannot remove it.
>>
>> Hmmm, it looks like software projects like Barebox don't really follow this DT
>> binding.  Is it possible to fix Barebox to avoid changing this DT binding by
>> this patch?  I'm assuming that Uboot has already been fixed.
> > What do you think?

I am sorry my prior feedback ended up stalling this series.

There is a lot of regressions happening due to upstream DT changes and I am
just trying to raise awareness. Another example I stumbled over today:
https://lore.kernel.org/all/91f764ab-bec1-4791-b01b-3ba0803ce8f8@pengutronix.de/


I have submitted a patch[1] to barebox adding explicit i.MX6 SoloX support,
so, having expressed my opinion above, please proceed as you see fit.

[1]: https://lore.barebox.org/barebox/20251107210033.2229781-3-a.fatoum@barebox.org/

Cheers,
Ahmad

> 
> Thanks
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2025-11-07 21:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 20:51 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
2025-10-13 20:51 ` [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam
2025-10-14  3:55   ` Liu Ying
2025-10-13 20:51 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
2025-10-14  4:12 ` [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Liu Ying
2025-10-20 17:24   ` Fabio Estevam
2025-10-21  2:52     ` Liu Ying
2025-11-04 20:44       ` Fabio Estevam
2025-11-07 21:05         ` Ahmad Fatoum [this message]
2025-11-10  9:14           ` Liu Ying
  -- strict thread matches above, loose matches on Subject: below --
2025-09-10  2:05 Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da41c891-db89-436f-a262-61dfd33d57f9@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stefan@agner.ch \
    --cc=tzimmermann@suse.de \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).