From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.denx.de (mx.denx.de [89.58.32.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF64733C9 for ; Mon, 30 Dec 2024 22:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.32.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735597241; cv=none; b=WvbQYqx5Rst61LTRJxjlXpcuFOVnt9cOM6WGgRBnK7oHLgenXhh4lk7Ncg9RKQdoo6tmlQcGCphxFnwOOpPsDUuuucZeSRZoUbjw5mA3GJ+Paag8lNHLw5ZTXVNb4LQHVYeen3jEONcjp5iaLB657foYXmNr1c4GPVMymU40GFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735597241; c=relaxed/simple; bh=HRSMKmqV/embUbHIAAhUYZ21E1kxHbwfhOo33ZbDnHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s2TCGXMZgcogMXqxQc0b71BRBORRSgQCiWHr4sXRlQdKwivUhf1FVnl5auBsbWUGfVcpa0KxYCBiHyYuAuhVa6JVrJC20Z61T7MTbEa6+oDxyXbBBjFw+cT0ijzHkFVzUHFLuStIUYrlYtN6EQsQgz7VSjNv7HGV59Y7W0gPMlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=dyQOCkC4; arc=none smtp.client-ip=89.58.32.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="dyQOCkC4" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DB5AC1048559D; Mon, 30 Dec 2024 23:20:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=mx-20241105; t=1735597236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SkIGZmwhg2neLO1jlUwO1QbcyyIDvbzGZHUYB0DXWPU=; b=dyQOCkC4zi2h/jh5Ubd0KW/ctVjjgO4bGU9YuZTP8ctxhxTBD6csQLevHwAQYl7FC3dBCb 6wBhxmoe1dwJ3PUCNY3gXTJ7+GJRdAp1HMAlnoY8CyHJ24yajJmEXg9F+sFxeaHvqNbA6P fSLpfCkD66+q+/x9SWstwflEeQCLgYyLUsp/50WoX7mDC7Qf/713MONCsthuFyr21rjxL7 Ur43H5ZfZxKZSAWrJLbICm7DSP2ziuoUZ1cJWWz1wPol8wyjnxwX50DItUlT1m+8LPniod feGIPFmfY2J1C+tqmozb2M0aW32P2kU7wKbzKn4Raelww25K+UXM5orsgLLaeg== Message-ID: Date: Mon, 30 Dec 2024 22:41:59 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR To: Liu Ying , dri-devel@lists.freedesktop.org Cc: Andrzej Hajda , David Airlie , Fabio Estevam , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Pengutronix Kernel Team , Robert Foss , Sascha Hauer , Shawn Guo , Simona Vetter , Stefan Agner , Thomas Zimmermann , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20241224014701.253490-1-marex@denx.de> <0140bb0c-35f0-4a5e-b100-32e09bc8c617@nxp.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <0140bb0c-35f0-4a5e-b100-32e09bc8c617@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 12/30/24 7:57 AM, Liu Ying wrote: [...] >> diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig >> index 9a480c6abb856..d8e9fbf75edbb 100644 >> --- a/drivers/gpu/drm/bridge/imx/Kconfig >> +++ b/drivers/gpu/drm/bridge/imx/Kconfig >> @@ -27,6 +27,7 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE >> config DRM_IMX8MP_HDMI_PVI >> tristate "Freescale i.MX8MP HDMI PVI bridge support" >> depends on OF >> + select DRM_DISPLAY_CONNECTOR > > Select it for DRM_IMX8MP_DW_HDMI_BRIDGE instead? > Furthermore, if yes, should it be even selected for DRM_DW_HDMI instead? > > I'm not sure if this is needed to be selected though, since only DRM_MESON is > selecting it while CONFIG_DRM_DISPLAY_CONNECTOR is enabled in multiple > defconfig files(like arch/arm/configs/multi_v7_defconfig). It is necessary to update existing .config . [...]