From: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/5] arm64: dts: qcom: talos-evk-camera: Add DT overlay
Date: Fri, 23 Jan 2026 10:30:02 +0800 [thread overview]
Message-ID: <e0e6f248-3d82-4b0c-9ee2-4a655b7bbbfd@oss.qualcomm.com> (raw)
In-Reply-To: <825c3e7c-469a-4d69-b298-18f2edf72ea4@oss.qualcomm.com>
Hi Konrad,
On 1/22/2026 9:44 PM, Konrad Dybcio wrote:
> On 1/22/26 11:48 AM, Wenmeng Liu wrote:
>> Enable IMX577 via CCI on Taloss EVK Core Kit.
>>
>> The Talos EVK board does not include a camera sensor
>> by default, this DTSO has enabled the Arducam 12.3MP
>> IMX577 Mini Camera Module on the CSI-1 interface.
>>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>> ---
>
> [...]
>
>> +&cci_i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + camera@1a {
>> + compatible = "sony,imx577";
>> + reg = <0x1a>;
>> +
>> + reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>;
>
> Let's define the pin settings for the reset pin too, otherwise lgtm
The reset pin on the Talos EVK board is different from the default. Do
you recommend that I define the reset pin's pinctrl in the Talos EVK
board's DTS?
Thanks,
Wenmeng
next prev parent reply other threads:[~2026-01-23 2:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 10:48 [PATCH v5 0/5] Add CCI and imx577 sensor support for Talos evk Wenmeng Liu
2026-01-22 10:48 ` [PATCH v5 1/5] arm64: dts: qcom: talos: Add camss node Wenmeng Liu
2026-01-22 10:48 ` [PATCH v5 2/5] dt-bindings: i2c: qcom-cci: Document sm6150 compatible Wenmeng Liu
2026-01-22 14:00 ` Krzysztof Kozlowski
2026-02-04 16:01 ` Andi Shyti
2026-02-06 16:31 ` Krzysztof Kozlowski
2026-01-22 10:48 ` [PATCH v5 3/5] arm64: dts: qcom: talos: Add CCI definitions Wenmeng Liu
2026-01-22 10:48 ` [PATCH v5 4/5] arm64: dts: qcom: talos: Add camera MCLK pinctrl Wenmeng Liu
2026-01-22 10:48 ` [PATCH v5 5/5] arm64: dts: qcom: talos-evk-camera: Add DT overlay Wenmeng Liu
2026-01-22 13:44 ` Konrad Dybcio
2026-01-23 2:30 ` Wenmeng Liu [this message]
2026-01-26 10:32 ` Konrad Dybcio
2026-02-06 16:25 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e6f248-3d82-4b0c-9ee2-4a655b7bbbfd@oss.qualcomm.com \
--to=wenmeng.liu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox