From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F651BE25F for ; Wed, 14 Aug 2024 19:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723665583; cv=none; b=JuOI5jNqywFOM7f09XCqw6d1v1s8P5mDhzoKxWq0t+4hV0NDaUXU3FiK21tCzImlR7kPiDKKqgzSXkZo9DA5gVVGS54fDNnmMxHY0XDMZGWtO8uWAn/3X8FHtHrLKG6GiCJv/c2q/zHjsvvehbKhp9XhCM+yrpiWzdZOa8KuP/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723665583; c=relaxed/simple; bh=GNV4tsHwSCmnO+Fg4jkmp7tkUCJGx/VdzsUl9ZVOIiw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qX6Ftj30EtA3akuKOb/t1+nfU1fEj1m2g48qyqE++G/rOslsz/mqKTh+3RgTQLP4+NwfCzaMorAyWGcgFpFP2GJkaDL8WBPBhh6LxLchUMqVO4+Q+3phv+cYs11xLl+1XRKlC0PQgQcFdheoqZLwMgPmhByBLOyAAjs3gKAySB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=Eniqi4OJ; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="Eniqi4OJ" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E8AE188A11; Wed, 14 Aug 2024 21:59:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1723665578; bh=5Ru4zIkS1NojlSPj+uZnab0ukXQuEwASFRNgcpKvFKQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Eniqi4OJy7BC4kh1kT+xXEHb+/sFTPF4u/b1qx+xXBn8+whHsxdrfdE90VNRF/PFo HFI1gmWkJs69EufMecg7SmjdFoIM2p1Nwh8QjspIpSIqMQN2AhLhjUwL/ZrFDj2JSl yeH+B+zMXNAU/QFrWhCf9XbeEikzmnjk+0kl6+aOKKgNGC9Qig64+aFkYzs7K/z2JQ +SycMf0PaJZ8eZ6QEM0kc9hGztixvA1hCGHlQoJ5pdnh8sbpXWQj80vHIes0ZeehlZ SJoQyMWwUSEdVbqBKEj8nQqCw4yxf7ePHpx8FpB8CNVR9yYcjTiSC9yyctrsauJj30 8xV+UtCzHdfyQ== Message-ID: Date: Wed, 14 Aug 2024 21:58:36 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml To: Frank Li , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Alexander Stein , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Cc: imx@lists.linux.dev References: <20240814185140.4033029-1-Frank.Li@nxp.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20240814185140.4033029-1-Frank.Li@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 8/14/24 8:51 PM, Frank Li wrote: Hi, > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml > new file mode 100644 > index 0000000000000..b8239491c747a > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml > @@ -0,0 +1,170 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/ti,ads7843.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI's SPI driven touch screen controllers. > + > +maintainers: > + - Dmitry Torokhov > + - Marek Vasut > + - Alexander Stein > Keep the list sorted alphabetically . +description: > + Device tree bindings for TI's ADS7843, ADS7845, ADS7846, ADS7873, TSC2046 > + SPI driven touch screen controllers. > + > + The node for this driver must be a child node of a SPI controller, hence > + all mandatory properties described in ... described in ... what/where ? I think part of the sentence is missing here. > +properties: > + compatible: > + enum: > + - ti,tsc2046 > + - ti,ads7843 > + - ti,ads7845 > + - ti,ads7846 > + - ti,ads7873 Keep the list sorted alphabetically. > + interrupts: > + maxItems: 1 > + > + vcc-supply: > + description: A regulator node for the supply voltage. > + > + ti,vref-delay-usecs: > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: vref supply delay in usecs, 0 for external vref (u16). Maybe the (u16) is duplicate of the $ref'd type ? Drop for all the rest below too ? > + ti,vref-mv: > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + The VREF voltage, in millivolts (u16). > + Set to 0 to use internal references (ADS7846). > + > + ti,keep-vref-on: > + $ref: /schemas/types.yaml#/definitions/flag > + description: set to keep vref on for differential measurements as well. Vref , because V (voltage) is written with capitals ... > + ti,settle-delay-usec: > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Settling time of the analog signals; a function of Vcc and the ... like Vcc here. > + capacitance on the X/Y drivers. If set to non-zero, two samples are > + taken with settle_delay us apart, and the second one is used. ~150 > + uSec with 0.01uF caps (u16). [...] > + ti,pendown-gpio-debounce: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Platform specific debounce time for the pendown-gpio (u32). > + > + pendown-gpio: > + description: > + GPIO handle describing the pin the !PENIRQ line is connected to. I think the properties have to be sorted alphabetically too. [...] > +required: > + - compatible > + - reg > + - vcc-supply Is vcc-supply really required ? > +allOf: > + - $ref: touchscreen.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi{ > + #address-cells = <1>; > + #size-cells = <0>; > + > + touchscreen@0 { > + compatible = "ti,tsc2046"; > + reg = <0>; /* CS0 */ > + interrupt-parent = <&gpio1>; > + interrupts = <8 0>; /* BOOT6 / GPIO 8 */ > + spi-max-frequency = <1000000>; > + pendown-gpio = <&gpio1 8 0>; > + vcc-supply = <®_vcc3>; Sort please . > + ti,x-min = /bits/ 16 <0>; > + ti,x-max = /bits/ 16 <8000>; > + ti,y-min = /bits/ 16 <0>; > + ti,y-max = /bits/ 16 <4800>; > + ti,x-plate-ohms = /bits/ 16 <40>; > + ti,pressure-max = /bits/ 16 <255>; > + > + wakeup-source; > + }; > + }; > + Thanks !