From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C03D47DFB9 for ; Thu, 20 Aug 2026 17:49:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248187; cv=none; b=hkhugyC9TUAmKraRybaHlsLSDSjMO9N+bVGHOwcG7gS9RaT8AHIzJPEJpnU1TnuklMRI4KfiI9hjzFAsixSBlBSVLYczJaqxCnhKTnmI2zfcInXbJJ1w4OiigQFlm5W2+mQbV1jVlyaPJQMtYAALlDv29YLdAw3mrOaddwcedZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248187; c=relaxed/simple; bh=sJiCG9GMt+8ts/wSdpjtZKthk4D4iZFfORrDzQ4jEXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vpimu1JEZqNb4SEpwrUkugURnn6ivS+EY8oP3ccFK8jQ+xeNrTcMhBvf9IsDmImrVadmCGjH/ZMGd8gJ/G1EJ9F1gN7UX+Aq/DH/d74B3tYRA8Mki7wJo7gNkAT7rYgIakw49Fkcpj0ESXzJ7h96GyzQJvivB7eLF4XdKWAqxjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gK+dBYE9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gK+dBYE9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787248184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+qiRA0Rr68w6luARuut3h/5z5IL9+5qPOnuZ1Bth1E=; b=gK+dBYE9eowgsgV3i9MLyrHWL3nXD7cm86gK65/I3DF1ni096WEozvuJSaKSYpIX1yHEFF iTd2c6nHaFZDLxaOoop0Y2y/pMpvHntNJ/p3l2Cfw3rGIPw0P4ZHC8RVFoXOe/agWrcetG pRsz2H6PVFYurN6SAK0IUPVM1Ml7qUI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-9eTFI6CxOfuM1WWbpdt31Q-1; Thu, 20 Aug 2026 13:49:41 -0400 X-MC-Unique: 9eTFI6CxOfuM1WWbpdt31Q-1 X-Mimecast-MFC-AGG-ID: 9eTFI6CxOfuM1WWbpdt31Q_1787248181 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f81362fb1so99839f8f.1 for ; Thu, 20 Aug 2026 10:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787248181; x=1787852981; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6+qiRA0Rr68w6luARuut3h/5z5IL9+5qPOnuZ1Bth1E=; b=HODRFWOhZcge8To9H6FVhqTOMeKLPP+qygPnBnIFuVkwC9ephWDaU4AzmaoBI9wlJg t0FCMZR1EVDBNVA4Do/892Gmu/McsRvcBB/UAa7W0hub6NsOEwBEd4kfBAgXdqyxfi89 XhLQgMPNTc2ESbxazXmjZSioXp69b8sJLN9vIAIWX+17xDb9nHPT+JzNSOJBT6hG4FM1 PneTJVv1crFTCiphL9LzpQL5CZfwFDK1u2aeXcMHUApevDxQY5cPpPY6k0G4cZGP6G2q UrPWhUj+aTjOdqcnhzhHkLHevuK8eOVc9F/Za36jyTiFb5F84JpuJtJRE7GaxMv2VmEX XOhA== X-Forwarded-Encrypted: i=1; AHgh+RrNRVBV4s+6xGfNfljnGlc2PYiT3BD2O46W545E6sxzZRVfSsPeJwnC1u49UlxjyObOd/w=@lists.linux.dev X-Gm-Message-State: AFuF++n2HCYmHqwmQ8vwKUlB1GMoV8o3GtMKUqsmZyPA6b5LzlfWa5Ns hjslN1sGSJqo2/qLYKwxAK0KdUnFlEExC5uz/YB4ZhARP12wURBW/O7/Ocs8PY8CGsiwQnt6xBq FjVkYc7YiYWWDj2VK1wa3PuAGxIp8yypWv7B4G2Q3PZvoJMurRBMiVA== X-Gm-Gg: AR+sD10x5l3XDN2WiULaadk16kq94skHtdIT2uu1QzzqN65M3gydwEA7eF4zGV1OHIY DzomyD9vG4LUje9QdGUsqyi0HZ8bachLv4zsPb2Nq64mBuiiFElH6rlXM4mXMq4PPqqBqKtpSxi 6/LoWqv7HI+C71TZp2rFI0ooLHrTjDDQZjhqsL9rGvFVF2UF/86Dj1n7ncAZMcqWrDNZIj9CqXO poTt0c4iY1jQqwPi6s1toEf6n2UUa+DYVuWsgh+ZmUIsT68iVBamKZyN1G3PgtYL8wz4O8bAzsK Uh2WP7AVaTqHurJ2tboB98RqJqnsLzTddn1F6Swi/biwBQ2RmcOTEhZeYPzhu8buqnf0zx7SLNf aeTpMjv8l5TyNtIxTaYmUrWv/dW2SDSUadyah8en5IhDZIw== X-Received: by 2002:a05:6000:184e:b0:47f:f339:556c with SMTP id ffacd0b85a97d-482c0b4a40dmr705148f8f.2.1787248180683; Thu, 20 Aug 2026 10:49:40 -0700 (PDT) X-Received: by 2002:a05:6000:184e:b0:47f:f339:556c with SMTP id ffacd0b85a97d-482c0b4a40dmr705081f8f.2.1787248180291; Thu, 20 Aug 2026 10:49:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:11aa:87f0:935:4f8e:b423:64eb? ([2a01:e0a:11aa:87f0:935:4f8e:b423:64eb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b145d31bsm13853815f8f.16.2026.08.20.10.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 10:49:39 -0700 (PDT) Message-ID: Date: Thu, 20 Aug 2026 19:49:36 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/12] drm/panic: Split into core and helpers To: Thomas Zimmermann , javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, virtualization@lists.linux.dev, sashiko-reviews@lists.linux.dev References: <20260818125012.468092-1-tzimmermann@suse.de> From: Jocelyn Falempe In-Reply-To: <20260818125012.468092-1-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: K5IZeG3HhT4Z4uf_L8mBEUD2ClRVUp7EazM7kMv0Xro_1787248181 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/08/2026 14:27, Thomas Zimmermann wrote: > Split DRM's current panic handling into a core and a helper module. > The core is still part of DRM's core library. The panic helpers are > part of DRM's KMS helper module (for now). > > The motivation behind this series is to get panic handling's drawing > code out of the DRM core. At some point it should share a single > module with DRM's other drawing and format conversion. > > With the series applied, panic hanlding follows DRM's established > design pattern of having a DRM core interface with an dedicated > implementation in each driver. Drivers share common code in helper > modules. For panic handling, the DRM core still contains the panic > entry points, the parameters and the debugfs interface. All drawing > is now located in the panic helpers. > > Patches 1 to 4 improve several issues in the current panic code. It > makes sense to fix them before moving the core around. > > Patches 5 to 8 put handling of all panic state and locking into a > single place, drm_panic_display_panic_screen(). It is maintained by > panic handling's DRM core code. This also enables the test cases to > work more independently from the kernel's configuration. > > Patches 9 to 11 split the panic-handling code into the core and panic > helpers. The former maintain all state, locking and public interfaces. > The latter handles drawing and details of the involved framebuffers. > > DRM devices that offer panic handling provide a single callback, struct > drm_plane_funcs.display_panic_screen. A new initializer macro makes it > point to the existing panic-drawing implementation. Hence there's no > change in features or functionality. If panic handling is configured > off, it all clears out to NULL. > > Patch 12 reworks the test cases slighly, so that they can be build as > a separate module. Do 'modprobe drm_panic_helper_test' to run them. > > Tested under bochs with debugfs and test cases. Overall the series looks good to me, and I like the split between the helper and the core. I would just drop the first two patches, as I don't see much difference between static allocation or kmalloc() at init, and I think that memset() the buffers to 0 is not useful in this case. Best regards, -- Jocelyn > > Future directions: > > - Panic handling shares some drawing code with format conversion and > clients. There's even more drawing code in vkms. Later series' can > attempt to unify and harmonize all these implementations in a single > draw module. > > - The drawing helper drm_plane_helper_display_panic_screen() still > implements various access schemes (map, set_pixel, memcpy) in a single > function. It could be split up into specifialized helpers. > > - If we ever need a driver-specific helper, it is now possible to > implement a custom version of display_panic_screen. > > Thomas Zimmermann (12): > drm/panic: Allocate QR-code buffers statically > drm/panic: Make allocation of zlib workspace more robust > drm/panic: Return -EINVAL if font is not available > drm/panic: Return errno codes if panic output fails > drm/panic: Pass colors to draw_panic_dispatch() > drm/panic: Pass global module parameters to drm_panic_dispatch() > drm/panic: Retry in dispatch function if panic output fails > drm/panic: Split draw_panic_plane() > drm/panic: Display panic screen via per-plane callback > drm/panic: Internalize panic locking in DRM core and helpers > drm/panic: Move panic display code into helper library > drm/panic: Compile KUnit tests as module > > Documentation/gpu/drm-kms-helpers.rst | 11 +- > Documentation/gpu/drm-kms.rst | 3 + > MAINTAINERS | 11 +- > drivers/gpu/drm/Kconfig | 5 + > drivers/gpu/drm/Kconfig.debug | 1 + > drivers/gpu/drm/Makefile | 3 +- > .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 + > drivers/gpu/drm/ast/ast_mode.c | 2 + > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > drivers/gpu/drm/drm_crtc_internal.h | 2 - > drivers/gpu/drm/drm_drv.c | 3 +- > drivers/gpu/drm/drm_kms_helper_common.c | 14 + > drivers/gpu/drm/drm_panic.c | 914 +---------------- > drivers/gpu/drm/drm_panic_helper.c | 915 ++++++++++++++++++ > ...drm_panic_qr.rs => drm_panic_helper_qr.rs} | 4 +- > drivers/gpu/drm/drm_panic_internal.h | 59 ++ > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 + > drivers/gpu/drm/i915/display/i9xx_plane.c | 3 + > .../drm/i915/display/skl_universal_plane.c | 4 + > drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 2 + > drivers/gpu/drm/mgag200/mgag200_drv.h | 4 +- > drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 + > .../gpu/drm/renesas/rcar-du/rcar_du_plane.c | 2 + > .../drm/renesas/shmobile/shmob_drm_plane.c | 2 + > drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 4 +- > drivers/gpu/drm/sysfb/vesadrm.c | 1 + > drivers/gpu/drm/tests/Makefile | 1 + > ...m_panic_test.c => drm_panic_helper_test.c} | 65 +- > drivers/gpu/drm/tidss/tidss_plane.c | 2 + > drivers/gpu/drm/tiny/bochs.c | 4 +- > drivers/gpu/drm/virtio/virtgpu_plane.c | 2 + > include/drm/drm_mode_config.h | 4 +- > include/drm/drm_modeset_helper_vtables.h | 11 +- > include/drm/drm_panic.h | 117 +-- > include/drm/drm_panic_helper.h | 40 + > include/drm/drm_plane.h | 57 ++ > rust/bindings/bindings_helper.h | 4 +- > 37 files changed, 1253 insertions(+), 1031 deletions(-) > create mode 100644 drivers/gpu/drm/drm_panic_helper.c > rename drivers/gpu/drm/{drm_panic_qr.rs => drm_panic_helper_qr.rs} (99%) > create mode 100644 drivers/gpu/drm/drm_panic_internal.h > rename drivers/gpu/drm/tests/{drm_panic_test.c => drm_panic_helper_test.c} (80%) > create mode 100644 include/drm/drm_panic_helper.h > > > base-commit: dc462ab791b686c48545c160ecc81be64f77a846 > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > prerequisite-patch-id: a5a973e527c88a5b47053d7a72aefe0b550197cb > prerequisite-patch-id: b9adc9622920a3e70168e672c2c92795b3e3a106 > prerequisite-patch-id: 5030de433a01c2e99056cadb676a8e2ba35f055a