* [PATCH v3 01/22] Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-09 13:53 ` [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API Luca Ceresoli
` (22 subsequent siblings)
23 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Louis Chauvet, Alim Akhtar, Inki Dae, Kyungmin Park,
Seung-Woo Kim
This reverts commit 3be618fab0e31b086cd6456280293119bb20fd41.
This patch has been applied by mistake without needed review/ack by
maintainers.
---
Cc: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 29a8366513fa70655c6ceec9a09db0158e7bb169..b34ec67283370e3fa836c7df06e12e2fba524622 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -379,11 +379,11 @@ static int exynos_mic_probe(struct platform_device *pdev)
struct resource res;
int ret, i;
- mic = devm_drm_bridge_alloc(dev, struct exynos_mic, bridge, &mic_bridge_funcs);
- if (IS_ERR(mic)) {
+ mic = devm_kzalloc(dev, sizeof(*mic), GFP_KERNEL);
+ if (!mic) {
DRM_DEV_ERROR(dev,
"mic: Failed to allocate memory for MIC object\n");
- ret = PTR_ERR(mic);
+ ret = -ENOMEM;
goto err;
}
@@ -421,6 +421,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mic);
+ mic->bridge.funcs = &mic_bridge_funcs;
mic->bridge.of_node = dev->of_node;
drm_bridge_add(&mic->bridge);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
2025-05-09 13:53 ` [PATCH v3 01/22] Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API" Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:43 ` Maxime Ripard
2025-05-25 19:40 ` Adam Ford
2025-05-09 13:53 ` [PATCH v3 03/22] drm/bridge: anx7625: convert " Luca Ceresoli
` (21 subsequent siblings)
23 siblings, 2 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Manikandan Muralidharan, Adam Ford, Adrien Grassein,
Aleksandr Mishin, Andy Yan, AngeloGioacchino Del Regno,
Benson Leung, Biju Das, Christoph Fritz, Cristian Ciocaltea,
Detlev Casanova, Dharma Balasubiramani, Guenter Roeck,
Heiko Stuebner, Jani Nikula, Janne Grunau, Jerome Brunet,
Jesse Van Gavere, Kevin Hilman, Kieran Bingham, Liu Ying,
Martin Blumenstingl, Matthias Brugger, Philipp Zabel, Phong LE,
Sasha Finkelstein, Sugar Zhang, Sui Jingfeng, Tomi Valkeinen,
Vitalii Mordan
devm_drm_bridge_alloc() is the new API to be used for allocating (and
partially initializing) a private driver struct embedding a struct
drm_bridge.
For many drivers having a simple code flow in the probe function, this
commit does a mass conversion automatically with the following semantic
patch. The changes have been reviewed manually for correctness as well as
to find any false positives.
The patch has been applied with the explicit exclusion of bridge/panel.c,
handled by a separate patch.
After applying the semantic patch, manually fixed these issues:
- 4 drivers need ERR_CAST() instead of PTR_ERR() as the function calling
devm_drm_bridge_alloc() returns a pointer
- re-added empty lines and comments that the script had removed but that
should stay
@@
type T;
identifier C;
identifier BR;
expression DEV;
expression FUNCS;
@@
-T *C;
+T *C;
...
(
-C = devm_kzalloc(DEV, ...);
-if (!C)
- return -ENOMEM;
+C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
+if (IS_ERR(C))
+ return PTR_ERR(C);
|
-C = devm_kzalloc(DEV, ...);
-if (!C)
- return ERR_PTR(-ENOMEM);
+C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
+if (IS_ERR(C))
+ return PTR_ERR(C);
)
...
-C->BR.funcs = FUNCS;
Reviewed-by: Manikandan Muralidharan <manikandan.m@microchip.com> # microchip-lvds.c
Reviewed-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
Tested-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Adam Ford <aford173@gmail.com>
Cc: Adrien Grassein <adrien.grassein@gmail.com>
Cc: Aleksandr Mishin <amishin@t-argos.ru>
Cc: Andy Yan <andy.yan@rock-chips.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Benson Leung <bleung@chromium.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Detlev Casanova <detlev.casanova@collabora.com>
Cc: Dharma Balasubiramani <dharma.b@microchip.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Janne Grunau <j@jannau.net>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Jesse Van Gavere <jesseevg@gmail.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Manikandan Muralidharan <manikandan.m@microchip.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Phong LE <ple@baylibre.com>
Cc: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: Sugar Zhang <sugar.zhang@rock-chips.com>
Cc: Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Cc: Vitalii Mordan <mordan@ispras.ru>
Changed in v3:
- manually replaced PTR_ERR() with ERR_CAST() in the 4 cases where the
return value is not int
- manually added empty lines and comments that the spatch had removed
inappropriately
- improved commit message
Changed in v2:
- added missing PTR_ERR() in the second spatch alternative
---
drivers/gpu/drm/adp/adp-mipi.c | 8 ++++----
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 8 ++++----
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ++++-----
drivers/gpu/drm/bridge/aux-bridge.c | 8 ++++----
drivers/gpu/drm/bridge/aux-hpd-bridge.c | 9 +++++----
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 8 ++++----
drivers/gpu/drm/bridge/chipone-icn6211.c | 8 ++++----
drivers/gpu/drm/bridge/chrontel-ch7033.c | 8 ++++----
drivers/gpu/drm/bridge/cros-ec-anx7688.c | 8 ++++----
drivers/gpu/drm/bridge/fsl-ldb.c | 7 +++----
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 8 ++++----
drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 8 ++++----
drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 8 ++++----
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 8 ++++----
drivers/gpu/drm/bridge/ite-it6263.c | 8 ++++----
drivers/gpu/drm/bridge/ite-it6505.c | 8 ++++----
drivers/gpu/drm/bridge/ite-it66121.c | 8 ++++----
drivers/gpu/drm/bridge/lontium-lt8912b.c | 8 ++++----
drivers/gpu/drm/bridge/lontium-lt9211.c | 7 +++----
drivers/gpu/drm/bridge/lontium-lt9611.c | 8 ++++----
drivers/gpu/drm/bridge/lvds-codec.c | 9 ++++-----
drivers/gpu/drm/bridge/microchip-lvds.c | 8 ++++----
drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++++----
drivers/gpu/drm/bridge/parade-ps8622.c | 8 ++++----
drivers/gpu/drm/bridge/parade-ps8640.c | 8 ++++----
drivers/gpu/drm/bridge/sii9234.c | 8 ++++----
drivers/gpu/drm/bridge/sil-sii8620.c | 8 ++++----
drivers/gpu/drm/bridge/simple-bridge.c | 8 ++++----
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 8 ++++----
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++++----
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 8 ++++----
drivers/gpu/drm/bridge/tc358762.c | 8 ++++----
drivers/gpu/drm/bridge/tc358764.c | 8 ++++----
drivers/gpu/drm/bridge/tc358768.c | 8 ++++----
drivers/gpu/drm/bridge/tc358775.c | 8 ++++----
drivers/gpu/drm/bridge/thc63lvd1024.c | 8 ++++----
drivers/gpu/drm/bridge/ti-dlpc3433.c | 8 ++++----
drivers/gpu/drm/bridge/ti-tdp158.c | 8 ++++----
drivers/gpu/drm/bridge/ti-tfp410.c | 8 ++++----
drivers/gpu/drm/bridge/ti-tpd12s015.c | 8 ++++----
drivers/gpu/drm/mediatek/mtk_dp.c | 8 ++++----
drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++++----
drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++----
drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 ++++----
drivers/gpu/drm/meson/meson_encoder_cvbs.c | 10 ++++++----
drivers/gpu/drm/meson/meson_encoder_dsi.c | 10 ++++++----
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 10 ++++++----
drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 8 ++++----
drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 8 ++++----
49 files changed, 201 insertions(+), 198 deletions(-)
diff --git a/drivers/gpu/drm/adp/adp-mipi.c b/drivers/gpu/drm/adp/adp-mipi.c
index 2b60128e2c693e9f85affff569cc57cdb6f47909..cba7d32150a98d78d07a25b1822dec6bf2f08f65 100644
--- a/drivers/gpu/drm/adp/adp-mipi.c
+++ b/drivers/gpu/drm/adp/adp-mipi.c
@@ -229,9 +229,10 @@ static int adp_mipi_probe(struct platform_device *pdev)
{
struct adp_mipi_drv_private *adp;
- adp = devm_kzalloc(&pdev->dev, sizeof(*adp), GFP_KERNEL);
- if (!adp)
- return -ENOMEM;
+ adp = devm_drm_bridge_alloc(&pdev->dev, struct adp_mipi_drv_private,
+ bridge, &adp_dsi_bridge_funcs);
+ if (IS_ERR(adp))
+ return PTR_ERR(adp);
adp->mipi = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(adp->mipi)) {
@@ -241,7 +242,6 @@ static int adp_mipi_probe(struct platform_device *pdev)
adp->dsi.dev = &pdev->dev;
adp->dsi.ops = &adp_dsi_host_ops;
- adp->bridge.funcs = &adp_dsi_bridge_funcs;
adp->bridge.of_node = pdev->dev.of_node;
adp->bridge.type = DRM_MODE_CONNECTOR_DSI;
dev_set_drvdata(&pdev->dev, adp);
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 1257009e850c1b20184cfaea5b6a4440e75e10d7..8d7b007ea203d0d8be8f5b145f8531e23294dacc 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1224,9 +1224,10 @@ static int adv7511_probe(struct i2c_client *i2c)
if (!dev->of_node)
return -EINVAL;
- adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL);
- if (!adv7511)
- return -ENOMEM;
+ adv7511 = devm_drm_bridge_alloc(dev, struct adv7511, bridge,
+ &adv7511_bridge_funcs);
+ if (IS_ERR(adv7511))
+ return PTR_ERR(adv7511);
adv7511->i2c_main = i2c;
adv7511->powered = false;
@@ -1327,7 +1328,6 @@ static int adv7511_probe(struct i2c_client *i2c)
if (ret)
goto err_unregister_cec;
- adv7511->bridge.funcs = &adv7511_bridge_funcs;
adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
if (adv7511->i2c_main->irq)
adv7511->bridge.ops |= DRM_BRIDGE_OP_HPD;
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index a83020d6576f78372056069947783a626acf64b1..ba0fc149a9e722a53da6027a851bf62262ba64b2 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -1193,9 +1193,10 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
bool found = false;
int err;
- anx78xx = devm_kzalloc(&client->dev, sizeof(*anx78xx), GFP_KERNEL);
- if (!anx78xx)
- return -ENOMEM;
+ anx78xx = devm_drm_bridge_alloc(&client->dev, struct anx78xx, bridge,
+ &anx78xx_bridge_funcs);
+ if (IS_ERR(anx78xx))
+ return PTR_ERR(anx78xx);
pdata = &anx78xx->pdata;
@@ -1306,8 +1307,6 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
goto err_poweroff;
}
- anx78xx->bridge.funcs = &anx78xx_bridge_funcs;
-
drm_bridge_add(&anx78xx->bridge);
/* If cable is pulled out, just poweroff and wait for HPD event */
diff --git a/drivers/gpu/drm/bridge/aux-bridge.c b/drivers/gpu/drm/bridge/aux-bridge.c
index c179b86d208f70d95b41e6f2157b78f97bac4d8d..5b219e3b87b1df9fc4aaf2c8a6e78bac8f894628 100644
--- a/drivers/gpu/drm/bridge/aux-bridge.c
+++ b/drivers/gpu/drm/bridge/aux-bridge.c
@@ -109,9 +109,10 @@ static int drm_aux_bridge_probe(struct auxiliary_device *auxdev,
{
struct drm_aux_bridge_data *data;
- data = devm_kzalloc(&auxdev->dev, sizeof(*data), GFP_KERNEL);
- if (!data)
- return -ENOMEM;
+ data = devm_drm_bridge_alloc(&auxdev->dev, struct drm_aux_bridge_data,
+ bridge, &drm_aux_bridge_funcs);
+ if (IS_ERR(data))
+ return PTR_ERR(data);
data->dev = &auxdev->dev;
data->next_bridge = devm_drm_of_get_bridge(&auxdev->dev, auxdev->dev.of_node, 0, 0);
@@ -119,7 +120,6 @@ static int drm_aux_bridge_probe(struct auxiliary_device *auxdev,
return dev_err_probe(&auxdev->dev, PTR_ERR(data->next_bridge),
"failed to acquire drm_bridge\n");
- data->bridge.funcs = &drm_aux_bridge_funcs;
data->bridge.of_node = data->dev->of_node;
/* passthrough data, allow everything */
diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
index b3f588b71a7d7ad5c2ee7b07c39079bc5ba34cee..3eb411f874e41b322f732649bd2074c5d8422566 100644
--- a/drivers/gpu/drm/bridge/aux-hpd-bridge.c
+++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
@@ -171,12 +171,13 @@ static int drm_aux_hpd_bridge_probe(struct auxiliary_device *auxdev,
{
struct drm_aux_hpd_bridge_data *data;
- data = devm_kzalloc(&auxdev->dev, sizeof(*data), GFP_KERNEL);
- if (!data)
- return -ENOMEM;
+ data = devm_drm_bridge_alloc(&auxdev->dev,
+ struct drm_aux_hpd_bridge_data, bridge,
+ &drm_aux_hpd_bridge_funcs);
+ if (IS_ERR(data))
+ return PTR_ERR(data);
data->dev = &auxdev->dev;
- data->bridge.funcs = &drm_aux_hpd_bridge_funcs;
data->bridge.of_node = dev_get_platdata(data->dev);
data->bridge.ops = DRM_BRIDGE_OP_HPD;
data->bridge.type = id->driver_data;
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index b431e7efd1f0d749320ea15b6f1f5ca13fc72800..cb5f5a8c539a471290df8435d4c2e3ed696b38d4 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -2389,9 +2389,10 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
int ret;
int irq;
- mhdp = devm_kzalloc(dev, sizeof(*mhdp), GFP_KERNEL);
- if (!mhdp)
- return -ENOMEM;
+ mhdp = devm_drm_bridge_alloc(dev, struct cdns_mhdp_device, bridge,
+ &cdns_mhdp_bridge_funcs);
+ if (IS_ERR(mhdp))
+ return PTR_ERR(mhdp);
clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(clk)) {
@@ -2481,7 +2482,6 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
mhdp->display_fmt.bpc = 8;
mhdp->bridge.of_node = pdev->dev.of_node;
- mhdp->bridge.funcs = &cdns_mhdp_bridge_funcs;
mhdp->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
DRM_BRIDGE_OP_HPD;
mhdp->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 634c5b0306679d2e68798c2b9013aae4491dd44c..814713c5bea97dcdc2b847d2f266a567ef40e981 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -691,9 +691,10 @@ static int chipone_common_probe(struct device *dev, struct chipone **icnr)
struct chipone *icn;
int ret;
- icn = devm_kzalloc(dev, sizeof(struct chipone), GFP_KERNEL);
- if (!icn)
- return -ENOMEM;
+ icn = devm_drm_bridge_alloc(dev, struct chipone, bridge,
+ &chipone_bridge_funcs);
+ if (IS_ERR(icn))
+ return PTR_ERR(icn);
icn->dev = dev;
@@ -701,7 +702,6 @@ static int chipone_common_probe(struct device *dev, struct chipone **icnr)
if (ret)
return ret;
- icn->bridge.funcs = &chipone_bridge_funcs;
icn->bridge.type = DRM_MODE_CONNECTOR_DPI;
icn->bridge.of_node = dev->of_node;
diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c
index 210c45c1efd48f5b541bf73da66a169c27e110b2..ab92747933568bfba77da45219e019408029f297 100644
--- a/drivers/gpu/drm/bridge/chrontel-ch7033.c
+++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c
@@ -536,9 +536,10 @@ static int ch7033_probe(struct i2c_client *client)
unsigned int val;
int ret;
- priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- if (!priv)
- return -ENOMEM;
+ priv = devm_drm_bridge_alloc(dev, struct ch7033_priv, bridge,
+ &ch7033_bridge_funcs);
+ if (IS_ERR(priv))
+ return PTR_ERR(priv);
dev_set_drvdata(dev, priv);
@@ -575,7 +576,6 @@ static int ch7033_probe(struct i2c_client *client)
}
INIT_LIST_HEAD(&priv->bridge.list);
- priv->bridge.funcs = &ch7033_bridge_funcs;
priv->bridge.of_node = dev->of_node;
drm_bridge_add(&priv->bridge);
diff --git a/drivers/gpu/drm/bridge/cros-ec-anx7688.c b/drivers/gpu/drm/bridge/cros-ec-anx7688.c
index c8abd9920fee956cf049bcb09827d658b7939333..a35dae9b56e247d43cac317d8bf1f904d5e7435e 100644
--- a/drivers/gpu/drm/bridge/cros-ec-anx7688.c
+++ b/drivers/gpu/drm/bridge/cros-ec-anx7688.c
@@ -103,9 +103,10 @@ static int cros_ec_anx7688_bridge_probe(struct i2c_client *client)
u8 buffer[4];
int ret;
- anx7688 = devm_kzalloc(dev, sizeof(*anx7688), GFP_KERNEL);
- if (!anx7688)
- return -ENOMEM;
+ anx7688 = devm_drm_bridge_alloc(dev, struct cros_ec_anx7688, bridge,
+ &cros_ec_anx7688_bridge_funcs);
+ if (IS_ERR(anx7688))
+ return PTR_ERR(anx7688);
anx7688->client = client;
i2c_set_clientdata(client, anx7688);
@@ -153,7 +154,6 @@ static int cros_ec_anx7688_bridge_probe(struct i2c_client *client)
DRM_WARN("Old ANX7688 FW version (0x%04x), not filtering\n",
fw_version);
- anx7688->bridge.funcs = &cros_ec_anx7688_bridge_funcs;
drm_bridge_add(&anx7688->bridge);
return 0;
diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
index 2cb6dfc7a6d3dbdd620a35345204f8fb9cae6651..5c3cf37200bcee1db285c97e2b463c9355ee6acb 100644
--- a/drivers/gpu/drm/bridge/fsl-ldb.c
+++ b/drivers/gpu/drm/bridge/fsl-ldb.c
@@ -298,16 +298,15 @@ static int fsl_ldb_probe(struct platform_device *pdev)
struct fsl_ldb *fsl_ldb;
int dual_link;
- fsl_ldb = devm_kzalloc(dev, sizeof(*fsl_ldb), GFP_KERNEL);
- if (!fsl_ldb)
- return -ENOMEM;
+ fsl_ldb = devm_drm_bridge_alloc(dev, struct fsl_ldb, bridge, &funcs);
+ if (IS_ERR(fsl_ldb))
+ return PTR_ERR(fsl_ldb);
fsl_ldb->devdata = of_device_get_match_data(dev);
if (!fsl_ldb->devdata)
return -EINVAL;
fsl_ldb->dev = &pdev->dev;
- fsl_ldb->bridge.funcs = &funcs;
fsl_ldb->bridge.of_node = dev->of_node;
fsl_ldb->clk = devm_clk_get(dev, "ldb");
diff --git a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
index f072c6ed39ef183b10518b43bd6d979bc89e36f9..989bc497b05071af2a92c750d907addcfe783858 100644
--- a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
+++ b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
@@ -59,9 +59,10 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
struct imx_legacy_bridge *imx_bridge;
int ret;
- imx_bridge = devm_kzalloc(dev, sizeof(*imx_bridge), GFP_KERNEL);
- if (!imx_bridge)
- return ERR_PTR(-ENOMEM);
+ imx_bridge = devm_drm_bridge_alloc(dev, struct imx_legacy_bridge,
+ base, &imx_legacy_bridge_funcs);
+ if (IS_ERR(imx_bridge))
+ return ERR_CAST(imx_bridge);
ret = of_get_drm_display_mode(np,
&imx_bridge->mode,
@@ -72,7 +73,6 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
imx_bridge->mode.type |= DRM_MODE_TYPE_DRIVER;
- imx_bridge->base.funcs = &imx_legacy_bridge_funcs;
imx_bridge->base.of_node = np;
imx_bridge->base.ops = DRM_BRIDGE_OP_MODES;
imx_bridge->base.type = type;
diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
index 8a4fd7d77a8d516b3b46f41cf07d2633d23bde12..3a6f8587a257c3ceacefbed1b37024289617b7c1 100644
--- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
+++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
@@ -140,9 +140,10 @@ static int imx8mp_hdmi_pvi_probe(struct platform_device *pdev)
struct device_node *remote;
struct imx8mp_hdmi_pvi *pvi;
- pvi = devm_kzalloc(&pdev->dev, sizeof(*pvi), GFP_KERNEL);
- if (!pvi)
- return -ENOMEM;
+ pvi = devm_drm_bridge_alloc(&pdev->dev, struct imx8mp_hdmi_pvi,
+ bridge, &imx_hdmi_pvi_bridge_funcs);
+ if (IS_ERR(pvi))
+ return PTR_ERR(pvi);
platform_set_drvdata(pdev, pvi);
pvi->dev = &pdev->dev;
@@ -166,7 +167,6 @@ static int imx8mp_hdmi_pvi_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
/* Register the bridge. */
- pvi->bridge.funcs = &imx_hdmi_pvi_bridge_funcs;
pvi->bridge.of_node = pdev->dev.of_node;
pvi->bridge.timings = pvi->next_bridge->timings;
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
index e092c9ea99b0224802919ff84b448acb53508951..e5943506981dfb8f113c94ad52ddbba52e00ec3f 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
@@ -327,9 +327,10 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
int ret;
- pl = devm_kzalloc(dev, sizeof(*pl), GFP_KERNEL);
- if (!pl)
- return -ENOMEM;
+ pl = devm_drm_bridge_alloc(dev, struct imx8qxp_pixel_link, bridge,
+ &imx8qxp_pixel_link_bridge_funcs);
+ if (IS_ERR(pl))
+ return PTR_ERR(pl);
ret = imx_scu_get_handle(&pl->ipc_handle);
if (ret) {
@@ -384,7 +385,6 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pl);
pl->bridge.driver_private = pl;
- pl->bridge.funcs = &imx8qxp_pixel_link_bridge_funcs;
pl->bridge.of_node = np;
drm_bridge_add(&pl->bridge);
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
index da138ab51b3bd2c6ebd3780c09818891d5320092..111310acab2ce403a62a47ecbe9d9dd372c75ecd 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
@@ -392,9 +392,10 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
int ret;
- p2d = devm_kzalloc(dev, sizeof(*p2d), GFP_KERNEL);
- if (!p2d)
- return -ENOMEM;
+ p2d = devm_drm_bridge_alloc(dev, struct imx8qxp_pxl2dpi, bridge,
+ &imx8qxp_pxl2dpi_bridge_funcs);
+ if (IS_ERR(p2d))
+ return PTR_ERR(p2d);
p2d->regmap = syscon_node_to_regmap(np->parent);
if (IS_ERR(p2d->regmap)) {
@@ -441,7 +442,6 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
p2d->bridge.driver_private = p2d;
- p2d->bridge.funcs = &imx8qxp_pxl2dpi_bridge_funcs;
p2d->bridge.of_node = np;
drm_bridge_add(&p2d->bridge);
diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
index a3a63a977b0a8487ad38fc08e0eed08672f4d41a..c4eedf643f39e9b91efeb5a6214bf2fe6f2c040a 100644
--- a/drivers/gpu/drm/bridge/ite-it6263.c
+++ b/drivers/gpu/drm/bridge/ite-it6263.c
@@ -816,9 +816,10 @@ static int it6263_probe(struct i2c_client *client)
struct it6263 *it;
int ret;
- it = devm_kzalloc(dev, sizeof(*it), GFP_KERNEL);
- if (!it)
- return -ENOMEM;
+ it = devm_drm_bridge_alloc(dev, struct it6263, bridge,
+ &it6263_bridge_funcs);
+ if (IS_ERR(it))
+ return PTR_ERR(it);
it->dev = dev;
it->hdmi_i2c = client;
@@ -866,7 +867,6 @@ static int it6263_probe(struct i2c_client *client)
i2c_set_clientdata(client, it);
- it->bridge.funcs = &it6263_bridge_funcs;
it->bridge.of_node = dev->of_node;
/* IT6263 chip doesn't support HPD interrupt. */
it->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 1383d1e21afea1acb46b7bd28860908b58832dbc..b0dc9280d870c4864d43984999238e8a34bf47df 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3583,9 +3583,10 @@ static int it6505_i2c_probe(struct i2c_client *client)
struct extcon_dev *extcon;
int err;
- it6505 = devm_kzalloc(&client->dev, sizeof(*it6505), GFP_KERNEL);
- if (!it6505)
- return -ENOMEM;
+ it6505 = devm_drm_bridge_alloc(&client->dev, struct it6505, bridge,
+ &it6505_bridge_funcs);
+ if (IS_ERR(it6505))
+ return PTR_ERR(it6505);
mutex_init(&it6505->extcon_lock);
mutex_init(&it6505->mode_lock);
@@ -3660,7 +3661,6 @@ static int it6505_i2c_probe(struct i2c_client *client)
it6505->aux.transfer = it6505_aux_transfer;
drm_dp_aux_init(&it6505->aux);
- it6505->bridge.funcs = &it6505_bridge_funcs;
it6505->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
it6505->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
DRM_BRIDGE_OP_HPD;
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 7b110ae532918d2d6f91ebc5f747c38e7e77dc07..6494f0842793829b7658b330338767e5b38a1115 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -1516,9 +1516,10 @@ static int it66121_probe(struct i2c_client *client)
return -ENXIO;
}
- ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct it66121_ctx, bridge,
+ &it66121_bridge_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
if (!ep)
@@ -1577,7 +1578,6 @@ static int it66121_probe(struct i2c_client *client)
return -ENODEV;
}
- ctx->bridge.funcs = &it66121_bridge_funcs;
ctx->bridge.of_node = dev->of_node;
ctx->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
ctx->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 3e49d855b3648880cea9bce5f3f04fbb6f838a45..bd83228b0f0eb49062ee84f62f8ae50b78bbfb0e 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -761,9 +761,10 @@ static int lt8912_probe(struct i2c_client *client)
int ret = 0;
struct device *dev = &client->dev;
- lt = devm_kzalloc(dev, sizeof(struct lt8912), GFP_KERNEL);
- if (!lt)
- return -ENOMEM;
+ lt = devm_drm_bridge_alloc(dev, struct lt8912, bridge,
+ <8912_bridge_funcs);
+ if (IS_ERR(lt))
+ return PTR_ERR(lt);
lt->dev = dev;
lt->i2c_client[0] = client;
@@ -778,7 +779,6 @@ static int lt8912_probe(struct i2c_client *client)
i2c_set_clientdata(client, lt);
- lt->bridge.funcs = <8912_bridge_funcs;
lt->bridge.of_node = dev->of_node;
lt->bridge.ops = (DRM_BRIDGE_OP_EDID |
DRM_BRIDGE_OP_DETECT);
diff --git a/drivers/gpu/drm/bridge/lontium-lt9211.c b/drivers/gpu/drm/bridge/lontium-lt9211.c
index 9b2dac9bd63c5afd4ffbafafdbbb1230549bc36f..399fa7eebd49cc3fe9e812517fc3e8ed25004086 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9211.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9211.c
@@ -727,9 +727,9 @@ static int lt9211_probe(struct i2c_client *client)
struct lt9211 *ctx;
int ret;
- ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct lt9211, bridge, <9211_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
ctx->dev = dev;
@@ -755,7 +755,6 @@ static int lt9211_probe(struct i2c_client *client)
dev_set_drvdata(dev, ctx);
i2c_set_clientdata(client, ctx);
- ctx->bridge.funcs = <9211_funcs;
ctx->bridge.of_node = dev->of_node;
drm_bridge_add(&ctx->bridge);
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index a35a8b8ca89c2cc138a7cb4de01c796c6211d655..d6ee79c1e42771174ee01f17448f1a8fff70b63f 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1072,9 +1072,10 @@ static int lt9611_probe(struct i2c_client *client)
return -ENODEV;
}
- lt9611 = devm_kzalloc(dev, sizeof(*lt9611), GFP_KERNEL);
- if (!lt9611)
- return -ENOMEM;
+ lt9611 = devm_drm_bridge_alloc(dev, struct lt9611, bridge,
+ <9611_bridge_funcs);
+ if (IS_ERR(lt9611))
+ return PTR_ERR(lt9611);
lt9611->dev = dev;
lt9611->client = client;
@@ -1127,7 +1128,6 @@ static int lt9611_probe(struct i2c_client *client)
/* Disable Audio InfoFrame, enabled by default */
regmap_update_bits(lt9611->regmap, 0x843d, LT9611_INFOFRAME_AUDIO, 0);
- lt9611->bridge.funcs = <9611_bridge_funcs;
lt9611->bridge.of_node = client->dev.of_node;
lt9611->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_MODES |
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index 1646e454e0b0b558d00f9421f15bb7084e2aa45a..e6a7147e141b64fc77dfef03a737ee599a0ecd10 100644
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -118,9 +118,10 @@ static int lvds_codec_probe(struct platform_device *pdev)
u32 val;
int ret;
- lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
- if (!lvds_codec)
- return -ENOMEM;
+ lvds_codec = devm_drm_bridge_alloc(dev, struct lvds_codec, bridge,
+ &funcs);
+ if (IS_ERR(lvds_codec))
+ return PTR_ERR(lvds_codec);
lvds_codec->dev = &pdev->dev;
lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
@@ -156,8 +157,6 @@ static int lvds_codec_probe(struct platform_device *pdev)
if (IS_ERR(lvds_codec->panel_bridge))
return PTR_ERR(lvds_codec->panel_bridge);
- lvds_codec->bridge.funcs = &funcs;
-
/*
* Decoder input LVDS format is a property of the decoder chip or even
* its strapping. Handle data-mapping the same way lvds-panel does. In
diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
index 1d4ae0097df847d9f93c79eecff0c4587ae331ba..9f4ff82bc6b49010f8727da3b367f5a744a28edc 100644
--- a/drivers/gpu/drm/bridge/microchip-lvds.c
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -157,9 +157,10 @@ static int mchp_lvds_probe(struct platform_device *pdev)
if (!dev->of_node)
return -ENODEV;
- lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
- if (!lvds)
- return -ENOMEM;
+ lvds = devm_drm_bridge_alloc(&pdev->dev, struct mchp_lvds, bridge,
+ &mchp_lvds_bridge_funcs);
+ if (IS_ERR(lvds))
+ return PTR_ERR(lvds);
lvds->dev = dev;
@@ -192,7 +193,6 @@ static int mchp_lvds_probe(struct platform_device *pdev)
lvds->bridge.of_node = dev->of_node;
lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS;
- lvds->bridge.funcs = &mchp_lvds_bridge_funcs;
dev_set_drvdata(dev, lvds);
ret = devm_pm_runtime_enable(dev);
diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index 55912ae11f46a1d551e11f93a306a8a00ef3f7d8..2f7429b24fc20db104dec17182f1119c6c75e600 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -1149,9 +1149,10 @@ static int nwl_dsi_probe(struct platform_device *pdev)
struct nwl_dsi *dsi;
int ret;
- dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(dev, struct nwl_dsi, bridge,
+ &nwl_dsi_bridge_funcs);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
dsi->dev = dev;
@@ -1180,7 +1181,6 @@ static int nwl_dsi_probe(struct platform_device *pdev)
dsi->quirks = (uintptr_t)attr->data;
dsi->bridge.driver_private = dsi;
- dsi->bridge.funcs = &nwl_dsi_bridge_funcs;
dsi->bridge.of_node = dev->of_node;
dsi->bridge.timings = &nwl_dsi_timings;
dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
index 8726fefc5c654e49bce029d943d241789ca4f802..f879a1df077d25d0c5121e51aa067f511a41a9bd 100644
--- a/drivers/gpu/drm/bridge/parade-ps8622.c
+++ b/drivers/gpu/drm/bridge/parade-ps8622.c
@@ -449,9 +449,10 @@ static int ps8622_probe(struct i2c_client *client)
struct drm_bridge *panel_bridge;
int ret;
- ps8622 = devm_kzalloc(dev, sizeof(*ps8622), GFP_KERNEL);
- if (!ps8622)
- return -ENOMEM;
+ ps8622 = devm_drm_bridge_alloc(dev, struct ps8622_bridge, bridge,
+ &ps8622_bridge_funcs);
+ if (IS_ERR(ps8622))
+ return PTR_ERR(ps8622);
panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0);
if (IS_ERR(panel_bridge))
@@ -509,7 +510,6 @@ static int ps8622_probe(struct i2c_client *client)
ps8622->bl->props.brightness = PS8622_MAX_BRIGHTNESS;
}
- ps8622->bridge.funcs = &ps8622_bridge_funcs;
ps8622->bridge.type = DRM_MODE_CONNECTOR_LVDS;
ps8622->bridge.of_node = dev->of_node;
drm_bridge_add(&ps8622->bridge);
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 2422ff68c1042bd8eaa6821ff387d4faad47c550..825777a5758f67b5bdaa5f9de2e0e4f597f0f7a4 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -636,9 +636,10 @@ static int ps8640_probe(struct i2c_client *client)
int ret;
u32 i;
- ps_bridge = devm_kzalloc(dev, sizeof(*ps_bridge), GFP_KERNEL);
- if (!ps_bridge)
- return -ENOMEM;
+ ps_bridge = devm_drm_bridge_alloc(dev, struct ps8640, bridge,
+ &ps8640_bridge_funcs);
+ if (IS_ERR(ps_bridge))
+ return PTR_ERR(ps_bridge);
mutex_init(&ps_bridge->aux_lock);
@@ -662,7 +663,6 @@ static int ps8640_probe(struct i2c_client *client)
if (IS_ERR(ps_bridge->gpio_reset))
return PTR_ERR(ps_bridge->gpio_reset);
- ps_bridge->bridge.funcs = &ps8640_bridge_funcs;
ps_bridge->bridge.of_node = dev->of_node;
ps_bridge->bridge.type = DRM_MODE_CONNECTOR_eDP;
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index cd7837c9a6e00b572a3fb65e5e0c9fa884555a73..bb1bed03eb5b7ae67f752c0d593dc54131e9e370 100644
--- a/drivers/gpu/drm/bridge/sii9234.c
+++ b/drivers/gpu/drm/bridge/sii9234.c
@@ -888,9 +888,10 @@ static int sii9234_probe(struct i2c_client *client)
struct device *dev = &client->dev;
int ret;
- ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct sii9234, bridge,
+ &sii9234_bridge_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
ctx->dev = dev;
mutex_init(&ctx->lock);
@@ -921,7 +922,6 @@ static int sii9234_probe(struct i2c_client *client)
i2c_set_clientdata(client, ctx);
- ctx->bridge.funcs = &sii9234_bridge_funcs;
ctx->bridge.of_node = dev->of_node;
drm_bridge_add(&ctx->bridge);
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
index 3af650dc92a1612ca88fe378319519546b79901f..9e48ad39e1cc995768d767c27b8116d7baa2f47e 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2291,9 +2291,10 @@ static int sii8620_probe(struct i2c_client *client)
struct sii8620 *ctx;
int ret;
- ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct sii8620, bridge,
+ &sii8620_bridge_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
ctx->dev = dev;
mutex_init(&ctx->lock);
@@ -2336,7 +2337,6 @@ static int sii8620_probe(struct i2c_client *client)
i2c_set_clientdata(client, ctx);
- ctx->bridge.funcs = &sii8620_bridge_funcs;
ctx->bridge.of_node = dev->of_node;
drm_bridge_add(&ctx->bridge);
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 70db5b99e5bb84f099ec54cf62abbda53475311d..c66bd913e33ae311a980251348199889ef5b99af 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -168,9 +168,10 @@ static int simple_bridge_probe(struct platform_device *pdev)
struct simple_bridge *sbridge;
struct device_node *remote;
- sbridge = devm_kzalloc(&pdev->dev, sizeof(*sbridge), GFP_KERNEL);
- if (!sbridge)
- return -ENOMEM;
+ sbridge = devm_drm_bridge_alloc(&pdev->dev, struct simple_bridge,
+ bridge, &simple_bridge_bridge_funcs);
+ if (IS_ERR(sbridge))
+ return PTR_ERR(sbridge);
sbridge->info = of_device_get_match_data(&pdev->dev);
@@ -204,7 +205,6 @@ static int simple_bridge_probe(struct platform_device *pdev)
"Unable to retrieve enable GPIO\n");
/* Register the bridge. */
- sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
sbridge->bridge.of_node = pdev->dev.of_node;
sbridge->bridge.timings = sbridge->info->timings;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
index 5e5f8c2f95be1f5c4633f1093b17a00f9425bb37..94dddaf49b3c1fa115f376e5cf1c2f515f2594ea 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
@@ -1045,9 +1045,10 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
return ERR_PTR(-ENODEV);
}
- hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
- if (!hdmi)
- return ERR_PTR(-ENOMEM);
+ hdmi = devm_drm_bridge_alloc(dev, struct dw_hdmi_qp, bridge,
+ &dw_hdmi_qp_bridge_funcs);
+ if (IS_ERR(hdmi))
+ return ERR_CAST(hdmi);
hdmi->dev = dev;
@@ -1073,7 +1074,6 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
return ERR_PTR(ret);
hdmi->bridge.driver_private = hdmi;
- hdmi->bridge.funcs = &dw_hdmi_qp_bridge_funcs;
hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT |
DRM_BRIDGE_OP_EDID |
DRM_BRIDGE_OP_HDMI |
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index b08ada920a501d6a62f39581944a87019f5e5c15..c0dc0f2976b92f5a4eb2416de8f510ec7214e562 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -1194,9 +1194,10 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
struct dw_mipi_dsi *dsi;
int ret;
- dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return ERR_PTR(-ENOMEM);
+ dsi = devm_drm_bridge_alloc(dev, struct dw_mipi_dsi, bridge,
+ &dw_mipi_dsi_bridge_funcs);
+ if (IS_ERR(dsi))
+ return ERR_CAST(dsi);
dsi->dev = dev;
dsi->plat_data = plat_data;
@@ -1265,7 +1266,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
}
dsi->bridge.driver_private = dsi;
- dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
dsi->bridge.of_node = pdev->dev.of_node;
return dsi;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
index c76f5f2e74d14bd372f969c6c7832aa57f80772b..fc91aca95d126ae37726ccd939fdc8657151ca81 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
@@ -914,9 +914,10 @@ __dw_mipi_dsi2_probe(struct platform_device *pdev,
struct dw_mipi_dsi2 *dsi2;
int ret;
- dsi2 = devm_kzalloc(dev, sizeof(*dsi2), GFP_KERNEL);
- if (!dsi2)
- return ERR_PTR(-ENOMEM);
+ dsi2 = devm_drm_bridge_alloc(dev, struct dw_mipi_dsi2, bridge,
+ &dw_mipi_dsi2_bridge_funcs);
+ if (IS_ERR(dsi2))
+ return ERR_CAST(dsi2);
dsi2->dev = dev;
dsi2->plat_data = plat_data;
@@ -981,7 +982,6 @@ __dw_mipi_dsi2_probe(struct platform_device *pdev,
}
dsi2->bridge.driver_private = dsi2;
- dsi2->bridge.funcs = &dw_mipi_dsi2_bridge_funcs;
dsi2->bridge.of_node = pdev->dev.of_node;
return dsi2;
diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
index edf01476f2ef6e05ef2c144ff4467e7f6babc4c6..98df3e667d4aac48c19c82c8bc9e116b36a4cec8 100644
--- a/drivers/gpu/drm/bridge/tc358762.c
+++ b/drivers/gpu/drm/bridge/tc358762.c
@@ -265,9 +265,10 @@ static int tc358762_probe(struct mipi_dsi_device *dsi)
struct tc358762 *ctx;
int ret;
- ctx = devm_kzalloc(dev, sizeof(struct tc358762), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct tc358762, bridge,
+ &tc358762_bridge_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
mipi_dsi_set_drvdata(dsi, ctx);
@@ -288,7 +289,6 @@ static int tc358762_probe(struct mipi_dsi_device *dsi)
if (ret < 0)
return ret;
- ctx->bridge.funcs = &tc358762_bridge_funcs;
ctx->bridge.type = DRM_MODE_CONNECTOR_DPI;
ctx->bridge.of_node = dev->of_node;
ctx->bridge.pre_enable_prev_first = true;
diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
index 3f76c890fad9ffa50dc02f289a37378332830516..084e9d898e226ecfa618a3c91c0786d2f83fa51b 100644
--- a/drivers/gpu/drm/bridge/tc358764.c
+++ b/drivers/gpu/drm/bridge/tc358764.c
@@ -347,9 +347,10 @@ static int tc358764_probe(struct mipi_dsi_device *dsi)
struct tc358764 *ctx;
int ret;
- ctx = devm_kzalloc(dev, sizeof(struct tc358764), GFP_KERNEL);
- if (!ctx)
- return -ENOMEM;
+ ctx = devm_drm_bridge_alloc(dev, struct tc358764, bridge,
+ &tc358764_bridge_funcs);
+ if (IS_ERR(ctx))
+ return PTR_ERR(ctx);
mipi_dsi_set_drvdata(dsi, ctx);
@@ -368,7 +369,6 @@ static int tc358764_probe(struct mipi_dsi_device *dsi)
if (ret < 0)
return ret;
- ctx->bridge.funcs = &tc358764_bridge_funcs;
ctx->bridge.of_node = dev->of_node;
ctx->bridge.pre_enable_prev_first = true;
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
index 063f217a17b6cf32e9793b8a96a5ac6128584098..fbdc44e162293f2f9b090bc956604184a2a406b2 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -1287,9 +1287,10 @@ static int tc358768_i2c_probe(struct i2c_client *client)
if (!np)
return -ENODEV;
- priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- if (!priv)
- return -ENOMEM;
+ priv = devm_drm_bridge_alloc(dev, struct tc358768_priv, bridge,
+ &tc358768_bridge_funcs);
+ if (IS_ERR(priv))
+ return PTR_ERR(priv);
dev_set_drvdata(dev, priv);
priv->dev = dev;
@@ -1321,7 +1322,6 @@ static int tc358768_i2c_probe(struct i2c_client *client)
priv->dsi_host.dev = dev;
priv->dsi_host.ops = &tc358768_dsi_host_ops;
- priv->bridge.funcs = &tc358768_bridge_funcs;
priv->bridge.timings = &default_tc358768_timings;
priv->bridge.of_node = np;
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
index 1b10e6ee1724ffb4bb8946f86d2f18e53428381a..366b12db0e7cbfb45b3dfc2a83a7af580cfde41f 100644
--- a/drivers/gpu/drm/bridge/tc358775.c
+++ b/drivers/gpu/drm/bridge/tc358775.c
@@ -659,9 +659,10 @@ static int tc_probe(struct i2c_client *client)
struct tc_data *tc;
int ret;
- tc = devm_kzalloc(dev, sizeof(*tc), GFP_KERNEL);
- if (!tc)
- return -ENOMEM;
+ tc = devm_drm_bridge_alloc(dev, struct tc_data, bridge,
+ &tc_bridge_funcs);
+ if (IS_ERR(tc))
+ return PTR_ERR(tc);
tc->dev = dev;
tc->i2c = client;
@@ -701,7 +702,6 @@ static int tc_probe(struct i2c_client *client)
return ret;
}
- tc->bridge.funcs = &tc_bridge_funcs;
tc->bridge.of_node = dev->of_node;
tc->bridge.pre_enable_prev_first = true;
drm_bridge_add(&tc->bridge);
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
index e2fc78adebcf22f0d8cdb484078e37b748b776c6..2cb7cd0c060824256bbfa511f833cc00437d318b 100644
--- a/drivers/gpu/drm/bridge/thc63lvd1024.c
+++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
@@ -181,9 +181,10 @@ static int thc63_probe(struct platform_device *pdev)
struct thc63_dev *thc63;
int ret;
- thc63 = devm_kzalloc(&pdev->dev, sizeof(*thc63), GFP_KERNEL);
- if (!thc63)
- return -ENOMEM;
+ thc63 = devm_drm_bridge_alloc(&pdev->dev, struct thc63_dev, bridge,
+ &thc63_bridge_func);
+ if (IS_ERR(thc63))
+ return PTR_ERR(thc63);
thc63->dev = &pdev->dev;
platform_set_drvdata(pdev, thc63);
@@ -208,7 +209,6 @@ static int thc63_probe(struct platform_device *pdev)
thc63->bridge.driver_private = thc63;
thc63->bridge.of_node = pdev->dev.of_node;
- thc63->bridge.funcs = &thc63_bridge_func;
thc63->bridge.timings = &thc63->timings;
drm_bridge_add(&thc63->bridge);
diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c
index 47638d1c96ec5ad999604c8c7e8839ff85936d98..b07f7c9d5890967a6db7bb01a9695abc809babbd 100644
--- a/drivers/gpu/drm/bridge/ti-dlpc3433.c
+++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c
@@ -348,9 +348,10 @@ static int dlpc3433_probe(struct i2c_client *client)
struct dlpc *dlpc;
int ret;
- dlpc = devm_kzalloc(dev, sizeof(*dlpc), GFP_KERNEL);
- if (!dlpc)
- return -ENOMEM;
+ dlpc = devm_drm_bridge_alloc(dev, struct dlpc, bridge,
+ &dlpc_bridge_funcs);
+ if (IS_ERR(dlpc))
+ return PTR_ERR(dlpc);
dlpc->dev = dev;
@@ -365,7 +366,6 @@ static int dlpc3433_probe(struct i2c_client *client)
dev_set_drvdata(dev, dlpc);
i2c_set_clientdata(client, dlpc);
- dlpc->bridge.funcs = &dlpc_bridge_funcs;
dlpc->bridge.of_node = dev->of_node;
drm_bridge_add(&dlpc->bridge);
diff --git a/drivers/gpu/drm/bridge/ti-tdp158.c b/drivers/gpu/drm/bridge/ti-tdp158.c
index cca75443f0121e39527a6cecf711eff2c0d507b5..27053d020df7c6fabbd5ce631b46c3f2358f12b2 100644
--- a/drivers/gpu/drm/bridge/ti-tdp158.c
+++ b/drivers/gpu/drm/bridge/ti-tdp158.c
@@ -68,9 +68,10 @@ static int tdp158_probe(struct i2c_client *client)
struct tdp158 *tdp158;
struct device *dev = &client->dev;
- tdp158 = devm_kzalloc(dev, sizeof(*tdp158), GFP_KERNEL);
- if (!tdp158)
- return -ENOMEM;
+ tdp158 = devm_drm_bridge_alloc(dev, struct tdp158, bridge,
+ &tdp158_bridge_funcs);
+ if (IS_ERR(tdp158))
+ return PTR_ERR(tdp158);
tdp158->next = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
if (IS_ERR(tdp158->next))
@@ -89,7 +90,6 @@ static int tdp158_probe(struct i2c_client *client)
return dev_err_probe(dev, PTR_ERR(tdp158->enable), "enable");
tdp158->bridge.of_node = dev->of_node;
- tdp158->bridge.funcs = &tdp158_bridge_funcs;
tdp158->bridge.driver_private = tdp158;
tdp158->dev = dev;
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index e15d232ddbac55c6f5f966471a6c63f9c29a06c1..549e8e8edeb4f2f27d86a86fa0312e727380ecd9 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -341,14 +341,14 @@ static int tfp410_init(struct device *dev, bool i2c)
return -ENXIO;
}
- dvi = devm_kzalloc(dev, sizeof(*dvi), GFP_KERNEL);
- if (!dvi)
- return -ENOMEM;
+ dvi = devm_drm_bridge_alloc(dev, struct tfp410, bridge,
+ &tfp410_bridge_funcs);
+ if (IS_ERR(dvi))
+ return PTR_ERR(dvi);
dvi->dev = dev;
dev_set_drvdata(dev, dvi);
- dvi->bridge.funcs = &tfp410_bridge_funcs;
dvi->bridge.of_node = dev->of_node;
dvi->bridge.timings = &dvi->timings;
dvi->bridge.type = DRM_MODE_CONNECTOR_DVID;
diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c
index 1c289051a5987e0aec4c286ef4c01ee1a2f9421f..0919364e80d1f69b95a99e76daa915bee0b43d45 100644
--- a/drivers/gpu/drm/bridge/ti-tpd12s015.c
+++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c
@@ -116,13 +116,13 @@ static int tpd12s015_probe(struct platform_device *pdev)
struct gpio_desc *gpio;
int ret;
- tpd = devm_kzalloc(&pdev->dev, sizeof(*tpd), GFP_KERNEL);
- if (!tpd)
- return -ENOMEM;
+ tpd = devm_drm_bridge_alloc(&pdev->dev, struct tpd12s015_device,
+ bridge, &tpd12s015_bridge_funcs);
+ if (IS_ERR(tpd))
+ return PTR_ERR(tpd);
platform_set_drvdata(pdev, tpd);
- tpd->bridge.funcs = &tpd12s015_bridge_funcs;
tpd->bridge.of_node = pdev->dev.of_node;
tpd->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
tpd->bridge.ops = DRM_BRIDGE_OP_DETECT;
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index b2408abb9d491bf25773d4dcc1be73c89cf208ce..bb80686a70e17dc79daa724b44e781a81ce4de85 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2725,9 +2725,10 @@ static int mtk_dp_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
int ret;
- mtk_dp = devm_kzalloc(dev, sizeof(*mtk_dp), GFP_KERNEL);
- if (!mtk_dp)
- return -ENOMEM;
+ mtk_dp = devm_drm_bridge_alloc(dev, struct mtk_dp, bridge,
+ &mtk_dp_bridge_funcs);
+ if (IS_ERR(mtk_dp))
+ return PTR_ERR(mtk_dp);
mtk_dp->dev = dev;
mtk_dp->data = (struct mtk_dp_data *)of_device_get_match_data(dev);
@@ -2785,7 +2786,6 @@ static int mtk_dp_probe(struct platform_device *pdev)
if (ret)
return ret;
- mtk_dp->bridge.funcs = &mtk_dp_bridge_funcs;
mtk_dp->bridge.of_node = dev->of_node;
mtk_dp->bridge.type = mtk_dp->data->bridge_type;
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 0f3b1ef8e497354edaf0a56e24660bf356fe01ac..9669bf4b80a14086159ae245ed51dd587b514bfb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -1179,9 +1179,10 @@ static int mtk_dpi_probe(struct platform_device *pdev)
struct mtk_dpi *dpi;
int ret;
- dpi = devm_kzalloc(dev, sizeof(*dpi), GFP_KERNEL);
- if (!dpi)
- return -ENOMEM;
+ dpi = devm_drm_bridge_alloc(dev, struct mtk_dpi, bridge,
+ &mtk_dpi_bridge_funcs);
+ if (IS_ERR(dpi))
+ return PTR_ERR(dpi);
dpi->dev = dev;
dpi->conf = (struct mtk_dpi_conf *)of_device_get_match_data(dev);
@@ -1233,7 +1234,6 @@ static int mtk_dpi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dpi);
- dpi->bridge.funcs = &mtk_dpi_bridge_funcs;
dpi->bridge.of_node = dev->of_node;
dpi->bridge.type = DRM_MODE_CONNECTOR_DPI;
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 4fe1f38a3c4b7fcbbdbf7f6a82f66c9e2b546c02..d7726091819c4762698b41060b3d4d8d27940238 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1196,9 +1196,10 @@ static int mtk_dsi_probe(struct platform_device *pdev)
int irq_num;
int ret;
- dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(dev, struct mtk_dsi, bridge,
+ &mtk_dsi_bridge_funcs);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
dsi->driver_data = of_device_get_match_data(dev);
@@ -1246,7 +1247,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dsi);
- dsi->bridge.funcs = &mtk_dsi_bridge_funcs;
dsi->bridge.of_node = dev->of_node;
dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index c9d0c335c519d405d480ffdc2feaa5b847c0e1bb..76aecad116bad23384db438ee2649f5f0b31ae50 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1690,9 +1690,10 @@ static int mtk_hdmi_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
int ret;
- hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
- if (!hdmi)
- return -ENOMEM;
+ hdmi = devm_drm_bridge_alloc(dev, struct mtk_hdmi, bridge,
+ &mtk_hdmi_bridge_funcs);
+ if (IS_ERR(hdmi))
+ return PTR_ERR(hdmi);
hdmi->dev = dev;
hdmi->conf = of_device_get_match_data(dev);
@@ -1719,7 +1720,6 @@ static int mtk_hdmi_probe(struct platform_device *pdev)
return dev_err_probe(dev, ret,
"Failed to register audio driver\n");
- hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
hdmi->bridge.of_node = pdev->dev.of_node;
hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
| DRM_BRIDGE_OP_HPD;
diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
index c9678dc68fa142882e2beb24fe81185fbdef733b..dc374bfc5951c0f13fc28f44325aa845ab590056 100644
--- a/drivers/gpu/drm/meson/meson_encoder_cvbs.c
+++ b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
@@ -227,9 +227,12 @@ int meson_encoder_cvbs_probe(struct meson_drm *priv)
struct device_node *remote;
int ret;
- meson_encoder_cvbs = devm_kzalloc(priv->dev, sizeof(*meson_encoder_cvbs), GFP_KERNEL);
- if (!meson_encoder_cvbs)
- return -ENOMEM;
+ meson_encoder_cvbs = devm_drm_bridge_alloc(priv->dev,
+ struct meson_encoder_cvbs,
+ bridge,
+ &meson_encoder_cvbs_bridge_funcs);
+ if (IS_ERR(meson_encoder_cvbs))
+ return PTR_ERR(meson_encoder_cvbs);
/* CVBS Connector Bridge */
remote = of_graph_get_remote_node(priv->dev->of_node, 0, 0);
@@ -245,7 +248,6 @@ int meson_encoder_cvbs_probe(struct meson_drm *priv)
"Failed to find CVBS Connector bridge\n");
/* CVBS Encoder Bridge */
- meson_encoder_cvbs->bridge.funcs = &meson_encoder_cvbs_bridge_funcs;
meson_encoder_cvbs->bridge.of_node = priv->dev->of_node;
meson_encoder_cvbs->bridge.type = DRM_MODE_CONNECTOR_Composite;
meson_encoder_cvbs->bridge.ops = DRM_BRIDGE_OP_MODES;
diff --git a/drivers/gpu/drm/meson/meson_encoder_dsi.c b/drivers/gpu/drm/meson/meson_encoder_dsi.c
index 3db518e5f95d324c218b730e0948c3dc845382bd..6c6624f9ba24a182900215d65b3ad7ab8aab6cf8 100644
--- a/drivers/gpu/drm/meson/meson_encoder_dsi.c
+++ b/drivers/gpu/drm/meson/meson_encoder_dsi.c
@@ -106,9 +106,12 @@ int meson_encoder_dsi_probe(struct meson_drm *priv)
struct device_node *remote;
int ret;
- meson_encoder_dsi = devm_kzalloc(priv->dev, sizeof(*meson_encoder_dsi), GFP_KERNEL);
- if (!meson_encoder_dsi)
- return -ENOMEM;
+ meson_encoder_dsi = devm_drm_bridge_alloc(priv->dev,
+ struct meson_encoder_dsi,
+ bridge,
+ &meson_encoder_dsi_bridge_funcs);
+ if (IS_ERR(meson_encoder_dsi))
+ return PTR_ERR(meson_encoder_dsi);
/* DSI Transceiver Bridge */
remote = of_graph_get_remote_node(priv->dev->of_node, 2, 0);
@@ -123,7 +126,6 @@ int meson_encoder_dsi_probe(struct meson_drm *priv)
"Failed to find DSI transceiver bridge\n");
/* DSI Encoder Bridge */
- meson_encoder_dsi->bridge.funcs = &meson_encoder_dsi_bridge_funcs;
meson_encoder_dsi->bridge.of_node = priv->dev->of_node;
meson_encoder_dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
index 040c04b5dff9f0d4e2875e344c076bb8ab635c76..5a0d37a257f53c22165fad1a32e3c7522b8dd7f1 100644
--- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
@@ -376,9 +376,12 @@ int meson_encoder_hdmi_probe(struct meson_drm *priv)
struct device_node *remote;
int ret;
- meson_encoder_hdmi = devm_kzalloc(priv->dev, sizeof(*meson_encoder_hdmi), GFP_KERNEL);
- if (!meson_encoder_hdmi)
- return -ENOMEM;
+ meson_encoder_hdmi = devm_drm_bridge_alloc(priv->dev,
+ struct meson_encoder_hdmi,
+ bridge,
+ &meson_encoder_hdmi_bridge_funcs);
+ if (IS_ERR(meson_encoder_hdmi))
+ return PTR_ERR(meson_encoder_hdmi);
/* HDMI Transceiver Bridge */
remote = of_graph_get_remote_node(priv->dev->of_node, 1, 0);
@@ -395,7 +398,6 @@ int meson_encoder_hdmi_probe(struct meson_drm *priv)
}
/* HDMI Encoder Bridge */
- meson_encoder_hdmi->bridge.funcs = &meson_encoder_hdmi_bridge_funcs;
meson_encoder_hdmi->bridge.of_node = priv->dev->of_node;
meson_encoder_hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
meson_encoder_hdmi->bridge.interlace_allowed = true;
diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c b/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
index a9145253294fcaef6bae4e1406a781f6d710d357..af58b814e5887f2e231338c1d87feedf4db5e754 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
@@ -878,9 +878,10 @@ static int rcar_lvds_probe(struct platform_device *pdev)
struct rcar_lvds *lvds;
int ret;
- lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
- if (lvds == NULL)
- return -ENOMEM;
+ lvds = devm_drm_bridge_alloc(&pdev->dev, struct rcar_lvds, bridge,
+ &rcar_lvds_bridge_ops);
+ if (IS_ERR(lvds))
+ return PTR_ERR(lvds);
platform_set_drvdata(pdev, lvds);
@@ -895,7 +896,6 @@ static int rcar_lvds_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- lvds->bridge.funcs = &rcar_lvds_bridge_ops;
lvds->bridge.of_node = pdev->dev.of_node;
lvds->mmio = devm_platform_ioremap_resource(pdev, 0);
diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
index dc6ab012cdb69f92a33da69638aef3fc6fdfa46c..8ba0dde8d48227944263159313e184e581d9cb58 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
@@ -701,9 +701,10 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
u32 txsetr;
int ret;
- dsi = devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(&pdev->dev, struct rzg2l_mipi_dsi, bridge,
+ &rzg2l_mipi_dsi_bridge_ops);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
platform_set_drvdata(pdev, dsi);
dsi->dev = &pdev->dev;
@@ -761,7 +762,6 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
pm_runtime_put(dsi->dev);
/* Initialize the DRM bridge. */
- dsi->bridge.funcs = &rzg2l_mipi_dsi_bridge_ops;
dsi->bridge.of_node = dsi->dev->of_node;
/* Init host device */
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API Luca Ceresoli
@ 2025-05-10 8:43 ` Maxime Ripard
2025-05-25 19:40 ` Adam Ford
1 sibling, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:43 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Jagan Teki, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Liu Ying, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan
[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]
On Fri, May 09, 2025 at 03:53:28PM +0200, Luca Ceresoli wrote:
> devm_drm_bridge_alloc() is the new API to be used for allocating (and
> partially initializing) a private driver struct embedding a struct
> drm_bridge.
>
> For many drivers having a simple code flow in the probe function, this
> commit does a mass conversion automatically with the following semantic
> patch. The changes have been reviewed manually for correctness as well as
> to find any false positives.
>
> The patch has been applied with the explicit exclusion of bridge/panel.c,
> handled by a separate patch.
>
> After applying the semantic patch, manually fixed these issues:
>
> - 4 drivers need ERR_CAST() instead of PTR_ERR() as the function calling
> devm_drm_bridge_alloc() returns a pointer
> - re-added empty lines and comments that the script had removed but that
> should stay
>
> @@
> type T;
> identifier C;
> identifier BR;
> expression DEV;
> expression FUNCS;
> @@
> -T *C;
> +T *C;
> ...
> (
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return -ENOMEM;
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> |
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return ERR_PTR(-ENOMEM);
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> )
> ...
> -C->BR.funcs = FUNCS;
>
> Reviewed-by: Manikandan Muralidharan <manikandan.m@microchip.com> # microchip-lvds.c
> Reviewed-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
> Tested-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API Luca Ceresoli
2025-05-10 8:43 ` Maxime Ripard
@ 2025-05-25 19:40 ` Adam Ford
2025-05-27 9:27 ` Luca Ceresoli
1 sibling, 1 reply; 55+ messages in thread
From: Adam Ford @ 2025-05-25 19:40 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Manikandan Muralidharan,
Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Liu Ying, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan
On Fri, May 9, 2025 at 8:56 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> devm_drm_bridge_alloc() is the new API to be used for allocating (and
> partially initializing) a private driver struct embedding a struct
> drm_bridge.
>
> For many drivers having a simple code flow in the probe function, this
> commit does a mass conversion automatically with the following semantic
> patch. The changes have been reviewed manually for correctness as well as
> to find any false positives.
>
> The patch has been applied with the explicit exclusion of bridge/panel.c,
> handled by a separate patch.
>
> After applying the semantic patch, manually fixed these issues:
>
> - 4 drivers need ERR_CAST() instead of PTR_ERR() as the function calling
> devm_drm_bridge_alloc() returns a pointer
> - re-added empty lines and comments that the script had removed but that
> should stay
>
> @@
> type T;
> identifier C;
> identifier BR;
> expression DEV;
> expression FUNCS;
> @@
> -T *C;
> +T *C;
> ...
> (
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return -ENOMEM;
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> |
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return ERR_PTR(-ENOMEM);
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> )
> ...
> -C->BR.funcs = FUNCS;
>
> Reviewed-by: Manikandan Muralidharan <manikandan.m@microchip.com> # microchip-lvds.c
> Reviewed-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
> Tested-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Adrien Grassein <adrien.grassein@gmail.com>
> Cc: Aleksandr Mishin <amishin@t-argos.ru>
> Cc: Andy Yan <andy.yan@rock-chips.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Christoph Fritz <chf.fritz@googlemail.com>
> Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Cc: Detlev Casanova <detlev.casanova@collabora.com>
> Cc: Dharma Balasubiramani <dharma.b@microchip.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Janne Grunau <j@jannau.net>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Jesse Van Gavere <jesseevg@gmail.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Manikandan Muralidharan <manikandan.m@microchip.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Phong LE <ple@baylibre.com>
> Cc: Sasha Finkelstein <fnkl.kernel@gmail.com>
> Cc: Sugar Zhang <sugar.zhang@rock-chips.com>
> Cc: Sui Jingfeng <sui.jingfeng@linux.dev>
> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Cc: Vitalii Mordan <mordan@ispras.ru>
>
> Changed in v3:
> - manually replaced PTR_ERR() with ERR_CAST() in the 4 cases where the
> return value is not int
> - manually added empty lines and comments that the spatch had removed
> inappropriately
> - improved commit message
>
> Changed in v2:
> - added missing PTR_ERR() in the second spatch alternative
> ---
> drivers/gpu/drm/adp/adp-mipi.c | 8 ++++----
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 8 ++++----
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ++++-----
> drivers/gpu/drm/bridge/aux-bridge.c | 8 ++++----
> drivers/gpu/drm/bridge/aux-hpd-bridge.c | 9 +++++----
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 8 ++++----
> drivers/gpu/drm/bridge/chipone-icn6211.c | 8 ++++----
> drivers/gpu/drm/bridge/chrontel-ch7033.c | 8 ++++----
> drivers/gpu/drm/bridge/cros-ec-anx7688.c | 8 ++++----
> drivers/gpu/drm/bridge/fsl-ldb.c | 7 +++----
> drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 8 ++++----
> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 8 ++++----
For: imx8mp-hdmi-pvi.c and adv7511_drv.c
Tested-by: Adam Ford <aford173@gmail.com> #imx8mp-beacon-kit
> drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 8 ++++----
> drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 8 ++++----
> drivers/gpu/drm/bridge/ite-it6263.c | 8 ++++----
> drivers/gpu/drm/bridge/ite-it6505.c | 8 ++++----
> drivers/gpu/drm/bridge/ite-it66121.c | 8 ++++----
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 8 ++++----
> drivers/gpu/drm/bridge/lontium-lt9211.c | 7 +++----
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 ++++----
> drivers/gpu/drm/bridge/lvds-codec.c | 9 ++++-----
> drivers/gpu/drm/bridge/microchip-lvds.c | 8 ++++----
> drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++++----
> drivers/gpu/drm/bridge/parade-ps8622.c | 8 ++++----
> drivers/gpu/drm/bridge/parade-ps8640.c | 8 ++++----
> drivers/gpu/drm/bridge/sii9234.c | 8 ++++----
> drivers/gpu/drm/bridge/sil-sii8620.c | 8 ++++----
> drivers/gpu/drm/bridge/simple-bridge.c | 8 ++++----
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 8 ++++----
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++++----
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 8 ++++----
> drivers/gpu/drm/bridge/tc358762.c | 8 ++++----
> drivers/gpu/drm/bridge/tc358764.c | 8 ++++----
> drivers/gpu/drm/bridge/tc358768.c | 8 ++++----
> drivers/gpu/drm/bridge/tc358775.c | 8 ++++----
> drivers/gpu/drm/bridge/thc63lvd1024.c | 8 ++++----
> drivers/gpu/drm/bridge/ti-dlpc3433.c | 8 ++++----
> drivers/gpu/drm/bridge/ti-tdp158.c | 8 ++++----
> drivers/gpu/drm/bridge/ti-tfp410.c | 8 ++++----
> drivers/gpu/drm/bridge/ti-tpd12s015.c | 8 ++++----
> drivers/gpu/drm/mediatek/mtk_dp.c | 8 ++++----
> drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++++----
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++----
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 ++++----
> drivers/gpu/drm/meson/meson_encoder_cvbs.c | 10 ++++++----
> drivers/gpu/drm/meson/meson_encoder_dsi.c | 10 ++++++----
> drivers/gpu/drm/meson/meson_encoder_hdmi.c | 10 ++++++----
> drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 8 ++++----
> drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 8 ++++----
> 49 files changed, 201 insertions(+), 198 deletions(-)
>
> diff --git a/drivers/gpu/drm/adp/adp-mipi.c b/drivers/gpu/drm/adp/adp-mipi.c
> index 2b60128e2c693e9f85affff569cc57cdb6f47909..cba7d32150a98d78d07a25b1822dec6bf2f08f65 100644
> --- a/drivers/gpu/drm/adp/adp-mipi.c
> +++ b/drivers/gpu/drm/adp/adp-mipi.c
> @@ -229,9 +229,10 @@ static int adp_mipi_probe(struct platform_device *pdev)
> {
> struct adp_mipi_drv_private *adp;
>
> - adp = devm_kzalloc(&pdev->dev, sizeof(*adp), GFP_KERNEL);
> - if (!adp)
> - return -ENOMEM;
> + adp = devm_drm_bridge_alloc(&pdev->dev, struct adp_mipi_drv_private,
> + bridge, &adp_dsi_bridge_funcs);
> + if (IS_ERR(adp))
> + return PTR_ERR(adp);
>
> adp->mipi = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adp->mipi)) {
> @@ -241,7 +242,6 @@ static int adp_mipi_probe(struct platform_device *pdev)
>
> adp->dsi.dev = &pdev->dev;
> adp->dsi.ops = &adp_dsi_host_ops;
> - adp->bridge.funcs = &adp_dsi_bridge_funcs;
> adp->bridge.of_node = pdev->dev.of_node;
> adp->bridge.type = DRM_MODE_CONNECTOR_DSI;
> dev_set_drvdata(&pdev->dev, adp);
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 1257009e850c1b20184cfaea5b6a4440e75e10d7..8d7b007ea203d0d8be8f5b145f8531e23294dacc 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1224,9 +1224,10 @@ static int adv7511_probe(struct i2c_client *i2c)
> if (!dev->of_node)
> return -EINVAL;
>
> - adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL);
> - if (!adv7511)
> - return -ENOMEM;
> + adv7511 = devm_drm_bridge_alloc(dev, struct adv7511, bridge,
> + &adv7511_bridge_funcs);
> + if (IS_ERR(adv7511))
> + return PTR_ERR(adv7511);
>
> adv7511->i2c_main = i2c;
> adv7511->powered = false;
> @@ -1327,7 +1328,6 @@ static int adv7511_probe(struct i2c_client *i2c)
> if (ret)
> goto err_unregister_cec;
>
> - adv7511->bridge.funcs = &adv7511_bridge_funcs;
> adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
> if (adv7511->i2c_main->irq)
> adv7511->bridge.ops |= DRM_BRIDGE_OP_HPD;
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> index a83020d6576f78372056069947783a626acf64b1..ba0fc149a9e722a53da6027a851bf62262ba64b2 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> @@ -1193,9 +1193,10 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
> bool found = false;
> int err;
>
> - anx78xx = devm_kzalloc(&client->dev, sizeof(*anx78xx), GFP_KERNEL);
> - if (!anx78xx)
> - return -ENOMEM;
> + anx78xx = devm_drm_bridge_alloc(&client->dev, struct anx78xx, bridge,
> + &anx78xx_bridge_funcs);
> + if (IS_ERR(anx78xx))
> + return PTR_ERR(anx78xx);
>
> pdata = &anx78xx->pdata;
>
> @@ -1306,8 +1307,6 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
> goto err_poweroff;
> }
>
> - anx78xx->bridge.funcs = &anx78xx_bridge_funcs;
> -
> drm_bridge_add(&anx78xx->bridge);
>
> /* If cable is pulled out, just poweroff and wait for HPD event */
> diff --git a/drivers/gpu/drm/bridge/aux-bridge.c b/drivers/gpu/drm/bridge/aux-bridge.c
> index c179b86d208f70d95b41e6f2157b78f97bac4d8d..5b219e3b87b1df9fc4aaf2c8a6e78bac8f894628 100644
> --- a/drivers/gpu/drm/bridge/aux-bridge.c
> +++ b/drivers/gpu/drm/bridge/aux-bridge.c
> @@ -109,9 +109,10 @@ static int drm_aux_bridge_probe(struct auxiliary_device *auxdev,
> {
> struct drm_aux_bridge_data *data;
>
> - data = devm_kzalloc(&auxdev->dev, sizeof(*data), GFP_KERNEL);
> - if (!data)
> - return -ENOMEM;
> + data = devm_drm_bridge_alloc(&auxdev->dev, struct drm_aux_bridge_data,
> + bridge, &drm_aux_bridge_funcs);
> + if (IS_ERR(data))
> + return PTR_ERR(data);
>
> data->dev = &auxdev->dev;
> data->next_bridge = devm_drm_of_get_bridge(&auxdev->dev, auxdev->dev.of_node, 0, 0);
> @@ -119,7 +120,6 @@ static int drm_aux_bridge_probe(struct auxiliary_device *auxdev,
> return dev_err_probe(&auxdev->dev, PTR_ERR(data->next_bridge),
> "failed to acquire drm_bridge\n");
>
> - data->bridge.funcs = &drm_aux_bridge_funcs;
> data->bridge.of_node = data->dev->of_node;
>
> /* passthrough data, allow everything */
> diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
> index b3f588b71a7d7ad5c2ee7b07c39079bc5ba34cee..3eb411f874e41b322f732649bd2074c5d8422566 100644
> --- a/drivers/gpu/drm/bridge/aux-hpd-bridge.c
> +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
> @@ -171,12 +171,13 @@ static int drm_aux_hpd_bridge_probe(struct auxiliary_device *auxdev,
> {
> struct drm_aux_hpd_bridge_data *data;
>
> - data = devm_kzalloc(&auxdev->dev, sizeof(*data), GFP_KERNEL);
> - if (!data)
> - return -ENOMEM;
> + data = devm_drm_bridge_alloc(&auxdev->dev,
> + struct drm_aux_hpd_bridge_data, bridge,
> + &drm_aux_hpd_bridge_funcs);
> + if (IS_ERR(data))
> + return PTR_ERR(data);
>
> data->dev = &auxdev->dev;
> - data->bridge.funcs = &drm_aux_hpd_bridge_funcs;
> data->bridge.of_node = dev_get_platdata(data->dev);
> data->bridge.ops = DRM_BRIDGE_OP_HPD;
> data->bridge.type = id->driver_data;
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> index b431e7efd1f0d749320ea15b6f1f5ca13fc72800..cb5f5a8c539a471290df8435d4c2e3ed696b38d4 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> @@ -2389,9 +2389,10 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
> int ret;
> int irq;
>
> - mhdp = devm_kzalloc(dev, sizeof(*mhdp), GFP_KERNEL);
> - if (!mhdp)
> - return -ENOMEM;
> + mhdp = devm_drm_bridge_alloc(dev, struct cdns_mhdp_device, bridge,
> + &cdns_mhdp_bridge_funcs);
> + if (IS_ERR(mhdp))
> + return PTR_ERR(mhdp);
>
> clk = devm_clk_get_enabled(dev, NULL);
> if (IS_ERR(clk)) {
> @@ -2481,7 +2482,6 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
> mhdp->display_fmt.bpc = 8;
>
> mhdp->bridge.of_node = pdev->dev.of_node;
> - mhdp->bridge.funcs = &cdns_mhdp_bridge_funcs;
> mhdp->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
> DRM_BRIDGE_OP_HPD;
> mhdp->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index 634c5b0306679d2e68798c2b9013aae4491dd44c..814713c5bea97dcdc2b847d2f266a567ef40e981 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -691,9 +691,10 @@ static int chipone_common_probe(struct device *dev, struct chipone **icnr)
> struct chipone *icn;
> int ret;
>
> - icn = devm_kzalloc(dev, sizeof(struct chipone), GFP_KERNEL);
> - if (!icn)
> - return -ENOMEM;
> + icn = devm_drm_bridge_alloc(dev, struct chipone, bridge,
> + &chipone_bridge_funcs);
> + if (IS_ERR(icn))
> + return PTR_ERR(icn);
>
> icn->dev = dev;
>
> @@ -701,7 +702,6 @@ static int chipone_common_probe(struct device *dev, struct chipone **icnr)
> if (ret)
> return ret;
>
> - icn->bridge.funcs = &chipone_bridge_funcs;
> icn->bridge.type = DRM_MODE_CONNECTOR_DPI;
> icn->bridge.of_node = dev->of_node;
>
> diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c
> index 210c45c1efd48f5b541bf73da66a169c27e110b2..ab92747933568bfba77da45219e019408029f297 100644
> --- a/drivers/gpu/drm/bridge/chrontel-ch7033.c
> +++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c
> @@ -536,9 +536,10 @@ static int ch7033_probe(struct i2c_client *client)
> unsigned int val;
> int ret;
>
> - priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv)
> - return -ENOMEM;
> + priv = devm_drm_bridge_alloc(dev, struct ch7033_priv, bridge,
> + &ch7033_bridge_funcs);
> + if (IS_ERR(priv))
> + return PTR_ERR(priv);
>
> dev_set_drvdata(dev, priv);
>
> @@ -575,7 +576,6 @@ static int ch7033_probe(struct i2c_client *client)
> }
>
> INIT_LIST_HEAD(&priv->bridge.list);
> - priv->bridge.funcs = &ch7033_bridge_funcs;
> priv->bridge.of_node = dev->of_node;
> drm_bridge_add(&priv->bridge);
>
> diff --git a/drivers/gpu/drm/bridge/cros-ec-anx7688.c b/drivers/gpu/drm/bridge/cros-ec-anx7688.c
> index c8abd9920fee956cf049bcb09827d658b7939333..a35dae9b56e247d43cac317d8bf1f904d5e7435e 100644
> --- a/drivers/gpu/drm/bridge/cros-ec-anx7688.c
> +++ b/drivers/gpu/drm/bridge/cros-ec-anx7688.c
> @@ -103,9 +103,10 @@ static int cros_ec_anx7688_bridge_probe(struct i2c_client *client)
> u8 buffer[4];
> int ret;
>
> - anx7688 = devm_kzalloc(dev, sizeof(*anx7688), GFP_KERNEL);
> - if (!anx7688)
> - return -ENOMEM;
> + anx7688 = devm_drm_bridge_alloc(dev, struct cros_ec_anx7688, bridge,
> + &cros_ec_anx7688_bridge_funcs);
> + if (IS_ERR(anx7688))
> + return PTR_ERR(anx7688);
>
> anx7688->client = client;
> i2c_set_clientdata(client, anx7688);
> @@ -153,7 +154,6 @@ static int cros_ec_anx7688_bridge_probe(struct i2c_client *client)
> DRM_WARN("Old ANX7688 FW version (0x%04x), not filtering\n",
> fw_version);
>
> - anx7688->bridge.funcs = &cros_ec_anx7688_bridge_funcs;
> drm_bridge_add(&anx7688->bridge);
>
> return 0;
> diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
> index 2cb6dfc7a6d3dbdd620a35345204f8fb9cae6651..5c3cf37200bcee1db285c97e2b463c9355ee6acb 100644
> --- a/drivers/gpu/drm/bridge/fsl-ldb.c
> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
> @@ -298,16 +298,15 @@ static int fsl_ldb_probe(struct platform_device *pdev)
> struct fsl_ldb *fsl_ldb;
> int dual_link;
>
> - fsl_ldb = devm_kzalloc(dev, sizeof(*fsl_ldb), GFP_KERNEL);
> - if (!fsl_ldb)
> - return -ENOMEM;
> + fsl_ldb = devm_drm_bridge_alloc(dev, struct fsl_ldb, bridge, &funcs);
> + if (IS_ERR(fsl_ldb))
> + return PTR_ERR(fsl_ldb);
>
> fsl_ldb->devdata = of_device_get_match_data(dev);
> if (!fsl_ldb->devdata)
> return -EINVAL;
>
> fsl_ldb->dev = &pdev->dev;
> - fsl_ldb->bridge.funcs = &funcs;
> fsl_ldb->bridge.of_node = dev->of_node;
>
> fsl_ldb->clk = devm_clk_get(dev, "ldb");
> diff --git a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
> index f072c6ed39ef183b10518b43bd6d979bc89e36f9..989bc497b05071af2a92c750d907addcfe783858 100644
> --- a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
> +++ b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
> @@ -59,9 +59,10 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
> struct imx_legacy_bridge *imx_bridge;
> int ret;
>
> - imx_bridge = devm_kzalloc(dev, sizeof(*imx_bridge), GFP_KERNEL);
> - if (!imx_bridge)
> - return ERR_PTR(-ENOMEM);
> + imx_bridge = devm_drm_bridge_alloc(dev, struct imx_legacy_bridge,
> + base, &imx_legacy_bridge_funcs);
> + if (IS_ERR(imx_bridge))
> + return ERR_CAST(imx_bridge);
>
> ret = of_get_drm_display_mode(np,
> &imx_bridge->mode,
> @@ -72,7 +73,6 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
>
> imx_bridge->mode.type |= DRM_MODE_TYPE_DRIVER;
>
> - imx_bridge->base.funcs = &imx_legacy_bridge_funcs;
> imx_bridge->base.of_node = np;
> imx_bridge->base.ops = DRM_BRIDGE_OP_MODES;
> imx_bridge->base.type = type;
> diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> index 8a4fd7d77a8d516b3b46f41cf07d2633d23bde12..3a6f8587a257c3ceacefbed1b37024289617b7c1 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> @@ -140,9 +140,10 @@ static int imx8mp_hdmi_pvi_probe(struct platform_device *pdev)
> struct device_node *remote;
> struct imx8mp_hdmi_pvi *pvi;
>
> - pvi = devm_kzalloc(&pdev->dev, sizeof(*pvi), GFP_KERNEL);
> - if (!pvi)
> - return -ENOMEM;
> + pvi = devm_drm_bridge_alloc(&pdev->dev, struct imx8mp_hdmi_pvi,
> + bridge, &imx_hdmi_pvi_bridge_funcs);
> + if (IS_ERR(pvi))
> + return PTR_ERR(pvi);
>
> platform_set_drvdata(pdev, pvi);
> pvi->dev = &pdev->dev;
> @@ -166,7 +167,6 @@ static int imx8mp_hdmi_pvi_probe(struct platform_device *pdev)
> pm_runtime_enable(&pdev->dev);
>
> /* Register the bridge. */
> - pvi->bridge.funcs = &imx_hdmi_pvi_bridge_funcs;
> pvi->bridge.of_node = pdev->dev.of_node;
> pvi->bridge.timings = pvi->next_bridge->timings;
>
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
> index e092c9ea99b0224802919ff84b448acb53508951..e5943506981dfb8f113c94ad52ddbba52e00ec3f 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
> @@ -327,9 +327,10 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
> struct device_node *np = dev->of_node;
> int ret;
>
> - pl = devm_kzalloc(dev, sizeof(*pl), GFP_KERNEL);
> - if (!pl)
> - return -ENOMEM;
> + pl = devm_drm_bridge_alloc(dev, struct imx8qxp_pixel_link, bridge,
> + &imx8qxp_pixel_link_bridge_funcs);
> + if (IS_ERR(pl))
> + return PTR_ERR(pl);
>
> ret = imx_scu_get_handle(&pl->ipc_handle);
> if (ret) {
> @@ -384,7 +385,6 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, pl);
>
> pl->bridge.driver_private = pl;
> - pl->bridge.funcs = &imx8qxp_pixel_link_bridge_funcs;
> pl->bridge.of_node = np;
>
> drm_bridge_add(&pl->bridge);
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> index da138ab51b3bd2c6ebd3780c09818891d5320092..111310acab2ce403a62a47ecbe9d9dd372c75ecd 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> @@ -392,9 +392,10 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
> struct device_node *np = dev->of_node;
> int ret;
>
> - p2d = devm_kzalloc(dev, sizeof(*p2d), GFP_KERNEL);
> - if (!p2d)
> - return -ENOMEM;
> + p2d = devm_drm_bridge_alloc(dev, struct imx8qxp_pxl2dpi, bridge,
> + &imx8qxp_pxl2dpi_bridge_funcs);
> + if (IS_ERR(p2d))
> + return PTR_ERR(p2d);
>
> p2d->regmap = syscon_node_to_regmap(np->parent);
> if (IS_ERR(p2d->regmap)) {
> @@ -441,7 +442,6 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
> pm_runtime_enable(dev);
>
> p2d->bridge.driver_private = p2d;
> - p2d->bridge.funcs = &imx8qxp_pxl2dpi_bridge_funcs;
> p2d->bridge.of_node = np;
>
> drm_bridge_add(&p2d->bridge);
> diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
> index a3a63a977b0a8487ad38fc08e0eed08672f4d41a..c4eedf643f39e9b91efeb5a6214bf2fe6f2c040a 100644
> --- a/drivers/gpu/drm/bridge/ite-it6263.c
> +++ b/drivers/gpu/drm/bridge/ite-it6263.c
> @@ -816,9 +816,10 @@ static int it6263_probe(struct i2c_client *client)
> struct it6263 *it;
> int ret;
>
> - it = devm_kzalloc(dev, sizeof(*it), GFP_KERNEL);
> - if (!it)
> - return -ENOMEM;
> + it = devm_drm_bridge_alloc(dev, struct it6263, bridge,
> + &it6263_bridge_funcs);
> + if (IS_ERR(it))
> + return PTR_ERR(it);
>
> it->dev = dev;
> it->hdmi_i2c = client;
> @@ -866,7 +867,6 @@ static int it6263_probe(struct i2c_client *client)
>
> i2c_set_clientdata(client, it);
>
> - it->bridge.funcs = &it6263_bridge_funcs;
> it->bridge.of_node = dev->of_node;
> /* IT6263 chip doesn't support HPD interrupt. */
> it->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 1383d1e21afea1acb46b7bd28860908b58832dbc..b0dc9280d870c4864d43984999238e8a34bf47df 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -3583,9 +3583,10 @@ static int it6505_i2c_probe(struct i2c_client *client)
> struct extcon_dev *extcon;
> int err;
>
> - it6505 = devm_kzalloc(&client->dev, sizeof(*it6505), GFP_KERNEL);
> - if (!it6505)
> - return -ENOMEM;
> + it6505 = devm_drm_bridge_alloc(&client->dev, struct it6505, bridge,
> + &it6505_bridge_funcs);
> + if (IS_ERR(it6505))
> + return PTR_ERR(it6505);
>
> mutex_init(&it6505->extcon_lock);
> mutex_init(&it6505->mode_lock);
> @@ -3660,7 +3661,6 @@ static int it6505_i2c_probe(struct i2c_client *client)
> it6505->aux.transfer = it6505_aux_transfer;
> drm_dp_aux_init(&it6505->aux);
>
> - it6505->bridge.funcs = &it6505_bridge_funcs;
> it6505->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
> it6505->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
> DRM_BRIDGE_OP_HPD;
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 7b110ae532918d2d6f91ebc5f747c38e7e77dc07..6494f0842793829b7658b330338767e5b38a1115 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1516,9 +1516,10 @@ static int it66121_probe(struct i2c_client *client)
> return -ENXIO;
> }
>
> - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct it66121_ctx, bridge,
> + &it66121_bridge_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
> if (!ep)
> @@ -1577,7 +1578,6 @@ static int it66121_probe(struct i2c_client *client)
> return -ENODEV;
> }
>
> - ctx->bridge.funcs = &it66121_bridge_funcs;
> ctx->bridge.of_node = dev->of_node;
> ctx->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> ctx->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> index 3e49d855b3648880cea9bce5f3f04fbb6f838a45..bd83228b0f0eb49062ee84f62f8ae50b78bbfb0e 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -761,9 +761,10 @@ static int lt8912_probe(struct i2c_client *client)
> int ret = 0;
> struct device *dev = &client->dev;
>
> - lt = devm_kzalloc(dev, sizeof(struct lt8912), GFP_KERNEL);
> - if (!lt)
> - return -ENOMEM;
> + lt = devm_drm_bridge_alloc(dev, struct lt8912, bridge,
> + <8912_bridge_funcs);
> + if (IS_ERR(lt))
> + return PTR_ERR(lt);
>
> lt->dev = dev;
> lt->i2c_client[0] = client;
> @@ -778,7 +779,6 @@ static int lt8912_probe(struct i2c_client *client)
>
> i2c_set_clientdata(client, lt);
>
> - lt->bridge.funcs = <8912_bridge_funcs;
> lt->bridge.of_node = dev->of_node;
> lt->bridge.ops = (DRM_BRIDGE_OP_EDID |
> DRM_BRIDGE_OP_DETECT);
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9211.c b/drivers/gpu/drm/bridge/lontium-lt9211.c
> index 9b2dac9bd63c5afd4ffbafafdbbb1230549bc36f..399fa7eebd49cc3fe9e812517fc3e8ed25004086 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9211.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9211.c
> @@ -727,9 +727,9 @@ static int lt9211_probe(struct i2c_client *client)
> struct lt9211 *ctx;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct lt9211, bridge, <9211_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> ctx->dev = dev;
>
> @@ -755,7 +755,6 @@ static int lt9211_probe(struct i2c_client *client)
> dev_set_drvdata(dev, ctx);
> i2c_set_clientdata(client, ctx);
>
> - ctx->bridge.funcs = <9211_funcs;
> ctx->bridge.of_node = dev->of_node;
> drm_bridge_add(&ctx->bridge);
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index a35a8b8ca89c2cc138a7cb4de01c796c6211d655..d6ee79c1e42771174ee01f17448f1a8fff70b63f 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1072,9 +1072,10 @@ static int lt9611_probe(struct i2c_client *client)
> return -ENODEV;
> }
>
> - lt9611 = devm_kzalloc(dev, sizeof(*lt9611), GFP_KERNEL);
> - if (!lt9611)
> - return -ENOMEM;
> + lt9611 = devm_drm_bridge_alloc(dev, struct lt9611, bridge,
> + <9611_bridge_funcs);
> + if (IS_ERR(lt9611))
> + return PTR_ERR(lt9611);
>
> lt9611->dev = dev;
> lt9611->client = client;
> @@ -1127,7 +1128,6 @@ static int lt9611_probe(struct i2c_client *client)
> /* Disable Audio InfoFrame, enabled by default */
> regmap_update_bits(lt9611->regmap, 0x843d, LT9611_INFOFRAME_AUDIO, 0);
>
> - lt9611->bridge.funcs = <9611_bridge_funcs;
> lt9611->bridge.of_node = client->dev.of_node;
> lt9611->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
> DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_MODES |
> diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
> index 1646e454e0b0b558d00f9421f15bb7084e2aa45a..e6a7147e141b64fc77dfef03a737ee599a0ecd10 100644
> --- a/drivers/gpu/drm/bridge/lvds-codec.c
> +++ b/drivers/gpu/drm/bridge/lvds-codec.c
> @@ -118,9 +118,10 @@ static int lvds_codec_probe(struct platform_device *pdev)
> u32 val;
> int ret;
>
> - lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
> - if (!lvds_codec)
> - return -ENOMEM;
> + lvds_codec = devm_drm_bridge_alloc(dev, struct lvds_codec, bridge,
> + &funcs);
> + if (IS_ERR(lvds_codec))
> + return PTR_ERR(lvds_codec);
>
> lvds_codec->dev = &pdev->dev;
> lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
> @@ -156,8 +157,6 @@ static int lvds_codec_probe(struct platform_device *pdev)
> if (IS_ERR(lvds_codec->panel_bridge))
> return PTR_ERR(lvds_codec->panel_bridge);
>
> - lvds_codec->bridge.funcs = &funcs;
> -
> /*
> * Decoder input LVDS format is a property of the decoder chip or even
> * its strapping. Handle data-mapping the same way lvds-panel does. In
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index 1d4ae0097df847d9f93c79eecff0c4587ae331ba..9f4ff82bc6b49010f8727da3b367f5a744a28edc 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -157,9 +157,10 @@ static int mchp_lvds_probe(struct platform_device *pdev)
> if (!dev->of_node)
> return -ENODEV;
>
> - lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
> - if (!lvds)
> - return -ENOMEM;
> + lvds = devm_drm_bridge_alloc(&pdev->dev, struct mchp_lvds, bridge,
> + &mchp_lvds_bridge_funcs);
> + if (IS_ERR(lvds))
> + return PTR_ERR(lvds);
>
> lvds->dev = dev;
>
> @@ -192,7 +193,6 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>
> lvds->bridge.of_node = dev->of_node;
> lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS;
> - lvds->bridge.funcs = &mchp_lvds_bridge_funcs;
>
> dev_set_drvdata(dev, lvds);
> ret = devm_pm_runtime_enable(dev);
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index 55912ae11f46a1d551e11f93a306a8a00ef3f7d8..2f7429b24fc20db104dec17182f1119c6c75e600 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -1149,9 +1149,10 @@ static int nwl_dsi_probe(struct platform_device *pdev)
> struct nwl_dsi *dsi;
> int ret;
>
> - dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
> - if (!dsi)
> - return -ENOMEM;
> + dsi = devm_drm_bridge_alloc(dev, struct nwl_dsi, bridge,
> + &nwl_dsi_bridge_funcs);
> + if (IS_ERR(dsi))
> + return PTR_ERR(dsi);
>
> dsi->dev = dev;
>
> @@ -1180,7 +1181,6 @@ static int nwl_dsi_probe(struct platform_device *pdev)
> dsi->quirks = (uintptr_t)attr->data;
>
> dsi->bridge.driver_private = dsi;
> - dsi->bridge.funcs = &nwl_dsi_bridge_funcs;
> dsi->bridge.of_node = dev->of_node;
> dsi->bridge.timings = &nwl_dsi_timings;
> dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 8726fefc5c654e49bce029d943d241789ca4f802..f879a1df077d25d0c5121e51aa067f511a41a9bd 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -449,9 +449,10 @@ static int ps8622_probe(struct i2c_client *client)
> struct drm_bridge *panel_bridge;
> int ret;
>
> - ps8622 = devm_kzalloc(dev, sizeof(*ps8622), GFP_KERNEL);
> - if (!ps8622)
> - return -ENOMEM;
> + ps8622 = devm_drm_bridge_alloc(dev, struct ps8622_bridge, bridge,
> + &ps8622_bridge_funcs);
> + if (IS_ERR(ps8622))
> + return PTR_ERR(ps8622);
>
> panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0);
> if (IS_ERR(panel_bridge))
> @@ -509,7 +510,6 @@ static int ps8622_probe(struct i2c_client *client)
> ps8622->bl->props.brightness = PS8622_MAX_BRIGHTNESS;
> }
>
> - ps8622->bridge.funcs = &ps8622_bridge_funcs;
> ps8622->bridge.type = DRM_MODE_CONNECTOR_LVDS;
> ps8622->bridge.of_node = dev->of_node;
> drm_bridge_add(&ps8622->bridge);
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 2422ff68c1042bd8eaa6821ff387d4faad47c550..825777a5758f67b5bdaa5f9de2e0e4f597f0f7a4 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -636,9 +636,10 @@ static int ps8640_probe(struct i2c_client *client)
> int ret;
> u32 i;
>
> - ps_bridge = devm_kzalloc(dev, sizeof(*ps_bridge), GFP_KERNEL);
> - if (!ps_bridge)
> - return -ENOMEM;
> + ps_bridge = devm_drm_bridge_alloc(dev, struct ps8640, bridge,
> + &ps8640_bridge_funcs);
> + if (IS_ERR(ps_bridge))
> + return PTR_ERR(ps_bridge);
>
> mutex_init(&ps_bridge->aux_lock);
>
> @@ -662,7 +663,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (IS_ERR(ps_bridge->gpio_reset))
> return PTR_ERR(ps_bridge->gpio_reset);
>
> - ps_bridge->bridge.funcs = &ps8640_bridge_funcs;
> ps_bridge->bridge.of_node = dev->of_node;
> ps_bridge->bridge.type = DRM_MODE_CONNECTOR_eDP;
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index cd7837c9a6e00b572a3fb65e5e0c9fa884555a73..bb1bed03eb5b7ae67f752c0d593dc54131e9e370 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -888,9 +888,10 @@ static int sii9234_probe(struct i2c_client *client)
> struct device *dev = &client->dev;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct sii9234, bridge,
> + &sii9234_bridge_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> ctx->dev = dev;
> mutex_init(&ctx->lock);
> @@ -921,7 +922,6 @@ static int sii9234_probe(struct i2c_client *client)
>
> i2c_set_clientdata(client, ctx);
>
> - ctx->bridge.funcs = &sii9234_bridge_funcs;
> ctx->bridge.of_node = dev->of_node;
> drm_bridge_add(&ctx->bridge);
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 3af650dc92a1612ca88fe378319519546b79901f..9e48ad39e1cc995768d767c27b8116d7baa2f47e 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -2291,9 +2291,10 @@ static int sii8620_probe(struct i2c_client *client)
> struct sii8620 *ctx;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct sii8620, bridge,
> + &sii8620_bridge_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> ctx->dev = dev;
> mutex_init(&ctx->lock);
> @@ -2336,7 +2337,6 @@ static int sii8620_probe(struct i2c_client *client)
>
> i2c_set_clientdata(client, ctx);
>
> - ctx->bridge.funcs = &sii8620_bridge_funcs;
> ctx->bridge.of_node = dev->of_node;
> drm_bridge_add(&ctx->bridge);
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 70db5b99e5bb84f099ec54cf62abbda53475311d..c66bd913e33ae311a980251348199889ef5b99af 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -168,9 +168,10 @@ static int simple_bridge_probe(struct platform_device *pdev)
> struct simple_bridge *sbridge;
> struct device_node *remote;
>
> - sbridge = devm_kzalloc(&pdev->dev, sizeof(*sbridge), GFP_KERNEL);
> - if (!sbridge)
> - return -ENOMEM;
> + sbridge = devm_drm_bridge_alloc(&pdev->dev, struct simple_bridge,
> + bridge, &simple_bridge_bridge_funcs);
> + if (IS_ERR(sbridge))
> + return PTR_ERR(sbridge);
>
> sbridge->info = of_device_get_match_data(&pdev->dev);
>
> @@ -204,7 +205,6 @@ static int simple_bridge_probe(struct platform_device *pdev)
> "Unable to retrieve enable GPIO\n");
>
> /* Register the bridge. */
> - sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
> sbridge->bridge.of_node = pdev->dev.of_node;
> sbridge->bridge.timings = sbridge->info->timings;
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> index 5e5f8c2f95be1f5c4633f1093b17a00f9425bb37..94dddaf49b3c1fa115f376e5cf1c2f515f2594ea 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> @@ -1045,9 +1045,10 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
> return ERR_PTR(-ENODEV);
> }
>
> - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
> - if (!hdmi)
> - return ERR_PTR(-ENOMEM);
> + hdmi = devm_drm_bridge_alloc(dev, struct dw_hdmi_qp, bridge,
> + &dw_hdmi_qp_bridge_funcs);
> + if (IS_ERR(hdmi))
> + return ERR_CAST(hdmi);
>
> hdmi->dev = dev;
>
> @@ -1073,7 +1074,6 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
> return ERR_PTR(ret);
>
> hdmi->bridge.driver_private = hdmi;
> - hdmi->bridge.funcs = &dw_hdmi_qp_bridge_funcs;
> hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT |
> DRM_BRIDGE_OP_EDID |
> DRM_BRIDGE_OP_HDMI |
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index b08ada920a501d6a62f39581944a87019f5e5c15..c0dc0f2976b92f5a4eb2416de8f510ec7214e562 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1194,9 +1194,10 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> struct dw_mipi_dsi *dsi;
> int ret;
>
> - dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
> - if (!dsi)
> - return ERR_PTR(-ENOMEM);
> + dsi = devm_drm_bridge_alloc(dev, struct dw_mipi_dsi, bridge,
> + &dw_mipi_dsi_bridge_funcs);
> + if (IS_ERR(dsi))
> + return ERR_CAST(dsi);
>
> dsi->dev = dev;
> dsi->plat_data = plat_data;
> @@ -1265,7 +1266,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> }
>
> dsi->bridge.driver_private = dsi;
> - dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
> dsi->bridge.of_node = pdev->dev.of_node;
>
> return dsi;
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
> index c76f5f2e74d14bd372f969c6c7832aa57f80772b..fc91aca95d126ae37726ccd939fdc8657151ca81 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c
> @@ -914,9 +914,10 @@ __dw_mipi_dsi2_probe(struct platform_device *pdev,
> struct dw_mipi_dsi2 *dsi2;
> int ret;
>
> - dsi2 = devm_kzalloc(dev, sizeof(*dsi2), GFP_KERNEL);
> - if (!dsi2)
> - return ERR_PTR(-ENOMEM);
> + dsi2 = devm_drm_bridge_alloc(dev, struct dw_mipi_dsi2, bridge,
> + &dw_mipi_dsi2_bridge_funcs);
> + if (IS_ERR(dsi2))
> + return ERR_CAST(dsi2);
>
> dsi2->dev = dev;
> dsi2->plat_data = plat_data;
> @@ -981,7 +982,6 @@ __dw_mipi_dsi2_probe(struct platform_device *pdev,
> }
>
> dsi2->bridge.driver_private = dsi2;
> - dsi2->bridge.funcs = &dw_mipi_dsi2_bridge_funcs;
> dsi2->bridge.of_node = pdev->dev.of_node;
>
> return dsi2;
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index edf01476f2ef6e05ef2c144ff4467e7f6babc4c6..98df3e667d4aac48c19c82c8bc9e116b36a4cec8 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -265,9 +265,10 @@ static int tc358762_probe(struct mipi_dsi_device *dsi)
> struct tc358762 *ctx;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(struct tc358762), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct tc358762, bridge,
> + &tc358762_bridge_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> mipi_dsi_set_drvdata(dsi, ctx);
>
> @@ -288,7 +289,6 @@ static int tc358762_probe(struct mipi_dsi_device *dsi)
> if (ret < 0)
> return ret;
>
> - ctx->bridge.funcs = &tc358762_bridge_funcs;
> ctx->bridge.type = DRM_MODE_CONNECTOR_DPI;
> ctx->bridge.of_node = dev->of_node;
> ctx->bridge.pre_enable_prev_first = true;
> diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
> index 3f76c890fad9ffa50dc02f289a37378332830516..084e9d898e226ecfa618a3c91c0786d2f83fa51b 100644
> --- a/drivers/gpu/drm/bridge/tc358764.c
> +++ b/drivers/gpu/drm/bridge/tc358764.c
> @@ -347,9 +347,10 @@ static int tc358764_probe(struct mipi_dsi_device *dsi)
> struct tc358764 *ctx;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(struct tc358764), GFP_KERNEL);
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_bridge_alloc(dev, struct tc358764, bridge,
> + &tc358764_bridge_funcs);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> mipi_dsi_set_drvdata(dsi, ctx);
>
> @@ -368,7 +369,6 @@ static int tc358764_probe(struct mipi_dsi_device *dsi)
> if (ret < 0)
> return ret;
>
> - ctx->bridge.funcs = &tc358764_bridge_funcs;
> ctx->bridge.of_node = dev->of_node;
> ctx->bridge.pre_enable_prev_first = true;
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 063f217a17b6cf32e9793b8a96a5ac6128584098..fbdc44e162293f2f9b090bc956604184a2a406b2 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -1287,9 +1287,10 @@ static int tc358768_i2c_probe(struct i2c_client *client)
> if (!np)
> return -ENODEV;
>
> - priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv)
> - return -ENOMEM;
> + priv = devm_drm_bridge_alloc(dev, struct tc358768_priv, bridge,
> + &tc358768_bridge_funcs);
> + if (IS_ERR(priv))
> + return PTR_ERR(priv);
>
> dev_set_drvdata(dev, priv);
> priv->dev = dev;
> @@ -1321,7 +1322,6 @@ static int tc358768_i2c_probe(struct i2c_client *client)
> priv->dsi_host.dev = dev;
> priv->dsi_host.ops = &tc358768_dsi_host_ops;
>
> - priv->bridge.funcs = &tc358768_bridge_funcs;
> priv->bridge.timings = &default_tc358768_timings;
> priv->bridge.of_node = np;
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> index 1b10e6ee1724ffb4bb8946f86d2f18e53428381a..366b12db0e7cbfb45b3dfc2a83a7af580cfde41f 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -659,9 +659,10 @@ static int tc_probe(struct i2c_client *client)
> struct tc_data *tc;
> int ret;
>
> - tc = devm_kzalloc(dev, sizeof(*tc), GFP_KERNEL);
> - if (!tc)
> - return -ENOMEM;
> + tc = devm_drm_bridge_alloc(dev, struct tc_data, bridge,
> + &tc_bridge_funcs);
> + if (IS_ERR(tc))
> + return PTR_ERR(tc);
>
> tc->dev = dev;
> tc->i2c = client;
> @@ -701,7 +702,6 @@ static int tc_probe(struct i2c_client *client)
> return ret;
> }
>
> - tc->bridge.funcs = &tc_bridge_funcs;
> tc->bridge.of_node = dev->of_node;
> tc->bridge.pre_enable_prev_first = true;
> drm_bridge_add(&tc->bridge);
> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
> index e2fc78adebcf22f0d8cdb484078e37b748b776c6..2cb7cd0c060824256bbfa511f833cc00437d318b 100644
> --- a/drivers/gpu/drm/bridge/thc63lvd1024.c
> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
> @@ -181,9 +181,10 @@ static int thc63_probe(struct platform_device *pdev)
> struct thc63_dev *thc63;
> int ret;
>
> - thc63 = devm_kzalloc(&pdev->dev, sizeof(*thc63), GFP_KERNEL);
> - if (!thc63)
> - return -ENOMEM;
> + thc63 = devm_drm_bridge_alloc(&pdev->dev, struct thc63_dev, bridge,
> + &thc63_bridge_func);
> + if (IS_ERR(thc63))
> + return PTR_ERR(thc63);
>
> thc63->dev = &pdev->dev;
> platform_set_drvdata(pdev, thc63);
> @@ -208,7 +209,6 @@ static int thc63_probe(struct platform_device *pdev)
>
> thc63->bridge.driver_private = thc63;
> thc63->bridge.of_node = pdev->dev.of_node;
> - thc63->bridge.funcs = &thc63_bridge_func;
> thc63->bridge.timings = &thc63->timings;
>
> drm_bridge_add(&thc63->bridge);
> diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c
> index 47638d1c96ec5ad999604c8c7e8839ff85936d98..b07f7c9d5890967a6db7bb01a9695abc809babbd 100644
> --- a/drivers/gpu/drm/bridge/ti-dlpc3433.c
> +++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c
> @@ -348,9 +348,10 @@ static int dlpc3433_probe(struct i2c_client *client)
> struct dlpc *dlpc;
> int ret;
>
> - dlpc = devm_kzalloc(dev, sizeof(*dlpc), GFP_KERNEL);
> - if (!dlpc)
> - return -ENOMEM;
> + dlpc = devm_drm_bridge_alloc(dev, struct dlpc, bridge,
> + &dlpc_bridge_funcs);
> + if (IS_ERR(dlpc))
> + return PTR_ERR(dlpc);
>
> dlpc->dev = dev;
>
> @@ -365,7 +366,6 @@ static int dlpc3433_probe(struct i2c_client *client)
> dev_set_drvdata(dev, dlpc);
> i2c_set_clientdata(client, dlpc);
>
> - dlpc->bridge.funcs = &dlpc_bridge_funcs;
> dlpc->bridge.of_node = dev->of_node;
> drm_bridge_add(&dlpc->bridge);
>
> diff --git a/drivers/gpu/drm/bridge/ti-tdp158.c b/drivers/gpu/drm/bridge/ti-tdp158.c
> index cca75443f0121e39527a6cecf711eff2c0d507b5..27053d020df7c6fabbd5ce631b46c3f2358f12b2 100644
> --- a/drivers/gpu/drm/bridge/ti-tdp158.c
> +++ b/drivers/gpu/drm/bridge/ti-tdp158.c
> @@ -68,9 +68,10 @@ static int tdp158_probe(struct i2c_client *client)
> struct tdp158 *tdp158;
> struct device *dev = &client->dev;
>
> - tdp158 = devm_kzalloc(dev, sizeof(*tdp158), GFP_KERNEL);
> - if (!tdp158)
> - return -ENOMEM;
> + tdp158 = devm_drm_bridge_alloc(dev, struct tdp158, bridge,
> + &tdp158_bridge_funcs);
> + if (IS_ERR(tdp158))
> + return PTR_ERR(tdp158);
>
> tdp158->next = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
> if (IS_ERR(tdp158->next))
> @@ -89,7 +90,6 @@ static int tdp158_probe(struct i2c_client *client)
> return dev_err_probe(dev, PTR_ERR(tdp158->enable), "enable");
>
> tdp158->bridge.of_node = dev->of_node;
> - tdp158->bridge.funcs = &tdp158_bridge_funcs;
> tdp158->bridge.driver_private = tdp158;
> tdp158->dev = dev;
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index e15d232ddbac55c6f5f966471a6c63f9c29a06c1..549e8e8edeb4f2f27d86a86fa0312e727380ecd9 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -341,14 +341,14 @@ static int tfp410_init(struct device *dev, bool i2c)
> return -ENXIO;
> }
>
> - dvi = devm_kzalloc(dev, sizeof(*dvi), GFP_KERNEL);
> - if (!dvi)
> - return -ENOMEM;
> + dvi = devm_drm_bridge_alloc(dev, struct tfp410, bridge,
> + &tfp410_bridge_funcs);
> + if (IS_ERR(dvi))
> + return PTR_ERR(dvi);
>
> dvi->dev = dev;
> dev_set_drvdata(dev, dvi);
>
> - dvi->bridge.funcs = &tfp410_bridge_funcs;
> dvi->bridge.of_node = dev->of_node;
> dvi->bridge.timings = &dvi->timings;
> dvi->bridge.type = DRM_MODE_CONNECTOR_DVID;
> diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c
> index 1c289051a5987e0aec4c286ef4c01ee1a2f9421f..0919364e80d1f69b95a99e76daa915bee0b43d45 100644
> --- a/drivers/gpu/drm/bridge/ti-tpd12s015.c
> +++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c
> @@ -116,13 +116,13 @@ static int tpd12s015_probe(struct platform_device *pdev)
> struct gpio_desc *gpio;
> int ret;
>
> - tpd = devm_kzalloc(&pdev->dev, sizeof(*tpd), GFP_KERNEL);
> - if (!tpd)
> - return -ENOMEM;
> + tpd = devm_drm_bridge_alloc(&pdev->dev, struct tpd12s015_device,
> + bridge, &tpd12s015_bridge_funcs);
> + if (IS_ERR(tpd))
> + return PTR_ERR(tpd);
>
> platform_set_drvdata(pdev, tpd);
>
> - tpd->bridge.funcs = &tpd12s015_bridge_funcs;
> tpd->bridge.of_node = pdev->dev.of_node;
> tpd->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> tpd->bridge.ops = DRM_BRIDGE_OP_DETECT;
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
> index b2408abb9d491bf25773d4dcc1be73c89cf208ce..bb80686a70e17dc79daa724b44e781a81ce4de85 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2725,9 +2725,10 @@ static int mtk_dp_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> int ret;
>
> - mtk_dp = devm_kzalloc(dev, sizeof(*mtk_dp), GFP_KERNEL);
> - if (!mtk_dp)
> - return -ENOMEM;
> + mtk_dp = devm_drm_bridge_alloc(dev, struct mtk_dp, bridge,
> + &mtk_dp_bridge_funcs);
> + if (IS_ERR(mtk_dp))
> + return PTR_ERR(mtk_dp);
>
> mtk_dp->dev = dev;
> mtk_dp->data = (struct mtk_dp_data *)of_device_get_match_data(dev);
> @@ -2785,7 +2786,6 @@ static int mtk_dp_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - mtk_dp->bridge.funcs = &mtk_dp_bridge_funcs;
> mtk_dp->bridge.of_node = dev->of_node;
> mtk_dp->bridge.type = mtk_dp->data->bridge_type;
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 0f3b1ef8e497354edaf0a56e24660bf356fe01ac..9669bf4b80a14086159ae245ed51dd587b514bfb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -1179,9 +1179,10 @@ static int mtk_dpi_probe(struct platform_device *pdev)
> struct mtk_dpi *dpi;
> int ret;
>
> - dpi = devm_kzalloc(dev, sizeof(*dpi), GFP_KERNEL);
> - if (!dpi)
> - return -ENOMEM;
> + dpi = devm_drm_bridge_alloc(dev, struct mtk_dpi, bridge,
> + &mtk_dpi_bridge_funcs);
> + if (IS_ERR(dpi))
> + return PTR_ERR(dpi);
>
> dpi->dev = dev;
> dpi->conf = (struct mtk_dpi_conf *)of_device_get_match_data(dev);
> @@ -1233,7 +1234,6 @@ static int mtk_dpi_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dpi);
>
> - dpi->bridge.funcs = &mtk_dpi_bridge_funcs;
> dpi->bridge.of_node = dev->of_node;
> dpi->bridge.type = DRM_MODE_CONNECTOR_DPI;
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4fe1f38a3c4b7fcbbdbf7f6a82f66c9e2b546c02..d7726091819c4762698b41060b3d4d8d27940238 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1196,9 +1196,10 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> int irq_num;
> int ret;
>
> - dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
> - if (!dsi)
> - return -ENOMEM;
> + dsi = devm_drm_bridge_alloc(dev, struct mtk_dsi, bridge,
> + &mtk_dsi_bridge_funcs);
> + if (IS_ERR(dsi))
> + return PTR_ERR(dsi);
>
> dsi->driver_data = of_device_get_match_data(dev);
>
> @@ -1246,7 +1247,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dsi);
>
> - dsi->bridge.funcs = &mtk_dsi_bridge_funcs;
> dsi->bridge.of_node = dev->of_node;
> dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index c9d0c335c519d405d480ffdc2feaa5b847c0e1bb..76aecad116bad23384db438ee2649f5f0b31ae50 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1690,9 +1690,10 @@ static int mtk_hdmi_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> int ret;
>
> - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
> - if (!hdmi)
> - return -ENOMEM;
> + hdmi = devm_drm_bridge_alloc(dev, struct mtk_hdmi, bridge,
> + &mtk_hdmi_bridge_funcs);
> + if (IS_ERR(hdmi))
> + return PTR_ERR(hdmi);
>
> hdmi->dev = dev;
> hdmi->conf = of_device_get_match_data(dev);
> @@ -1719,7 +1720,6 @@ static int mtk_hdmi_probe(struct platform_device *pdev)
> return dev_err_probe(dev, ret,
> "Failed to register audio driver\n");
>
> - hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
> hdmi->bridge.of_node = pdev->dev.of_node;
> hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> | DRM_BRIDGE_OP_HPD;
> diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> index c9678dc68fa142882e2beb24fe81185fbdef733b..dc374bfc5951c0f13fc28f44325aa845ab590056 100644
> --- a/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> +++ b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> @@ -227,9 +227,12 @@ int meson_encoder_cvbs_probe(struct meson_drm *priv)
> struct device_node *remote;
> int ret;
>
> - meson_encoder_cvbs = devm_kzalloc(priv->dev, sizeof(*meson_encoder_cvbs), GFP_KERNEL);
> - if (!meson_encoder_cvbs)
> - return -ENOMEM;
> + meson_encoder_cvbs = devm_drm_bridge_alloc(priv->dev,
> + struct meson_encoder_cvbs,
> + bridge,
> + &meson_encoder_cvbs_bridge_funcs);
> + if (IS_ERR(meson_encoder_cvbs))
> + return PTR_ERR(meson_encoder_cvbs);
>
> /* CVBS Connector Bridge */
> remote = of_graph_get_remote_node(priv->dev->of_node, 0, 0);
> @@ -245,7 +248,6 @@ int meson_encoder_cvbs_probe(struct meson_drm *priv)
> "Failed to find CVBS Connector bridge\n");
>
> /* CVBS Encoder Bridge */
> - meson_encoder_cvbs->bridge.funcs = &meson_encoder_cvbs_bridge_funcs;
> meson_encoder_cvbs->bridge.of_node = priv->dev->of_node;
> meson_encoder_cvbs->bridge.type = DRM_MODE_CONNECTOR_Composite;
> meson_encoder_cvbs->bridge.ops = DRM_BRIDGE_OP_MODES;
> diff --git a/drivers/gpu/drm/meson/meson_encoder_dsi.c b/drivers/gpu/drm/meson/meson_encoder_dsi.c
> index 3db518e5f95d324c218b730e0948c3dc845382bd..6c6624f9ba24a182900215d65b3ad7ab8aab6cf8 100644
> --- a/drivers/gpu/drm/meson/meson_encoder_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_encoder_dsi.c
> @@ -106,9 +106,12 @@ int meson_encoder_dsi_probe(struct meson_drm *priv)
> struct device_node *remote;
> int ret;
>
> - meson_encoder_dsi = devm_kzalloc(priv->dev, sizeof(*meson_encoder_dsi), GFP_KERNEL);
> - if (!meson_encoder_dsi)
> - return -ENOMEM;
> + meson_encoder_dsi = devm_drm_bridge_alloc(priv->dev,
> + struct meson_encoder_dsi,
> + bridge,
> + &meson_encoder_dsi_bridge_funcs);
> + if (IS_ERR(meson_encoder_dsi))
> + return PTR_ERR(meson_encoder_dsi);
>
> /* DSI Transceiver Bridge */
> remote = of_graph_get_remote_node(priv->dev->of_node, 2, 0);
> @@ -123,7 +126,6 @@ int meson_encoder_dsi_probe(struct meson_drm *priv)
> "Failed to find DSI transceiver bridge\n");
>
> /* DSI Encoder Bridge */
> - meson_encoder_dsi->bridge.funcs = &meson_encoder_dsi_bridge_funcs;
> meson_encoder_dsi->bridge.of_node = priv->dev->of_node;
> meson_encoder_dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
>
> diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> index 040c04b5dff9f0d4e2875e344c076bb8ab635c76..5a0d37a257f53c22165fad1a32e3c7522b8dd7f1 100644
> --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> @@ -376,9 +376,12 @@ int meson_encoder_hdmi_probe(struct meson_drm *priv)
> struct device_node *remote;
> int ret;
>
> - meson_encoder_hdmi = devm_kzalloc(priv->dev, sizeof(*meson_encoder_hdmi), GFP_KERNEL);
> - if (!meson_encoder_hdmi)
> - return -ENOMEM;
> + meson_encoder_hdmi = devm_drm_bridge_alloc(priv->dev,
> + struct meson_encoder_hdmi,
> + bridge,
> + &meson_encoder_hdmi_bridge_funcs);
> + if (IS_ERR(meson_encoder_hdmi))
> + return PTR_ERR(meson_encoder_hdmi);
>
> /* HDMI Transceiver Bridge */
> remote = of_graph_get_remote_node(priv->dev->of_node, 1, 0);
> @@ -395,7 +398,6 @@ int meson_encoder_hdmi_probe(struct meson_drm *priv)
> }
>
> /* HDMI Encoder Bridge */
> - meson_encoder_hdmi->bridge.funcs = &meson_encoder_hdmi_bridge_funcs;
> meson_encoder_hdmi->bridge.of_node = priv->dev->of_node;
> meson_encoder_hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> meson_encoder_hdmi->bridge.interlace_allowed = true;
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c b/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
> index a9145253294fcaef6bae4e1406a781f6d710d357..af58b814e5887f2e231338c1d87feedf4db5e754 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c
> @@ -878,9 +878,10 @@ static int rcar_lvds_probe(struct platform_device *pdev)
> struct rcar_lvds *lvds;
> int ret;
>
> - lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
> - if (lvds == NULL)
> - return -ENOMEM;
> + lvds = devm_drm_bridge_alloc(&pdev->dev, struct rcar_lvds, bridge,
> + &rcar_lvds_bridge_ops);
> + if (IS_ERR(lvds))
> + return PTR_ERR(lvds);
>
> platform_set_drvdata(pdev, lvds);
>
> @@ -895,7 +896,6 @@ static int rcar_lvds_probe(struct platform_device *pdev)
> if (ret < 0)
> return ret;
>
> - lvds->bridge.funcs = &rcar_lvds_bridge_ops;
> lvds->bridge.of_node = pdev->dev.of_node;
>
> lvds->mmio = devm_platform_ioremap_resource(pdev, 0);
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> index dc6ab012cdb69f92a33da69638aef3fc6fdfa46c..8ba0dde8d48227944263159313e184e581d9cb58 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> @@ -701,9 +701,10 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
> u32 txsetr;
> int ret;
>
> - dsi = devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL);
> - if (!dsi)
> - return -ENOMEM;
> + dsi = devm_drm_bridge_alloc(&pdev->dev, struct rzg2l_mipi_dsi, bridge,
> + &rzg2l_mipi_dsi_bridge_ops);
> + if (IS_ERR(dsi))
> + return PTR_ERR(dsi);
>
> platform_set_drvdata(pdev, dsi);
> dsi->dev = &pdev->dev;
> @@ -761,7 +762,6 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
> pm_runtime_put(dsi->dev);
>
> /* Initialize the DRM bridge. */
> - dsi->bridge.funcs = &rzg2l_mipi_dsi_bridge_ops;
> dsi->bridge.of_node = dsi->dev->of_node;
>
> /* Init host device */
>
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 55+ messages in thread* Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
2025-05-25 19:40 ` Adam Ford
@ 2025-05-27 9:27 ` Luca Ceresoli
0 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-27 9:27 UTC (permalink / raw)
To: Adam Ford
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Manikandan Muralidharan,
Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Liu Ying, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan
Hello Adam,
On Sun, 25 May 2025 14:40:46 -0500
Adam Ford <aford173@gmail.com> wrote:
> For: imx8mp-hdmi-pvi.c and adv7511_drv.c
>
> Tested-by: Adam Ford <aford173@gmail.com> #imx8mp-beacon-kit
Thanks for your testing, on the v1 as well!
Sadly your Tested-by tag won't be in the commit because the patch had
already been applied, but it is useful per se, and in the records
anyway.
Kind regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
2025-05-09 13:53 ` [PATCH v3 01/22] Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API" Luca Ceresoli
2025-05-09 13:53 ` [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:43 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 04/22] drm/bridge: cdns-dsi: " Luca Ceresoli
` (20 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Rob Herring (Arm), Hsin-Te Yuan, Jani Nikula, Pin-yen Lin,
Sui Jingfeng, Xin Ji
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Hsin-Te Yuan <yuanhsinte@chromium.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Pin-yen Lin <treapking@chromium.org>
Cc: Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 8a9079c2ed5c22565d0733ef899119e347947d21..0ac4a82c5a6e5e665d913674b664905a96c0d8e6 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -2596,7 +2596,6 @@ static int anx7625_link_bridge(struct drm_dp_aux *aux)
return ret;
}
- platform->bridge.funcs = &anx7625_bridge_funcs;
platform->bridge.of_node = dev->of_node;
if (!anx7625_of_panel_on_aux_bus(dev))
platform->bridge.ops |= DRM_BRIDGE_OP_EDID;
@@ -2630,10 +2629,10 @@ static int anx7625_i2c_probe(struct i2c_client *client)
return -ENODEV;
}
- platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
- if (!platform) {
+ platform = devm_drm_bridge_alloc(dev, struct anx7625_data, bridge, &anx7625_bridge_funcs);
+ if (IS_ERR(platform)) {
DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
- return -ENOMEM;
+ return PTR_ERR(platform);
}
pdata = &platform->pdata;
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 03/22] drm/bridge: anx7625: convert " Luca Ceresoli
@ 2025-05-10 8:43 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:43 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Jagan Teki, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Rob Herring (Arm),
Hsin-Te Yuan, Jani Nikula, Pin-yen Lin, Sui Jingfeng, Xin Ji
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
On Fri, May 09, 2025 at 03:53:29PM +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 04/22] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (2 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 03/22] drm/bridge: anx7625: convert " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:44 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Luca Ceresoli
` (19 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Aradhya Bhatia, Tomi Valkeinen
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Aradhya Bhatia <a-bhatia1@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
index b022dd6e6b6e9e43bf11583806e1a8d1e7431ae8..7604574da66606c103cc035dd94b0e211b64ebdc 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
@@ -1289,9 +1289,10 @@ static int cdns_dsi_drm_probe(struct platform_device *pdev)
int ret, irq;
u32 val;
- dsi = devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(&pdev->dev, struct cdns_dsi, input.bridge,
+ &cdns_dsi_bridge_funcs);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
platform_set_drvdata(pdev, dsi);
@@ -1349,7 +1350,6 @@ static int cdns_dsi_drm_probe(struct platform_device *pdev)
* CDNS_DPI_INPUT.
*/
input->id = CDNS_DPI_INPUT;
- input->bridge.funcs = &cdns_dsi_bridge_funcs;
input->bridge.of_node = pdev->dev.of_node;
/* Mask all interrupts before registering the IRQ handler. */
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 04/22] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 04/22] drm/bridge: cdns-dsi: " Luca Ceresoli
@ 2025-05-10 8:44 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:44 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Jagan Teki, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Aradhya Bhatia,
Tomi Valkeinen
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Fri, May 09, 2025 at 03:53:30PM +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (3 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 04/22] drm/bridge: cdns-dsi: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:52 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 06/22] drm/bridge: nxp-ptn3460: " Luca Ceresoli
` (18 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli, Ian Ray,
Martyn Welch, Peter Senna Tschudin
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Ian Ray <ian.ray@gehealthcare.com>
Cc: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>
Changed in v3:
- updated Ian Ray's e-mail (old one is bouncing
Changed in v2: none
---
drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
index 15a5a1f644fc10182c55bc9e489ccb81d4f924f9..81dde9ed7bcf7cacae000d9da31a3a5c347ce037 100644
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
@@ -225,13 +225,11 @@ static int ge_b850v3_lvds_init(struct device *dev)
if (ge_b850v3_lvds_ptr)
goto success;
- ge_b850v3_lvds_ptr = devm_kzalloc(dev,
- sizeof(*ge_b850v3_lvds_ptr),
- GFP_KERNEL);
-
- if (!ge_b850v3_lvds_ptr) {
+ ge_b850v3_lvds_ptr = devm_drm_bridge_alloc(dev, struct ge_b850v3_lvds, bridge,
+ &ge_b850v3_lvds_funcs);
+ if (IS_ERR(ge_b850v3_lvds_ptr)) {
mutex_unlock(&ge_b850v3_lvds_dev_mutex);
- return -ENOMEM;
+ return PTR_ERR(ge_b850v3_lvds_ptr);
}
success:
@@ -264,7 +262,6 @@ static int ge_b850v3_register(void)
struct device *dev = &stdp4028_i2c->dev;
/* drm bridge initialization */
- ge_b850v3_lvds_ptr->bridge.funcs = &ge_b850v3_lvds_funcs;
ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT |
DRM_BRIDGE_OP_EDID;
ge_b850v3_lvds_ptr->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Luca Ceresoli
@ 2025-05-10 8:52 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:52 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Ian Ray, Jagan Teki, Jernej Skrabec,
Jonas Karlman, Krzysztof Kozlowski, Laurent Pinchart,
Maarten Lankhorst, Martyn Welch, Maxime Ripard, Neil Armstrong,
Paul Kocialkowski, Pengutronix Kernel Team, Peter Senna Tschudin,
Robert Foss, Sascha Hauer, Shawn Guo, Simona Vetter,
Thomas Petazzoni, Thomas Zimmermann
On Fri, 9 May 2025 15:53:31 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 06/22] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (4 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:52 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 07/22] drm/bridge: sii902x: " Luca Ceresoli
` (17 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 25d7c415478b14ef634bff4185a8dd8e866be0c6..7acb11f16dc19e87a84cc765b1cebef158662c00 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -261,10 +261,10 @@ static int ptn3460_probe(struct i2c_client *client)
struct drm_bridge *panel_bridge;
int ret;
- ptn_bridge = devm_kzalloc(dev, sizeof(*ptn_bridge), GFP_KERNEL);
- if (!ptn_bridge) {
- return -ENOMEM;
- }
+ ptn_bridge = devm_drm_bridge_alloc(dev, struct ptn3460_bridge, bridge,
+ &ptn3460_bridge_funcs);
+ if (IS_ERR(ptn_bridge))
+ return PTR_ERR(ptn_bridge);
panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0);
if (IS_ERR(panel_bridge))
@@ -300,7 +300,6 @@ static int ptn3460_probe(struct i2c_client *client)
return ret;
}
- ptn_bridge->bridge.funcs = &ptn3460_bridge_funcs;
ptn_bridge->bridge.ops = DRM_BRIDGE_OP_EDID;
ptn_bridge->bridge.type = DRM_MODE_CONNECTOR_LVDS;
ptn_bridge->bridge.of_node = dev->of_node;
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 06/22] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 06/22] drm/bridge: nxp-ptn3460: " Luca Ceresoli
@ 2025-05-10 8:52 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:52 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann
On Fri, 9 May 2025 15:53:32 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 07/22] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (5 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 06/22] drm/bridge: nxp-ptn3460: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:52 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 08/22] drm/omap: dss: dpi: " Luca Ceresoli
` (16 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/bridge/sii902x.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 6de61d9fe06487856e8b3c32db3c8d8c25633fd8..882973e900628c0d972d32cd4ff3588432daa8e9 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1135,7 +1135,6 @@ static int sii902x_init(struct sii902x *sii902x)
if (ret)
goto err_unreg_audio;
- sii902x->bridge.funcs = &sii902x_bridge_funcs;
sii902x->bridge.of_node = dev->of_node;
sii902x->bridge.timings = &default_sii902x_timings;
sii902x->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
@@ -1170,9 +1169,9 @@ static int sii902x_probe(struct i2c_client *client)
return -EIO;
}
- sii902x = devm_kzalloc(dev, sizeof(*sii902x), GFP_KERNEL);
- if (!sii902x)
- return -ENOMEM;
+ sii902x = devm_drm_bridge_alloc(dev, struct sii902x, bridge, &sii902x_bridge_funcs);
+ if (IS_ERR(sii902x))
+ return PTR_ERR(sii902x);
sii902x->i2c = client;
sii902x->regmap = devm_regmap_init_i2c(client, &sii902x_regmap_config);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 07/22] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 07/22] drm/bridge: sii902x: " Luca Ceresoli
@ 2025-05-10 8:52 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:52 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann
On Fri, 9 May 2025 15:53:33 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 08/22] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (6 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 07/22] drm/bridge: sii902x: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:54 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 09/22] drm/omap: dss: dsi: " Luca Ceresoli
` (15 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Rob Herring (Arm), Helge Deller, Kuninori Morimoto,
Tomi Valkeinen
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c
index 6eff97a091602f6d137095b3b7bf54fce17e8d3e..9f86db774c395db7e3396cbf2694748fc23c309d 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
@@ -562,7 +562,6 @@ static const struct drm_bridge_funcs dpi_bridge_funcs = {
static void dpi_bridge_init(struct dpi_data *dpi)
{
- dpi->bridge.funcs = &dpi_bridge_funcs;
dpi->bridge.of_node = dpi->pdev->dev.of_node;
dpi->bridge.type = DRM_MODE_CONNECTOR_DPI;
@@ -707,9 +706,9 @@ int dpi_init_port(struct dss_device *dss, struct platform_device *pdev,
u32 datalines;
int r;
- dpi = devm_kzalloc(&pdev->dev, sizeof(*dpi), GFP_KERNEL);
- if (!dpi)
- return -ENOMEM;
+ dpi = devm_drm_bridge_alloc(&pdev->dev, struct dpi_data, bridge, &dpi_bridge_funcs);
+ if (IS_ERR(dpi))
+ return PTR_ERR(dpi);
ep = of_graph_get_next_port_endpoint(port, NULL);
if (!ep)
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 08/22] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 08/22] drm/omap: dss: dpi: " Luca Ceresoli
@ 2025-05-10 8:54 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:54 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Helge Deller, Hui Pu, Jagan Teki, Jernej Skrabec,
Jonas Karlman, Krzysztof Kozlowski, Kuninori Morimoto,
Laurent Pinchart, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Paul Kocialkowski, Pengutronix Kernel Team,
Rob Herring (Arm), Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann,
Tomi Valkeinen
On Fri, 9 May 2025 15:53:34 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 09/22] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (7 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 08/22] drm/omap: dss: dpi: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:54 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 10/22] drm/omap: dss: hdmi4: " Luca Ceresoli
` (14 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Tomi Valkeinen
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index 91ee63bfe0bc73e28877d0383812225867e167a4..b129e5a8d791507098c7b8d1bc54f54c4b453954 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -4701,7 +4701,6 @@ static const struct drm_bridge_funcs dsi_bridge_funcs = {
static void dsi_bridge_init(struct dsi_data *dsi)
{
- dsi->bridge.funcs = &dsi_bridge_funcs;
dsi->bridge.of_node = dsi->host.dev->of_node;
dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
@@ -4894,9 +4893,9 @@ static int dsi_probe(struct platform_device *pdev)
unsigned int i;
int r;
- dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
- if (!dsi)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(dev, struct dsi_data, bridge, &dsi_bridge_funcs);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
dsi->dev = dev;
dev_set_drvdata(dev, dsi);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 09/22] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 09/22] drm/omap: dss: dsi: " Luca Ceresoli
@ 2025-05-10 8:54 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:54 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann,
Tomi Valkeinen
On Fri, 9 May 2025 15:53:35 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 10/22] drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (8 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 09/22] drm/omap: dss: dsi: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:54 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 11/22] drm/omap: dss: hdmi5: " Luca Ceresoli
` (13 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Tomi Valkeinen
This is the new API for allocating DRM bridges.
Switching from a non-devm to a devm allocation allows removing the kfree()
in the remove function and in the probe error management code, and as a
consequence to simplify the code flow by removing now unnecessary gotos.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index a3b22952fdc32b5899dae82d413108c5c0a1c3c8..3cd612af24498b057c33eaecb3d43c8df76cd23e 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -505,7 +505,6 @@ static const struct drm_bridge_funcs hdmi4_bridge_funcs = {
static void hdmi4_bridge_init(struct omap_hdmi *hdmi)
{
- hdmi->bridge.funcs = &hdmi4_bridge_funcs;
hdmi->bridge.of_node = hdmi->pdev->dev.of_node;
hdmi->bridge.ops = DRM_BRIDGE_OP_EDID;
hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
@@ -761,9 +760,9 @@ static int hdmi4_probe(struct platform_device *pdev)
int irq;
int r;
- hdmi = kzalloc(sizeof(*hdmi), GFP_KERNEL);
- if (!hdmi)
- return -ENOMEM;
+ hdmi = devm_drm_bridge_alloc(&pdev->dev, struct omap_hdmi, bridge, &hdmi4_bridge_funcs);
+ if (IS_ERR(hdmi))
+ return PTR_ERR(hdmi);
hdmi->pdev = pdev;
@@ -774,25 +773,24 @@ static int hdmi4_probe(struct platform_device *pdev)
r = hdmi4_probe_of(hdmi);
if (r)
- goto err_free;
+ return r;
r = hdmi_wp_init(pdev, &hdmi->wp, 4);
if (r)
- goto err_free;
+ return r;
r = hdmi_phy_init(pdev, &hdmi->phy, 4);
if (r)
- goto err_free;
+ return r;
r = hdmi4_core_init(pdev, &hdmi->core);
if (r)
- goto err_free;
+ return r;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
DSSERR("platform_get_irq failed\n");
- r = -ENODEV;
- goto err_free;
+ return -ENODEV;
}
r = devm_request_threaded_irq(&pdev->dev, irq,
@@ -800,7 +798,7 @@ static int hdmi4_probe(struct platform_device *pdev)
IRQF_ONESHOT, "OMAP HDMI", hdmi);
if (r) {
DSSERR("HDMI IRQ request failed\n");
- goto err_free;
+ return r;
}
hdmi->vdda_reg = devm_regulator_get(&pdev->dev, "vdda");
@@ -808,7 +806,7 @@ static int hdmi4_probe(struct platform_device *pdev)
r = PTR_ERR(hdmi->vdda_reg);
if (r != -EPROBE_DEFER)
DSSERR("can't get VDDA regulator\n");
- goto err_free;
+ return r;
}
pm_runtime_enable(&pdev->dev);
@@ -827,8 +825,6 @@ static int hdmi4_probe(struct platform_device *pdev)
hdmi4_uninit_output(hdmi);
err_pm_disable:
pm_runtime_disable(&pdev->dev);
-err_free:
- kfree(hdmi);
return r;
}
@@ -841,8 +837,6 @@ static void hdmi4_remove(struct platform_device *pdev)
hdmi4_uninit_output(hdmi);
pm_runtime_disable(&pdev->dev);
-
- kfree(hdmi);
}
static const struct of_device_id hdmi_of_match[] = {
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 10/22] drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 10/22] drm/omap: dss: hdmi4: " Luca Ceresoli
@ 2025-05-10 8:54 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:54 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann,
Tomi Valkeinen
On Fri, 9 May 2025 15:53:36 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Switching from a non-devm to a devm allocation allows removing the kfree()
> in the remove function and in the probe error management code, and as a
> consequence to simplify the code flow by removing now unnecessary gotos.
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 11/22] drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (9 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 10/22] drm/omap: dss: hdmi4: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:54 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 12/22] drm/omap: dss: sdi: " Luca Ceresoli
` (12 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Tomi Valkeinen
This is the new API for allocating DRM bridges.
Switching from a non-devm to a devm allocation allows removing the kfree()
in the remove function and in the probe error management code, and as a
consequence to simplify the code flow by removing now unnecessary gotos.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
index 0c98444d39a93d8336b4d8dbd45aa4521181c3b4..5636b3dfec1c9581118b20adecd268c03e882efb 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
@@ -480,7 +480,6 @@ static const struct drm_bridge_funcs hdmi5_bridge_funcs = {
static void hdmi5_bridge_init(struct omap_hdmi *hdmi)
{
- hdmi->bridge.funcs = &hdmi5_bridge_funcs;
hdmi->bridge.of_node = hdmi->pdev->dev.of_node;
hdmi->bridge.ops = DRM_BRIDGE_OP_EDID;
hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
@@ -727,9 +726,9 @@ static int hdmi5_probe(struct platform_device *pdev)
int irq;
int r;
- hdmi = kzalloc(sizeof(*hdmi), GFP_KERNEL);
- if (!hdmi)
- return -ENOMEM;
+ hdmi = devm_drm_bridge_alloc(&pdev->dev, struct omap_hdmi, bridge, &hdmi5_bridge_funcs);
+ if (IS_ERR(hdmi))
+ return PTR_ERR(hdmi);
hdmi->pdev = pdev;
@@ -740,25 +739,24 @@ static int hdmi5_probe(struct platform_device *pdev)
r = hdmi5_probe_of(hdmi);
if (r)
- goto err_free;
+ return r;
r = hdmi_wp_init(pdev, &hdmi->wp, 5);
if (r)
- goto err_free;
+ return r;
r = hdmi_phy_init(pdev, &hdmi->phy, 5);
if (r)
- goto err_free;
+ return r;
r = hdmi5_core_init(pdev, &hdmi->core);
if (r)
- goto err_free;
+ return r;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
DSSERR("platform_get_irq failed\n");
- r = -ENODEV;
- goto err_free;
+ return -ENODEV;
}
r = devm_request_threaded_irq(&pdev->dev, irq,
@@ -766,7 +764,7 @@ static int hdmi5_probe(struct platform_device *pdev)
IRQF_ONESHOT, "OMAP HDMI", hdmi);
if (r) {
DSSERR("HDMI IRQ request failed\n");
- goto err_free;
+ return r;
}
hdmi->vdda_reg = devm_regulator_get(&pdev->dev, "vdda");
@@ -774,7 +772,7 @@ static int hdmi5_probe(struct platform_device *pdev)
r = PTR_ERR(hdmi->vdda_reg);
if (r != -EPROBE_DEFER)
DSSERR("can't get VDDA regulator\n");
- goto err_free;
+ return r;
}
pm_runtime_enable(&pdev->dev);
@@ -793,8 +791,6 @@ static int hdmi5_probe(struct platform_device *pdev)
hdmi5_uninit_output(hdmi);
err_pm_disable:
pm_runtime_disable(&pdev->dev);
-err_free:
- kfree(hdmi);
return r;
}
@@ -807,8 +803,6 @@ static void hdmi5_remove(struct platform_device *pdev)
hdmi5_uninit_output(hdmi);
pm_runtime_disable(&pdev->dev);
-
- kfree(hdmi);
}
static const struct of_device_id hdmi_of_match[] = {
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 11/22] drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 11/22] drm/omap: dss: hdmi5: " Luca Ceresoli
@ 2025-05-10 8:54 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:54 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann,
Tomi Valkeinen
On Fri, 9 May 2025 15:53:37 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Switching from a non-devm to a devm allocation allows removing the kfree()
> in the remove function and in the probe error management code, and as a
> consequence to simplify the code flow by removing now unnecessary gotos.
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 12/22] drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (10 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 11/22] drm/omap: dss: hdmi5: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:58 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 13/22] drm/omap: dss: venc: " Luca Ceresoli
` (11 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Rob Herring (Arm), Kuninori Morimoto, Tomi Valkeinen
This is the new API for allocating DRM bridges.
Switching from a non-devm to a devm allocation allows removing the kfree()
in the remove function and in the probe error management code, and as a
consequence to simplify the code flow by removing now unnecessary gotos.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/sdi.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c b/drivers/gpu/drm/omapdrm/dss/sdi.c
index e78826e4b560a2b9af2d8a5a38e181bd3e44d250..df4cbc683e2ca27ef5fc45f79b77dcdcd9ca529a 100644
--- a/drivers/gpu/drm/omapdrm/dss/sdi.c
+++ b/drivers/gpu/drm/omapdrm/dss/sdi.c
@@ -284,7 +284,6 @@ static const struct drm_bridge_funcs sdi_bridge_funcs = {
static void sdi_bridge_init(struct sdi_device *sdi)
{
- sdi->bridge.funcs = &sdi_bridge_funcs;
sdi->bridge.of_node = sdi->pdev->dev.of_node;
sdi->bridge.type = DRM_MODE_CONNECTOR_LVDS;
@@ -344,21 +343,19 @@ int sdi_init_port(struct dss_device *dss, struct platform_device *pdev,
u32 datapairs;
int r;
- sdi = kzalloc(sizeof(*sdi), GFP_KERNEL);
- if (!sdi)
- return -ENOMEM;
+ sdi = devm_drm_bridge_alloc(&pdev->dev, struct sdi_device, bridge, &sdi_bridge_funcs);
+ if (IS_ERR(sdi))
+ return PTR_ERR(sdi);
ep = of_graph_get_next_port_endpoint(port, NULL);
- if (!ep) {
- r = 0;
- goto err_free;
- }
+ if (!ep)
+ return 0;
r = of_property_read_u32(ep, "datapairs", &datapairs);
of_node_put(ep);
if (r) {
DSSERR("failed to parse datapairs\n");
- goto err_free;
+ return r;
}
sdi->datapairs = datapairs;
@@ -372,19 +369,14 @@ int sdi_init_port(struct dss_device *dss, struct platform_device *pdev,
r = PTR_ERR(sdi->vdds_sdi_reg);
if (r != -EPROBE_DEFER)
DSSERR("can't get VDDS_SDI regulator\n");
- goto err_free;
+ return r;
}
r = sdi_init_output(sdi);
if (r)
- goto err_free;
+ return r;
return 0;
-
-err_free:
- kfree(sdi);
-
- return r;
}
void sdi_uninit_port(struct device_node *port)
@@ -395,5 +387,4 @@ void sdi_uninit_port(struct device_node *port)
return;
sdi_uninit_output(sdi);
- kfree(sdi);
}
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 12/22] drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 12/22] drm/omap: dss: sdi: " Luca Ceresoli
@ 2025-05-10 8:58 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:58 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Kuninori Morimoto, Laurent Pinchart,
Maarten Lankhorst, Maxime Ripard, Neil Armstrong,
Paul Kocialkowski, Pengutronix Kernel Team, Rob Herring (Arm),
Robert Foss, Sascha Hauer, Shawn Guo, Simona Vetter,
Thomas Petazzoni, Thomas Zimmermann, Tomi Valkeinen
On Fri, 9 May 2025 15:53:38 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Switching from a non-devm to a devm allocation allows removing the kfree()
> in the remove function and in the probe error management code, and as a
> consequence to simplify the code flow by removing now unnecessary gotos.
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 13/22] drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (11 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 12/22] drm/omap: dss: sdi: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:55 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 14/22] drm/rcar-du: dsi: " Luca Ceresoli
` (10 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Tomi Valkeinen
This is the new API for allocating DRM bridges.
Switching from a non-devm to a devm allocation allows removing the kfree()
in the remove function and in the probe error management code, and as a
consequence to simplify the code flow by removing now unnecessary gotos.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/venc.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
index 50349518eda1630400529caf27ca4469bb09fc82..9b5d53dc361e654a2e4009c3c81b726f9ef76ced 100644
--- a/drivers/gpu/drm/omapdrm/dss/venc.c
+++ b/drivers/gpu/drm/omapdrm/dss/venc.c
@@ -664,7 +664,6 @@ static const struct drm_bridge_funcs venc_bridge_funcs = {
static void venc_bridge_init(struct venc_device *venc)
{
- venc->bridge.funcs = &venc_bridge_funcs;
venc->bridge.of_node = venc->pdev->dev.of_node;
venc->bridge.ops = DRM_BRIDGE_OP_MODES;
venc->bridge.type = DRM_MODE_CONNECTOR_SVIDEO;
@@ -809,9 +808,9 @@ static int venc_probe(struct platform_device *pdev)
struct venc_device *venc;
int r;
- venc = kzalloc(sizeof(*venc), GFP_KERNEL);
- if (!venc)
- return -ENOMEM;
+ venc = devm_drm_bridge_alloc(&pdev->dev, struct venc_device, bridge, &venc_bridge_funcs);
+ if (IS_ERR(venc))
+ return PTR_ERR(venc);
venc->pdev = pdev;
@@ -824,26 +823,24 @@ static int venc_probe(struct platform_device *pdev)
venc->config = &venc_config_pal_trm;
venc->base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(venc->base)) {
- r = PTR_ERR(venc->base);
- goto err_free;
- }
+ if (IS_ERR(venc->base))
+ return PTR_ERR(venc->base);
venc->vdda_dac_reg = devm_regulator_get(&pdev->dev, "vdda");
if (IS_ERR(venc->vdda_dac_reg)) {
r = PTR_ERR(venc->vdda_dac_reg);
if (r != -EPROBE_DEFER)
DSSERR("can't get VDDA_DAC regulator\n");
- goto err_free;
+ return r;
}
r = venc_get_clocks(venc);
if (r)
- goto err_free;
+ return r;
r = venc_probe_of(venc);
if (r)
- goto err_free;
+ return r;
pm_runtime_enable(&pdev->dev);
@@ -861,8 +858,6 @@ static int venc_probe(struct platform_device *pdev)
venc_uninit_output(venc);
err_pm_disable:
pm_runtime_disable(&pdev->dev);
-err_free:
- kfree(venc);
return r;
}
@@ -875,8 +870,6 @@ static void venc_remove(struct platform_device *pdev)
venc_uninit_output(venc);
pm_runtime_disable(&pdev->dev);
-
- kfree(venc);
}
static __maybe_unused int venc_runtime_suspend(struct device *dev)
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 13/22] drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 13/22] drm/omap: dss: venc: " Luca Ceresoli
@ 2025-05-10 8:55 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:55 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann,
Tomi Valkeinen
On Fri, 9 May 2025 15:53:39 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Switching from a non-devm to a devm allocation allows removing the kfree()
> in the remove function and in the probe error management code, and as a
> consequence to simplify the code flow by removing now unnecessary gotos.
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 14/22] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (12 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 13/22] drm/omap: dss: venc: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:56 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 15/22] drm/bridge: stm_lvds: " Luca Ceresoli
` (9 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Kieran Bingham, Laurent Pinchart, Tomi Valkeinen
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
---
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
index 7ab8be46c7f6547f29b4d45af7ac704283da9dcd..1af4c73f7a887712aef8c8176b0d0338d9ca9727 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
@@ -918,7 +918,6 @@ static int rcar_mipi_dsi_host_attach(struct mipi_dsi_host *host,
}
/* Initialize the DRM bridge. */
- dsi->bridge.funcs = &rcar_mipi_dsi_bridge_ops;
dsi->bridge.of_node = dsi->dev->of_node;
drm_bridge_add(&dsi->bridge);
@@ -1004,9 +1003,10 @@ static int rcar_mipi_dsi_probe(struct platform_device *pdev)
struct rcar_mipi_dsi *dsi;
int ret;
- dsi = devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL);
- if (dsi == NULL)
- return -ENOMEM;
+ dsi = devm_drm_bridge_alloc(&pdev->dev, struct rcar_mipi_dsi, bridge,
+ &rcar_mipi_dsi_bridge_ops);
+ if (IS_ERR(dsi))
+ return PTR_ERR(dsi);
platform_set_drvdata(pdev, dsi);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 14/22] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 14/22] drm/rcar-du: dsi: " Luca Ceresoli
@ 2025-05-10 8:56 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:56 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Kieran Bingham, Krzysztof Kozlowski, Laurent Pinchart,
Laurent Pinchart, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Paul Kocialkowski, Pengutronix Kernel Team,
Robert Foss, Sascha Hauer, Shawn Guo, Simona Vetter,
Thomas Petazzoni, Thomas Zimmermann, Tomi Valkeinen
On Fri, 9 May 2025 15:53:40 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (13 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 14/22] drm/rcar-du: dsi: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:56 ` Maxime Ripard
2025-05-20 11:37 ` Raphael Gallais-Pou
2025-05-09 13:53 ` [PATCH v3 16/22] drm/sti: dvo: " Luca Ceresoli
` (8 subsequent siblings)
23 siblings, 2 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
Raphael Gallais-Pou, Yannick Fertre
This is the new API for allocating DRM bridges.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Philippe Cornu <philippe.cornu@foss.st.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Yannick Fertre <yannick.fertre@foss.st.com>
---
drivers/gpu/drm/stm/lvds.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
index a3ae9a93ce6670eb2c4dd36b3e572fcbca791a1c..07788e8d3d8302a3951e97d64736b721033998d3 100644
--- a/drivers/gpu/drm/stm/lvds.c
+++ b/drivers/gpu/drm/stm/lvds.c
@@ -1049,9 +1049,9 @@ static int lvds_probe(struct platform_device *pdev)
dev_dbg(dev, "Probing LVDS driver...\n");
- lvds = devm_kzalloc(dev, sizeof(*lvds), GFP_KERNEL);
- if (!lvds)
- return -ENOMEM;
+ lvds = devm_drm_bridge_alloc(dev, struct stm_lvds, lvds_bridge, &lvds_bridge_funcs);
+ if (IS_ERR(lvds))
+ return PTR_ERR(lvds);
lvds->dev = dev;
@@ -1164,7 +1164,6 @@ static int lvds_probe(struct platform_device *pdev)
goto err_lvds_probe;
}
- lvds->lvds_bridge.funcs = &lvds_bridge_funcs;
lvds->lvds_bridge.of_node = dev->of_node;
lvds->hw_version = lvds_read(lvds, LVDS_VERR);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 15/22] drm/bridge: stm_lvds: " Luca Ceresoli
@ 2025-05-10 8:56 ` Maxime Ripard
2025-05-20 11:37 ` Raphael Gallais-Pou
1 sibling, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:56 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Alexandre Torgue, Andrzej Hajda,
Anusha Srivatsa, Chun-Kuang Hu, David Airlie, Dmitry Baryshkov,
Douglas Anderson, Fabio Estevam, Hui Pu, Jagan Teki,
Jernej Skrabec, Jonas Karlman, Krzysztof Kozlowski,
Laurent Pinchart, Maarten Lankhorst, Maxime Coquelin,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Philippe Cornu, Raphael Gallais-Pou,
Robert Foss, Sascha Hauer, Shawn Guo, Simona Vetter,
Thomas Petazzoni, Thomas Zimmermann, Yannick Fertre
On Fri, 9 May 2025 15:53:41 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 15/22] drm/bridge: stm_lvds: " Luca Ceresoli
2025-05-10 8:56 ` Maxime Ripard
@ 2025-05-20 11:37 ` Raphael Gallais-Pou
1 sibling, 0 replies; 55+ messages in thread
From: Raphael Gallais-Pou @ 2025-05-20 11:37 UTC (permalink / raw)
To: Luca Ceresoli, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Andrzej Hajda,
Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, Jagan Teki, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Douglas Anderson,
Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Yannick Fertre
Hi Luca,
On 5/9/25 15:53, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Philippe Cornu <philippe.cornu@foss.st.com>
> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> Cc: Yannick Fertre <yannick.fertre@foss.st.com>
> ---
I went away from keyboard for some time. Sorry for the delay :
Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Regards,
Raphaël
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 16/22] drm/sti: dvo: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (14 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 15/22] drm/bridge: stm_lvds: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:57 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 17/22] drm: zynqmp_dp: " Luca Ceresoli
` (7 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Alain Volmat, Raphael Gallais-Pou
This is the new API for allocating DRM bridges.
This driver allocates the DRM bridge separately from the main driver
private struct, which prevents using the new devm_drm_bridge_alloc()
API. Simplify the code by replacing the struct drm_bridge pointer with an
embedded struct drm_bridge inside the private struct, to make use of the
new API with the same code flow.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Alain Volmat <alain.volmat@foss.st.com>
Cc: Raphael Gallais-Pou <rgallaispou@gmail.com>
Changed in v2:
- fix typos in commit message
---
drivers/gpu/drm/sti/sti_dvo.c | 29 +++++++++++------------------
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 74a1eef4674eeabc445b53b380e325f785242024..7484d3c3f4ed5fac7eab408e30cbe2f6b87f27e5 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -97,7 +97,7 @@ struct sti_dvo {
struct dvo_config *config;
bool enabled;
struct drm_encoder *encoder;
- struct drm_bridge *bridge;
+ struct drm_bridge bridge;
};
struct sti_dvo_connector {
@@ -439,7 +439,6 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
struct drm_encoder *encoder;
struct sti_dvo_connector *connector;
struct drm_connector *drm_connector;
- struct drm_bridge *bridge;
int err;
/* Set the drm device handle */
@@ -455,20 +454,14 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
connector->dvo = dvo;
- bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
- if (!bridge)
- return -ENOMEM;
-
- bridge->driver_private = dvo;
- bridge->funcs = &sti_dvo_bridge_funcs;
- bridge->of_node = dvo->dev.of_node;
- drm_bridge_add(bridge);
+ dvo->bridge.driver_private = dvo;
+ dvo->bridge.of_node = dvo->dev.of_node;
+ drm_bridge_add(&dvo->bridge);
- err = drm_bridge_attach(encoder, bridge, NULL, 0);
+ err = drm_bridge_attach(encoder, &dvo->bridge, NULL, 0);
if (err)
return err;
- dvo->bridge = bridge;
connector->encoder = encoder;
dvo->encoder = encoder;
@@ -490,7 +483,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
return 0;
err_sysfs:
- drm_bridge_remove(bridge);
+ drm_bridge_remove(&dvo->bridge);
return -EINVAL;
}
@@ -499,7 +492,7 @@ static void sti_dvo_unbind(struct device *dev,
{
struct sti_dvo *dvo = dev_get_drvdata(dev);
- drm_bridge_remove(dvo->bridge);
+ drm_bridge_remove(&dvo->bridge);
}
static const struct component_ops sti_dvo_ops = {
@@ -515,10 +508,10 @@ static int sti_dvo_probe(struct platform_device *pdev)
DRM_INFO("%s\n", __func__);
- dvo = devm_kzalloc(dev, sizeof(*dvo), GFP_KERNEL);
- if (!dvo) {
- DRM_ERROR("Failed to allocate memory for DVO\n");
- return -ENOMEM;
+ dvo = devm_drm_bridge_alloc(dev, struct sti_dvo, bridge, &sti_dvo_bridge_funcs);
+ if (IS_ERR(dvo)) {
+ DRM_ERROR("Failed to allocate DVO\n");
+ return PTR_ERR(dvo);
}
dvo->dev = pdev->dev;
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 16/22] drm/sti: dvo: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 16/22] drm/sti: dvo: " Luca Ceresoli
@ 2025-05-10 8:57 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:57 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Alain Volmat, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Raphael Gallais-Pou, Robert Foss,
Sascha Hauer, Shawn Guo, Simona Vetter, Thomas Petazzoni,
Thomas Zimmermann
On Fri, 9 May 2025 15:53:42 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> This driver allocates the DRM bridge separately from the main driver
> private struct, which prevents using the new devm_drm_bridge_alloc()
> API. Simplify the code by replacing the struct drm_bridge pointer with an
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 17/22] drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (15 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 16/22] drm/sti: dvo: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 8:57 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-combiner: " Luca Ceresoli
` (6 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Laurent Pinchart, Michal Simek, Tomi Valkeinen
This is the new API for allocating DRM bridges.
This driver has a peculiar structure. zynqmp_dpsub.c is the actual driver,
which delegates to a submodule (zynqmp_dp.c) the allocation of a
sub-structure embedding the drm_bridge and its initialization, however it
does not delegate the drm_bridge_add(). Hence, following carefully the code
flow, it is correct to change the allocation function and .funcs assignment
in the submodule, while the drm_bridge_add() is not in that submodule.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Michal Simek <michal.simek@amd.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Changes in v2:
- rebased on current drm-misc-next
- remove the kfree() calls too, as we are converting from kzalloc+kfree,
not from devm_kzalloc
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 31 +++++++++++--------------------
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 -
2 files changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 238cbb49963efa6e8cc737d8a6e76250f6531276..02e1feaa611596a24217136ee8ce7f5d2f1900a2 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -2439,9 +2439,9 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
struct zynqmp_dp *dp;
int ret;
- dp = kzalloc(sizeof(*dp), GFP_KERNEL);
- if (!dp)
- return -ENOMEM;
+ dp = devm_drm_bridge_alloc(&pdev->dev, struct zynqmp_dp, bridge, &zynqmp_dp_bridge_funcs);
+ if (IS_ERR(dp))
+ return PTR_ERR(dp);
dp->dev = &pdev->dev;
dp->dpsub = dpsub;
@@ -2454,31 +2454,25 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
/* Acquire all resources (IOMEM, IRQ and PHYs). */
dp->iomem = devm_platform_ioremap_resource_byname(pdev, "dp");
- if (IS_ERR(dp->iomem)) {
- ret = PTR_ERR(dp->iomem);
- goto err_free;
- }
+ if (IS_ERR(dp->iomem))
+ return PTR_ERR(dp->iomem);
dp->irq = platform_get_irq(pdev, 0);
- if (dp->irq < 0) {
- ret = dp->irq;
- goto err_free;
- }
+ if (dp->irq < 0)
+ return dp->irq;
dp->reset = devm_reset_control_get(dp->dev, NULL);
- if (IS_ERR(dp->reset)) {
- ret = dev_err_probe(dp->dev, PTR_ERR(dp->reset),
+ if (IS_ERR(dp->reset))
+ return dev_err_probe(dp->dev, PTR_ERR(dp->reset),
"failed to get reset\n");
- goto err_free;
- }
ret = zynqmp_dp_reset(dp, true);
if (ret < 0)
- goto err_free;
+ return ret;
ret = zynqmp_dp_reset(dp, false);
if (ret < 0)
- goto err_free;
+ return ret;
ret = zynqmp_dp_phy_probe(dp);
if (ret)
@@ -2486,7 +2480,6 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
/* Initialize the bridge. */
bridge = &dp->bridge;
- bridge->funcs = &zynqmp_dp_bridge_funcs;
bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
| DRM_BRIDGE_OP_HPD;
bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
@@ -2539,8 +2532,6 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
zynqmp_dp_phy_exit(dp);
err_reset:
zynqmp_dp_reset(dp, true);
-err_free:
- kfree(dp);
return ret;
}
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 3a9544b97bc5311f9adeb57c08c837a04b6922fa..2764c4b17c5e49611db8adf41dd09e3134c2d524 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -180,7 +180,6 @@ static int zynqmp_dpsub_parse_dt(struct zynqmp_dpsub *dpsub)
void zynqmp_dpsub_release(struct zynqmp_dpsub *dpsub)
{
kfree(dpsub->disp);
- kfree(dpsub->dp);
kfree(dpsub);
}
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 17/22] drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 17/22] drm: zynqmp_dp: " Luca Ceresoli
@ 2025-05-10 8:57 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 8:57 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Laurent Pinchart,
Maarten Lankhorst, Maxime Ripard, Michal Simek, Neil Armstrong,
Paul Kocialkowski, Pengutronix Kernel Team, Robert Foss,
Sascha Hauer, Shawn Guo, Simona Vetter, Thomas Petazzoni,
Thomas Zimmermann, Tomi Valkeinen
On Fri, 9 May 2025 15:53:43 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> This driver has a peculiar structure. zynqmp_dpsub.c is the actual driver,
> which delegates to a submodule (zynqmp_dp.c) the allocation of a
> sub-structure embedding the drm_bridge and its initialization, however it
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (16 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 17/22] drm: zynqmp_dp: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-27 1:48 ` Liu Ying
2025-05-09 13:53 ` [PATCH v3 19/22] drm/bridge: tc358767: " Luca Ceresoli
` (5 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli, Liu Ying
This is the new API for allocating DRM bridges.
This driver embeds an array of channels in the main struct, and each
channel embeds a drm_bridge. This prevents dynamic, refcount-based
deallocation of the bridges.
To make the new, dynamic bridge allocation possible:
* change the array of channels into an array of channel pointers
* allocate each channel using devm_drm_bridge_alloc()
* adapt the code wherever using the channels
* remove the is_available flag, now "ch != NULL" is equivalent
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Cc: Liu Ying <victor.liu@nxp.com>
Changes in v3:
- fix NULL pointer deref in .remove and remove is_available bool
Changes in v2: none
---
.../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 27 +++++++++++-----------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
index 1f6fd488e7039e943351006d3373009f0c15cb08..8517b1c953d4e0fb9f5b6dbe25fbaaa63eef2b33 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
@@ -63,12 +63,11 @@ struct imx8qxp_pc_channel {
struct drm_bridge *next_bridge;
struct imx8qxp_pc *pc;
unsigned int stream_id;
- bool is_available;
};
struct imx8qxp_pc {
struct device *dev;
- struct imx8qxp_pc_channel ch[2];
+ struct imx8qxp_pc_channel *ch[2];
struct clk *clk_apb;
void __iomem *base;
};
@@ -307,7 +306,14 @@ static int imx8qxp_pc_bridge_probe(struct platform_device *pdev)
goto free_child;
}
- ch = &pc->ch[i];
+ ch = devm_drm_bridge_alloc(dev, struct imx8qxp_pc_channel, bridge,
+ &imx8qxp_pc_bridge_funcs);
+ if (IS_ERR(ch)) {
+ ret = PTR_ERR(ch);
+ goto free_child;
+ }
+
+ pc->ch[i] = ch;
ch->pc = pc;
ch->stream_id = i;
@@ -333,9 +339,7 @@ static int imx8qxp_pc_bridge_probe(struct platform_device *pdev)
of_node_put(remote);
ch->bridge.driver_private = ch;
- ch->bridge.funcs = &imx8qxp_pc_bridge_funcs;
ch->bridge.of_node = child;
- ch->is_available = true;
drm_bridge_add(&ch->bridge);
}
@@ -345,8 +349,8 @@ static int imx8qxp_pc_bridge_probe(struct platform_device *pdev)
free_child:
of_node_put(child);
- if (i == 1 && pc->ch[0].next_bridge)
- drm_bridge_remove(&pc->ch[0].bridge);
+ if (i == 1 && pc->ch[0]->next_bridge)
+ drm_bridge_remove(&pc->ch[0]->bridge);
pm_runtime_disable(dev);
return ret;
@@ -359,13 +363,10 @@ static void imx8qxp_pc_bridge_remove(struct platform_device *pdev)
int i;
for (i = 0; i < 2; i++) {
- ch = &pc->ch[i];
-
- if (!ch->is_available)
- continue;
+ ch = pc->ch[i];
- drm_bridge_remove(&ch->bridge);
- ch->is_available = false;
+ if (ch)
+ drm_bridge_remove(&ch->bridge);
}
pm_runtime_disable(&pdev->dev);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-combiner: " Luca Ceresoli
@ 2025-05-27 1:48 ` Liu Ying
0 siblings, 0 replies; 55+ messages in thread
From: Liu Ying @ 2025-05-27 1:48 UTC (permalink / raw)
To: Luca Ceresoli, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Andrzej Hajda,
Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, Jagan Teki, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Douglas Anderson,
Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32
On 05/09/2025, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> This driver embeds an array of channels in the main struct, and each
> channel embeds a drm_bridge. This prevents dynamic, refcount-based
> deallocation of the bridges.
>
> To make the new, dynamic bridge allocation possible:
>
> * change the array of channels into an array of channel pointers
> * allocate each channel using devm_drm_bridge_alloc()
> * adapt the code wherever using the channels
> * remove the is_available flag, now "ch != NULL" is equivalent
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> Cc: Liu Ying <victor.liu@nxp.com>
>
> Changes in v3:
> - fix NULL pointer deref in .remove and remove is_available bool
>
> Changes in v2: none
> ---
> .../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 27 +++++++++++-----------
> 1 file changed, 14 insertions(+), 13 deletions(-)
Reviewed-by: Liu Ying <victor.liu@nxp.com>
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 19/22] drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (17 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-combiner: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-09 13:53 ` [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge() Luca Ceresoli
` (4 subsequent siblings)
23 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli
This is the new API for allocating DRM bridges.
Converting this driver is a bit convoluted because the drm_bridge funcs
pointer differs based on the bridge mode. So the current code does:
* tc_probe()
* devm_kzalloc() private struct embedding drm_bridge
* call tc_probe_bridge_endpoint() which
* parses DT description into struct fields
* computes the mode
* calls different bridge init functions based on the mode
* each sets a different bridge.funcs pointer
The new API expects the funcs pointer to be known at alloc time, which does
not fit in the current code structure.
Solve this by moving the part of tc_probe_bridge_endpoint() computing the
mode into a separate function, tc_probe_get_mode(), which does not need the
private driver structure. So now the mode is known before allocation and so
is the funcs pointer, while all other operations are still happening after
allocation, directly into the private struct data, as they used to.
This solution is chosen to minimize the changes in the driver logical code
flow. The drawback is we now iterate twice over the endpoints.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/bridge/tc358767.c | 56 ++++++++++++++++++++++++++++-----------
1 file changed, 40 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 7e5449fb86a3fcdae8255bc490d12c543ef3f8ae..61559467e2d22b4b1b4223c97766ca3bf58908fd 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -344,6 +344,14 @@
#define COLOR_BAR_MODE_BARS 2
#define PLL_DBG 0x0a04
+enum tc_mode {
+ mode_dpi_to_edp = BIT(1) | BIT(2),
+ mode_dpi_to_dp = BIT(1),
+ mode_dsi_to_edp = BIT(0) | BIT(2),
+ mode_dsi_to_dp = BIT(0),
+ mode_dsi_to_dpi = BIT(0) | BIT(1),
+};
+
static bool tc_test_pattern;
module_param_named(test, tc_test_pattern, bool, 0644);
@@ -2327,7 +2335,6 @@ static int tc_probe_dpi_bridge_endpoint(struct tc_data *tc)
if (bridge) {
tc->panel_bridge = bridge;
tc->bridge.type = DRM_MODE_CONNECTOR_DPI;
- tc->bridge.funcs = &tc_dpi_bridge_funcs;
return 0;
}
@@ -2360,7 +2367,6 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
tc->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
}
- tc->bridge.funcs = &tc_edp_bridge_funcs;
if (tc->hpd_pin >= 0)
tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
@@ -2368,17 +2374,11 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
return 0;
}
-static int tc_probe_bridge_endpoint(struct tc_data *tc)
+static enum tc_mode tc_probe_get_mode(struct device *dev)
{
- struct device *dev = tc->dev;
struct of_endpoint endpoint;
struct device_node *node = NULL;
- const u8 mode_dpi_to_edp = BIT(1) | BIT(2);
- const u8 mode_dpi_to_dp = BIT(1);
- const u8 mode_dsi_to_edp = BIT(0) | BIT(2);
- const u8 mode_dsi_to_dp = BIT(0);
- const u8 mode_dsi_to_dpi = BIT(0) | BIT(1);
- u8 mode = 0;
+ enum tc_mode mode = 0;
/*
* Determine bridge configuration.
@@ -2401,7 +2401,27 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
return -EINVAL;
}
mode |= BIT(endpoint.port);
+ }
+
+ if (mode != mode_dpi_to_edp &&
+ mode != mode_dpi_to_dp &&
+ mode != mode_dsi_to_dpi &&
+ mode != mode_dsi_to_edp &&
+ mode != mode_dsi_to_dp) {
+ dev_warn(dev, "Invalid mode (0x%x) is not supported!\n", mode);
+ return -EINVAL;
+ }
+
+ return mode;
+}
+static int tc_probe_bridge_endpoint(struct tc_data *tc, enum tc_mode mode)
+{
+ struct device *dev = tc->dev;
+ struct of_endpoint endpoint;
+ struct device_node *node = NULL;
+
+ for_each_endpoint_of_node(dev->of_node, node) {
if (endpoint.port == 2) {
of_property_read_u8_array(node, "toshiba,pre-emphasis",
tc->pre_emphasis,
@@ -2427,24 +2447,28 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
return tc_probe_edp_bridge_endpoint(tc);
}
- dev_warn(dev, "Invalid mode (0x%x) is not supported!\n", mode);
-
+ /* Should never happen, mode was validated by tc_probe_get_mode() */
return -EINVAL;
}
static int tc_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
+ const struct drm_bridge_funcs *funcs;
struct tc_data *tc;
+ int mode;
int ret;
- tc = devm_kzalloc(dev, sizeof(*tc), GFP_KERNEL);
- if (!tc)
- return -ENOMEM;
+ mode = tc_probe_get_mode(dev);
+ funcs = (mode == mode_dsi_to_dpi) ? &tc_dpi_bridge_funcs : &tc_edp_bridge_funcs;
+
+ tc = devm_drm_bridge_alloc(dev, struct tc_data, bridge, funcs);
+ if (IS_ERR(tc))
+ return PTR_ERR(tc);
tc->dev = dev;
- ret = tc_probe_bridge_endpoint(tc);
+ ret = tc_probe_bridge_endpoint(tc, mode);
if (ret)
return ret;
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge()
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (18 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 19/22] drm/bridge: tc358767: " Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 9:15 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API Luca Ceresoli
` (3 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli
Bridges obtained via devm_drm_bridge_alloc(dev, ...) will be put when the
requesting device (@dev) is removed.
However drivers which obtained them may need to put the obtained reference
explicitly. One such case is if they bind the devm removal action to a
different device than the one implemented by the driver itself and which
might be removed at a different time, such as bridge/panel.c.
Add devm_drm_put_bridge() to manually release a devm-obtained bridge in
such cases.
This function is considered only a temporary workaround until the panel
bridge is reworked and should be removed afterwards.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Changes in v3:
- document this function is a temporary workaround, not to be used
(in kerneldoc and commit message)
Changes in v2: none
---
drivers/gpu/drm/drm_bridge.c | 17 +++++++++++++++++
include/drm/drm_bridge.h | 4 ++++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index b4c89ec01998b849018ce031c7cd84614e65e710..d0e81639927a73422671b7b43f3e8a946f1d4300 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -1392,6 +1392,23 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
EXPORT_SYMBOL(of_drm_find_bridge);
#endif
+/**
+ * devm_drm_put_bridge - Release a bridge reference obtained via devm
+ * @dev: device that got the bridge via devm
+ * @bridge: pointer to a struct drm_bridge obtained via devm
+ *
+ * Same as drm_bridge_put() for bridge pointers obtained via devm functions
+ * such as devm_drm_bridge_alloc().
+ *
+ * This function is a temporary workaround and MUST NOT be used. Manual
+ * handling of bridge lifetime is inherently unsafe.
+ */
+void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge)
+{
+ devm_release_action(dev, drm_bridge_put_void, bridge);
+}
+EXPORT_SYMBOL(devm_drm_put_bridge);
+
static void drm_bridge_debugfs_show_bridge(struct drm_printer *p,
struct drm_bridge *bridge,
unsigned int idx)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 4e418a29a9ff9d014d6ac0910a5d9bcf7118195e..6f00a3998ed6d026332b0f1e3bb5bee3cb5158e0 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -1265,6 +1265,8 @@ static inline struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
return ERR_PTR(-ENODEV);
}
+static inline void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge) {}
+
static inline struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
struct device_node *node,
u32 port,
@@ -1274,6 +1276,8 @@ static inline struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
}
#endif
+void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge);
+
void drm_bridge_debugfs_params(struct dentry *root);
void drm_bridge_debugfs_encoder_params(struct dentry *root, struct drm_encoder *encoder);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge()
2025-05-09 13:53 ` [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge() Luca Ceresoli
@ 2025-05-10 9:15 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 9:15 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann
On Fri, 9 May 2025 15:53:46 +0200, Luca Ceresoli wrote:
> Bridges obtained via devm_drm_bridge_alloc(dev, ...) will be put when the
> requesting device (@dev) is removed.
>
> However drivers which obtained them may need to put the obtained reference
> explicitly. One such case is if they bind the devm removal action to a
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (19 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge() Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 9:42 ` Maxime Ripard
2025-05-09 13:53 ` [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge() Luca Ceresoli
` (2 subsequent siblings)
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli
This is the new API for allocating DRM bridges.
The devm lifetime management of this driver is peculiar. The underlying
device for the panel_bridge is the panel, and the devm lifetime is tied the
panel device (panel->dev). However the panel_bridge allocation is not
performed by the panel driver, but rather by a separate entity (typically
the previous bridge in the encoder chain).
Thus when that separate entity is destroyed, the panel_bridge is not
removed automatically by devm, so it is rather done explicitly by calling
drm_panel_bridge_remove(). This is the function that does devm_kfree() the
panel_bridge in current code, so update it as well to put the bridge
reference instead.
This is a temporary solution until the panel lifetime is reworked, which
should make this workaround unnecessary, so add a comment to clarify that.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Changes in v3:
- add TODO to remove devm_drm_put_bridge(), update commit message
- fix typo in commit message
Changes in v2: none
---
drivers/gpu/drm/bridge/panel.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 79b009ab9396048eac57ad47631a902e949d77c6..6cbbfb1381a4a75fbc3acf6e6c5361202627e740 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -287,15 +287,14 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
if (!panel)
return ERR_PTR(-EINVAL);
- panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
- GFP_KERNEL);
- if (!panel_bridge)
- return ERR_PTR(-ENOMEM);
+ panel_bridge = devm_drm_bridge_alloc(panel->dev, struct panel_bridge, bridge,
+ &panel_bridge_bridge_funcs);
+ if (IS_ERR(panel_bridge))
+ return (void *)panel_bridge;
panel_bridge->connector_type = connector_type;
panel_bridge->panel = panel;
- panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs;
panel_bridge->bridge.of_node = panel->dev->of_node;
panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
panel_bridge->bridge.type = connector_type;
@@ -327,7 +326,8 @@ void drm_panel_bridge_remove(struct drm_bridge *bridge)
panel_bridge = drm_bridge_to_panel_bridge(bridge);
drm_bridge_remove(bridge);
- devm_kfree(panel_bridge->panel->dev, bridge);
+ /* TODO remove this after reworking panel_bridge lifetime */
+ devm_drm_put_bridge(panel_bridge->panel->dev, bridge);
}
EXPORT_SYMBOL(drm_panel_bridge_remove);
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API
2025-05-09 13:53 ` [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API Luca Ceresoli
@ 2025-05-10 9:42 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 9:42 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek,
linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Paul Kocialkowski,
Pengutronix Kernel Team, Robert Foss, Sascha Hauer, Shawn Guo,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann
On Fri, 9 May 2025 15:53:47 +0200, Luca Ceresoli wrote:
> This is the new API for allocating DRM bridges.
>
> The devm lifetime management of this driver is peculiar. The underlying
> device for the panel_bridge is the panel, and the devm lifetime is tied the
> panel device (panel->dev). However the panel_bridge allocation is not
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge()
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (20 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API Luca Ceresoli
@ 2025-05-09 13:53 ` Luca Ceresoli
2025-05-10 9:42 ` Maxime Ripard
2025-05-21 14:22 ` [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
2025-05-27 10:21 ` (subset) " Luca Ceresoli
23 siblings, 1 reply; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-09 13:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Luca Ceresoli,
Jonathan Corbet, linux-doc
devm_drm_put_bridge() is a temporary workaround waiting for the panel
bridge lifetime rework. Add a TODO entry to not forget it must be removed
after such rework.
Suggested-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
This patch was added in v3
---
Documentation/gpu/todo.rst | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index c57777a24e03d91b1ffe04365f7356f2d938befd..be8637da3fe950ddcb65cdcf626bc4b4e6b0fa26 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -515,6 +515,21 @@ Contact: Douglas Anderson <dianders@chromium.org>
Level: Starter
+Remove devm_drm_put_bridge()
+----------------------------
+
+Due to how the panel bridge handles the drm_bridge object lifetime, special
+care must be taken to dispose of the drm_bridge object when the
+panel_bridge is removed. This is currently managed using
+devm_drm_put_bridge(), but that is an unsafe, temporary workaround. To fix
+that, the DRM panel lifetime needs to be reworked. After the rework is
+done, remove devm_drm_put_bridge() and the TODO in
+drm_panel_bridge_remove().
+
+Contact: Maxime Ripard <mripard@kernel.org>,
+ Luca Ceresoli <luca.ceresoli@bootlin.com>
+
+Level: Intermediate
Core refactorings
=================
--
2.49.0
^ permalink raw reply related [flat|nested] 55+ messages in thread* Re: [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge()
2025-05-09 13:53 ` [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge() Luca Ceresoli
@ 2025-05-10 9:42 ` Maxime Ripard
0 siblings, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-10 9:42 UTC (permalink / raw)
To: Luca Ceresoli
Cc: asahi, chrome-platform, dri-devel, freedreno, imx, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-doc, linux-kernel,
linux-mediatek, linux-renesas-soc, linux-samsung-soc, linux-stm32,
platform-driver-x86, Andrzej Hajda, Anusha Srivatsa,
Chun-Kuang Hu, David Airlie, Dmitry Baryshkov, Douglas Anderson,
Fabio Estevam, Hui Pu, Jagan Teki, Jernej Skrabec, Jonas Karlman,
Jonathan Corbet, Krzysztof Kozlowski, Laurent Pinchart,
Maarten Lankhorst, Maxime Ripard, Neil Armstrong,
Paul Kocialkowski, Pengutronix Kernel Team, Robert Foss,
Sascha Hauer, Shawn Guo, Simona Vetter, Thomas Petazzoni,
Thomas Zimmermann
On Fri, 9 May 2025 15:53:48 +0200, Luca Ceresoli wrote:
> devm_drm_put_bridge() is a temporary workaround waiting for the panel
> bridge lifetime rework. Add a TODO entry to not forget it must be removed
> after such rework.
>
> Suggested-by: Maxime Ripard <mripard@kernel.org>
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (21 preceding siblings ...)
2025-05-09 13:53 ` [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge() Luca Ceresoli
@ 2025-05-21 14:22 ` Luca Ceresoli
2025-05-22 3:20 ` Liu Ying
` (2 more replies)
2025-05-27 10:21 ` (subset) " Luca Ceresoli
23 siblings, 3 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-21 14:22 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski, Liu Ying
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
Hello Maxime, Shawn, Liu, all,
On Fri, 09 May 2025 15:53:26 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
> bridge, and the only one supported from now on. It is the first milestone
> towards removal of bridges from a still existing DRM pipeline without
> use-after-free.
I applied on drm-misc-next patches 3-17,20-21 as they match all the
criteria:
- At least a Acked-by (or R-by maintainers)
- patch is for drm-misc
Being my very first commits to drm-misc, I tried to be careful, and
double checked all the patches with Louis (thanks!).
Here are the pending questions and plan for the remaining patches.
> Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
This reverts the commit applied my mistake:
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518
Neither the original patch nor the revert has been reviewed/acked.
As the commit was a mistake, I'm applying the revert by the end of this
week (i.e. on Friday) unless there are better instructions.
> drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
This patch affects multiple drivers. Running get_maintainers.pl
points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
this looks like due to the 'N:' line in:
ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
M: Shawn Guo <shawnguo@kernel.org>
M: Sascha Hauer <s.hauer@pengutronix.de>
R: Pengutronix Kernel Team <kernel@pengutronix.de>
...
T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
N: imx
...
(https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
file that is touched by the patch. That regexp appears overly generic to me.
Shawn, can it be fixed by making it less generic?
If not, can we at least add a band-aid 'X:' entry for
drivers/gpu/drm/bridge/imx?
I think the other matching entry is the one to consider:
DRM DRIVERS FOR FREESCALE IMX BRIDGE
M: Liu Ying <victor.liu@nxp.com>
L: dri-devel@lists.freedesktop.org
S: Maintained
F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
F: drivers/gpu/drm/bridge/imx/
(https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
However it does not list any trees. I _guess_ drm-misc applies here as
a fallback as well as common sense.
Liu, should this entry have a 'T:' line for drm/misc?
> drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
Not acked/reviewed, some discussion happened. I am resending it in v4,
possibly with updates based on the discussion.
But it has the same issue discussed above, with get_maintiners.pl
pointing at Shawn Guo's tree, so in the future I'm assuming this goes
to drm-misc unless there are news about that.
> drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
No feedback, resending in v4.
> drm/todo: add entry to remove devm_drm_put_bridge()
This involves documentation maintained on another tree. Where should it
be applied? There are two matching entries in MAINTAINERS:
* DRM DRIVERS -> the drm tree
* DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
To me it looks like the second is obviously the closest match as we are
dealing with DRM bridges, so I'm applying this as well on Friday unless
there are better instructions.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 55+ messages in thread* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-21 14:22 ` [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
@ 2025-05-22 3:20 ` Liu Ying
2025-05-22 7:28 ` Luca Ceresoli
2025-05-22 15:01 ` Maxime Ripard
2025-05-22 14:57 ` Maxime Ripard
2025-05-22 15:11 ` Inki Dae
2 siblings, 2 replies; 55+ messages in thread
From: Liu Ying @ 2025-05-22 3:20 UTC (permalink / raw)
To: Luca Ceresoli, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Andrzej Hajda,
Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, Jagan Teki, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Douglas Anderson,
Chun-Kuang Hu, Krzysztof Kozlowski
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
On 05/21/2025, Luca Ceresoli wrote:
> Hello Maxime, Shawn, Liu, all,
>
> On Fri, 09 May 2025 15:53:26 +0200
> Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
>> devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
>> bridge, and the only one supported from now on. It is the first milestone
>> towards removal of bridges from a still existing DRM pipeline without
>> use-after-free.
>
> I applied on drm-misc-next patches 3-17,20-21 as they match all the
> criteria:
> - At least a Acked-by (or R-by maintainers)
> - patch is for drm-misc
>
> Being my very first commits to drm-misc, I tried to be careful, and
> double checked all the patches with Louis (thanks!).
>
> Here are the pending questions and plan for the remaining patches.
>
>> Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
>
> This reverts the commit applied my mistake:
> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518
>
> Neither the original patch nor the revert has been reviewed/acked.
>
> As the commit was a mistake, I'm applying the revert by the end of this
> week (i.e. on Friday) unless there are better instructions.
>
>> drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
>
> This patch affects multiple drivers. Running get_maintainers.pl
> points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> this looks like due to the 'N:' line in:
>
> ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> M: Shawn Guo <shawnguo@kernel.org>
> M: Sascha Hauer <s.hauer@pengutronix.de>
> R: Pengutronix Kernel Team <kernel@pengutronix.de>
> ...
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> N: imx
> ...
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
>
> Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> file that is touched by the patch. That regexp appears overly generic to me.
>
> Shawn, can it be fixed by making it less generic?
>
> If not, can we at least add a band-aid 'X:' entry for
> drivers/gpu/drm/bridge/imx?
>
> I think the other matching entry is the one to consider:
>
> DRM DRIVERS FOR FREESCALE IMX BRIDGE
> M: Liu Ying <victor.liu@nxp.com>
> L: dri-devel@lists.freedesktop.org
> S: Maintained
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> F: drivers/gpu/drm/bridge/imx/
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
>
> However it does not list any trees. I _guess_ drm-misc applies here as
> a fallback as well as common sense.
>
> Liu, should this entry have a 'T:' line for drm/misc?
These bridge drivers also don't have a 'T:' line:
DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE
DRM DRIVER FOR PARADE PS8640 BRIDGE CHIP
DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE
DRM DRIVER FOR TI SN65DSI86 BRIDGE CHIP
LONTIUM LT8912B MIPI TO HDMI BRIDGE
MEGACHIPS STDPXXXX-GE-B850V3-FW LVDS/DP++ BRIDGES
MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER
I think that they fallback to drm-misc since "DRM DRIVERS FOR BRIDGE CHIPS"
covers them. I don't have strong opinion on adding a "T" line to them, at
least to "DRM DRIVERS FOR FREESCALE IMX BRIDGE". Anyway, it would be good
to know comments from maintainers for "DRM DRIVERS FOR BRIDGE CHIPS" and
"DRM DRIVERS".
>
>> drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
>
> Not acked/reviewed, some discussion happened. I am resending it in v4,
> possibly with updates based on the discussion.
I still think the main structures in imx8qxp-pixel-combiner.c and imx*-ldb.c
should have the same lifetime with the allocated bridges. I added a new
comment on this driver in v2 just now.
>
> But it has the same issue discussed above, with get_maintiners.pl
> pointing at Shawn Guo's tree, so in the future I'm assuming this goes
> to drm-misc unless there are news about that.
>
>> drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
>
> No feedback, resending in v4.
>
>> drm/todo: add entry to remove devm_drm_put_bridge()
>
> This involves documentation maintained on another tree. Where should it
> be applied? There are two matching entries in MAINTAINERS:
>
> * DRM DRIVERS -> the drm tree
> * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
>
> To me it looks like the second is obviously the closest match as we are
> dealing with DRM bridges, so I'm applying this as well on Friday unless
> there are better instructions.
>
> Best regards,
> Luca
>
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-22 3:20 ` Liu Ying
@ 2025-05-22 7:28 ` Luca Ceresoli
2025-05-22 15:01 ` Maxime Ripard
1 sibling, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-22 7:28 UTC (permalink / raw)
To: Liu Ying
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
Hello Liu,
On Thu, 22 May 2025 11:20:17 +0800
Liu Ying <victor.liu@nxp.com> wrote:
> > If not, can we at least add a band-aid 'X:' entry for
> > drivers/gpu/drm/bridge/imx?
> >
> > I think the other matching entry is the one to consider:
> >
> > DRM DRIVERS FOR FREESCALE IMX BRIDGE
> > M: Liu Ying <victor.liu@nxp.com>
> > L: dri-devel@lists.freedesktop.org
> > S: Maintained
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> > F: drivers/gpu/drm/bridge/imx/
> >
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
> >
> > However it does not list any trees. I _guess_ drm-misc applies here as
> > a fallback as well as common sense.
> >
> > Liu, should this entry have a 'T:' line for drm/misc?
>
> These bridge drivers also don't have a 'T:' line:
>
> DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE
> DRM DRIVER FOR PARADE PS8640 BRIDGE CHIP
> DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE
> DRM DRIVER FOR TI SN65DSI86 BRIDGE CHIP
> LONTIUM LT8912B MIPI TO HDMI BRIDGE
> MEGACHIPS STDPXXXX-GE-B850V3-FW LVDS/DP++ BRIDGES
> MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER
>
> I think that they fallback to drm-misc since "DRM DRIVERS FOR BRIDGE CHIPS"
> covers them. I don't have strong opinion on adding a "T" line to them, at
> least to "DRM DRIVERS FOR FREESCALE IMX BRIDGE". Anyway, it would be good
> to know comments from maintainers for "DRM DRIVERS FOR BRIDGE CHIPS" and
> "DRM DRIVERS".
I agree the fallback seems OK for this MAINTAINERS entry.
The other entry (ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) is another
story.
> >> drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
> >
> > Not acked/reviewed, some discussion happened. I am resending it in v4,
> > possibly with updates based on the discussion.
>
> I still think the main structures in imx8qxp-pixel-combiner.c and imx*-ldb.c
> should have the same lifetime with the allocated bridges. I added a new
> comment on this driver in v2 just now.
Thanks, let's continue the conversation there.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-22 3:20 ` Liu Ying
2025-05-22 7:28 ` Luca Ceresoli
@ 2025-05-22 15:01 ` Maxime Ripard
1 sibling, 0 replies; 55+ messages in thread
From: Maxime Ripard @ 2025-05-22 15:01 UTC (permalink / raw)
To: Liu Ying
Cc: Luca Ceresoli, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
[-- Attachment #1: Type: text/plain, Size: 2961 bytes --]
On Thu, May 22, 2025 at 11:20:17AM +0800, Liu Ying wrote:
> >> drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
> >
> > This patch affects multiple drivers. Running get_maintainers.pl
> > points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> > this looks like due to the 'N:' line in:
> >
> > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > M: Shawn Guo <shawnguo@kernel.org>
> > M: Sascha Hauer <s.hauer@pengutronix.de>
> > R: Pengutronix Kernel Team <kernel@pengutronix.de>
> > ...
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > N: imx
> > ...
> >
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
> >
> > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> > file that is touched by the patch. That regexp appears overly generic to me.
> >
> > Shawn, can it be fixed by making it less generic?
> >
> > If not, can we at least add a band-aid 'X:' entry for
> > drivers/gpu/drm/bridge/imx?
> >
> > I think the other matching entry is the one to consider:
> >
> > DRM DRIVERS FOR FREESCALE IMX BRIDGE
> > M: Liu Ying <victor.liu@nxp.com>
> > L: dri-devel@lists.freedesktop.org
> > S: Maintained
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> > F: drivers/gpu/drm/bridge/imx/
> >
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
> >
> > However it does not list any trees. I _guess_ drm-misc applies here as
> > a fallback as well as common sense.
> >
> > Liu, should this entry have a 'T:' line for drm/misc?
>
> These bridge drivers also don't have a 'T:' line:
>
> DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE
> DRM DRIVER FOR PARADE PS8640 BRIDGE CHIP
> DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE
> DRM DRIVER FOR TI SN65DSI86 BRIDGE CHIP
> LONTIUM LT8912B MIPI TO HDMI BRIDGE
> MEGACHIPS STDPXXXX-GE-B850V3-FW LVDS/DP++ BRIDGES
> MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER
>
> I think that they fallback to drm-misc since "DRM DRIVERS FOR BRIDGE CHIPS"
> covers them. I don't have strong opinion on adding a "T" line to them, at
> least to "DRM DRIVERS FOR FREESCALE IMX BRIDGE". Anyway, it would be good
> to know comments from maintainers for "DRM DRIVERS FOR BRIDGE CHIPS" and
> "DRM DRIVERS".
That's good enough to me. drivers/gpu/drm/bridge is indeed under the
maintenance of drm-misc and there's no exception afaik.
get_maintainers.pl also properly reports it, so I'm not sure we need to
do anything there.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-21 14:22 ` [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
2025-05-22 3:20 ` Liu Ying
@ 2025-05-22 14:57 ` Maxime Ripard
2025-05-22 15:56 ` Luca Ceresoli
2025-05-22 15:11 ` Inki Dae
2 siblings, 1 reply; 55+ messages in thread
From: Maxime Ripard @ 2025-05-22 14:57 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Jagan Teki, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski, Liu Ying,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
[-- Attachment #1: Type: text/plain, Size: 4766 bytes --]
On Wed, May 21, 2025 at 04:22:16PM +0200, Luca Ceresoli wrote:
> Hello Maxime, Shawn, Liu, all,
>
> On Fri, 09 May 2025 15:53:26 +0200
> Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
> > bridge, and the only one supported from now on. It is the first milestone
> > towards removal of bridges from a still existing DRM pipeline without
> > use-after-free.
>
> I applied on drm-misc-next patches 3-17,20-21 as they match all the
> criteria:
> - At least a Acked-by (or R-by maintainers)
> - patch is for drm-misc
>
> Being my very first commits to drm-misc, I tried to be careful, and
> double checked all the patches with Louis (thanks!).
>
> Here are the pending questions and plan for the remaining patches.
>
> > Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
>
> This reverts the commit applied my mistake:
> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518
>
> Neither the original patch nor the revert has been reviewed/acked.
>
> As the commit was a mistake, I'm applying the revert by the end of this
> week (i.e. on Friday) unless there are better instructions.
Given the lack of answers, and that it looks correct to me, just leave
it there. We can always revert later on if things turned out to be
broken.
> > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
>
> This patch affects multiple drivers. Running get_maintainers.pl
> points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> this looks like due to the 'N:' line in:
>
> ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> M: Shawn Guo <shawnguo@kernel.org>
> M: Sascha Hauer <s.hauer@pengutronix.de>
> R: Pengutronix Kernel Team <kernel@pengutronix.de>
> ...
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> N: imx
> ...
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
>
> Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> file that is touched by the patch. That regexp appears overly generic to me.
I agree, or at least, we shouldn't wait for Shawn or Sasha...
> Shawn, can it be fixed by making it less generic?
>
> If not, can we at least add a band-aid 'X:' entry for
> drivers/gpu/drm/bridge/imx?
>
> I think the other matching entry is the one to consider:
>
> DRM DRIVERS FOR FREESCALE IMX BRIDGE
> M: Liu Ying <victor.liu@nxp.com>
> L: dri-devel@lists.freedesktop.org
> S: Maintained
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> F: drivers/gpu/drm/bridge/imx/
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
... As long as Ying is fine with it, because it does look like they are
the actual maintainer.
> However it does not list any trees. I _guess_ drm-misc applies here as
> a fallback as well as common sense.
>
> Liu, should this entry have a 'T:' line for drm/misc?
>
> > drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
>
> Not acked/reviewed, some discussion happened. I am resending it in v4,
> possibly with updates based on the discussion.
>
> But it has the same issue discussed above, with get_maintiners.pl
> pointing at Shawn Guo's tree, so in the future I'm assuming this goes
> to drm-misc unless there are news about that.
>
> > drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
>
> No feedback, resending in v4.
>
> > drm/todo: add entry to remove devm_drm_put_bridge()
>
> This involves documentation maintained on another tree. Where should it
> be applied? There are two matching entries in MAINTAINERS:
>
> * DRM DRIVERS -> the drm tree
> * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
>
> To me it looks like the second is obviously the closest match as we are
> dealing with DRM bridges, so I'm applying this as well on Friday unless
> there are better instructions.
Yes, they should be applied to drm-misc.
That being said, putting a two days timeout on *any* email is really
over-the-top. I doubt you reply to any of your mail in such a short
timeframe. We have rules for a reason, I'd expect you to follow them, no
matter how frustrating the lack of answers can be.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-22 14:57 ` Maxime Ripard
@ 2025-05-22 15:56 ` Luca Ceresoli
0 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-22 15:56 UTC (permalink / raw)
To: Maxime Ripard
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Jagan Teki, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski, Liu Ying,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
Hi Maxime,
On Thu, 22 May 2025 16:57:30 +0200
Maxime Ripard <mripard@kernel.org> wrote:
[...]
> > As the commit was a mistake, I'm applying the revert by the end of this
> > week (i.e. on Friday) unless there are better instructions.
>
> Given the lack of answers, and that it looks correct to me, just leave
> it there. We can always revert later on if things turned out to be
> broken.
OK, I'll leave the commit and drop the revert in v4.
> > > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
> >
> > This patch affects multiple drivers. Running get_maintainers.pl
> > points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> > this looks like due to the 'N:' line in:
> >
> > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > M: Shawn Guo <shawnguo@kernel.org>
> > M: Sascha Hauer <s.hauer@pengutronix.de>
> > R: Pengutronix Kernel Team <kernel@pengutronix.de>
> > ...
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > N: imx
> > ...
> >
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
> >
> > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> > file that is touched by the patch. That regexp appears overly generic to me.
>
> I agree, or at least, we shouldn't wait for Shawn or Sasha...
>
> > Shawn, can it be fixed by making it less generic?
> >
> > If not, can we at least add a band-aid 'X:' entry for
> > drivers/gpu/drm/bridge/imx?
> >
> > I think the other matching entry is the one to consider:
> >
> > DRM DRIVERS FOR FREESCALE IMX BRIDGE
> > M: Liu Ying <victor.liu@nxp.com>
> > L: dri-devel@lists.freedesktop.org
> > S: Maintained
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> > F: drivers/gpu/drm/bridge/imx/
> >
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
>
> ... As long as Ying is fine with it, because it does look like they are
> the actual maintainer.
Ack, thanks for confirming this.
Bottom line, given that large patch has your Acked-by, and given the
shawnguo repo was ruled out, the conclusion is it can apply it to
drm-misc-next.
Having that large patch applied will be relieving me a lot! I think
next time I'm going to split any imilar change in per-driver patches,
even if it is spatch-automated.
> > > drm/todo: add entry to remove devm_drm_put_bridge()
> >
> > This involves documentation maintained on another tree. Where should it
> > be applied? There are two matching entries in MAINTAINERS:
> >
> > * DRM DRIVERS -> the drm tree
> > * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
> >
> > To me it looks like the second is obviously the closest match as we are
> > dealing with DRM bridges, so I'm applying this as well on Friday unless
> > there are better instructions.
>
> Yes, they should be applied to drm-misc.
OK, will do soon.
> That being said, putting a two days timeout on *any* email is really
> over-the-top. I doubt you reply to any of your mail in such a short
> timeframe. We have rules for a reason, I'd expect you to follow them, no
> matter how frustrating the lack of answers can be.
Apologies if that was too much.
I was indeed nervous about the revert. A patch got applied by mistake
and I believe it should have been reverted very quickly, if need be.
Both Louis and I didn't want to break the process again. So we asked,
but not having answer after 2+ weeks I must admit I got a bit nervous
about it.
Sorry about that and thanks for the feedback about my questions.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-21 14:22 ` [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
2025-05-22 3:20 ` Liu Ying
2025-05-22 14:57 ` Maxime Ripard
@ 2025-05-22 15:11 ` Inki Dae
2025-05-23 13:23 ` Luca Ceresoli
2 siblings, 1 reply; 55+ messages in thread
From: Inki Dae @ 2025-05-22 15:11 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski, Liu Ying,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan, Adam Ford,
Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
Hello Luca Ceresoli,
2025년 5월 21일 (수) 오후 11:23, Luca Ceresoli <luca.ceresoli@bootlin.com>님이 작성:
>
> Hello Maxime, Shawn, Liu, all,
>
> On Fri, 09 May 2025 15:53:26 +0200
> Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
> > bridge, and the only one supported from now on. It is the first milestone
> > towards removal of bridges from a still existing DRM pipeline without
> > use-after-free.
>
> I applied on drm-misc-next patches 3-17,20-21 as they match all the
> criteria:
> - At least a Acked-by (or R-by maintainers)
> - patch is for drm-misc
>
> Being my very first commits to drm-misc, I tried to be careful, and
> double checked all the patches with Louis (thanks!).
>
> Here are the pending questions and plan for the remaining patches.
>
> > Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
>
> This reverts the commit applied my mistake:
> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518
>
> Neither the original patch nor the revert has been reviewed/acked.
>
> As the commit was a mistake, I'm applying the revert by the end of this
> week (i.e. on Friday) unless there are better instructions.
Really sorry for late. I was made aware of it later through a
colleague's remark. There is no need to proceed with the revert.
Acked-by : Inki Dae <inki.dae@samsung.com>
Thanks,
Inki Dae
>
> > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
>
> This patch affects multiple drivers. Running get_maintainers.pl
> points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> this looks like due to the 'N:' line in:
>
> ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> M: Shawn Guo <shawnguo@kernel.org>
> M: Sascha Hauer <s.hauer@pengutronix.de>
> R: Pengutronix Kernel Team <kernel@pengutronix.de>
> ...
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> N: imx
> ...
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
>
> Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> file that is touched by the patch. That regexp appears overly generic to me.
>
> Shawn, can it be fixed by making it less generic?
>
> If not, can we at least add a band-aid 'X:' entry for
> drivers/gpu/drm/bridge/imx?
>
> I think the other matching entry is the one to consider:
>
> DRM DRIVERS FOR FREESCALE IMX BRIDGE
> M: Liu Ying <victor.liu@nxp.com>
> L: dri-devel@lists.freedesktop.org
> S: Maintained
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> F: drivers/gpu/drm/bridge/imx/
>
> (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
>
> However it does not list any trees. I _guess_ drm-misc applies here as
> a fallback as well as common sense.
>
> Liu, should this entry have a 'T:' line for drm/misc?
>
> > drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
>
> Not acked/reviewed, some discussion happened. I am resending it in v4,
> possibly with updates based on the discussion.
>
> But it has the same issue discussed above, with get_maintiners.pl
> pointing at Shawn Guo's tree, so in the future I'm assuming this goes
> to drm-misc unless there are news about that.
>
> > drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
>
> No feedback, resending in v4.
>
> > drm/todo: add entry to remove devm_drm_put_bridge()
>
> This involves documentation maintained on another tree. Where should it
> be applied? There are two matching entries in MAINTAINERS:
>
> * DRM DRIVERS -> the drm tree
> * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
>
> To me it looks like the second is obviously the closest match as we are
> dealing with DRM bridges, so I'm applying this as well on Friday unless
> there are better instructions.
>
> Best regards,
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-22 15:11 ` Inki Dae
@ 2025-05-23 13:23 ` Luca Ceresoli
0 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-23 13:23 UTC (permalink / raw)
To: Inki Dae
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski, Liu Ying,
Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan, Adam Ford,
Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou, Michal Simek,
Jonathan Corbet, linux-doc
Hello Inki,
On Fri, 23 May 2025 00:11:24 +0900
Inki Dae <daeinki@gmail.com> wrote:
> Hello Luca Ceresoli,
>
> 2025년 5월 21일 (수) 오후 11:23, Luca Ceresoli <luca.ceresoli@bootlin.com>님이 작성:
> >
> > Hello Maxime, Shawn, Liu, all,
> >
> > On Fri, 09 May 2025 15:53:26 +0200
> > Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> >
> > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
> > > bridge, and the only one supported from now on. It is the first milestone
> > > towards removal of bridges from a still existing DRM pipeline without
> > > use-after-free.
> >
> > I applied on drm-misc-next patches 3-17,20-21 as they match all the
> > criteria:
> > - At least a Acked-by (or R-by maintainers)
> > - patch is for drm-misc
> >
> > Being my very first commits to drm-misc, I tried to be careful, and
> > double checked all the patches with Louis (thanks!).
> >
> > Here are the pending questions and plan for the remaining patches.
> >
> > > Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API"
> >
> > This reverts the commit applied my mistake:
> > https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518
> >
> > Neither the original patch nor the revert has been reviewed/acked.
> >
> > As the commit was a mistake, I'm applying the revert by the end of this
> > week (i.e. on Friday) unless there are better instructions.
>
> Really sorry for late. I was made aware of it later through a
> colleague's remark. There is no need to proceed with the revert.
> Acked-by : Inki Dae <inki.dae@samsung.com>
Thanks for the feedback. As agreed with Maxime and approved by you, I'm
leaving the commit as is, without reverting and reapplying. Your
Acked-by is in the records anyway, so somehow reachable in case of need.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: (subset) [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()
2025-05-09 13:53 [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
` (22 preceding siblings ...)
2025-05-21 14:22 ` [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Luca Ceresoli
@ 2025-05-27 10:21 ` Luca Ceresoli
23 siblings, 0 replies; 55+ messages in thread
From: Luca Ceresoli @ 2025-05-27 10:21 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Jagan Teki,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Douglas Anderson, Chun-Kuang Hu, Krzysztof Kozlowski,
Luca Ceresoli
Cc: Anusha Srivatsa, Paul Kocialkowski, Dmitry Baryshkov, Hui Pu,
Thomas Petazzoni, dri-devel, asahi, linux-kernel, chrome-platform,
imx, linux-arm-kernel, linux-mediatek, linux-amlogic,
linux-renesas-soc, platform-driver-x86, linux-samsung-soc,
linux-arm-msm, freedreno, linux-stm32, Louis Chauvet, Alim Akhtar,
Inki Dae, Kyungmin Park, Seung-Woo Kim, Manikandan Muralidharan,
Adam Ford, Adrien Grassein, Aleksandr Mishin, Andy Yan,
AngeloGioacchino Del Regno, Benson Leung, Biju Das,
Christoph Fritz, Cristian Ciocaltea, Detlev Casanova,
Dharma Balasubiramani, Guenter Roeck, Heiko Stuebner, Jani Nikula,
Janne Grunau, Jerome Brunet, Jesse Van Gavere, Kevin Hilman,
Kieran Bingham, Liu Ying, Martin Blumenstingl, Matthias Brugger,
Philipp Zabel, Phong LE, Sasha Finkelstein, Sugar Zhang,
Sui Jingfeng, Tomi Valkeinen, Vitalii Mordan, Rob Herring (Arm),
Hsin-Te Yuan, Pin-yen Lin, Xin Ji, Aradhya Bhatia, Tomi Valkeinen,
Ian Ray, Martyn Welch, Peter Senna Tschudin, Helge Deller,
Kuninori Morimoto, Laurent Pinchart, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Alain Volmat, Raphael Gallais-Pou,
Laurent Pinchart, Michal Simek, Jonathan Corbet, linux-doc
On Fri, 09 May 2025 15:53:26 +0200, Luca Ceresoli wrote:
> devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
> bridge, and the only one supported from now on. It is the first milestone
> towards removal of bridges from a still existing DRM pipeline without
> use-after-free.
>
> The steps in the grand plan [1] are:
>
> [...]
Applied, thanks!
[18/22] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
commit: 99764593528f9e0ee9509f9e4a4eb21db99d0681
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 55+ messages in thread