From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nandor Han <nandor.han@gehealthcare.com>,
wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document continue in low power mode
Date: Wed, 14 Jan 2026 16:58:58 +0100 [thread overview]
Message-ID: <ed99a966-6c10-4156-846a-4ae02621dcf3@kernel.org> (raw)
In-Reply-To: <1359781c-a1cc-43ff-88e2-f381e8ab81d2@gehealthcare.com>
On 14/01/2026 14:22, Nandor Han wrote:
>
> On 1/12/26 15:55, Krzysztof Kozlowski wrote:
>> CAUTION: This email originated from outside of GE HealthCare. Only open links or attachments if you trust the sender. Report suspicious emails using Outlook’s “Report” button.
>>
>> On 12/01/2026 14:08, Nandor Han wrote:
>>> Property "fsl,wdt-continue-in-low-power" allows the watchdog to continue
>>> running in low power modes (STOP and DOZE). By default, the watchdog is
>>> suspended in these modes. This property provides the option to keep the
>>> watchdog active during low power states when needed.
>>>
>>> Signed-off-by: Nandor Han <nandor.han@gehealthcare.com>
>> Do not attach (thread) your patchsets to some other threads (unrelated
>> or older versions). This buries them deep in the mailbox and might
>> interfere with applying entire sets. See also:
>> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
>
> Apologies, will not do that on the next version.
>
>
> <snip>
>
>>> + fsl,wdt-continue-in-low-power:
>>> + $ref: /schemas/types.yaml#/definitions/flag
>>> + description: |
>> Do not need '|' unless you need to preserve formatting.
>
> Thanks, will update.
>
>>> + If present, the watchdog device continues to run in low power modes
>>> + (STOP and DOZE).
>> Not much improved. My questions how this petting is suppose to work
>> remain unanswered.
>>
>> Again, system load is really not relevant whether watchdog works or not
>> in low power mode.
>
> Our use case is that we do not allow the CPU (i.MX7) to enter low-power modes.
That's very close to OS policy... or some sort of runtime choice.
>
> To enforce this, we explicitly enable the watchdog during low-power states so that if the system enters such a mode for any reason, the watchdog will reset the CPU.
So finally this is explained. You actually want to trigger the bite by
lack of petting.
You can as well set the bit moment you put the system to suspend. You do
not need DT flag for this.
I unfortunately do not see how this could be anything else than OS
policy, so it is not suitable for DT. Maybe some rephrasing could help
and that's what I would expect usually, but I already raised objections
and then you sent v2 with the same ignoring these objections (really,
never do that), so I doubt that discussing will change anything and you
need very specific answer: no.
> Since in STOP and DOZE modes the CPU is halted and systemd can no longer service the watchdog, the watchdog will eventually trigger a reset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-14 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 14:49 [PATCH 0/2] watchdog: imx2_wdt: Allow to run in low power mode Nandor Han
2025-12-29 14:49 ` [PATCH 1/2] watchdog: imx2_wdt: Allow to continue " Nandor Han
2025-12-30 12:35 ` Krzysztof Kozlowski
2026-01-07 9:04 ` Nandor Han
2026-01-12 13:08 ` [PATCH v2 0/2] watchdog: imx2_wdt: Allow to run " Nandor Han
2026-01-12 13:08 ` [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document continue " Nandor Han
2026-01-12 13:55 ` Krzysztof Kozlowski
2026-01-14 13:22 ` Nandor Han
2026-01-14 15:58 ` Krzysztof Kozlowski [this message]
2026-01-12 13:08 ` [PATCH v2 2/2] watchdog: imx2_wdt: Allow to " Nandor Han
2025-12-31 23:41 ` [PATCH 1/2] " Guenter Roeck
2025-12-29 14:50 ` [PATCH 2/2] dt-bindings: watchdog: fsl-imx: document " Nandor Han
2025-12-30 12:34 ` Krzysztof Kozlowski
2026-01-07 9:12 ` Nandor Han
2026-01-07 10:48 ` Krzysztof Kozlowski
2026-01-08 7:58 ` Nandor Han
2026-01-12 13:56 ` Krzysztof Kozlowski
2026-01-06 11:51 ` Peng Fan
2026-01-07 10:29 ` Nandor Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed99a966-6c10-4156-846a-4ae02621dcf3@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nandor.han@gehealthcare.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox