[PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[Frank Li]

The original txt binding doc is:
  reg : Specifies base physical address and size of the register sets for
        the clock event device and clock source device.

And existed dts provide two reg MMIO spaces. So change to use items to
descript reg property.

Update examples.

Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- add kk review tag
- add missed )
---
 Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
index 0e4a8ddc3de32..e3b61b62521e8 100644
--- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
@@ -14,7 +14,9 @@ properties:
     const: fsl,ftm-timer
 
   reg:
-    maxItems: 1
+    items:
+      - description: clock event device
+      - description: clock source device
 
   interrupts:
     maxItems: 1
@@ -50,7 +52,8 @@ examples:
 
     ftm@400b8000 {
         compatible = "fsl,ftm-timer";
-        reg = <0x400b8000 0x1000>;
+        reg = <0x400b8000 0x1000>,
+              <0x400b9000 0x1000>;
         interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
         clock-names = "ftm-evt", "ftm-src", "ftm-evt-counter-en", "ftm-src-counter-en";
         clocks = <&clks VF610_CLK_FTM2>, <&clks VF610_CLK_FTM3>,
-- 
2.34.1

Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[Frank Li]

On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
> The original txt binding doc is:
>   reg : Specifies base physical address and size of the register sets for
>         the clock event device and clock source device.
>
> And existed dts provide two reg MMIO spaces. So change to use items to
> descript reg property.
>
> Update examples.
>
> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Daniel Lezcano Or Rob

Krzysztof Kozlowski already reviewed. Could you place pick this one?

Frank

> ---
> change in v2
> - add kk review tag
> - add missed )
> ---
>  Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> index 0e4a8ddc3de32..e3b61b62521e8 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> @@ -14,7 +14,9 @@ properties:
>      const: fsl,ftm-timer
>
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: clock event device
> +      - description: clock source device
>
>    interrupts:
>      maxItems: 1
> @@ -50,7 +52,8 @@ examples:
>
>      ftm@400b8000 {
>          compatible = "fsl,ftm-timer";
> -        reg = <0x400b8000 0x1000>;
> +        reg = <0x400b8000 0x1000>,
> +              <0x400b9000 0x1000>;
>          interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
>          clock-names = "ftm-evt", "ftm-src", "ftm-evt-counter-en", "ftm-src-counter-en";
>          clocks = <&clks VF610_CLK_FTM2>, <&clks VF610_CLK_FTM3>,
> --
> 2.34.1
>

Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[Krzysztof Kozlowski]

On 14/07/2025 17:24, Frank Li wrote:
> On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
>> The original txt binding doc is:
>>   reg : Specifies base physical address and size of the register sets for
>>         the clock event device and clock source device.
>>
>> And existed dts provide two reg MMIO spaces. So change to use items to
>> descript reg property.
>>
>> Update examples.
>>
>> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Daniel Lezcano Or Rob
> 
> Krzysztof Kozlowski already reviewed. Could you place pick this one?

Just FYI,
I review either through DT patchwork or my own email client. In the
first case I mark the patch as done in DT patchwork, thus Rob will not
see it. If you want Rob to pick it up, please resend with a note in
changelog --- for Tob.

Best regards,
Krzysztof

Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[Daniel Lezcano]

On 7/14/25 17:24, Frank Li wrote:
> On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
>> The original txt binding doc is:
>>    reg : Specifies base physical address and size of the register sets for
>>          the clock event device and clock source device.
>>
>> And existed dts provide two reg MMIO spaces. So change to use items to
>> descript reg property.
>>
>> Update examples.
>>
>> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Daniel Lezcano Or Rob
> 
> Krzysztof Kozlowski already reviewed. Could you place pick this one?


Yes



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

[Daniel Lezcano]

On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
> The original txt binding doc is:
>   reg : Specifies base physical address and size of the register sets for
>         the clock event device and clock source device.
> 
> And existed dts provide two reg MMIO spaces. So change to use items to
> descript reg property.
> 
> Update examples.
> 
> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

Applied, thanks

-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog