From: Josua Mayer <josua@solid-run.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Yazan Shhady <yazan.shhady@solid-run.com>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Jon Nettleton <jon@solid-run.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] arm64: dts: add description for solidrun imx8mp hummingboard variants
Date: Mon, 16 Jun 2025 11:47:13 +0000 [thread overview]
Message-ID: <f0ef8578-7a48-4dbf-a1b4-25284c3964e7@solid-run.com> (raw)
In-Reply-To: <92c723c3-81ab-422c-ae5f-7c2d64c117f9@kernel.org>
Am 16.06.25 um 09:20 schrieb Krzysztof Kozlowski:
> On 14/06/2025 16:20, Josua Mayer wrote:
>> +
>> +/* mikrobus spi */
>> +&ecspi2 {
>> + num-cs = <1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mikro_spi_pins>;
>> + status = "okay";
>> +
>> + spi@0 {
>> + reg = <0>;
>> + compatible = "rohm,dh2228fv";
> NAK, such device DOES NOT EXIST. It is impossible to obtain dh2228fv, so
> your engineers were able to find it from Rohm?
Correct.
This description was used for hardware validation without a real dh2228fv.
>
> Drop entire node.
Will do for v2, thanks.
>
>
>> + spi-max-frequency = <500000>;
>> + };
>> +};
>> +
Did the separation of board features into various dtsi look acceptable?
prev parent reply other threads:[~2025-06-16 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 14:20 [PATCH 0/3] arm64: dts: add descriptions for solidrun i.mx8mp based boards Josua Mayer
2025-06-14 14:20 ` [PATCH 1/3] dt-bindings: arm: fsl: Add bindings for SolidRun i.MX8MP SoM and boards Josua Mayer
2025-06-26 23:50 ` Rob Herring (Arm)
2025-06-14 14:20 ` [PATCH 2/3] arm64: dts: add description for solidrun imx8mp som and cubox-m Josua Mayer
2025-06-14 14:20 ` [PATCH 3/3] arm64: dts: add description for solidrun imx8mp hummingboard variants Josua Mayer
2025-06-16 6:20 ` Krzysztof Kozlowski
2025-06-16 11:47 ` Josua Mayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ef8578-7a48-4dbf-a1b4-25284c3964e7@solid-run.com \
--to=josua@solid-run.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jon@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail.anikin@solid-run.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox