Re: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support

Andrew Lunn
2022-09-29T15:19:50Z

> > > I actually did some compare testing regarding the page pool for normal
> > > traffic. So far I don't see significant improvement in the current
> > > implementation. The performance for large packets improves a little,
> > > and the performance for small packets get a little worse.
> >
> > What hardware was this for? imx51? imx6? imx7 Vybrid? These all use the FEC.
>
> I tested on imx8qxp platform. It is ARM64.

Please also test the older platforms. imx8 is quite powerful, so some
performance loss does not matter too much. But for the older systems,
i know people has spent a lot of time and effort optimising network
performance, and they will be unhappy if you make it slower.

> > By small packets, do you mean those under the copybreak limit?
> >
> > Please provide some benchmark numbers with your next patchset.
>

> Yes, the packet size is 64 bytes and it is under the copybreak
> limit. As the impact is not significant, I would prefer to remove
> the copybreak logic.

Lets look at the benchmark numbers, what you actually mean by not
significant, and across a range of hardware.

Andrew