From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
xiaoning.wang@nxp.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, aziz.sellami@nxp.com, imx@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95
Date: Thu, 30 Oct 2025 18:43:48 +0100 [thread overview]
Message-ID: <f6db67ec-9eb0-4730-af18-31214afe2e09@lunn.ch> (raw)
In-Reply-To: <20251030091538.581541-1-wei.fang@nxp.com>
> Similar to the external MDIO registers, each ENETC has a set of internal
> MDIO registers to access its on-die PHY (PCS), so internal MDIO support
> is also added.
Any reason to not just hard code it to 0?
What is the reset default?
DT describes hardware, not configuration. So getting this from DT
seems wrong.
Andrew
next prev parent reply other threads:[~2025-10-30 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 9:15 [PATCH net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 Wei Fang
2025-10-30 9:15 ` [PATCH net-next 1/3] net: enetc: set external MDIO PHY address for i.MX95 ENETC Wei Fang
2025-10-30 9:15 ` [PATCH net-next 2/3] net: enetc: set external MDIO PHY address for i.MX94 ENETC Wei Fang
2025-10-30 9:15 ` [PATCH net-next 3/3] net: enetc: add port MDIO support for ENETC v4 Wei Fang
2025-10-30 17:43 ` Andrew Lunn [this message]
2025-10-31 1:49 ` [PATCH net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 Wei Fang
2025-10-31 12:31 ` Andrew Lunn
2025-11-01 0:24 ` Wei Fang
2025-11-01 14:43 ` Andrew Lunn
2025-11-03 2:11 ` Wei Fang
2025-11-03 13:16 ` Andrew Lunn
2025-11-04 2:29 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6db67ec-9eb0-4730-af18-31214afe2e09@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=aziz.sellami@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox