Re: [PATCH v1 00/11] media: Add iMX95 neoisp driver

[Antoine Bouyer <antoine.bouyer@nxp.com>]

Le 16/04/2026 à 11:20, Krzysztof Kozlowski a écrit :
> 
> 
> On Mon, Apr 13, 2026 at 06:03:20PM +0200, Antoine Bouyer wrote:
>> Hello
>>
>> This patch series introduces the NXP Neo Image Signal Processor (ISP)
>> driver, used in the NXP i.MX95 SoC and future devices in the i.MX9 family.
>> The series also includes updates to the generic v4l2-isp interface to
>> support extended statistics required by the Neo ISP.
>>
>> The Neo ISP processes one or more camera streams, converting RAW formats
>> into YUV or RGB outputs. Its architecture is largely influenced by the
>> PISP driver. To limit the number of v4l2 devices, the driver supports only
>> one context, with three sink pads (main input, second input for HDR, and
>> parameter buffers) and three source pads (RGB output, IR output, and
>> statistics metadata).
>>
>> The driver supports the generic extensible v4l2-isp framework for
>> parameters, similar to rkisp1 and mali-c55, and applies the same approach
>> to statistics buffers. The generic v4l2-isp framework is modified to
>> factorize structure definitions and versioning, so that both parameters
>> and statistics buffers share the same mechanisms.
> 
> That's a v2, not v1.

Hi Krzysztof

Thanks for your review

Sorry, my mistake. My previous submission was an RFC, so I reset version 
counter to 1 by mistake when submitting this patch series.

> 
> Does this work:
> b4 diff 20260413160331.2611829-1-antoine.bouyer@nxp.com
> 
> ? No.
> 
> Should it work? Yes.

I hope v2 will do then ...

> 
> Also, implement previous feedback - I see no changelog, so I assume you
> just ignored everything. Judging by build process errors, it's even
> worse.

Oh no, don't worry, I did not ignore your comments: using maxItems for 
clocks, removing unused configs, and renaming filename to match the 
compatible used in imx95 SoC.

I tried to summarize these changes in this cover letter, but probably 
missing details.

They will be included in v2, along with the fix for the obvious error 
reported by the bot.

Best regards
Antoine

> 
> Best regards,
> Krzysztof
>