From: Florian Fainelli <f.fainelli@gmail.com>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, xiaoning.wang@nxp.com,
linux-imx@nxp.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
bsp-development.geo@leica-geosystems.com,
m.felsch@pengutronix.de
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dwmac-imx: add nxp,phy-wol
Date: Wed, 6 Mar 2024 09:42:02 -0800 [thread overview]
Message-ID: <fc8a079f-10f1-4b2e-abc1-0a043eb1876e@gmail.com> (raw)
In-Reply-To: <20240306172409.878928-1-catalin.popescu@leica-geosystems.com>
On 3/6/24 09:24, Catalin Popescu wrote:
> Add support for PHY WOL capability to dwmac-imx MAC driver.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 4c01cae7c93a..6cf373772eb1 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -71,6 +71,12 @@ properties:
> description:
> To select RMII reference clock from external.
>
> + nxp,phy-wol:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + If present, indicates that PHY supports WOL(Wake-On-LAN), and PHY WOL will be enabled.
> + Otherwise, MAC WOL is preferred.
This is encoding a policy in Device Tree, which is not acceptable, see
my comment about your second patch.
pw-bot: cr
--
Florian
prev parent reply other threads:[~2024-03-06 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 17:24 [PATCH net-next 1/2] dt-bindings: net: dwmac-imx: add nxp,phy-wol Catalin Popescu
2024-03-06 17:24 ` [PATCH net-next 2/2] net: stmmac: dwmac-imx: add support for PHY WOL Catalin Popescu
2024-03-06 17:41 ` Florian Fainelli
2024-03-07 9:13 ` POPESCU Catalin
2024-03-07 10:01 ` POPESCU Catalin
2024-03-07 18:52 ` Florian Fainelli
2024-03-08 17:48 ` POPESCU Catalin
2024-03-08 17:56 ` Florian Fainelli
2024-03-06 17:42 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc8a079f-10f1-4b2e-abc1-0a043eb1876e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=m.felsch@pengutronix.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox