From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-10626.protonmail.ch (mail-10626.protonmail.ch [79.135.106.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4371CD215 for ; Fri, 11 Jul 2025 10:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.26 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752228288; cv=none; b=fsCxBAsOtdHvvOr9k6OCEGnvFPitEXclVJi8wIeh9SOPaKZJXKyPChITngNTYcJEEZnVQYQE8vg23dTOJ75qGYUVijurIwrsBSuTcJ8fpbra13DalzLWKvZoEhfj59XIUjTwmMDYAcntPcarEzgorcH6KV+W/mEhurFiGZhRW3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752228288; c=relaxed/simple; bh=y6SFqHAsZ+1U0g+VQ10xtYYL0E22g1zsauVndKyBnmI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j0OCrZlYF16rSG849GKw9n425XXcRUbXdgWL0jnjHveI6HnqPpzMLBaJu/tYjHGcZWG97cSjDT4E/8/8ho+dTHlznZfXGoUkbLPJFxDTKWA34j5CwB63EY04bKqx95Ndn3RbmImnr1wKdGu9FIrcLbx4kDbmOmnxVnUOHtttgHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=ExkwTmor; arc=none smtp.client-ip=79.135.106.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="ExkwTmor" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail; t=1752228284; x=1752487484; bh=y6SFqHAsZ+1U0g+VQ10xtYYL0E22g1zsauVndKyBnmI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ExkwTmorolutl9yXI6Y6f121KdON4optTi7BFgVYWDpu1r8l4OzkcKMq1CtHCpZ1+ rerw/LMWyVY0Y4DQnGFG0LQVivfTYPS3XXO9p07v+SVtPKQuK9nNLhCzb7jgysy/In ue6nnnZpSFangiLRpIFwkwdadR0EMUtZjm7vgPotf9MHP6IcF+eHOu8ZaoGdjcfbcu YzQ41fk8WGap0SpyP4ayowPQVPJcnrurwpNnc5uzCKxL9fuULCDF8sqI+5hwAeiGZ1 tyidWHvtlpXo8aIqot37nGHQjVkIc0lEMFs7dwaSt/ryYnjzwZ4UdyCTppbbvNydol BmYEGoZh8I/Ug== Date: Fri, 11 Jul 2025 10:04:40 +0000 To: Samuel Kayode From: Sean Nyekjaer Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Dmitry Torokhov , Sebastian Reichel , Frank Li , imx@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org, Abel Vesa , Abel Vesa , Robin Gong , Robin Gong , Enric Balletbo i Serra Subject: Re: [PATCH v8 3/6] regulator: pf1550: add support for regulator Message-ID: In-Reply-To: <20250707-pf1550-v8-3-6b6eb67c03a0@savoirfairelinux.com> References: <20250707-pf1550-v8-0-6b6eb67c03a0@savoirfairelinux.com> <20250707-pf1550-v8-3-6b6eb67c03a0@savoirfairelinux.com> Feedback-ID: 134068486:user:proton X-Pm-Message-ID: 888c58051b555ccdfcba7c9369c9eab466ff9121 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2025 at 05:37:22PM +0100, Samuel Kayode wrote: > Add regulator support for the pf1550 PMIC. >=20 > Reviewed-by: Frank Li > Reviewed-by: Mark Brown > Signed-off-by: Samuel Kayode > --- [...] > + > +struct pf1550_desc { > +=09struct regulator_desc desc; > +=09unsigned char stby_reg; > +=09unsigned char stby_mask; > +}; > + I would suggest doing support for the stby voltages. We are using them to lower consumption in suspend. >From the devicetree we configure: regulator-suspend-min-microvolt, regulator-suspend-max-microvolt, regulator-off-in-suspend and/or regulator-on-in-suspend /Sean