Re: [PATCH v5 11/13] gpio: mxc: switch probe error paths to dev_err_probe()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: mxc: missed dev_err_probe() conversion for irq_count and clk
--

commit 9d304bc479f48f3358f5e78d0a6c7c31a38cd860
Author: Peng Fan <peng.fan@nxp.com>

gpio: mxc: switch probe error paths to dev_err_probe()

This commit converts the error handling paths in the probe function of the
mxc gpio driver to use dev_err_probe(). It aims to provide consistent
diagnostics and support for deferred probe tracking.

> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 6074b1e3d6834..1eb5cd148c28a 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -520,7 +520,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>  
>  	err = gpio_generic_chip_init(&port->gen_gc, &config);
>  	if (err)
> -		return err;
> +		return dev_err_probe(dev, err, "Failed to init gpio chip\n");

[Severity: Low]
The commit message states that bare return statements are replaced across
all probe error paths. Are there some that were missed in this conversion?

Looking earlier in mxc_gpio_probe(), there are still bare returns for the
IRQ count and clock setup:

	irq_count = platform_irq_count(pdev);
	if (irq_count < 0)
		return irq_count;

and:

	/* the controller clock is optional */
	port->clk = devm_clk_get_optional_enabled(dev, NULL);
	if (IS_ERR(port->clk))
		return PTR_ERR(port->clk);

Since platform_irq_count() and devm_clk_get_optional_enabled() can return
-EPROBE_DEFER when their dependencies are not yet ready, should these paths
also be converted to use dev_err_probe() to ensure those deferrals are
properly logged to the deferred-probe debugfs tracking mechanism?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-gpio-mxc-cleanup-v5-0-1e59e6ddfa00@nxp.com?part=11