From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Thu, 22 Oct 2026 14:10:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-181612@kernel.org> (raw)
In-Reply-To: <20261022140244.3476844-2-petko.manolov@konsulko.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arm: fsl: undocumented draeger vendor prefix in fsl.yaml
--
commit 3465979b7c116a128c865587fd61bc41cff5927b
Author: Petko Manolov <petko.manolov@konsulko.com>
dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
This commit adds the draeger,imx6q-m48 and draeger,imx6dl-m48 board
compatible strings to Documentation/devicetree/bindings/arm/fsl.yaml.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..8f3a04228780a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -260,6 +260,7 @@ properties:
> - boundary,imx6q-nitrogen6x
> - compulab,cm-fx6 # CompuLab CM-FX6
> - dmo,imx6q-edmqmx6 # Data Modul eDM-QMX6 Board
> + - draeger,imx6q-m48 # Draeger imx6q variant of M48
> - ds,imx6q-sbc # Da Sheng COM-9XX Modules
> - embest,imx6q-marsboard # Embest MarS Board i.MX6Dual
> - emtrion,emcon-mx6 # emCON-MX6D or emCON-MX6Q SoM
> @@ -458,6 +459,7 @@ properties:
> - boundary,imx6dl-nit6xlite # Boundary Devices Nitrogen6 Lite
> - boundary,imx6dl-nitrogen6x # Boundary Devices Nitrogen6x
> - bticino,imx6dl-mamoj # BTicino i.MX6DL Mamoj
> + - draeger,imx6dl-m48 # Draeger imx6dl variant of M48
> - eckelmann,imx6dl-ci4x10
> - emtrion,emcon-mx6 # emCON-MX6S or emCON-MX6DL SoM
> - emtrion,emcon-mx6-avari # emCON-MX6S or emCON-MX6DL SoM on Avari Base
[Severity: Low]
Both hunks in properties:compatible of
Documentation/devicetree/bindings/arm/fsl.yaml introduce compatible strings
with the draeger vendor prefix (draeger,imx6q-m48 and draeger,imx6dl-m48),
and the follow-up commit 6e00402d882f ("arm: dts: nxp: imx: Add devicetree
files for M48") uses them as well.
However, patternProperties in
Documentation/devicetree/bindings/vendor-prefixes.yaml does not appear to
have a matching "^draeger,.*" entry:
"^dptel,.*":
description: Guangdong Dapu Telecom Co., Ltd.
"^dragino,.*":
description: Dragino Technology Co., Limited
Should the "^draeger,.*" vendor prefix be added to
Documentation/devicetree/bindings/vendor-prefixes.yaml so that
scripts/checkpatch.pl (in process()) and devicetree schema validation
(dt_binding_check and dtbs_check) do not report draeger as an undocumented
vendor prefix?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261022140244.3476844-1-petko.manolov@konsulko.com?part=1
next prev parent reply other threads:[~2026-10-22 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 14:02 [PATCH v4 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-10-22 14:02 ` [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-10-22 14:10 ` sashiko-bot [this message]
2026-10-22 15:13 ` Frank Li
2026-10-22 16:40 ` Petko Manolov
2026-10-22 14:02 ` [PATCH v4 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-181612@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox